Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-20 Thread Andrew Lunn
> Right. TLC591xx has the constant output mode which should be used for > GPIO. Perhaps that mode could be always used when the brightness is > turned to maximum. I haven't read the spec carefully enough to know if > there are some downsides. The original Belkin code did use that mode for full bri

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-20 Thread Tomi Valkeinen
On 20/01/15 15:26, Andrew Lunn wrote: >> I'm not familiar with the LED/PWM frameworks, so I want to summarize our >> use case and how I guess this should be done: >> >> We use the TLC59108 to provide backlight to a LCD, but in addition to >> that, it is used as a GPIO expander (or GPO, as it cannot

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-20 Thread Geert Uytterhoeven
On Tue, Jan 20, 2015 at 2:26 PM, Andrew Lunn wrote: > led-gpio looks like more work, but i don't see why it should not be > possible. One thing i do need to check is that if the brightness is > set to 255 the output is not set to 255/256 on and you have a regular is set to 255/256? > glitch. For

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-20 Thread Andrew Lunn
> I'm not familiar with the LED/PWM frameworks, so I want to summarize our > use case and how I guess this should be done: > > We use the TLC59108 to provide backlight to a LCD, but in addition to > that, it is used as a GPIO expander (or GPO, as it cannot do input). In > your earlier patch versio

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-20 Thread Tomi Valkeinen
On 16/01/15 21:17, Andrew Lunn wrote: > On Fri, Jan 16, 2015 at 04:52:12PM +0200, Tomi Valkeinen wrote: >> Hi, >> >> On 15/01/15 01:15, Andrew Lunn wrote: >>> This patchset is a driver for the TI tlc59116 16 Channel i2c LED >>> driver. This driver is used on the Belkin WRT1900AC access point and >>

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-16 Thread Andrew Lunn
On Fri, Jan 16, 2015 at 04:52:12PM +0200, Tomi Valkeinen wrote: > Hi, > > On 15/01/15 01:15, Andrew Lunn wrote: > > This patchset is a driver for the TI tlc59116 16 Channel i2c LED > > driver. This driver is used on the Belkin WRT1900AC access point and > > the C code is derived from code Belkin c

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-16 Thread Andrew Lunn
> I understand that period of TLC chip cannot be changed and hence cannot > fully implement PWM interface. O.K, so that is agreed. > But, suppose I want to control brightness > of an LCD screen, with your current design, my LCD driver can never can do > something like: > pwm_get(chip); >

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-16 Thread R, Vignesh
On 1/16/2015 9:25 PM, Andrew Lunn wrote: > On Fri, Jan 16, 2015 at 04:52:12PM +0200, Tomi Valkeinen wrote: >> Hi, >> >> On 15/01/15 01:15, Andrew Lunn wrote: >>> This patchset is a driver for the TI tlc59116 16 Channel i2c LED >>> driver. This driver is used on the Belkin WRT1900AC access point a

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-16 Thread Andrew Lunn
On Fri, Jan 16, 2015 at 04:52:12PM +0200, Tomi Valkeinen wrote: > Hi, > > On 15/01/15 01:15, Andrew Lunn wrote: > > This patchset is a driver for the TI tlc59116 16 Channel i2c LED > > driver. This driver is used on the Belkin WRT1900AC access point and > > the C code is derived from code Belkin c

Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-16 Thread Tomi Valkeinen
Hi, On 15/01/15 01:15, Andrew Lunn wrote: > This patchset is a driver for the TI tlc59116 16 Channel i2c LED > driver. This driver is used on the Belkin WRT1900AC access point and > the C code is derived from code Belkin contributed to OpenWRT. > However it has been extensively re-written, and a d

[PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver

2015-01-14 Thread Andrew Lunn
This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver. This driver is used on the Belkin WRT1900AC access point and the C code is derived from code Belkin contributed to OpenWRT. However it has been extensively re-written, and a device tree binding added to replace platform data.