Re: [PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-24 Thread Thomas Petazzoni
Dear Andrew Lunn, On Sun, 23 Nov 2014 04:36:03 +0100, Andrew Lunn wrote: No, it is not the BootROM that does this. It is the binary header, which is something different. O.K, so this definitely needs documenting somewhere, since it is not obvious. I'm not sure if it is sufficient to make

Re: [PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-22 Thread Thomas Petazzoni
Dear Andrew Lunn, On Fri, 21 Nov 2014 18:20:31 +0100, Andrew Lunn wrote: Hi Thomas Is this a well defined mechanism supported by mainline uboot, barebox etc. Or is it some Marvell extension to their uboot? As far as I know, it is a Marvell extension to their binary header, so

Re: [PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-22 Thread Andrew Lunn
On Sat, Nov 22, 2014 at 09:56:48PM +0100, Thomas Petazzoni wrote: Dear Andrew Lunn, On Fri, 21 Nov 2014 18:20:31 +0100, Andrew Lunn wrote: Hi Thomas Is this a well defined mechanism supported by mainline uboot, barebox etc. Or is it some Marvell extension to their uboot?

[PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-21 Thread Thomas Petazzoni
This commit implements the core of the platform code to enable suspend/resume on Armada XP. It registers the platform_suspend_ops structure, and implements the -enter() hook of this structure. It is worth mentioning that this commit only provides the SoC-level part of suspend/resume, which calls

Re: [PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-21 Thread Andrew Lunn
+static void mvebu_pm_store_bootinfo(void) +{ + u32 *store_addr; + phys_addr_t resume_pc; + + store_addr = phys_to_virt(BOOT_INFO_ADDR); + resume_pc = virt_to_phys(armada_370_xp_cpu_resume); + + /* + * The bootloader expects the first two words to be a magic +

Re: [PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-21 Thread Thomas Petazzoni
Dear Andrew Lunn, On Fri, 21 Nov 2014 17:41:42 +0100, Andrew Lunn wrote: +static void mvebu_pm_store_bootinfo(void) +{ + u32 *store_addr; + phys_addr_t resume_pc; + + store_addr = phys_to_virt(BOOT_INFO_ADDR); + resume_pc = virt_to_phys(armada_370_xp_cpu_resume); + +

Re: [PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-21 Thread Andrew Lunn
Hi Thomas Is this a well defined mechanism supported by mainline uboot, barebox etc. Or is it some Marvell extension to their uboot? As far as I know, it is a Marvell extension to their binary header, so it's done even before U-Boot starts. Ah, O.K. So i miss understood what you

Re: [PATCHv3 09/16] ARM: mvebu: implement suspend/resume support for Armada XP

2014-11-21 Thread Jason Cooper
On Fri, Nov 21, 2014 at 06:20:31PM +0100, Andrew Lunn wrote: Hi Thomas Is this a well defined mechanism supported by mainline uboot, barebox etc. Or is it some Marvell extension to their uboot? As far as I know, it is a Marvell extension to their binary header, so it's done