Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-13 Thread Pavel Machek
Hi! #define to_adp1653_flash(sd) container_of(sd, struct adp1653_flash, subdev) Let me know if you're going to send v8 or if I can make the changes. I think we're pretty much done then. You are free to make the changes. Thanks,

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Pavel Machek
On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: Hi, On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: [...] +#include linux/of_gpio.h +#include linux/gpio.h [...] This should probably be #include linux/of.h #include linux/gpio/consumer.h And I thought people

[PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Pavel Machek
Add device tree support for adp1653 flash LED driver. Signed-off-by: Pavel Machek pa...@ucw.cz --- Second part of a patch after documentation was merged. Please apply, Pavel diff --git a/drivers/media/i2c/adp1653.c

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Sebastian Reichel
Hi, On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: [...] +#include linux/of_gpio.h +#include linux/gpio.h [...] This should probably be #include linux/of.h #include linux/gpio/consumer.h -- Sebastian signature.asc Description: Digital signature

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Sebastian Reichel
On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: [...] +#include linux/of_gpio.h +#include linux/gpio.h [...] This should probably be #include