Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-14 Thread Eduardo Valentin
Hello Wei, On 13-01-2014 22:54, Wei Ni wrote: On 01/14/2014 05:29 AM, Eduardo Valentin wrote: * PGP Signed by an unknown key Wei, On 06-01-2014 22:44, Wei Ni wrote: On 01/06/2014 10:54 PM, Eduardo Valentin wrote: Old Signed by an unknown key On 06-01-2014 09:51, Mark Rutland wrote: On

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-13 Thread Eduardo Valentin
On 02-01-2014 13:50, Matthew Longnecker wrote: I think the platform driver may set governor for the thermal zone, so how about to add a property named as governor, and parse it to tzp-governor_name, something like: ret = of_property_read_string(child, governor, str);

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-13 Thread Eduardo Valentin
Wei, On 06-01-2014 22:44, Wei Ni wrote: On 01/06/2014 10:54 PM, Eduardo Valentin wrote: * PGP Signed by an unknown key On 06-01-2014 09:51, Mark Rutland wrote: On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: I think the platform driver may set governor for the thermal

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-13 Thread Wei Ni
On 01/14/2014 05:29 AM, Eduardo Valentin wrote: * PGP Signed by an unknown key Wei, On 06-01-2014 22:44, Wei Ni wrote: On 01/06/2014 10:54 PM, Eduardo Valentin wrote: Old Signed by an unknown key On 06-01-2014 09:51, Mark Rutland wrote: On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-07 Thread Wei Ni
On 01/07/2014 07:17 PM, Eduardo Valentin wrote: * PGP Signed by an unknown key On 06-01-2014 22:48, Wei Ni wrote: Hi, Eduardo Will you consider my comments :) By now Wei, it is better if you start a new thread, by sending a patch on top of it, as this thread has been already merged by

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-07 Thread Wei Ni
On 01/08/2014 11:24 AM, Hu Yaohui wrote: I am new here. How can I could not mail a new message to this mail list? TIA I use Thunderbird, it's a pretty good mail client :) On Tue, Jan 7, 2014 at 10:19 PM, Wei Ni w...@nvidia.com mailto:w...@nvidia.com wrote: On 01/07/2014 07:17 PM,

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-07 Thread Eduardo Valentin
On 06-01-2014 22:48, Wei Ni wrote: Hi, Eduardo Will you consider my comments :) By now Wei, it is better if you start a new thread, by sending a patch on top of it, as this thread has been already merged by Rui. Thanks. Wei. On 12/31/2013 06:17 PM, Wei Ni wrote: On 11/13/2013 03:46 AM,

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-07 Thread Mark Rutland
On Tue, Jan 07, 2014 at 02:44:10AM +, Wei Ni wrote: On 01/06/2014 10:54 PM, Eduardo Valentin wrote: * PGP Signed by an unknown key On 06-01-2014 09:51, Mark Rutland wrote: On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: I think the platform driver may set

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-06 Thread Mark Rutland
On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: I think the platform driver may set governor for the thermal zone, so how about to add a property named as governor, and parse it to tzp-governor_name, something like: ret =

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-06 Thread Eduardo Valentin
On 06-01-2014 09:51, Mark Rutland wrote: On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: I think the platform driver may set governor for the thermal zone, so how about to add a property named as governor, and parse it to tzp-governor_name, something like:

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-06 Thread Eduardo Valentin
On 02-01-2014 13:35, Matthew Longnecker wrote: Eduardo, Hello Matthew, For the most part, this binding is really well thought out. It makes a lot of sense to me (as someone who has been working with thermal management in Linux/Android-based mobile devices for a few years). No issues, I

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-06 Thread Wei Ni
On 01/06/2014 10:54 PM, Eduardo Valentin wrote: * PGP Signed by an unknown key On 06-01-2014 09:51, Mark Rutland wrote: On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: I think the platform driver may set governor for the thermal zone, so how about to add a property

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-02 Thread Matthew Longnecker
I think the platform driver may set governor for the thermal zone, so how about to add a property named as governor, and parse it to tzp-governor_name, something like: ret = of_property_read_string(child, governor, str); if (ret == 0)

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-02 Thread Matthew Longnecker
Eduardo, For the most part, this binding is really well thought out. It makes a lot of sense to me (as someone who has been working with thermal management in Linux/Android-based mobile devices for a few years). However, I have one substantive criticism. On 11/12/2013 11:46 AM, Eduardo

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-01 Thread Wei Ni
On 11/13/2013 03:46 AM, Eduardo Valentin wrote: ... + +/** + * of_parse_thermal_zones - parse device tree thermal data + * + * Initialization function that can be called by machine initialization + * code to parse thermal data and populate the thermal framework + * with hardware thermal

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-01 Thread Wei Ni
Sorry, please ignore this mail. This is not my regularly mail address. Thanks. Wei. On 01/02/2014 10:55 AM, Wei Ni wrote: On 11/13/2013 03:46 AM, Eduardo Valentin wrote: + +/** + * of_parse_thermal_zones - parse device tree thermal data + * + * Initialization function that can be

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-25 Thread Mark Rutland
[...] +* Trip points + +The trip node is a node to describe a point in the temperature domain +in which the system takes an action. This node describes just the point, +not the action. + +Required properties: +- temperature: An integer indicating the trip

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-25 Thread Mark Rutland
On Fri, Nov 22, 2013 at 12:33:34PM +, Eduardo Valentin wrote: Hello Tomasz, On 21-11-2013 12:32, Tomasz Figa wrote: On Thursday 21 of November 2013 11:48:08 Eduardo Valentin wrote: On 21-11-2013 10:57, Tomasz Figa wrote: On Friday 15 of November 2013 09:19:02 Eduardo Valentin

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-25 Thread Eduardo Valentin
On 25-11-2013 11:14, Mark Rutland wrote: [...] +* Trip points + +The trip node is a node to describe a point in the temperature domain +in which the system takes an action. This node describes just the point, +not the action. + +Required properties: +- temperature: An integer

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-25 Thread Mark Rutland
On Tue, Nov 12, 2013 at 07:46:04PM +, Eduardo Valentin wrote: This patch introduces a device tree bindings for describing the hardware thermal behavior and limits. Also a parser to read and interpret the data and feed it in the thermal framework is presented. This patch introduces a

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-25 Thread Eduardo Valentin
On 25-11-2013 11:31, Mark Rutland wrote: Any cooling device has a range of cooling states (i.e. different levels of heat dissipation). For example a fan's cooling states correspond to the different fan speeds possible. Cooling states are referred to by single unsigned integers, where larger

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-25 Thread Eduardo Valentin
On 25-11-2013 11:31, Mark Rutland wrote: I think if these are needed the set of types can be extended, no? As long as we have a real board with real use cases to be covered, yes, why not. -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin signature.asc

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-21 Thread Eduardo Valentin
On 21-11-2013 10:57, Tomasz Figa wrote: On Friday 15 of November 2013 09:19:02 Eduardo Valentin wrote: Hello Tomasz, On 14-11-2013 09:40, Tomasz Figa wrote: On Thursday 14 of November 2013 07:31:04 Eduardo Valentin wrote: On 13-11-2013 12:57, Tomasz Figa wrote: Hi Eduardo, Hello Tomaz

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-21 Thread Tomasz Figa
On Friday 15 of November 2013 09:19:02 Eduardo Valentin wrote: Hello Tomasz, On 14-11-2013 09:40, Tomasz Figa wrote: On Thursday 14 of November 2013 07:31:04 Eduardo Valentin wrote: On 13-11-2013 12:57, Tomasz Figa wrote: Hi Eduardo, Hello Tomaz On Tuesday 12 of November 2013

Re: [lm-sensors] [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-19 Thread Jean Delvare
Eduardo, Rui, I don't want to enter a long discussion here. I don't see get_trend() being implemented by any currently existing hwmon driver. But if you think future monitoring chips will be different and will be able to implement get_trend(), well, you'll know better. -- Jean Delvare -- To

Re: [lm-sensors] [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-18 Thread Eduardo Valentin
Hello Jean, I will try to complement what Rui's already commented. On 18-11-2013 02:04, Zhang Rui wrote: On δΊ”, 2013-11-15 at 09:07 +0100, Jean Delvare wrote: Hi Eduardo, On Tue, 12 Nov 2013 15:46:04 -0400, Eduardo Valentin wrote: This patch introduces a device tree bindings for describing

Re: [lm-sensors] [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-15 Thread Jean Delvare
Hi Eduardo, On Tue, 12 Nov 2013 15:46:04 -0400, Eduardo Valentin wrote: This patch introduces a device tree bindings for describing the hardware thermal behavior and limits. Also a parser to read and interpret the data and feed it in the thermal framework is presented. This patch

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-15 Thread Eduardo Valentin
Hello Tomasz, On 14-11-2013 09:40, Tomasz Figa wrote: On Thursday 14 of November 2013 07:31:04 Eduardo Valentin wrote: On 13-11-2013 12:57, Tomasz Figa wrote: Hi Eduardo, Hello Tomaz On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: This patch introduces a device tree

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-14 Thread Eduardo Valentin
On 13-11-2013 12:57, Tomasz Figa wrote: Hi Eduardo, Hello Tomaz On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: This patch introduces a device tree bindings for describing the hardware thermal behavior and limits. Also a parser to read and interpret the data and feed it

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-14 Thread Tomasz Figa
On Thursday 14 of November 2013 07:31:04 Eduardo Valentin wrote: On 13-11-2013 12:57, Tomasz Figa wrote: Hi Eduardo, Hello Tomaz On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: This patch introduces a device tree bindings for describing the hardware thermal

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-13 Thread Tomasz Figa
Hi Eduardo, On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: This patch introduces a device tree bindings for describing the hardware thermal behavior and limits. Also a parser to read and interpret the data and feed it in the thermal framework is presented. [snip] diff --git

[PATCHv9 02/20] thermal: introduce device tree parser

2013-11-12 Thread Eduardo Valentin
This patch introduces a device tree bindings for describing the hardware thermal behavior and limits. Also a parser to read and interpret the data and feed it in the thermal framework is presented. This patch introduces a thermal data parser for device tree. The parsed data is used to build