Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Michael Turquette
Quoting Doug Anderson (2015-08-28 14:08:52) Mike, On Fri, Aug 28, 2015 at 1:02 PM, Michael Turquette mturque...@linaro.org wrote: Hi Doug, Quoting Doug Anderson (2015-08-27 19:03:20) Kevin, On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman khil...@kernel.org wrote: That is not

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Kevin Hilman
Michael Turquette mturque...@linaro.org writes: Hi Doug, Quoting Doug Anderson (2015-08-27 19:03:20) Kevin, On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman khil...@kernel.org wrote: That is not really workable: the attach and detach happen in probe/remove path; if you do not have driver

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Doug Anderson
Mike, On Fri, Aug 28, 2015 at 1:02 PM, Michael Turquette mturque...@linaro.org wrote: Hi Doug, Quoting Doug Anderson (2015-08-27 19:03:20) Kevin, On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman khil...@kernel.org wrote: That is not really workable: the attach and detach happen in

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Michael Turquette
Hi Doug, Quoting Doug Anderson (2015-08-27 19:03:20) Kevin, On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman khil...@kernel.org wrote: That is not really workable: the attach and detach happen in probe/remove path; if you do not have driver for the device you will miss the clocks for it.

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-27 Thread Doug Anderson
Kevin, On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman khil...@kernel.org wrote: That is not really workable: the attach and detach happen in probe/remove path; if you do not have driver for the device you will miss the clocks for it. And in my proposal, I suggested that clocks without drivers

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-27 Thread Kevin Hilman
Dmitry Torokhov dmitry.torok...@gmail.com writes: On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman khil...@kernel.org wrote: Doug Anderson diand...@chromium.org writes: To put things in a concrete way, for pd_vio we'd go through the entire device tree ourselves and find all properties that

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-26 Thread Caesar Wang
在 2015年08月26日 06:45, Kevin Hilman 写道: Doug Anderson diand...@chromium.org writes: Kevin, On Tue, Aug 25, 2015 at 2:07 PM, Kevin Hilman khil...@kernel.org wrote: Caesar Wang w...@rock-chips.com writes: We can add more domains node in the future. This patch add the needed clocks into

[RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Caesar Wang
We can add more domains node in the future. This patch add the needed clocks into power-controller. As the discuess about all the device clocks being listed in the power-domains itself. There are several reasons as follows: Firstly, the clocks need be turned off to save power when the system

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Kevin Hilman
Doug Anderson diand...@chromium.org writes: Kevin, On Tue, Aug 25, 2015 at 2:07 PM, Kevin Hilman khil...@kernel.org wrote: Caesar Wang w...@rock-chips.com writes: We can add more domains node in the future. This patch add the needed clocks into power-controller. As the discuess about all

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Dmitry Torokhov
On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman khil...@kernel.org wrote: Doug Anderson diand...@chromium.org writes: To put things in a concrete way, for pd_vio we'd go through the entire device tree ourselves and find all properties that look like power-domains = power RK3288_PD_VIO;. We'd

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Doug Anderson
Kevin, On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman khil...@kernel.org wrote: To put things in a concrete way, for pd_vio we'd go through the entire device tree ourselves and find all properties that look like power-domains = power RK3288_PD_VIO;. We'd then find the parent of those

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Kevin Hilman
Caesar Wang w...@rock-chips.com writes: We can add more domains node in the future. This patch add the needed clocks into power-controller. As the discuess about all the device clocks being listed in the power-domains itself. There are several reasons as follows: Firstly, the clocks need

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Doug Anderson
Kevin, On Tue, Aug 25, 2015 at 2:07 PM, Kevin Hilman khil...@kernel.org wrote: Caesar Wang w...@rock-chips.com writes: We can add more domains node in the future. This patch add the needed clocks into power-controller. As the discuess about all the device clocks being listed in the