Re: [RFC] improve binding for linux,wdt-gpio

2015-07-30 Thread Uwe Kleine-König
Hello, while hacking on the gpio driver I found yet another ambiguity: On Tue, Jul 28, 2015 at 10:33:48PM +0200, Uwe Kleine-König wrote: - - level: Low or high level starts counting WDT timeout, -the opposite level disables the WDT. Active level is determined -by the GPIO flags. The

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-30 Thread Uwe Kleine-König
Hello Guenter, On Wed, Jul 29, 2015 at 08:49:23AM -0700, Guenter Roeck wrote: On 07/29/2015 12:35 AM, Uwe Kleine-König wrote: always-running is meant to indicate that the watchdog can not be stopped (meaning a timer has to be used to send keepalives while the watchdog device is closed). The

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-30 Thread Mike Looijmans
On 29-07-15 09:35, Uwe Kleine-König wrote: Hello Guenter, On Tue, Jul 28, 2015 at 02:21:55PM -0700, Guenter Roeck wrote: On Tue, Jul 28, 2015 at 10:33:48PM +0200, Uwe Kleine-König wrote: This is just a suggestion up to now, I don't have any code yet to share. Apart from minor rewording to

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-30 Thread Uwe Kleine-König
Hello Mike, On Thu, Jul 30, 2015 at 08:15:30AM +0200, Mike Looijmans wrote: I'd go for these properties then: toggle-gpio: the gpio used to stroke the watchdog enable-gpio: optional, the gpio to enable and disable the watchdog disable-on-tri-state: optional, signals that the

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-30 Thread Uwe Kleine-König
Hello Guenter, On Thu, Jul 30, 2015 at 12:25:07AM -0700, Guenter Roeck wrote: On 07/29/2015 11:59 PM, Uwe Kleine-König wrote: On Wed, Jul 29, 2015 at 08:49:23AM -0700, Guenter Roeck wrote: On 07/29/2015 12:35 AM, Uwe Kleine-König wrote: always-running is meant to indicate that the watchdog

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-30 Thread Guenter Roeck
Hi Uwe, On 07/29/2015 11:59 PM, Uwe Kleine-König wrote: Hello Guenter, On Wed, Jul 29, 2015 at 08:49:23AM -0700, Guenter Roeck wrote: On 07/29/2015 12:35 AM, Uwe Kleine-König wrote: always-running is meant to indicate that the watchdog can not be stopped (meaning a timer has to be used to

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-29 Thread Guenter Roeck
Hi Uwe, On 07/29/2015 12:35 AM, Uwe Kleine-König wrote: Hello Guenter, [ ... ] always-running is meant to indicate that the watchdog can not be stopped (meaning a timer has to be used to send keepalives while the watchdog device is closed). The documentation specifically states that.

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-29 Thread Uwe Kleine-König
Hello Guenter, On Tue, Jul 28, 2015 at 02:21:55PM -0700, Guenter Roeck wrote: On Tue, Jul 28, 2015 at 10:33:48PM +0200, Uwe Kleine-König wrote: This is just a suggestion up to now, I don't have any code yet to share. Apart from minor rewording to make the document easier to understand and

Re: [RFC] improve binding for linux,wdt-gpio

2015-07-28 Thread Guenter Roeck
Hi Uwe, On Tue, Jul 28, 2015 at 10:33:48PM +0200, Uwe Kleine-König wrote: This is just a suggestion up to now, I don't have any code yet to share. Apart from minor rewording to make the document easier to understand and less ambiguous the relevant changes are: - add an enable-gpio

[RFC] improve binding for linux,wdt-gpio

2015-07-28 Thread Uwe Kleine-König
This is just a suggestion up to now, I don't have any code yet to share. Apart from minor rewording to make the document easier to understand and less ambiguous the relevant changes are: - add an enable-gpio property. I admit the device I'm currently working with doesn't have this. Still