Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-10 Thread Anish Khurana
small suggestions regarding interrupt registration ( request_irq()) call: 1. instead of request_irq() call in probe function , i think interrupt can be registered in dwceqos_open() call . since packet only come when we make interface up( ifconfig up) . 2. in request_irq() thier is flag parameter ca

Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-09 Thread Tobias Klauser
On 2014-05-08 at 14:50:14 +0200, Andreas Irestal wrote: > This is an early version of a driver for the Synopsys DWC Ethernet QoS IP > version 4. Unfortunately, version 4.00a and onwards of this IP is totally > different from earlier versions used in the STMicroelectronics drivers. Both > function

Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-08 Thread Andreas Irestål
On Thursday 08 May 2014 19:29:37 David Miller wrote: > > Why did you post this patch twice? Is there some difference between > the two versions? No they're not. It was a mistake by me as the patch did not appear on my netdev subscription, fooling me to send a second time. Please ignore the dupl

Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-08 Thread David Miller
Why did you post this patch twice? Is there some difference between the two versions? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-08 Thread Andreas Irestål
> > Signed-off-by: Andreas Irestaal > > --- > > drivers/net/ethernet/Kconfig|1 + > > drivers/net/ethernet/Makefile |1 + > > drivers/net/ethernet/synopsys/Kconfig | 24 + > > drivers/net/ethernet/synopsys/Makefile |5 + > > drivers/net/ether

Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-08 Thread Arnd Bergmann
On Thursday 08 May 2014 16:18:04 Andreas Irestål wrote: > > > > + > > > + /* Set poll wait timeout to 2 seconds */ > > > + dwc_wait = 200; > > > + > > > + while (lp->tx_descs[i].tdes3.wr.own) { > > > + mdelay(10); > > > + if (!dwc_wait--) > > > + break;

Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-08 Thread Arnd Bergmann
On Thursday 08 May 2014 13:49:02 Andreas Irestal wrote: > This is an early version of a driver for the Synopsys DWC Ethernet QoS IP > version 4. Unfortunately, version 4.00a and onwards of this IP is totally > different from earlier versions used in the STMicroelectronics drivers. Both > functional

[RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-08 Thread Andreas Irestal
This is an early version of a driver for the Synopsys DWC Ethernet QoS IP version 4. Unfortunately, version 4.00a and onwards of this IP is totally different from earlier versions used in the STMicroelectronics drivers. Both functionality and registers are different. As this is my first network dri

[RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-08 Thread Andreas Irestal
This is an early version of a driver for the Synopsys DWC Ethernet QoS IP version 4. Unfortunately, version 4.00a and onwards of this IP is totally different from earlier versions used in the STMicroelectronics drivers. Both functionality and registers are different. As this is my first network dri