Re: [RFC PATCH v3 3/8] regulator: add pbias regulator support

2013-12-03 Thread Balaji T K
On Thursday 21 November 2013 08:16 PM, Mark Brown wrote: On Thu, Nov 21, 2013 at 07:50:22PM +0530, Balaji T K wrote: +static int pbias_regulator_set_voltage(struct regulator_dev *dev, + int min_uV, int max_uV, unsigned *selector) +{ + struct pbias_regulator_data

Re: [RFC PATCH v3 3/8] regulator: add pbias regulator support

2013-12-03 Thread Mark Brown
On Tue, Dec 03, 2013 at 09:24:15PM +0530, Balaji T K wrote: On Thursday 21 November 2013 08:16 PM, Mark Brown wrote: These don't match up with each other - the get and set voltage calls should reflect what the hardware state is, not what was requested by the caller. You should be able to use

Re: [RFC PATCH v3 3/8] regulator: add pbias regulator support

2013-11-21 Thread Mark Brown
On Thu, Nov 21, 2013 at 07:50:22PM +0530, Balaji T K wrote: +static int pbias_regulator_set_voltage(struct regulator_dev *dev, + int min_uV, int max_uV, unsigned *selector) +{ + struct pbias_regulator_data *data = rdev_get_drvdata(dev); + const struct