Re: [RFC v3 05/13] ahci-platform: Pass ahci_host_priv ptr to ahci_platform_data init method

2014-01-20 Thread Tejun Heo
On Sun, Jan 19, 2014 at 08:56:09PM +0100, Hans de Goede wrote: Ok, asking the obvious here I guess, but you would accept a patch moving drivers/ata/ahci.h to include/linux as part of this patch-set ? Wouldn't creating a minimal file which only contains the necessary bits make more sense?

Re: [RFC v3 05/13] ahci-platform: Pass ahci_host_priv ptr to ahci_platform_data init method

2014-01-19 Thread Hans de Goede
Hi, On 01/19/2014 08:17 PM, Tejun Heo wrote: On Sun, Jan 19, 2014 at 07:51:48PM +0100, Hans de Goede wrote: Yes, but they are part of arch/arm/mach-foo, so moving them is non trivial, and I don't want to go make these kinda changes without hardware to test. Please keep in mind that I'm

[RFC v3 05/13] ahci-platform: Pass ahci_host_priv ptr to ahci_platform_data init method

2014-01-18 Thread Hans de Goede
Some ahci_platform_data-init methods need access to the ahci_host_priv data. Note: When calling ahci_platform_data-init the ata_host has not been allocated yet, so access to ahci_host_priv through the dev argument is not possible. The hpriv-mmio argument may seem redundant, but it is useful for