Re: [alsa-devel] [PATCH 1/3] ASoC: samsung: Add machine driver for Trats2

2015-01-05 Thread Inha Song
Hi, Thanks for your comments. > Hi, > > A few small comments inline. > > On 01/05/2015 12:25 PM, Inha Song wrote: > > --- /dev/null > > +++ b/sound/soc/samsung/trats2_wm1811.c > > @@ -0,0 +1,216 @@ > >[...] > > +#include > > +#include > > +#include > > +#include > > +#include > > +#includ

Re: [alsa-devel] [PATCH 1/3] ASoC: samsung: Add machine driver for Trats2

2015-01-05 Thread Lars-Peter Clausen
Hi, A few small comments inline. On 01/05/2015 12:25 PM, Inha Song wrote: --- /dev/null +++ b/sound/soc/samsung/trats2_wm1811.c @@ -0,0 +1,216 @@ [...] +#include +#include +#include +#include +#include +#include "i2s.h" +#include "i2s-regs.h" You probably don't need i2s-regs.h +#includ

[alsa-devel] [PATCH 1/3] ASoC: samsung: Add machine driver for Trats2

2015-01-05 Thread Inha Song
This patch add the sound machine driver for Trats2 board. The codec operate in master mode. So, Reference to the codec master clock must be defined in DT. Signed-off-by: Inha Song --- sound/soc/samsung/Kconfig | 8 ++ sound/soc/samsung/Makefile| 2 + sound/soc/samsung/trats2_