Re: [linux-sunxi] Re: [PATCH 2/5] ARM: dts: sun4i: Add support for mmc

2013-12-16 Thread David Lanzendörfer
Hi Note as said before I expect David to take things from here. I will start working on it this evening. I just took what David was using. I agree picking one and staying with it would be better. There is a reason why my working branch was called plsdsif (short for Please don't shout at me in

Re: [linux-sunxi] Re: [PATCH 2/5] ARM: dts: sun4i: Add support for mmc

2013-12-16 Thread Maxime Ripard
Hi Hans, Damn google-groups removed me from Cc :) On Sun, Dec 15, 2013 at 03:31:29PM +0100, Hans de Goede wrote: @@ -376,6 +385,13 @@ allwinner,drive = 0; allwinner,pull = 0; }; + + sdc0_pins_a:

Re: [linux-sunxi] Re: [PATCH 2/5] ARM: dts: sun4i: Add support for mmc

2013-12-16 Thread Hans de Goede
Hi, On 12/16/2013 10:04 AM, David Lanzendörfer wrote: snip Yes and no. The pullups are enabled by uboot and the allwinner sources, most of my testing has been done without them, which seems to work fine. I've enabled them to be consisten with the allwinner sources and u-boot. Ok As for

Re: [linux-sunxi] Re: [PATCH 2/5] ARM: dts: sun4i: Add support for mmc

2013-12-16 Thread Hans de Goede
Hi, On 12/16/2013 11:02 AM, Maxime Ripard wrote: Hi Hans, Damn google-groups removed me from Cc :) On Sun, Dec 15, 2013 at 03:31:29PM +0100, Hans de Goede wrote: @@ -376,6 +385,13 @@ allwinner,drive = 0; allwinner,pull = 0;

Re: [linux-sunxi] Re: [PATCH 2/5] ARM: dts: sun4i: Add support for mmc

2013-12-15 Thread Hans de Goede
Hi, On 12/15/2013 02:58 PM, Maxime Ripard wrote: Hi Hans, On Sat, Dec 14, 2013 at 10:58:12PM +0100, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Commit-log :) Heh. Note as said before I expect David to take things from here. ---

Re: [linux-sunxi] Re: [PATCH 2/5] ARM: dts: sun4i: Add support for mmc

2013-12-15 Thread Henrik Nordström
sön 2013-12-15 klockan 15:31 +0100 skrev Hans de Goede: Yes and no. The pullups are enabled by uboot and the allwinner sources, most of my testing has been done without them, which seems to work fine. I've enabled them to be consisten with the allwinner sources and u-boot. Many boards have