Re: [PATCH 1/3] regulator: act8865: add PMIC(Power Management IC) driver

2013-12-13 Thread Mark Brown
On Fri, Dec 13, 2013 at 07:10:36AM +, Yang, Wenyou wrote: > > Please keep this and the Makefile sorted. > Only this one confuses me, > How can I sort it? By i2c interface, by regulator type: voltage or current? > Where is act8865 should be? By name - look at the existing entries. signature

RE: [PATCH 1/3] regulator: act8865: add PMIC(Power Management IC) driver

2013-12-12 Thread Yang, Wenyou
.org; > devicetree@vger.kernel.org; linux-ker...@vger.kernel.org; linux- > d...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > plagn...@jcrosoft.com; Ferre, Nicolas > Subject: Re: [PATCH 1/3] regulator: act8865: add PMIC(Power Management > IC) driver > > On Thu, Dec 12, 2013

Re: [PATCH 1/3] regulator: act8865: add PMIC(Power Management IC) driver

2013-12-12 Thread Mark Brown
On Thu, Dec 12, 2013 at 09:18:49AM +0800, Wenyou Yang wrote: The main thing with this driver seems to be that it needs a bit of modernisation to use current kernel features and APIs - there's nothing terribly wrong from a quick glance through but it needs an update. Details below. > --- a/drivers