Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-12-12 Thread Linus Walleij
On Wed, Dec 11, 2013 at 1:05 AM, Sherman Yin wrote: > I was just trying to move "select PINCTRL" to a defconfig as Christian > suggested. However, CONFIG_PINCTRL is not selectable by a defconfig file > (the option will be gone by the time .config is generated), even though > PINCTRL has no depen

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-12-10 Thread Sherman Yin
On 13-10-17 08:31 AM, Christian Daudt wrote: On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren wrote: On 10/17/2013 12:03 AM, Christian Daudt wrote: On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin wrote: Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. Signed-off-by: Sherman Yin Reviewed-

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-19 Thread Linus Walleij
On Thu, Nov 14, 2013 at 12:43 AM, Sherman Yin wrote: > On 13-11-11 02:01 AM, Linus Walleij wrote: >>> >>> I would imagine that the platform-specific device tree bindings would >>> need >>> to clearly explain what the valid values are, as they should. >> >> But this is not a platform-specific bindi

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-13 Thread Sherman Yin
On 13-11-11 02:01 AM, Linus Walleij wrote: I would imagine that the platform-specific device tree bindings would need to clearly explain what the valid values are, as they should. But this is not a platform-specific binding. These are the generic pin configuration bindings we're talking about.

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-11 Thread Linus Walleij
On Fri, Nov 8, 2013 at 1:29 AM, Sherman Yin wrote: > [Me] >> On Wed, Nov 6, 2013 at 3:02 AM, Sherman Yin wrote: >> You would have to patch the OF core to do something like that: >> >> bias-pull-up = ; >> >> 1/0 isn't so good I think, what should the parser do with e.g. 2? >> This is more to the

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-07 Thread Sherman Yin
On 13-11-06 01:40 AM, Linus Walleij wrote: On Wed, Nov 6, 2013 at 3:02 AM, Sherman Yin wrote: When Linus asked me to try using generic pinconf instead, I ran into problems with this feature due to how the generic pinconf properties are defined differently than my properties - perhaps this featu

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-07 Thread Sherman Yin
On 13-11-06 09:00 AM, Stephen Warren wrote: You probably don't want to reference the individual xxx1/2/3 nodes in the client pinctrl properties, but instead wrap them in a higher-level node that represents the whole pinctrl state. Then, the client pinctrl properties can reference just that single

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-06 Thread Stephen Warren
On 11/05/2013 07:02 PM, Sherman Yin wrote: > On 13-11-04 04:04 PM, Stephen Warren wrote: >> On 11/04/2013 04:26 PM, Heiko Stübner wrote: >> >>> I remember we had a discussion about how things like bias-disable >>> explicitly >>> shouldn't have a value, when they are represented in the list-format:

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-06 Thread Linus Walleij
On Wed, Nov 6, 2013 at 3:02 AM, Sherman Yin wrote: > If I understand correctly, in Stephen's example, if a certain driver wants > to configure PINA PINB and PINC, the pin configuration nodes "xxx1", "xxx2", > and "xxx3" will all have to be selected for the particular pin state. This > works fine

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-06 Thread Linus Walleij
On Tue, Nov 5, 2013 at 1:04 AM, Stephen Warren wrote: > On 11/04/2013 04:26 PM, Heiko Stübner wrote: > Pure Boolean values should be represented as a valueless property. If > the property is present, the value is true, otherwise false. > > However, pinctrl bindings often don't represent Boolean v

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-05 Thread Sherman Yin
On 13-11-04 04:04 PM, Stephen Warren wrote: On 11/04/2013 04:26 PM, Heiko Stübner wrote: I remember we had a discussion about how things like bias-disable explicitly shouldn't have a value, when they are represented in the list-format: pcfg_pull_none: pcfg_pull_none {

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-04 Thread Stephen Warren
On 11/04/2013 04:26 PM, Heiko Stübner wrote: > I remember we had a discussion about how things like bias-disable explicitly > shouldn't have a value, when they are represented in the list-format: > > pcfg_pull_none: pcfg_pull_none { > bias-disable; >

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-04 Thread Heiko Stübner
Am Montag, 4. November 2013, 13:24:10 schrieb Linus Walleij: > > In my driver, I have the "one entry per pin" support for all my > > properties instead of just the function property, like the "drive_str" > > property below: > > > > + grp_1 { > > + brcm,pins

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-11-04 Thread Linus Walleij
On Sat, Oct 26, 2013 at 12:48 AM, Sherman Yin wrote: > So I will go ahead and make the change in pinconf-generic.c and > pinctrl-bindings.txt > to include parsing of the "slew-rate" property and submit it as part of my > pinctrl > changes. OK, good. > Question regarding pinctrl-generic: in pi

RE: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-25 Thread Sherman Yin
>As well as all this stuff... OK. Will see if I can find something suitable for "input disable" and "mode" >>> >>>Let's discuss this. What exactly does "input disable" and "mode" >>>mean, in electrical terms? >>> >>>When you come down to what actually happens it may turn out th

RE: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-22 Thread Sherman Yin
> +static const struct capri_cfg_param capri_pinconf_params[] = { > + {"brcm,hysteresis", CAPRI_PINCONF_PARAM_HYST}, > + {"brcm,pull", CAPRI_PINCONF_PARAM_PULL}, > + {"brcm,slew", CAPRI_PINCONF_PARAM_SLEW}, > + {"brcm,input_dis",

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-17 Thread Christian Daudt
On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren wrote: > On 10/17/2013 12:03 AM, Christian Daudt wrote: >> On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin wrote: >>> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. >>> >>> Signed-off-by: Sherman Yin >>> Reviewed-by: Christian Daudt >>> Revie

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-17 Thread Stephen Warren
On 10/17/2013 12:03 AM, Christian Daudt wrote: > On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin wrote: >> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. >> >> Signed-off-by: Sherman Yin >> Reviewed-by: Christian Daudt >> Reviewed-by: Matt Porter >> --- >> arch/arm/mach-bcm/Kconfig

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-16 Thread Christian Daudt
On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin wrote: > Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. > > Signed-off-by: Sherman Yin > Reviewed-by: Christian Daudt > Reviewed-by: Matt Porter > --- > arch/arm/mach-bcm/Kconfig |2 + > drivers/pinctrl/Kconfig | 10 + >

RE: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-11 Thread Sherman Yin
+static const struct capri_cfg_param capri_pinconf_params[] = { + {"brcm,hysteresis", CAPRI_PINCONF_PARAM_HYST}, + {"brcm,pull", CAPRI_PINCONF_PARAM_PULL}, + {"brcm,slew", CAPRI_PINCONF_PARAM_SLEW}, + {"brcm,input_dis", C

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-11 Thread Linus Walleij
On Fri, Oct 11, 2013 at 1:48 AM, Sherman Yin wrote: >>> +static const struct capri_cfg_param capri_pinconf_params[] = { >>> + {"brcm,hysteresis", CAPRI_PINCONF_PARAM_HYST}, >>> + {"brcm,pull", CAPRI_PINCONF_PARAM_PULL}, >>> + {"brcm,slew", CAPRI_PINCONF_P

RE: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-10 Thread Sherman Yin
>> +config PINCTRL_CAPRI >> + bool "Broadcom Capri pinctrl driver" >> + select PINMUX >> + select PINCONF >> + help >> + Say Y here to support Broadcom Capri pinctrl driver, which is used >> for >> + the BCM281xx SoC family, including BCM11130, BCM11140, BCM

Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

2013-10-09 Thread Linus Walleij
On Fri, Oct 4, 2013 at 2:23 AM, Sherman Yin wrote: > Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. > > Signed-off-by: Sherman Yin > Reviewed-by: Christian Daudt > Reviewed-by: Matt Porter (...) > +config PINCTRL_CAPRI > + bool "Broadcom Capri pinctrl driver" > + select P