Re: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-27 Thread Lars-Peter Clausen
On 11/27/2013 05:44 AM, Fugang Duan wrote: [...] + if (info-vref) + info-vref_uv = regulator_get_voltage(info-vref); + else if (of_property_read_u32(np, fsl,adc-vref, info-vref_uv)) + dev_err(info-dev, + Miss adc-vref property or vref regulator in the

RE: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-27 Thread Fugang Duan
From: Lars-Peter Clausen [mailto:l...@metafoo.de] Data: Wednesday, November 27, 2013 4:21 PM To: Duan Fugang-B38611 Cc: ji...@kernel.org; sachin.ka...@linaro.org; devicetree@vger.kernel.org; shawn@linaro.org; Li Frank-B20596; linux-...@vger.kernel.org Subject: Re: [PATCH v3 2/3] iio:adc:imx

Re: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-27 Thread Mark Rutland
-...@vger.kernel.org Subject: Re: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver On Tue, Nov 26, 2013 at 10:56:33AM +, Fugang Duan wrote: Add Freescale Vybrid vf610 adc driver. The driver only support ADC software trigger. Signed-off-by: Fugang Duan b38

RE: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-27 Thread Fugang Duan
@linaro.org; Li Frank-B20596; linux-...@vger.kernel.org Subject: Re: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver On Tue, Nov 26, 2013 at 10:56:33AM +, Fugang Duan wrote: Add Freescale Vybrid vf610 adc driver. The driver only support ADC software trigger. Signed-off

Re: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-26 Thread Lars-Peter Clausen
On 11/26/2013 11:56 AM, Fugang Duan wrote: Add Freescale Vybrid vf610 adc driver. The driver only support ADC software trigger. Signed-off-by: Fugang Duan b38...@freescale.com The driver itself looks mostly fine. I'm not so sure about the dt bindings though. --- drivers/iio/adc/Kconfig

Re: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-26 Thread Mark Rutland
On Tue, Nov 26, 2013 at 10:56:33AM +, Fugang Duan wrote: Add Freescale Vybrid vf610 adc driver. The driver only support ADC software trigger. Signed-off-by: Fugang Duan b38...@freescale.com --- drivers/iio/adc/Kconfig | 11 + drivers/iio/adc/Makefile|1 +

RE: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-26 Thread Fugang Duan
From: Lars-Peter Clausen l...@metafoo.de Data: Tuesday, November 26, 2013 7:52 PM To: Duan Fugang-B38611 Cc: ji...@kernel.org; sachin.ka...@linaro.org; devicetree@vger.kernel.org; shawn@linaro.org; Li Frank-B20596; linux-...@vger.kernel.org Subject: Re: [PATCH v3 2/3] iio:adc:imx: add

RE: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver

2013-11-26 Thread Fugang Duan
From: Mark Rutland mark.rutl...@arm.com Data: Tuesday, November 26, 2013 10:26 PM To: Duan Fugang-B38611 Cc: ji...@kernel.org; sachin.ka...@linaro.org; devicetree@vger.kernel.org; shawn@linaro.org; Li Frank-B20596; linux-...@vger.kernel.org Subject: Re: [PATCH v3 2/3] iio:adc:imx: add