Re: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 08:36 AM, Peter Chen wrote: The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 58

Re: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Peter Chen
On Tue, Dec 03, 2013 at 09:38:20AM +0100, Marc Kleine-Budde wrote: On 12/03/2013 08:36 AM, Peter Chen wrote: The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Michael Grzeschik
On Tue, Dec 03, 2013 at 03:36:56PM +0800, Peter Chen wrote: The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 58

RE: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Peter Chen
+ +static const struct mxs_phy_data imx23_phy_data = { + .flags = MXS_PHY_ABNORAML_IN_SUSPEND | MXS_PHY_SENDING_SOF_TOO_FAST, +}; ABNORAML? - ABNORMAL My careless, will change. Thanks. Peter + +static const struct mxs_phy_data imx6q_phy_data = { + .flags =