Re: [RFC PATCH v2 1/3] dtc: dts source location annotation

2015-09-22 Thread David Gibson
On Tue, Sep 22, 2015 at 10:10:42AM -0700, Frank Rowand wrote: > On 9/22/2015 3:32 AM, David Gibson wrote: > > On Mon, Sep 21, 2015 at 10:36:47PM -0700, Frank Rowand wrote: > >> From: Frank Rowand [snip] > >> @@ -71,6 +72,7 @@ static struct option const usage_long_op > >>{"error",

Re: [RFC PATCH v2 2/3] dtc: make check test for dtc --annotate

2015-09-22 Thread David Gibson
On Tue, Sep 22, 2015 at 10:21:55AM -0700, Frank Rowand wrote: > On 9/22/2015 3:39 AM, David Gibson wrote: > > On Mon, Sep 21, 2015 at 10:38:27PM -0700, Frank Rowand wrote: > >> From: Frank Rowand > >> > >> Add dtc tests. > >> > >> - dtc --annotate to create a .dts with annotations > >> - compi

Re: [RFC PATCH v2 3/3] dtc: linux kernel build process to create annotated .dts

2015-09-22 Thread Frank Rowand
On 9/22/2015 3:40 AM, David Gibson wrote: > On Mon, Sep 21, 2015 at 10:39:46PM -0700, Frank Rowand wrote: >> From: Frank Rowand >> >> Add a new temp file in the build directory arch/${arch}/boot/dts/ >> that contains the expanded device tree source with source file locations. >> >> Requires a new

Re: [RFC PATCH v2 2/3] dtc: make check test for dtc --annotate

2015-09-22 Thread Frank Rowand
On 9/22/2015 3:39 AM, David Gibson wrote: > On Mon, Sep 21, 2015 at 10:38:27PM -0700, Frank Rowand wrote: >> From: Frank Rowand >> >> Add dtc tests. >> >> - dtc --annotate to create a .dts with annotations >> - compile the annotated .dts >> - compare the .dts created from include0.dts to the

Re: [RFC PATCH v2 1/3] dtc: dts source location annotation

2015-09-22 Thread Frank Rowand
On 9/22/2015 3:32 AM, David Gibson wrote: > On Mon, Sep 21, 2015 at 10:36:47PM -0700, Frank Rowand wrote: >> From: Frank Rowand >> >> Proof of concept patch. > > Still like the idea, still some some problems with the implementation. > >> Annotates input source file and line number of nodes and p

Re: [RFC PATCH v2 3/3] dtc: linux kernel build process to create annotated .dts

2015-09-22 Thread David Gibson
On Mon, Sep 21, 2015 at 10:39:46PM -0700, Frank Rowand wrote: > From: Frank Rowand > > Add a new temp file in the build directory arch/${arch}/boot/dts/ > that contains the expanded device tree source with source file locations. > > Requires a new version of the dtc compiler that understands the

Re: [RFC PATCH v2 1/3] dtc: dts source location annotation

2015-09-22 Thread David Gibson
On Mon, Sep 21, 2015 at 10:36:47PM -0700, Frank Rowand wrote: > From: Frank Rowand > > Proof of concept patch. Still like the idea, still some some problems with the implementation. > Annotates input source file and line number of nodes and properties > as comments in output .dts file when --an

Re: [RFC PATCH v2 2/3] dtc: make check test for dtc --annotate

2015-09-22 Thread David Gibson
On Mon, Sep 21, 2015 at 10:38:27PM -0700, Frank Rowand wrote: > From: Frank Rowand > > Add dtc tests. > > - dtc --annotate to create a .dts with annotations > - compile the annotated .dts > - compare the .dts created from include0.dts to the .dts created > by first compiling include0.d