Re: RFC: proposal to extend the open-pic interrupt specifierdefinition

2010-01-06 Thread David Gibson
On Wed, Jan 06, 2010 at 08:33:03PM -0700, Yoder Stuart-B08248 wrote: > > From: > > devicetree-discuss-bounces+stuart.yoder=freescale@lists.oz > labs.org [mailto:devicetree-discuss-> > bounces+stuart.yoder=freescale@lists.ozlabs.org] On > > Behalf Of David Gibson > > Sent: Wednesday, Janua

RE: RFC: proposal to extend the open-pic interrupt specifierdefinition

2010-01-06 Thread Yoder Stuart-B08248
> -Original Message- > From: > devicetree-discuss-bounces+stuart.yoder=freescale@lists.oz labs.org [mailto:devicetree-discuss-> bounces+stuart.yoder=freescale@lists.ozlabs.org] On > Behalf Of David Gibson > Sent: Wednesday, January 06, 2010 6:51 PM > To: Yoder Stuart-B08248 > C

Re: RFC: proposal to extend the open-pic interrupt specifier definition

2010-01-06 Thread David Gibson
On Tue, Jan 05, 2010 at 04:28:12PM -0700, Yoder Stuart-B08248 wrote: > > The current open-pic binding defines that interrupt specifiers > have 2 cells-- an interrupt number and level/sense encoding. > > With chips like the P4080 this is no longer sufficient to > represent the various types of int

Re: [PATCH 02/11] arm: use generic infrastructure for early params

2010-01-06 Thread Jeremy Kerr
Russell, > This is something which should be separate from the rest of the DT > patch - could we have this as a patch which can be applied to the > current kernel tree please? Sure, patch coming. The first three patches of this series (prefixed with arm:, rather than arm- dt:) are all generic ar

Re: [PATCH 02/11] arm: use generic infrastructure for early params

2010-01-06 Thread Russell King - ARM Linux
On Tue, Dec 22, 2009 at 06:54:56PM +0800, Jeremy Kerr wrote: > The ARM setup code includes its own parser for early params, there's > also one in the generic init code. This is something which should be separate from the rest of the DT patch - could we have this as a patch which can be applied to

Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-06 Thread Wolfram Sang
> > It still works here and, as I see it, all issues were resolved as discussed. > > OK, fine if I add your acked-by then? I wanted to add a 'Reviewed-by' after I checked V3. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Sol

Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-06 Thread Wolfgang Grandegger
Wolfram Sang wrote: >> Wolfram, is it OK from your point of view now? I will roll out v3 after >> some more thorough testing tomorrow. > > It still works here and, as I see it, all issues were resolved as discussed. OK, fine if I add your acked-by then? Thanks, Wolfgang. __

Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-06 Thread Wolfram Sang
> Wolfram, is it OK from your point of view now? I will roll out v3 after > some more thorough testing tomorrow. It still works here and, as I see it, all issues were resolved as discussed. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Indust

Re: [PATCH net-next v2 1/3] can: mscan: fix improper return if dlc < 8 in start_xmit function

2010-01-06 Thread Wolfram Sang
On Tue, Jan 05, 2010 at 08:19:27PM +0100, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > The start_xmit function of the MSCAN Driver did return improperly if > the CAN dlc check failed (skb not freed and invalid return code). This > patch adds a proper check of the frame lenght and da

Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-06 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: > This patch series adds support for the MPC512x from Freescale to > the mpc5xxx_can MSCAN driver. > > Changes since v1: > > - Various coding style issues, printk formats, variable names and > error messagaes and typos fixes or improved > > - MPC5xxx specific data ar