[PATCH] of/device: Fix build errors for non-ppc and non-microblaze

2010-07-14 Thread Grant Likely
Only powerpc and microblaze supply (struct device *)->archdata.dma_mask. This patch stops referencing it on other architectures. Signed-off-by: Grant Likely --- drivers/of/platform.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/

Re: [PATCH 2/3] of/flattree: Fix crash when device tree absent

2010-07-14 Thread Grant Likely
On Wed, Jul 14, 2010 at 7:11 PM, Jeremy Kerr wrote: > Hi Grant, > >> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c >> index d61fda8..66401bc 100644 >> --- a/drivers/of/fdt.c >> +++ b/drivers/of/fdt.c >> @@ -94,6 +94,8 @@ int __init of_scan_flat_dt(int (*it)(unsigned long node, >>              

[PATCH 05/11] tulip: formatting of pointers in printk()

2010-07-14 Thread Kulikov Vasiliy
Use %p instead of %08x in printk(). Signed-off-by: Kulikov Vasiliy --- drivers/net/tulip/tulip_core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c index 03e96b9..14e5312 100644 --- a/drivers/net/tulip/

[PATCH v3] ll_temac: fix DMA and memory leaks

2010-07-14 Thread Kulikov Vasiliy
temac_dma_bd_init() doesn't free DMA and memory on error. Also temac_stop() must free them. Signed-off-by: Denis Kirjanov Signed-off-by: Kulikov Vasiliy --- drivers/net/ll_temac_main.c | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a

Re: Fix a filehandle leak

2010-07-14 Thread David Gibson
On Wed, Jul 14, 2010 at 05:31:38PM -0500, Jon Loeliger wrote: > > From: Martin Ettl [snip] > > Applied -p 3. Ugh, sorry. Meant to mangle the patch to apply directly to the dtc tree, but I forgot. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dro

Re: [PATCH 1/3] of/flattree: Use common ALIGN() macro instead of arch specific _ALIGN

2010-07-14 Thread Jeremy Kerr
Hi Grant, > There's no reason to use the powerpc-specific _ALIGN macro in the fdt > code. Replace it with ALIGN() from kernel.h > Been using this for a while, looks good. Acked-By: Jeremy Kerr Cheers, Jeremy ___ devicetree-discuss mailing list d

Re: [PATCH 2/3] of/flattree: Fix crash when device tree absent

2010-07-14 Thread Jeremy Kerr
Hi Grant, > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index d61fda8..66401bc 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -94,6 +94,8 @@ int __init of_scan_flat_dt(int (*it)(unsigned long node, > break; > } while (1); > > + if (rc) > +

[PATCH 3/3] of: Remove unused of_find_device_by_phandle()

2010-07-14 Thread Grant Likely
Signed-off-by: Grant Likely --- arch/microblaze/include/asm/of_platform.h |2 -- arch/microblaze/kernel/of_platform.c | 18 -- arch/powerpc/include/asm/of_platform.h|2 -- arch/powerpc/kernel/of_platform.c | 19 --- 4 files changed, 0 i

[PATCH 2/3] of/flattree: Fix crash when device tree absent

2010-07-14 Thread Grant Likely
This patch fixes the condition where device tree support is compiled in, but no device tree was proved by firmware. It makes of_platform_bus_probe() explicitly check for a NULL device tree pointer, and adds an error message if the device tree was unable to be flattened. Signed-off-by: Grant Likel

[PATCH 1/3] of/flattree: Use common ALIGN() macro instead of arch specific _ALIGN

2010-07-14 Thread Grant Likely
There's no reason to use the powerpc-specific _ALIGN macro in the fdt code. Replace it with ALIGN() from kernel.h Signed-off-by: Grant Likely --- arch/microblaze/include/asm/page.h |7 --- drivers/of/fdt.c | 20 ++-- 2 files changed, 10 insertions(+),

Re: Fix a filehandle leak

2010-07-14 Thread Jon Loeliger
> From: Martin Ettl > > During a check of the current git head of the linux kernel with the > static code analysis tool cppcheck > (http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page) > the tool discovered a resource leak in linux-2.6/scripts/dtc/fstree.c. > > Please refer

Re: [PATCH 05/11] tulip: formatting of pointers in printk()

2010-07-14 Thread David Miller
From: Kulikov Vasiliy Date: Wed, 14 Jul 2010 22:02:47 +0400 > Use %p instead of %08x in printk(). > > Signed-off-by: Kulikov Vasiliy Since patch #5 and #6 are doing the same change to different files in the same driver, I combined them into one commit. There is no need to split things up with