Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread Richard Cochran
On Wed, Aug 18, 2010 at 05:12:56PM -0700, john stultz wrote: > On Wed, 2010-08-18 at 09:19 +0200, Richard Cochran wrote: > > The timer/alarm stuff is "ancillary" and is not at all necessary. It > > is just a "nice to have." I will happily remove it, if it is too > > troubling for people. > > If th

Re: [RFC PATCH 00/14] Versatile Express device tree port

2010-08-18 Thread Jeremy Kerr
Hi Lorenzo, > This patchset provides an initial version of device tree enabled kernel on > an ARM Versatile Express board. Awesome, nice work. As Grant has said, most of my patches are now in his tree, and that's probably the best place to work from. There shouldn't be much change required to do

Re: [RFC PATCH 07/14] drivers/smsc911x: add DT support

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 3:17 PM, Grant Likely wrote: >> +static struct of_device_id smsc911x_matches[] = { >> +       { .compatible = "smc,smsc-911"}, >> +       {}, >> +}; >> + Oh, and this should be the actual part number instead of an abbreviation. So, something like "smsc,lan91c111". g. ___

Re: [RFC PATCH 12/14] ARM: vexpress: add board support for DT probing

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 5:56 PM, Mitch Bradley wrote: > The sequence "of_get_property() .. of_read_number()" is sufficiently common > to justify a function like > >  error = of_read_numeric_property(node, name, default_value, &value) Agreed. g. ___ dev

Re: [RFC PATCH 12/14] ARM: vexpress: add board support for DT probing

2010-08-18 Thread Mitch Bradley
The sequence "of_get_property() .. of_read_number()" is sufficiently common to justify a function like error = of_read_numeric_property(node, name, default_value, &value) Mitch ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org

Re: [RFC PATCH 12/14] ARM: vexpress: add board support for DT probing

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > Discussion is under way to decide if a set of machine ids is allocated > to ARM platforms based on device tree initialization. > Init code for a given platform should be split in a static init version > and a device tree init version. Th

Re: [RFC PATCH 14/14] ARM: vexpress: add device tree build system and dtbuImage

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 1:00 PM, Lorenzo Pieralisi wrote: > The introduction of device tree in ARM Linux kernel tree requires the > definition of a new class of machines. Board init files should be split > in DT and non-DT (static) and the Kernel build system and config files > should be updated a

Re: [RFC PATCH 13/14] ARM: vexpress: Definition of vexpress dts specification

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > The device tree methodology requires a dts file to be defined per > platform in order to describe the platform address space and topology, > in short the device tree in source format. > > This patch adds the dts file for the Versatile Ex

Re: [RFC PATCH 11/14] ARM: PMU: add device tree probing

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > When OF is enabled, platform drivers are required to define a > match table in order to allow the kernel to find drivers suitable > for a given device. The device tree allows to retrieve resources > from device tree nodes dynamically. >

Re: [RFC PATCH 10/14] drivers/USB: isp1760 DT platform parsing and binding

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > When OF is enabled, each driver should define a match table to > allow the kernel to recognise drivers suitable for a given device. > Initialization is carried out through a static inline at driver init > time. The match-table is declare

Re: [RFC PATCH 09/14] ARM: ARM flash driver DT port

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > When OF is enabled drivers should initialize the driver match table > to allow the kernel to find and recognise drivers suitable for > devices. The initialization is carried out through a static inline > function at driver init time. > >

Re: [RFC PATCH 08/14] ARM: versatile-i2c driver DT port

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > When OF is enabled, each driver should define a match table to > allow the kernel to recognise drivers suitable for a given device. > Initialization is carried out through a static inline at driver init > time. The match-table is declare

Re: [RFC PATCH 07/14] drivers/smsc911x: add DT support

2010-08-18 Thread Grant Likely
[cc'ing networking maintainer David Miller to keep him in the loop] Hi Lorenzo, A number of comments below and some rework required, but in general the approach looks good and impact on the core driver is limited to the start of the .probe() routine. On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pie

Re: [RFC PATCH 05/14] ARM: vexpress: fix typo in addruart

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > The new infrastructure for low level debug in ARM requires the > addruart macro to be defined on a platform specific basis to get > rid of static addresses init in machine descriptors. > Uart physical and virtual addresses should be retr

Re: [RFC PATCH 04/14] ARM: r1 DT mach id init

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > Device tree ARM machine desc has been allocated id 0x temporarily. > This machine id should be passed in r1 upon kernel booting. > Legacy code requires code stubs to update r1 accordingly when > booting from legacy boot loaders t

Re: [RFC PATCH 03/14] ARM: fix add instruction to set the flags

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > ARM data processing instructions require the 's' suffix to update > the flags upon execution. > > This patch fixes code requiring flags to be updated in order to check > the carry flag for overflow. > > Signed-off-by: Lorenzo Pieralisi

Re: [RFC PATCH 02/14] ARM: vexpress: fix clocks definition to comply with new framework

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > The new clock infrastructure introduced within the DT series of patches > slightly changed how clocks are declared and initialized. Some clock > definitions become platform specific. > > This patch fixes some typos on ARM Versatile Expre

Re: [RFC PATCH 01/14] ARM: amba device memory allocation fix

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > When instantiating amba devices dynamically from device tree nodes, the > memory allocation should be carried out using the kzalloc function to make > sure all the members are zero initialized. > > This patch replaces the kmalloc call wi

Re: [RFC PATCH 00/14] Versatile Express device tree port

2010-08-18 Thread Grant Likely
On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi wrote: > This patchset provides an initial version of device tree enabled kernel on > an ARM Versatile Express board. The patchset applies to Jeremy Kerr's tree: > >        git://kernel.ubuntu.com/jk/dt/linux-2.6.git dtbimage >        commit: 4cb

[RFC PATCH 00/14] Versatile Express device tree port

2010-08-18 Thread Lorenzo Pieralisi
This patchset provides an initial version of device tree enabled kernel on an ARM Versatile Express board. The patchset applies to Jeremy Kerr's tree: git://kernel.ubuntu.com/jk/dt/linux-2.6.git dtbimage commit: 4cb80ac96489220554d28f6fde527aeef83e628b The patched kernel version i

[RFC PATCH 01/14] ARM: amba device memory allocation fix

2010-08-18 Thread Lorenzo Pieralisi
When instantiating amba devices dynamically from device tree nodes, the memory allocation should be carried out using the kzalloc function to make sure all the members are zero initialized. This patch replaces the kmalloc call with a kzalloc one. Signed-off-by: Lorenzo Pieralisi --- drivers/amb

[RFC PATCH 14/14] ARM: vexpress: add device tree build system and dtbuImage

2010-08-18 Thread Lorenzo Pieralisi
The introduction of device tree in ARM Linux kernel tree requires the definition of a new class of machines. Board init files should be split in DT and non-DT (static) and the Kernel build system and config files should be updated accordingly. To allow u-boot to recognize and boot images with a dev

[RFC PATCH 12/14] ARM: vexpress: add board support for DT probing

2010-08-18 Thread Lorenzo Pieralisi
Discussion is under way to decide if a set of machine ids is allocated to ARM platforms based on device tree initialization. Init code for a given platform should be split in a static init version and a device tree init version. The Versatile Express ARM board requires the initialization of motherb

[RFC PATCH 13/14] ARM: vexpress: Definition of vexpress dts specification

2010-08-18 Thread Lorenzo Pieralisi
The device tree methodology requires a dts file to be defined per platform in order to describe the platform address space and topology, in short the device tree in source format. This patch adds the dts file for the Versatile Express board. Some device names are still temporary and non-compliant

[RFC PATCH 11/14] ARM: PMU: add device tree probing

2010-08-18 Thread Lorenzo Pieralisi
When OF is enabled, platform drivers are required to define a match table in order to allow the kernel to find drivers suitable for a given device. The device tree allows to retrieve resources from device tree nodes dynamically. This patch adds device tree support to the ARM PMU driver. This inclu

[RFC PATCH 02/14] ARM: vexpress: fix clocks definition to comply with new framework

2010-08-18 Thread Lorenzo Pieralisi
The new clock infrastructure introduced within the DT series of patches slightly changed how clocks are declared and initialized. Some clock definitions become platform specific. This patch fixes some typos on ARM Versatile Express clock definition and initialization that caused compile time error

[RFC PATCH 08/14] ARM: versatile-i2c driver DT port

2010-08-18 Thread Lorenzo Pieralisi
When OF is enabled, each driver should define a match table to allow the kernel to recognise drivers suitable for a given device. Initialization is carried out through a static inline at driver init time. The match-table is declared following OF bindings. This patch adds the required initializatio

[RFC PATCH 04/14] ARM: r1 DT mach id init

2010-08-18 Thread Lorenzo Pieralisi
Device tree ARM machine desc has been allocated id 0x temporarily. This machine id should be passed in r1 upon kernel booting. Legacy code requires code stubs to update r1 accordingly when booting from legacy boot loaders that do not necessarily pass DT mach id on r1. This patch adds code

[RFC PATCH 05/14] ARM: vexpress: fix typo in addruart

2010-08-18 Thread Lorenzo Pieralisi
The new infrastructure for low level debug in ARM requires the addruart macro to be defined on a platform specific basis to get rid of static addresses init in machine descriptors. Uart physical and virtual addresses should be retrieved through the addruart macro. This patch fixes the addruart mac

[RFC PATCH 06/14] platform: add function to initialize OF match table

2010-08-18 Thread Lorenzo Pieralisi
If the kernel is configured to enable the Open Firmware device tree infrastructure, the driver member of struct platform_driver has an additional member, the match table, that has to be initialized in order for the kernel to be capable of probing drivers at run-time using the OF methodology. This

[RFC PATCH 07/14] drivers/smsc911x: add DT support

2010-08-18 Thread Lorenzo Pieralisi
When OF is enabled the device driver should initialize the match table in order to be probable from the device tree. Furthermore, HW properties should be retrieved from the device tree node, so a device tree probe function is required to parse node properties at run-time. To avoid preprocessor macr

[RFC PATCH 03/14] ARM: fix add instruction to set the flags

2010-08-18 Thread Lorenzo Pieralisi
ARM data processing instructions require the 's' suffix to update the flags upon execution. This patch fixes code requiring flags to be updated in order to check the carry flag for overflow. Signed-off-by: Lorenzo Pieralisi --- arch/arm/kernel/head.S |2 +- 1 files changed, 1 insertions(+),

[RFC PATCH 10/14] drivers/USB: isp1760 DT platform parsing and binding

2010-08-18 Thread Lorenzo Pieralisi
When OF is enabled, each driver should define a match table to allow the kernel to recognise drivers suitable for a given device. Initialization is carried out through a static inline at driver init time. The match-table is declared following OF bindings. Driver properties are parsed from the devic

[RFC PATCH 09/14] ARM: ARM flash driver DT port

2010-08-18 Thread Lorenzo Pieralisi
When OF is enabled drivers should initialize the driver match table to allow the kernel to find and recognise drivers suitable for devices. The initialization is carried out through a static inline function at driver init time. This patch adds a match table and relative init code to support device

Re: [PATCH v2 1/2] MIPS: Add device tree support to MIPS

2010-08-18 Thread Ralf Baechle
On Thu, Aug 19, 2010 at 01:18:56AM +1000, Stephen Rothwell wrote: > > A suggested set of kernel defconfigs to test: > > > > bigsur_defconfig > > cavium-octeon_defconfig > > ip22_defconfig > > ip27_defconfig > > ip32_defconfig > > malta_defconfig > > allmodconfig > > > > These cover a huge variet

Re: [PATCH v2 1/2] MIPS: Add device tree support to MIPS

2010-08-18 Thread Stephen Rothwell
Hi Ralf, On Wed, 18 Aug 2010 15:39:26 +0100 Ralf Baechle wrote: > > Kconfig will pick the default machine which is an IP22 for allyesconfig > and allmodconfig. The makefile will then pick the right flags for the > compiler based on machine, processor and endian selection. so it'll > happily bui

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread Arnd Bergmann
On Wednesday 18 August 2010, Richard Cochran wrote: > On Tue, Aug 17, 2010 at 01:36:29PM +0200, Arnd Bergmann wrote: > > On Tuesday 17 August 2010, Richard Cochran wrote: > > > I've been looking at offering the PTP clock as a posix clock, and it > > > is not as hard as I first thought. The PTP cloc

Re: [PATCH v2 1/2] MIPS: Add device tree support to MIPS

2010-08-18 Thread Ralf Baechle
On Tue, Aug 17, 2010 at 01:40:39PM +1000, Stephen Rothwell wrote: > On Mon, 16 Aug 2010 14:42:11 -0600 Grant Likely > wrote: > > > > I'll also make sure to start build testing on MIPS. Ralf, any suggestions > > on defconfigs I should use? > > Linux-next does defconfig, allnoconfig, allmodconf

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread Richard Cochran
On Tue, Aug 17, 2010 at 01:36:29PM +0200, Arnd Bergmann wrote: > On Tuesday 17 August 2010, Richard Cochran wrote: > > I've been looking at offering the PTP clock as a posix clock, and it > > is not as hard as I first thought. The PTP clock or clocks just have > > to be registered as one of the pos

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread Richard Cochran
On Tue, Aug 17, 2010 at 05:22:43PM -0700, john stultz wrote: > Why would system time not be adjusted to the PTP time? > > This is my main concern, that we're presenting a fractured API to > userland. Suddenly there isn't just system time, but ptp time as well, > and possibly multiple different ptp