Re: [RFC] dtc: Optionally sort nodes and properties

2010-09-08 Thread Grant Likely
On Wed, Sep 08, 2010 at 03:39:52PM -0500, Scott Wood wrote: > On Wed, 8 Sep 2010 14:25:30 -0600 > Grant Likely wrote: > > > On Wed, Sep 01, 2010 at 12:47:18PM +1000, David Gibson wrote: > > > Hi folks, > > > > > > Here's a patch I made for dtc a little while ago, and I'm not sure if > > > it's s

Re: ARM machine specific DT probing

2010-09-08 Thread Jeremy Kerr
Hi Nicolas, > What Jeremy did is to add a probe_dt method in the mdesc structure, and > then the core is calling them in sequence until one of them returns > success. > > now, the "compatible" property is explained here: > > http://devicetree.org/Device_Tree_Usage#Understanding_the_compatible_

ARM machine specific DT probing

2010-09-08 Thread Nicolas Pitre
While reviewing the ARM DT patches I've come to a misunderstanding of how the specific machine support is meant to be matched with DT. What Jeremy did is to add a probe_dt method in the mdesc structure, and then the core is calling them in sequence until one of them returns success. now, the "

Re: [RFC] dtc: Optionally sort nodes and properties

2010-09-08 Thread Scott Wood
On Wed, 8 Sep 2010 14:25:30 -0600 Grant Likely wrote: > On Wed, Sep 01, 2010 at 12:47:18PM +1000, David Gibson wrote: > > Hi folks, > > > > Here's a patch I made for dtc a little while ago, and I'm not sure if > > it's something that sensibly ought to be merged into mainline dtc. > > > > The pa

Re: [RFC] dtc: Optionally sort nodes and properties

2010-09-08 Thread Grant Likely
On Wed, Sep 01, 2010 at 12:47:18PM +1000, David Gibson wrote: > Hi folks, > > Here's a patch I made for dtc a little while ago, and I'm not sure if > it's something that sensibly ought to be merged into mainline dtc. > > The patch adds a '-s' option to dtc, which causes it to "sort" the > tree be

Re: [PATCH 4/4] arch/powerpc/platforms/chrp/nvram.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Tue, Aug 31, 2010 at 05:48:58PM +0200, Julia Lawall wrote: > Add a call to of_node_put in the error handling code following a call to > of_find_node_by_type. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r exists@ > local idexpression x

Re: [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Tue, Aug 31, 2010 at 05:48:55PM +0200, Julia Lawall wrote: > Add a call to of_node_put in the error handling code following a call to > of_find_compatible_node or of_find_node_by_type. > > This patch also substantially reorganizes the error handling code in the > function, to that it is possibl

Re: [PATCH 6/7] arch/powerpc/platforms/maple/setup.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Sun, Aug 29, 2010 at 11:52:45AM +0200, Julia Lawall wrote: > Add a call to of_node_put in the error handling code following a call to > of_find_node_by_path. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r exists@ > local idexpression x

Re: [PATCH 7/7] arch/powerpc/platforms/cell: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Sun, Aug 29, 2010 at 11:52:46AM +0200, Julia Lawall wrote: > Add calls to of_node_put in the error handling code following calls to > of_find_node_by_path and of_find_node_by_phandle. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r exis

Re: [PATCH] arch/powerpc/platforms/52xx/efika.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Sat, Sep 04, 2010 at 09:13:17AM +0200, Julia Lawall wrote: > This function is implemented as though the function of_get_next_child does > not increment the reference count of its result, but actually it does. > Thus the patch adds of_node_put in error handling code and drops a call to > of_node_