Re: [PATCH 1/5] arm/dts: babbage: add gpt and uart related clock nodes

2011-03-07 Thread Jason Hui
Hi, Shawn, On Tue, Mar 8, 2011 at 3:07 PM, Shawn Guo wrote: > On Tue, Mar 08, 2011 at 02:56:52PM +0800, Jason Hui wrote: >> Hi, Shawn, >> >> On Tue, Mar 8, 2011 at 12:22 AM, Shawn Guo wrote: >> > The patch is to add all gpt, uart related dt clock nodes for babbage. >> > It sticks to the clock na

Re: [PATCH 1/5] arm/dts: babbage: add gpt and uart related clock nodes

2011-03-07 Thread Shawn Guo
On Tue, Mar 08, 2011 at 02:56:52PM +0800, Jason Hui wrote: > Hi, Shawn, > > On Tue, Mar 8, 2011 at 12:22 AM, Shawn Guo wrote: > > The patch is to add all gpt, uart related dt clock nodes for babbage. > > It sticks to the clock name used in clock-mx51-mx53.c, so that > > everything gets consistent

Re: [PATCH 1/5] arm/dts: babbage: add gpt and uart related clock nodes

2011-03-07 Thread Jason Hui
Hi, Shawn, On Tue, Mar 8, 2011 at 12:22 AM, Shawn Guo wrote: > The patch is to add all gpt, uart related dt clock nodes for babbage. > It sticks to the clock name used in clock-mx51-mx53.c, so that > everything gets consistent to Reference Manual.  For example, the > numbering in clock name usual

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-07 Thread Shawn Guo
On Mon, Mar 07, 2011 at 10:53:37AM -0700, Grant Likely wrote: > On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo wrote: > > The 'rate' is added for fixed-clock support, while 'pll_base' is for > > pll clock.  These two particular type of clocks are supposed to be > > gracefully supported by the common cl

Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-07 Thread Shawn Guo
On Tue, Mar 08, 2011 at 11:31:07AM +0800, Jason Hui wrote: > Hi, Shawn, > > On Tue, Mar 8, 2011 at 11:11 AM, Shawn Guo wrote: > > On Tue, Mar 08, 2011 at 10:20:33AM +0800, Jason Hui wrote: > >> Hi, Shawn, > >> > >> On Mon, Mar 7, 2011 at 10:51 PM, Shawn Guo wrote: > >> > Aha, Jason.  Grant and I

Re: [PATCH 1/5] arm/dts: babbage: add gpt and uart related clock nodes

2011-03-07 Thread Shawn Guo
On Mon, Mar 07, 2011 at 10:48:10AM -0700, Grant Likely wrote: > On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo wrote: > > The patch is to add all gpt, uart related dt clock nodes for babbage. > > It sticks to the clock name used in clock-mx51-mx53.c, so that > > everything gets consistent to Reference

Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-07 Thread Jason Hui
Hi, Shawn, On Tue, Mar 8, 2011 at 11:11 AM, Shawn Guo wrote: > On Tue, Mar 08, 2011 at 10:20:33AM +0800, Jason Hui wrote: >> Hi, Shawn, >> >> On Mon, Mar 7, 2011 at 10:51 PM, Shawn Guo wrote: >> > Aha, Jason.  Grant and I put many comments on v1 of this patch, but it >> > seems that v2 is identi

Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-07 Thread Shawn Guo
On Tue, Mar 08, 2011 at 10:20:33AM +0800, Jason Hui wrote: > Hi, Shawn, > > On Mon, Mar 7, 2011 at 10:51 PM, Shawn Guo wrote: > > Aha, Jason.  Grant and I put many comments on v1 of this patch, but it > > seems that v2 is identical to v1, except adding Rob Herring sign-off. > > Please compare wi

Re: [PATCH V2 3/3] serial/imx: parse from device tree support

2011-03-07 Thread Jason Hui
Hi, Grant, On Tue, Mar 8, 2011 at 12:22 AM, Grant Likely wrote: > On Mon, Mar 7, 2011 at 6:06 AM, Jason Liu wrote: >> Signed-off-by: Jason Liu >> Signed-off-by: Jeremy Kerr > > Hi Jason, > > comments below. > >> --- >>  drivers/tty/serial/imx.c |   79 >> ++

Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-07 Thread Jason Hui
Hi, Shawn, On Mon, Mar 7, 2011 at 10:51 PM, Shawn Guo wrote: > Aha, Jason.  Grant and I put many comments on v1 of this patch, but it > seems that v2 is identical to v1, except adding Rob Herring sign-off. Please compare with v1 and say it once again, It should include the grant and your comment

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-07 Thread Grant Likely
On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo wrote: > The 'rate' is added for fixed-clock support, while 'pll_base' is for > pll clock.  These two particular type of clocks are supposed to be > gracefully supported by the common clk api when it gets ready. How does the current imx clock code handle

Re: [PATCH 1/5] arm/dts: babbage: add gpt and uart related clock nodes

2011-03-07 Thread Grant Likely
On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo wrote: > The patch is to add all gpt, uart related dt clock nodes for babbage. > It sticks to the clock name used in clock-mx51-mx53.c, so that > everything gets consistent to Reference Manual.  For example, the > numbering in clock name usually starts fro

Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support

2011-03-07 Thread Grant Likely
On Mon, Mar 7, 2011 at 7:52 AM, Arnd Bergmann wrote: > On Monday 07 March 2011, Shawn Guo wrote: >> > Alternatively, it could be done the other way round: rename the identifiers >> > in the file from mx51_ to mx5_, and make sure that they don't contain >> > any mx51 specific settings but always re

Re: [PATCH V2 3/3] serial/imx: parse from device tree support

2011-03-07 Thread Grant Likely
On Mon, Mar 7, 2011 at 6:06 AM, Jason Liu wrote: > Signed-off-by: Jason Liu > Signed-off-by: Jeremy Kerr Hi Jason, comments below. > --- >  drivers/tty/serial/imx.c |   79 > -- >  1 files changed, 69 insertions(+), 10 deletions(-) > > diff --git a/

[PATCH 5/5] of/clock: eliminate function __of_clk_get_from_provider

2011-03-07 Thread Shawn Guo
With the platform clock support, the 'struct clk' should have been associated with device_node->data. So the use of function __of_clk_get_from_provider can be eliminated. Signed-off-by: Shawn Guo --- drivers/of/clock.c | 23 ++- 1 files changed, 2 insertions(+), 21 deletio

[PATCH 4/5] arm/dt: mx5: change timer init function to dt clock way

2011-03-07 Thread Shawn Guo
The big deal here is that it removes the call to mx51_clocks_init, where all the possible clocks are added to clkdev in static way. Signed-off-by: Shawn Guo --- arch/arm/mach-mx5/board-dt.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mx5/board-d

[PATCH 3/5] arm/dt: mx51: dynamically add gpt and uart related clocks per dt nodes

2011-03-07 Thread Shawn Guo
This patch is to change the static clock creating and registering to the dynamic way, which scans dt clock nodes, associate clk with device_node, and then add them to clkdev accordingly. Signed-off-by: Shawn Guo --- arch/arm/mach-mx5/clock-mx51-mx53.c | 436 +--

[PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-07 Thread Shawn Guo
The 'rate' is added for fixed-clock support, while 'pll_base' is for pll clock. These two particular type of clocks are supposed to be gracefully supported by the common clk api when it gets ready. Signed-off-by: Shawn Guo --- arch/arm/plat-mxc/include/mach/clock.h |4 1 files changed,

[PATCH 1/5] arm/dts: babbage: add gpt and uart related clock nodes

2011-03-07 Thread Shawn Guo
The patch is to add all gpt, uart related dt clock nodes for babbage. It sticks to the clock name used in clock-mx51-mx53.c, so that everything gets consistent to Reference Manual. For example, the numbering in clock name usually starts from 1, while 'reg' property numbering starts from 0 to easy

[PATCH RFC 0/5] Dynamically add clk to clkdev per dt clock nodes

2011-03-07 Thread Shawn Guo
Before translating all mx5 clocks from static adding way to dynamic way, I would send this out for review and comment, so that I can turn around in case that I'm on a wrong direction. It's based on Jason's mx51-basic-dt-support patch set, and only adds gpt and uart related clocks, but it's enough

Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-07 Thread Shawn Guo
Aha, Jason. Grant and I put many comments on v1 of this patch, but it seems that v2 is identical to v1, except adding Rob Herring sign-off. On Mon, Mar 07, 2011 at 09:05:59PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > Singed-off-by: Rob Herring > --- > arch/arm/boot/dts/babbage.dts |

Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support

2011-03-07 Thread Arnd Bergmann
On Monday 07 March 2011, Shawn Guo wrote: > > Alternatively, it could be done the other way round: rename the identifiers > > in the file from mx51_ to mx5_, and make sure that they don't contain > > any mx51 specific settings but always refer to properties in the > > device tree for the differenc

Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support

2011-03-07 Thread Shawn Guo
Hi Arnd, On Mon, Mar 07, 2011 at 03:37:48PM +0100, Arnd Bergmann wrote: > On Monday 07 March 2011, Shawn Guo wrote: > > > diff --git a/arch/arm/mach-mx5/Makefile b/arch/arm/mach-mx5/Makefile > > > index 0d43be9..540697e 100644 > > > --- a/arch/arm/mach-mx5/Makefile > > > +++ b/arch/arm/mach-mx5/Ma

Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support

2011-03-07 Thread Arnd Bergmann
On Monday 07 March 2011, Shawn Guo wrote: > > diff --git a/arch/arm/mach-mx5/Makefile b/arch/arm/mach-mx5/Makefile > > index 0d43be9..540697e 100644 > > --- a/arch/arm/mach-mx5/Makefile > > +++ b/arch/arm/mach-mx5/Makefile > > @@ -18,3 +18,4 @@ obj-$(CONFIG_MACH_EUKREA_CPUIMX51SD) += board-cpuimx51

Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support

2011-03-07 Thread Shawn Guo
On Mon, Mar 07, 2011 at 09:05:58PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > --- [...] > diff --git a/arch/arm/mach-mx5/board-dt.c b/arch/arm/mach-mx5/board-dt.c > new file mode 100644 > index 000..90593f5 > --- /dev/null > +++ b/arch/arm/mach-mx5/board-dt.c > @@ -0,0 +1,64 @@ > +/*

Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support

2011-03-07 Thread Shawn Guo
On Mon, Mar 07, 2011 at 09:05:58PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > --- > arch/arm/mach-mx5/Kconfig |8 > arch/arm/mach-mx5/Makefile |1 + > arch/arm/mach-mx5/board-dt.c| 64 > +++ > arch/arm/ma

Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-07 Thread Shawn Guo
Hi Jason, On Mon, Mar 07, 2011 at 09:05:59PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > Singed-off-by: Rob Herring > --- > arch/arm/boot/dts/babbage.dts | 110 > + > 1 files changed, 110 insertions(+), 0 deletions(-) > > diff --git a/arch/arm

[PATCH V2 3/3] serial/imx: parse from device tree support

2011-03-07 Thread Jason Liu
Signed-off-by: Jason Liu Signed-off-by: Jeremy Kerr --- drivers/tty/serial/imx.c | 79 -- 1 files changed, 69 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index dfcf4b1..1ebca28 100644 --- a/drivers

[PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-07 Thread Jason Liu
Signed-off-by: Jason Liu Singed-off-by: Rob Herring --- arch/arm/boot/dts/babbage.dts | 110 + 1 files changed, 110 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/babbage.dts b/arch/arm/boot/dts/babbage.dts new file mode 100644 index 00

[PATCH V2 1/3] arm/dt: add basic mx51 device tree support

2011-03-07 Thread Jason Liu
Signed-off-by: Jason Liu --- arch/arm/mach-mx5/Kconfig |8 arch/arm/mach-mx5/Makefile |1 + arch/arm/mach-mx5/board-dt.c| 64 +++ arch/arm/mach-mx5/clock-mx51-mx53.c | 43 - arch/arm/plat-m

[PATCH V2 0/3] Add MX51 basic DT support

2011-03-07 Thread Jason Liu
From: Jason Liu This patchset adds FSL mx51 with device tree support. This is based on git://git.secretlab.ca/git/linux-2.6 devicetree/test This patch has been tested on MX51 babbage board and can boot up succesfully to linux console with DT enabled. Jason Liu (3): arm/dt: add basic mx51 dev