Re: clock bindings

2011-03-31 Thread Shawn Guo
On Thu, Mar 31, 2011 at 04:45:47PM -0600, Grant Likely wrote: > On Wed, Feb 02, 2011 at 10:47:40AM -0600, Rob Herring wrote: > > I've started looking at the DT clock bindings in more depth. To what > > level should the clock tree be defined in the DT? Should it be a > > one-to-one correlation of cu

Re: [PATCH 4/5] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-03-31 Thread Shawn Guo
On Thu, Mar 31, 2011 at 09:53:12AM -0600, Grant Likely wrote: > On Fri, Mar 25, 2011 at 04:48:50PM +0800, Shawn Guo wrote: > > This patch is to consolidate SDHCI driver for Freescale eSDHC > > controller found on both MPCxxx and i.MX platforms. It turns > > sdhci-of-esdhc.c and sdhci-esdhc-imx.c i

Re: [PATCH 1/5] mmc: sdhci: make sdhci-pltfm device drivers self registered

2011-03-31 Thread Shawn Guo
On Thu, Mar 31, 2011 at 09:33:22AM -0600, Grant Likely wrote: > On Fri, Mar 25, 2011 at 04:48:47PM +0800, Shawn Guo wrote: > > The patch turns the common stuff in sdhci-pltfm.c into functions, and > > add device drivers their own .probe and .remove which in turn call > > into the common functions,

Re: clock bindings

2011-03-31 Thread Grant Likely
On Wed, Feb 02, 2011 at 10:47:40AM -0600, Rob Herring wrote: > I've started looking at the DT clock bindings in more depth. To what > level should the clock tree be defined in the DT? Should it be a > one-to-one correlation of current struct clk nodes to node in DT > where each node is a single inp

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Hans J. Koch
On Thu, Mar 31, 2011 at 01:48:32PM -0600, Grant Likely wrote: > On Thu, Mar 31, 2011 at 1:23 PM, Hans J. Koch wrote: > > On Thu, Mar 31, 2011 at 07:57:47PM +0200, Michal Simek wrote: > >> Hans J. Koch wrote: > >> >On Thu, Mar 31, 2011 at 03:28:41PM +0200, Michal Simek wrote: > >> +         uio

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Hans J. Koch
On Thu, Mar 31, 2011 at 07:57:47PM +0200, Michal Simek wrote: > Hans J. Koch wrote: > >On Thu, Mar 31, 2011 at 03:28:41PM +0200, Michal Simek wrote: > + uioinfo->name = pdev->dev.of_node->name; > + /* Use version for storing full IP name for identification */ > +

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Hans J. Koch
On Thu, Mar 31, 2011 at 03:28:41PM +0200, Michal Simek wrote: > >>+ uioinfo->name = pdev->dev.of_node->name; > >>+ /* Use version for storing full IP name for identification */ > >>+ uioinfo->version = pdev->dev.of_node->full_name; > > > >I don't think this is apropria

Re: [PATCH] arm/dt: Add basic device tree support for genesi mx board

2011-03-31 Thread Loïc Minier
On Wed, Mar 30, 2011, Steev Klimaszewski wrote: > We actually call the small desktop a Smarttop not nettop :) I thought the same, but this name is already used in mainline linux/arch/arm/mach-mx5/board-mx51_efikamx.c: MACHINE_START(MX51_EFIKAMX, "Genesi EfikaMX nettop" -- Loïc Minier

Re: [PATCH] arm/dt: Add basic device tree support for genesi mx board

2011-03-31 Thread Steev Klimaszewski
On Wed, Mar 30, 2011 at 8:15 AM, Jason Liu wrote: > This patch add support for Genesi Efika MX Smarttop and Smartbook > > Signed-off-by: Jason Liu > > --- > Grant, uboot patch has been included in your uboot patchset. > And mx51_efika build break, need pull in the patch to fix it > http://git.pen

Re: [PATCH v2 6/6] of/clock: eliminate function __of_clk_get_from_provider

2011-03-31 Thread Grant Likely
On Sat, Mar 19, 2011 at 02:24:32AM +0800, Shawn Guo wrote: > With the platform clock support, the 'struct clk' should have been > associated with device_node->data. So the use of function > __of_clk_get_from_provider can be eliminated. > > Signed-off-by: Shawn Guo Not really true since a device

Re: [PATCH v2 4/6] arm/dt: mx51: dynamically add clocks per dt nodes

2011-03-31 Thread Grant Likely
On Sat, Mar 19, 2011 at 02:24:30AM +0800, Shawn Guo wrote: > This patch is to change the static clock creating and registering to > the dynamic way, which scans dt clock nodes, associate clk with > device_node, and then add them to clkdev accordingly. > > It's a pretty straight translation from no

Re: [PATCH v2 3/6] dt: add new member 'clk' into device_node

2011-03-31 Thread Grant Likely
On Sat, Mar 19, 2011 at 02:24:29AM +0800, Shawn Guo wrote: > This pointer to 'struct clk' is added to save the reference to 'clk' > which is dynamically created per dt clock node, so that clkdev API > like clk_get can work with dt based device driver. > > Signed-off-by: Shawn Guo > --- > include

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Grant Likely
On Thu, Mar 31, 2011 at 1:23 PM, Hans J. Koch wrote: > On Thu, Mar 31, 2011 at 07:57:47PM +0200, Michal Simek wrote: >> Hans J. Koch wrote: >> >On Thu, Mar 31, 2011 at 03:28:41PM +0200, Michal Simek wrote: >> +         uioinfo->name = pdev->dev.of_node->name; >> +         /* Use version fo

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Michal Simek
Hans J. Koch wrote: On Thu, Mar 31, 2011 at 03:28:41PM +0200, Michal Simek wrote: + uioinfo->name = pdev->dev.of_node->name; + /* Use version for storing full IP name for identification */ + uioinfo->version = pdev->dev.of_node->full_name; I don't think

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Michal Simek
Grant Likely wrote: On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: Support OF support. "generic-uio" compatible property is used. Signed-off-by: Michal Simek --- drivers/uio/uio_pdrv_genirq.c | 60 ++-- 1 files changed, 57 insertions(+), 3

Re: [PATCH 0/5] consolidate sdhci pltfm & OF drivers and get them self registered

2011-03-31 Thread Chris Ball
Hi Wolfram, On Fri, Mar 25 2011, Shawn Guo wrote: > Here are what the patch set does. > > * Remove .probe and .remove hooks from sdhci-pltfm.c and make it be > a pure common helper function providers. > * Add .probe and .remove hooks for sdhci pltfm drivers sdhci-cns3xxx, > sdhci-dove, sdhci-t

Re: [PATCH] arm/dt: Add basic device tree support for mx53 loco board

2011-03-31 Thread Grant Likely
On Thu, Mar 31, 2011 at 10:50 AM, Grant Likely wrote: > On Fri, Apr 01, 2011 at 12:36:16AM +0800, Shawn Guo wrote: >> Hi Grant, >> >> On Wed, Mar 30, 2011 at 09:52:15PM -0600, Grant Likely wrote: >> > On Tue, Mar 29, 2011 at 10:34:12AM +, Liu Hui-R64343 wrote: >> > > Hi, Grant, >> > > The two

Re: [PATCH] arm/dt: Add basic device tree support for mx53 loco board

2011-03-31 Thread Grant Likely
On Fri, Apr 01, 2011 at 12:36:16AM +0800, Shawn Guo wrote: > Hi Grant, > > On Wed, Mar 30, 2011 at 09:52:15PM -0600, Grant Likely wrote: > > On Tue, Mar 29, 2011 at 10:34:12AM +, Liu Hui-R64343 wrote: > > > Hi, Grant, > > > The two patches for mx51/mx53 DT support have the same issue, which >

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Grant Likely
On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: > Support OF support. "generic-uio" compatible property is used. > > Signed-off-by: Michal Simek > --- > drivers/uio/uio_pdrv_genirq.c | 60 ++-- > 1 files changed, 57 insertions(+), 3 deletions(-

Re: [PATCH] arm/dt: Add basic device tree support for mx53 loco board

2011-03-31 Thread Shawn Guo
Hi Grant, On Wed, Mar 30, 2011 at 09:52:15PM -0600, Grant Likely wrote: > On Tue, Mar 29, 2011 at 10:34:12AM +, Liu Hui-R64343 wrote: > > Hi, Grant, > > The two patches for mx51/mx53 DT support have the same issue, which > > is the S-O-B will be missed when you git am. Let me know if you want

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Grant Likely
On Thu, Mar 31, 2011 at 03:51:32PM +0200, Michal Simek wrote: > Arnd Bergmann wrote: > >On Thursday 31 March 2011, John Williams wrote: > >>On Thu, Mar 31, 2011 at 10:49 PM, Wolfram Sang > >>wrote: > >>>On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: > Support OF support. "gener

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Grant Likely
On Thu, Mar 31, 2011 at 11:47:04PM +1000, John Williams wrote: > On Thu, Mar 31, 2011 at 11:23 PM, Wolfram Sang wrote: > > > >>    Maybe I misunderstand you, in my view it is the responsibility of > >> > >>    to create their DTS files to indicate they want to bind > >> to > >>    generic-uio.

Re: [PATCH] net/fec: fix compile error introduced by dt support

2011-03-31 Thread Grant Likely
On Fri, Mar 25, 2011 at 03:13:58PM +0800, Shawn Guo wrote: > After fec dt support is added, the following compile error will be > seen when building a pure non-dt kernel. > > drivers/net/fec.c: In function ‘fec_probe’: > drivers/net/fec.c:1383: error: implicit declaration of function > ‘of_match_

Re: [PATCH 5/5] mmc: sdhci: merge two sdhci-pltfm.h into one

2011-03-31 Thread Grant Likely
On Fri, Mar 25, 2011 at 04:48:51PM +0800, Shawn Guo wrote: > The structure sdhci_pltfm_data is not necessarily to be in a public > header like include/linux/mmc/sdhci-pltfm.h, so the patch moves it > into drivers/mmc/host/sdhci-pltfm.h and eliminates the former one. > > Signed-off-by: Shawn Guo

Re: [PATCH 4/5] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-03-31 Thread Grant Likely
On Fri, Mar 25, 2011 at 04:48:50PM +0800, Shawn Guo wrote: > This patch is to consolidate SDHCI driver for Freescale eSDHC > controller found on both MPCxxx and i.MX platforms. It turns > sdhci-of-esdhc.c and sdhci-esdhc-imx.c into one sdhci-esdhc.c, > which gets the same pair of .probe and .remov

Re: [PATCH 3/5] mmc: sdhci: make sdhci-of device drivers self registered

2011-03-31 Thread Grant Likely
On Fri, Mar 25, 2011 at 04:48:49PM +0800, Shawn Guo wrote: > The patch turns the sdhci-of-core common stuff into helper functions > added into sdhci-pltfm.c, and makes sdhci-of device drviers self > registered using the same pair of .probe and .remove used by > sdhci-pltfm device drivers. > > As a

Re: [PATCH 2/5] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data

2011-03-31 Thread Grant Likely
On Fri, Mar 25, 2011 at 04:48:48PM +0800, Shawn Guo wrote: > The patch is to migrate the use of sdhci_of_host and sdhci_of_data > to sdhci_pltfm_host and sdhci_pltfm_data, so that the former pair can > be eliminated. > > Signed-off-by: Shawn Guo Reviewed-by: Grant Likely > --- > drivers/mmc/h

Re: [PATCH 1/5] mmc: sdhci: make sdhci-pltfm device drivers self registered

2011-03-31 Thread Grant Likely
On Fri, Mar 25, 2011 at 04:48:47PM +0800, Shawn Guo wrote: > The patch turns the common stuff in sdhci-pltfm.c into functions, and > add device drivers their own .probe and .remove which in turn call > into the common functions, so that those sdhci-pltfm device drivers > register itself and keep al

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Michal Simek
Arnd Bergmann wrote: On Thursday 31 March 2011, John Williams wrote: On Thu, Mar 31, 2011 at 10:49 PM, Wolfram Sang wrote: On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: Support OF support. "generic-uio" compatible property is used. And exactly this was the issue last time (wh

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread John Williams
On Thu, Mar 31, 2011 at 11:23 PM, Wolfram Sang wrote: > >>    Maybe I misunderstand you, in my view it is the responsibility of >>    to create their DTS files to indicate they want to bind to >>    generic-uio. > > Device tree is a OS-neutral hardware description language. "generic-uio" > is ne

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Michal Simek
Wolfram Sang wrote: Maybe I misunderstand you, in my view it is the responsibility of to create their DTS files to indicate they want to bind to generic-uio. Device tree is a OS-neutral hardware description language. "generic-uio" is neither OS-neutral nor a hardware description. dev

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Michal Simek
Wolfram Sang wrote: On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: Support OF support. "generic-uio" compatible property is used. And exactly this was the issue last time (when I tried). This is a generic property, which is linux-specific and not describing HW. The agreement bac

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Arnd Bergmann
On Thursday 31 March 2011, John Williams wrote: > On Thu, Mar 31, 2011 at 10:49 PM, Wolfram Sang wrote: > > > > On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: > > > Support OF support. "generic-uio" compatible property is used. > > > > And exactly this was the issue last time (when

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Wolfram Sang
>Maybe I misunderstand you, in my view it is the responsibility of >to create their DTS files to indicate they want to bind to >generic-uio. Device tree is a OS-neutral hardware description language. "generic-uio" is neither OS-neutral nor a hardware description. devicetree.org has

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread John Williams
Hi Wolfram, Sorry for the resend, my gmail session was in rich formatting mode and the reply was rejected from the list servers. On Thu, Mar 31, 2011 at 10:49 PM, Wolfram Sang wrote: > > On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: > > Support OF support. "generic-uio" compatibl

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread John Williams
Hi Wolfram, We discuss this again :) On Thu, Mar 31, 2011 at 10:49 PM, Wolfram Sang wrote: > On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: > > Support OF support. "generic-uio" compatible property is used. > > And exactly this was the issue last time (when I tried). This is a > g

Re: [PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Wolfram Sang
On Thu, Mar 31, 2011 at 02:30:00PM +0200, Michal Simek wrote: > Support OF support. "generic-uio" compatible property is used. And exactly this was the issue last time (when I tried). This is a generic property, which is linux-specific and not describing HW. The agreement back then was to we proba

[PATCH] uio/pdrv_genirq: Add OF support

2011-03-31 Thread Michal Simek
Support OF support. "generic-uio" compatible property is used. Signed-off-by: Michal Simek --- drivers/uio/uio_pdrv_genirq.c | 60 ++-- 1 files changed, 57 insertions(+), 3 deletions(-) diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genir

UIO OF support

2011-03-31 Thread Michal Simek
Hi, here is OF support for UIO. I tried to do minimal changes. John Williams has warned me that there was any previous attempt to add this OF support to UIO. Grant: Can you please review it? I wasn't sure about one part. I think you will see it and will comment it if there is something stupid