Re: [PATCH 2/9] regulator: helper routine to extract regulator_init_data

2011-09-28 Thread Cousson, Benoit
On 9/27/2011 5:05 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 08:18:04PM +0530, Rajendra Nayak wrote: On Tuesday 27 September 2011 05:40 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 03:42:45PM +0530, Rajendra Nayak wrote: + init_data = devm_kzalloc(dev, sizeof(struct

Re: [PATCH 8/9] regulator: helper to extract regulator node based on supply name

2011-09-28 Thread Cousson, Benoit
On 9/27/2011 8:59 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 08:19:37PM +0530, Rajendra Nayak wrote: On Tuesday 27 September 2011 05:51 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 03:42:51PM +0530, Rajendra Nayak wrote: + if (!dev) + return NULL; So how do we

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Cousson, Benoit
Hi Rajendra, On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: Adapt the GPIO driver to retrieve information from a DT file. Note that since the driver is currently under cleanup, some hacks will have to be removed after. Add

Re: [PATCH 8/9] regulator: helper to extract regulator node based on supply name

2011-09-28 Thread Rajendra Nayak
On Wednesday 28 September 2011 01:39 PM, Cousson, Benoit wrote: On 9/27/2011 8:59 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 08:19:37PM +0530, Rajendra Nayak wrote: On Tuesday 27 September 2011 05:51 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 03:42:51PM +0530, Rajendra Nayak wrote: +

Re: [PATCH 06/13] mfd: twl-core: Add initial DT support for twl4030/twl6030

2011-09-28 Thread Cousson, Benoit
On 9/27/2011 7:42 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: Add initial device-tree support for twl familly chips. s/familly/family Oops. The current version is missing the regulator entries due to the lack of DT regulator bindings for the

Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node

2011-09-28 Thread Daniel Drake
On Tue, Sep 27, 2011 at 7:38 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: You're modifying global data which should really be const and is shared between multiple devices in place.  Probably you'll not notice any practical effects, especially if you don't happen to have multiple

[PATCH 1/3] mfd: allow mfd_cell association with device tree node

2011-09-28 Thread Daniel Drake
This allows a mfd_cell to be linked with a device tree node, which then allows child drivers to have easy access to that handle. Signed-off-by: Daniel Drake d...@laptop.org --- drivers/mfd/mfd-core.c |1 + include/linux/mfd/core.h |4 2 files changed, 5 insertions(+), 0

[PATCH 2/3] mfd: link vx855 with device tree

2011-09-28 Thread Daniel Drake
Set the of_node of the mfd device, and use it to assign the of_node of the child gpio cell. The child driver will then pass the handle to gpiolib, which enables device-tree-probed gpio-leds and more. Signed-off-by: Daniel Drake d...@laptop.org --- drivers/mfd/vx855.c | 24

[PATCH 3/3] gpio-vx855: Add device tree binding

2011-09-28 Thread Daniel Drake
This is needed to enable the HDD LED on the OLPC XO-1.5 laptop, enabled through devicetree and the gpio-leds driver. Signed-off-by: Daniel Drake d...@laptop.org --- .../devicetree/bindings/gpio/gpio_vx855.txt| 20 drivers/gpio/gpio-vx855.c

[PATCH v5 0/6] Add device tree support for PL330 dma controller driver

2011-09-28 Thread Thomas Abraham
Changes since v4: - Rebased with Samsung maintainer's for-next branch which is at linux-3.1-rc7 - Modified Patch 6/6 to apply cleanly. Changes since v3: - In Patch 4/6, a recommendation is added in the pl330 binding documentation for the name of the property which specifies the dma channel in

[PATCH v5 1/6] DMA: PL330: move filter function into driver

2011-09-28 Thread Thomas Abraham
The dma channel selection filter function is moved from plat-samsung into the pl330 driver. In additon to that, a check is added in the filter function to ensure that the channel on which the filter has been invoked is pl330 channel instance (and avoid any incorrect access of chan-private in a

[PATCH v5 2/6] DMA: PL330: Infer transfer direction from transfer request instead of platform data

2011-09-28 Thread Thomas Abraham
The transfer direction for a channel can be inferred from the transfer request and the need for specifying transfer direction in platfrom data can be eliminated. So the structure definition 'struct dma_pl330_peri' is no longer required. The channel's private data is set to point to a channel id

[PATCH v5 3/6] ARM: EXYNOS4: Modify platform data for pl330 driver

2011-09-28 Thread Thomas Abraham
With the 'struct dma_pl330_peri' removed, the platfrom data for dma driver can be simplified to a simple list of peripheral request ids. Cc: Jassi Brar jassisinghb...@gmail.com Cc: Boojin Kim boojin@samsung.com Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Kukjin Kim

[PATCH v5 4/6] DMA: PL330: Add device tree support

2011-09-28 Thread Thomas Abraham
For PL330 dma controllers instantiated from device tree, the channel lookup is based on phandle of the dma controller and dma request id specified by the client node. During probe, the private data of each channel of the controller is set to point to the device node of the dma controller. The

[PATCH v5 5/6] ARM: SAMSUNG: Add device tree support for pl330 dma engine wrappers

2011-09-28 Thread Thomas Abraham
A new dma request id 'DMACH_DT_PROP' is introduced for client drivers requesting a dma channel. This request indicates that a device tree node property represting the dma channel is available in 'struct samsung_dma_info'. The dma channel request wrapper uses the node property value as the value

[PATCH v5 6/6] ARM: EXYNOS4: Limit usage of pl330 device instance to non-dt build

2011-09-28 Thread Thomas Abraham
The pl330 device instances and associated platform data is required only for non-device-tree builds. With device tree enabled, the data about the platform is obtained from the device tree. For images that include both dt and non-dt platforms, an addditional check is added to ensure that static

[PATCHv2 02/10] ARM: vic: MULTI_IRQ_HANDLER handler

2011-09-28 Thread Jamie Iles
Add a handler for the VIC that is suitable for MULTI_IRQ_HANDLER platforms. This can replace the ASM entry macros for platforms that use the VIC. v2: - allow the handler be used for !CONFIG_OF - use irq_domain_to_irq() Cc: Rob Herring robherri...@gmail.com Cc: Grant Likely

[PATCHv2 00/10] VIC DT binding and MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
This patch series adds a device tree binding for the VIC and support for a generic VIC MULTI_IRQ_HANDLER. The MULTI_IRQ_HANDLER is a step towards a single image kernel, removing the need for mach specific entry handlers for platforms using the VIC as the primary interrupt controller. This has

[PATCHv2 03/10] ARM: ep93xx: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for ep93xx to help building multi platform kernels. Cc: Hartley Sweeten hswee...@visionengravers.com Cc: Ryan Mallon rmal...@gmail.com Signed-off-by: Jamie Iles ja...@jamieiles.com --- arch/arm/Kconfig

[PATCHv2 01/10] ARM: vic: device tree binding

2011-09-28 Thread Jamie Iles
This adds a device tree binding for the VIC based on the of_irq_init() support. This adds an irqdomain to the vic and always registers all vics in the static vic array rather than for pm only to keep track of the irq domain. struct irq_data::hwirq is used where appropriate rather than runtime

[PATCHv2 04/10] ARM: netx: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for netx to help building multi platform kernels. Signed-off-by: Jamie Iles ja...@jamieiles.com --- arch/arm/Kconfig |1 + arch/arm/mach-netx/include/mach/entry-macro.S | 13 -

[PATCHv2 05/10] ARM: nomadik: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for nomadik to help building multi platform kernels. Cc: Alessandro Rubini rub...@unipv.it Cc: Linus Walleij linus.wall...@stericsson.com Cc: STEricsson stericsson_nomadik_li...@list.st.com Signed-off-by: Jamie Iles

[PATCHv2 06/10] ARM: s3c64xx: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for s3c64xx to help building multi platform kernels. Cc: Ben Dooks ben-li...@fluff.org Signed-off-by: Jamie Iles ja...@jamieiles.com --- arch/arm/Kconfig |1 +

[PATCHv2 07/10] ARM: spear: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for spear to help building multi platform kernels. Cc: Viresh Kumar viresh.ku...@st.com Cc: Rajeev Kumar rajeev-dlh.ku...@st.com Signed-off-by: Jamie Iles ja...@jamieiles.com --- arch/arm/Kconfig

[PATCHv2 08/10] ARM: u300: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for u300 to help building multi platform kernels. Cc: Linus Walleij linus.wall...@stericsson.com Signed-off-by: Jamie Iles ja...@jamieiles.com --- arch/arm/Kconfig |1 +

[PATCHv2 10/10] ARM: samsung: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for samsung to help building multi platform kernels. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Jamie Iles ja...@jamieiles.com --- arch/arm/Kconfig |3 ++

[PATCHv2 09/10] ARM: versatile: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Now that there is a generic IRQ handler for multiple VIC devices use it for versatile to help building multi platform kernels. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Jamie Iles ja...@jamieiles.com --- arch/arm/Kconfig |1 +

Re: [PATCH 8/9] regulator: helper to extract regulator node based on supply name

2011-09-28 Thread Rajendra Nayak
On Wednesday 28 September 2011 12:29 AM, Mark Brown wrote: On Tue, Sep 27, 2011 at 08:19:37PM +0530, Rajendra Nayak wrote: On Tuesday 27 September 2011 05:51 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 03:42:51PM +0530, Rajendra Nayak wrote: + if (!dev) + return NULL;

Re: [PATCHv2 08/10] ARM: u300: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Linus Walleij
Hold your horses: On Wed, Sep 28, 2011 at 12:41 PM, Jamie Iles ja...@jamieiles.com wrote: diff --git a/arch/arm/mach-u300/include/mach/entry-macro.S b/arch/arm/mach-u300/include/mach/entry-macro.S index 20731ae..7181d6a 100644 --- a/arch/arm/mach-u300/include/mach/entry-macro.S +++

Re: [PATCHv2 02/10] ARM: vic: MULTI_IRQ_HANDLER handler

2011-09-28 Thread Linus Walleij
On Wed, Sep 28, 2011 at 12:41 PM, Jamie Iles ja...@jamieiles.com wrote: +static void vic_single_handle_irq(struct vic_device *vic, struct pt_regs *regs) +{ +       u32 stat, irq; +       bool handled = false; + +       while (!handled) { +               stat = readl_relaxed(vic-base +

Re: [PATCHv2 05/10] ARM: nomadik: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Linus Walleij
On Wed, Sep 28, 2011 at 12:41 PM, Jamie Iles ja...@jamieiles.com wrote: -       /* This stanza gets the irq mask from one of two status registers */ -       mov     \irqnr, #0 -       ldr     \irqstat, [\base, #VIC_REG_IRQSR0]      @ get masked status -       cmp     \irqstat, #0 -       bne

Re: [PATCHv2 03/10] ARM: ep93xx: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Linus Walleij
On Wed, Sep 28, 2011 at 12:41 PM, Jamie Iles ja...@jamieiles.com wrote: -               .macro  get_irqnr_and_base, irqnr, irqstat, base, tmp -               ldr     \base, =(EP93XX_AHB_VIRT_BASE) -               orr     \base, \base, #0x000b -               mov     \irqnr, #0 -          

Re: [PATCHv2 08/10] ARM: u300: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
Hi Linus, On Wed, Sep 28, 2011 at 01:03:34PM +0200, Linus Walleij wrote: Hold your horses: On Wed, Sep 28, 2011 at 12:41 PM, Jamie Iles ja...@jamieiles.com wrote: diff --git a/arch/arm/mach-u300/include/mach/entry-macro.S b/arch/arm/mach-u300/include/mach/entry-macro.S index

Re: [PATCHv2 02/10] ARM: vic: MULTI_IRQ_HANDLER handler

2011-09-28 Thread Jamie Iles
Hi Linus, On Wed, Sep 28, 2011 at 01:09:48PM +0200, Linus Walleij wrote: On Wed, Sep 28, 2011 at 12:41 PM, Jamie Iles ja...@jamieiles.com wrote: +static void vic_single_handle_irq(struct vic_device *vic, struct pt_regs *regs) +{ +       u32 stat, irq; +       bool handled = false;

Re: [PATCHv2 08/10] ARM: u300: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Linus Walleij
On Wed, Sep 28, 2011 at 2:03 PM, Jamie Iles ja...@jamieiles.com wrote: vic_single_handle_irq() needs to be modified to handle several ranges or atleast two. The platform IRQ handler is actually vic_handle_irq() that internally calls vic_single_handle_irq() for each registered vic (in the

Re: [PATCH 8/9] regulator: helper to extract regulator node based on supply name

2011-09-28 Thread Mark Brown
On Wed, Sep 28, 2011 at 10:09:30AM +0200, Cousson, Benoit wrote: On 9/27/2011 8:59 PM, Mark Brown wrote: I'm not sure how this should work in a device tree world, I'd *hope* we'd get a device tree node for the CPU and could then just make this a regular consumer thing but then the cpufreq

Re: [PATCHv2 08/10] ARM: u300: convert to MULTI_IRQ_HANDLER

2011-09-28 Thread Jamie Iles
On Wed, Sep 28, 2011 at 02:18:14PM +0200, Linus Walleij wrote: On Wed, Sep 28, 2011 at 2:03 PM, Jamie Iles ja...@jamieiles.com wrote: vic_single_handle_irq() needs to be modified to handle several ranges or atleast two. The platform IRQ handler is actually vic_handle_irq() that

Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node

2011-09-28 Thread Mark Brown
On Wed, Sep 28, 2011 at 10:07:43AM +0100, Daniel Drake wrote: On Tue, Sep 27, 2011 at 7:38 PM, Mark Brown You're modifying global data which should really be const and is shared between multiple devices in place.  Probably you'll not notice any practical effects, especially if you don't

Re: [PATCH v3 07/24] C6X: devicetree support

2011-09-28 Thread Arnd Bergmann
On Tuesday 27 September 2011, Mark Salter wrote: diff --git a/arch/c6x/boot/install-dtb.c b/arch/c6x/boot/install-dtb.c new file mode 100644 index 000..fa979ce --- /dev/null +++ b/arch/c6x/boot/install-dtb.c @@ -0,0 +1,333 @@ +/* + * Program to hack in a DTB to an ELF file having a

Re: [PATCH v3 07/24] C6X: devicetree support

2011-09-28 Thread Mark Salter
On Wed, 2011-09-28 at 15:31 +0200, Arnd Bergmann wrote: On Tuesday 27 September 2011, Mark Salter wrote: diff --git a/arch/c6x/boot/install-dtb.c b/arch/c6x/boot/install-dtb.c new file mode 100644 index 000..fa979ce --- /dev/null +++ b/arch/c6x/boot/install-dtb.c @@ -0,0 +1,333 @@

Re: [PATCH v3 07/24] C6X: devicetree support

2011-09-28 Thread Arnd Bergmann
On Wednesday 28 September 2011, Mark Salter wrote: Other architectures allow simply appending the device tree to the kernel image file, which is more convenient for users and does not require much kernel support. Have you tried this? Well, I considered it. My main reason for doing it this

Re: [PATCH v2] dtc: Add support for named integer constants

2011-09-28 Thread Scott Wood
On 09/27/2011 07:29 PM, David Gibson wrote: On Tue, Sep 20, 2011 at 12:35:29PM -0500, Scott Wood wrote: Another disadvantage of any approach that tries to separate macros from the underlying language is that you can't have anything be conditional on an expression that the macro layer doesn't

Re: [PATCH v2 2/3] netdev/of/phy: Add MDIO bus multiplexer support.

2011-09-28 Thread David Daney
On 09/28/2011 12:25 AM, Michał Mirosław wrote: 2011/9/28 David Daneydavid.da...@cavium.com: [...] +Example : + + /* The parent MDIO bus. */ + smi1: mdio@118001900 { + compatible = cavium,octeon-3860-mdio; + #address-cells =1; +

Re: [PATCH v2 2/3] netdev/of/phy: Add MDIO bus multiplexer support.

2011-09-28 Thread David Daney
On 09/28/2011 10:32 AM, Michał Mirosław wrote: W dniu 28 września 2011 18:51 użytkownik David Daney david.da...@cavium.com napisał: On 09/28/2011 12:25 AM, Michał Mirosław wrote: 2011/9/28 David Daneydavid.da...@cavium.com: [...] +Example : + + /* The parent MDIO bus. */ +

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Scott Wood
On 09/28/2011 03:15 AM, Cousson, Benoit wrote: On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: +Required properties: +- compatible: + - ti,omap2-gpio for OMAP2 and OMAP3 controllers Would it be more readable to have ti,omap2-gpio

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Cousson, Benoit
On 9/28/2011 8:23 PM, Scott Wood wrote: On 09/28/2011 03:15 AM, Cousson, Benoit wrote: On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: +Required properties: +- compatible: + - ti,omap2-gpio for OMAP2 and OMAP3 controllers Would it be

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Scott Wood
On 09/28/2011 03:57 PM, Cousson, Benoit wrote: On 9/28/2011 8:23 PM, Scott Wood wrote: What does the id mean, in relation to the actual hardware? It's true that the description is not super meaningful... This is the HW instance number. We have 6 gpios, named gpio1 to gpio6, but the pin

Re: [PATCH v3 07/24] C6X: devicetree support

2011-09-28 Thread Grant Likely
On Wed, Sep 28, 2011 at 03:31:36PM +0200, Arnd Bergmann wrote: On Tuesday 27 September 2011, Mark Salter wrote: diff --git a/arch/c6x/boot/install-dtb.c b/arch/c6x/boot/install-dtb.c new file mode 100644 index 000..fa979ce --- /dev/null +++ b/arch/c6x/boot/install-dtb.c @@ -0,0

Re: [PATCHv2 02/10] ARM: vic: MULTI_IRQ_HANDLER handler

2011-09-28 Thread Grant Likely
On Wed, Sep 28, 2011 at 11:41:39AM +0100, Jamie Iles wrote: Add a handler for the VIC that is suitable for MULTI_IRQ_HANDLER platforms. This can replace the ASM entry macros for platforms that use the VIC. v2: - allow the handler be used for !CONFIG_OF - use irq_domain_to_irq()

Re: [PATCHv2 01/10] ARM: vic: device tree binding

2011-09-28 Thread Grant Likely
On Wed, Sep 28, 2011 at 11:41:38AM +0100, Jamie Iles wrote: This adds a device tree binding for the VIC based on the of_irq_init() support. This adds an irqdomain to the vic and always registers all vics in the static vic array rather than for pm only to keep track of the irq domain. struct

[PATCH 0/2] GIC OF bindings

2011-09-28 Thread Rob Herring
From: Rob Herring rob.herr...@calxeda.com With recent patches for VIC device tree support and GIC MULTI_IRQ support, it is evident that the irq domain support should be moved into the core GIC code and not be dependent on the DT initialization. So I've split things up into 2 patches separating

[PATCH 2/2] ARM: gic: add OF based initialization

2011-09-28 Thread Rob Herring
From: Rob Herring rob.herr...@calxeda.com This adds ARM gic interrupt controller initialization using device tree data. The initialization function is intended to be called by of_irq_init function like this: const static struct of_device_id irq_match[] = { { .compatible =

Re: [PATCHv2 01/10] ARM: vic: device tree binding

2011-09-28 Thread Rob Herring
On 09/28/2011 05:41 AM, Jamie Iles wrote: This adds a device tree binding for the VIC based on the of_irq_init() support. This adds an irqdomain to the vic and always registers all vics in the static vic array rather than for pm only to keep track of the irq domain. struct irq_data::hwirq is