[PATCH 2/6] tegra: fdt: Add keyboard definitions for Seaboard

2011-12-02 Thread Simon Glass
From: Anton Staff Seaboard uses a QUERTY keyboard. We add key codes for this to enable key scanning to work. Signed-off-by: Simon Glass --- board/nvidia/dts/tegra2-seaboard.dts | 71 ++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/board/nvid

[PATCH 1/6] tegra: fdt: Add keyboard controller definition

2011-12-02 Thread Simon Glass
From: Anton Staff The Tegra keyboard controller provides a simple interface to a matrix keyboard. Signed-off-by: Simon Glass --- arch/arm/dts/tegra20.dtsi |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi index d7a

[PATCH 3/6] fdt: Add fdtdec functions to read byte array

2011-12-02 Thread Simon Glass
From: Anton Staff Sometimes we don't need a full cell for each value. This provides a simple function to read a byte array, both with and without copying it. Signed-off-by: Simon Glass --- include/fdtdec.h | 32 lib/fdtdec.c | 24 +++

[PATCH v2 17/17] tegra: fdt: Enable FDT support for Seaboard

2011-12-02 Thread Simon Glass
This switches Seaboard over to use FDT for run-time config instead of CONFIG options. USB is the only user at present. Signed-off-by: Simon Glass --- include/configs/seaboard.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/configs/seaboard.h b/include/conf

[PATCH v2 09/17] tegra: usb: fdt: Add additional device tree definitions for USB ports

2011-12-02 Thread Simon Glass
This adds peripheral IDs and timing information to the USB part of the device tree for U-Boot. The peripheral IDs provide easy access to clock registers. We will likely remove this in favor of a full clock tree when it is available in the kernel (but probably still retain the peripheral ID, just m

[PATCH v2 07/17] tegra: fdt: Add Tegra2x device tree file from kernel

2011-12-02 Thread Simon Glass
This was taken from commit b48c54e2 at: git://git.kernel.org/pub/scm/linux/kernel/git/olof/tegra.git config.mk is updated to provide this file to boards through the built-in mechanism: /include/ ARCH_CPU_DTS Signed-off-by: Simon Glass --- arch/arm/cpu/armv7/tegra2/config.mk |2 + arch/arm

[PATCH v2 06/17] arm: fdt: Add skeleton device tree file from kernel

2011-12-02 Thread Simon Glass
This was taken from commit b48c54e2 at: git://git.kernel.org/pub/scm/linux/kernel/git/olof/tegra.git Signed-off-by: Simon Glass --- arch/arm/dts/skeleton.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 arch/arm/dts/skeleton.dtsi diff --git a/arc

[PATCH v2 02/17] fdt: Add functions to access phandles, arrays and bools

2011-12-02 Thread Simon Glass
Add a function to look up a property which is a phandle in a node, and another to read a fixed-length integer array from an fdt property. Also add a function to read boolean properties, although there is no actual boolean type in U-Boot. Signed-off-by: Simon Glass --- Changes in v2: - Rename get_

[PATCH v2 10/17] tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard

2011-12-02 Thread Simon Glass
We set up two USB ports, one of which can be host or device. For some reason the kernel version does enable both ports. Signed-off-by: Simon Glass --- Changes in v2: - Use "okay" instead of "ok" for fdt node status - Remove 0x from fdt aliases board/nvidia/dts/tegra2-seaboard.dts | 14 +++

[PATCH v2 08/17] tegra: fdt: Add device tree file for Tegra2 Seaboard from kernel

2011-12-02 Thread Simon Glass
This was taken from commit b48c54e2 at: git://git.kernel.org/pub/scm/linux/kernel/git/olof/tegra.git Signed-off-by: Simon Glass --- Changes in v2: - Pulled USB fdt definitions from newer for-next instead of master board/nvidia/dts/tegra2-seaboard.dts | 36 ++ 1

[PATCH v2 04/17] fdt: Add basic support for decoding GPIO definitions

2011-12-02 Thread Simon Glass
This adds some support into fdtdec for reading GPIO definitions from the fdt. We permit up to FDT_GPIO_MAX GPIOs in the system. Each GPIO is of the form: gpio-function-name = ; where: phandle is a pointer to the GPIO node gpio_num is the number of the GPIO (0 to 223) flags is some flags, propose

[PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-02 Thread Simon Glass
This fixes five trivial issues in fdtdec.c: 1. fdtdec_get_is_enabled() doesn't really need a default value 2. The fdt must be word-aligned, since otherwise it will fail on ARM 3. The compat_names[] array is missing its first element. This is needed only because the first fdt_compat_id is defined to

[PATCH v2 05/17] arm: fdt: Ensure that an embedded fdt is word-aligned

2011-12-02 Thread Simon Glass
By putting the fdt blob into a distinctive area we can ensure that it appears at the start of the data section and is word-aligned. Note: It does not seem to be possible to get objcopy to honour its --section-alignment flag, which would otherwise provide an easier fix for this problem. Signed-off

Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

2011-12-02 Thread Alan Cox
> This is now broken on ARM where, for good or bad, NO_IRQ currently is > used and is -1. Good. ARM developers have been told to change this for several years. The nice approach hasn't worked, the patient approach hasn't worked so now finally ARM is going to be dragged kicking and screaming into

Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

2011-12-02 Thread Benjamin Herrenschmidt
On Fri, 2011-12-02 at 11:28 -0800, Linus Torvalds wrote: > On Fri, Dec 2, 2011 at 11:26 AM, Dave Martin wrote: > > > > This is now broken on ARM where, for good or bad, NO_IRQ currently is > > used and is -1. > > > > How do we resolve it? If we are ready to eliminate NO_IRQ from > > drivers/of/ir

Re: [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support

2011-12-02 Thread Marek Vasut
> On Fri, 2 Dec 2011, Stephen Warren wrote: > > For the record, the changes are now in U-Boot master: > > > > d510859 image: Don't detect XIP images as overlapping. > > b9b50e8 image: Implement IH_TYPE_KERNEL_NOLOAD > > Yay! Thank you Stephen for driving this to a successful resolution. > > Of

RE: [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support

2011-12-02 Thread Nicolas Pitre
On Fri, 2 Dec 2011, Stephen Warren wrote: > For the record, the changes are now in U-Boot master: > > d510859 image: Don't detect XIP images as overlapping. > b9b50e8 image: Implement IH_TYPE_KERNEL_NOLOAD Yay! Thank you Stephen for driving this to a successful resolution. Of course, boards wo

[PATCH v2 5/5] ASoC: WM8903: Add device tree binding

2011-12-02 Thread Stephen Warren
Document the device tree binding for the WM8903 codec, and modify the driver to extract platform data from the device tree, if present. Based on work by John Bonesio, but significantly reworked since then. Signed-off-by: Stephen Warren --- Documentation/devicetree/bindings/sound/wm8903.txt |

[PATCH v2 4/5] ASoC: WM8903: Get default irq_active_low from IRQ controller

2011-12-02 Thread Stephen Warren
If the WM8903 is hooked up to an interrupt, set the irq_active_low flag in the default platform data based on the IRQ's IRQ_TYPE. Map IRQ_TYPE_NONE (a lack of explicit configuration/restriction) to irq_active_low = false; the previous default. This code is mainly added to support device tree inter

[PATCH v2 1/5] ASoC: WM8903: Fix platform data gpio_cfg confusion

2011-12-02 Thread Stephen Warren
wm8903_platform_data.gpio_cfg[] was intended to be interpreted as follows: 0: Don't touch this GPIO's configuration register 1..7fff: Write that value to the GPIO's configuration register 8000:Write zero to the GPIO's configuration register other: Undefined (invalid) The rationale is t

[PATCH v2 3/5] ASoC: WM8903: Remove conditionals checking pdata != NULL

2011-12-02 Thread Stephen Warren
The pdata pointer is now always valid. Remove any conditions that check its validity. This patch is mostly just removing an indentation level. One variable had to be moved due to the removal of a scope, and one comment was split into two. Viewing the patch with git show/diff -b will show that it's

[PATCH v2 0/5] ASoC: WM8903: DT bindings & related

2011-12-02 Thread Stephen Warren
v2: * Fixed default pdata logic so that 0 in pdata fields really means "do nothing". * Added a patch to fix pdata gpio_cfg value confusion. * Moved all the pdata default & DT parsing logic to i2c_probe from codec probe. * Split parsing logic out into separate functions so probe is easier to r

[PATCH v2 2/5] ASoC: WM8903: Create default platform data structure

2011-12-02 Thread Stephen Warren
When no platform data is supplied, point pdata at a default platform structure. This enables two future changes: a) Defines the default platform data values in a single place. b) There is always a valid pdata pointer, so some conditional code can be simplified by a later patch. Based on work b

[RFC PATCH 3/3] New "gpio-poweroff" driver to turn off platform devices with GPIOs

2011-12-02 Thread Kyle Moffett
This driver is especially useful on systems with an OF device-tree as they can automatically instantiate the driver from GPIOs described in the device-tree. Signed-off-by: Kyle Moffett --- .../devicetree/bindings/gpio/gpio-poweroff.txt | 70 drivers/gpio/Kconfig

[RFC PATCH 2/3] of_gpio: Add new helpers for easily requesting lots of GPIOs

2011-12-02 Thread Kyle Moffett
Mirroring the new gpio_request_array() interface, we add several a few helper functions for operating on entire arrays of GPIOs. Also, to make it easier to write various combinations of "of_get_gpio()" followed by "gpio_request()", add several other new inline wrappers. Signed-off-by: Kyle Moffet

[RFC PATCH 1/3] of_gpio: Extend of_gpio_count() to support other property names

2011-12-02 Thread Kyle Moffett
The of_get_named_gpio_flags() function allows the caller to specify the property name which should be read for a list of GPIOs. Unfortunately there is no easy way to *count* the number of GPIOs listed in an arbitrary property. To resolve this, rename of_gpio_count() to of_gpio_count_named() and a

[RFC PATCH 0/3] New "gpio-poweroff" driver to turn off platform devices with GPIOs

2011-12-02 Thread Kyle Moffett
Hello all, I'm working on support for some custom hardware of ours, and part of the support code is the ability for the software to shutdown the power supply using GPIOs (via an I2C GPIO controller). I previously had this in my platform code, but it seemed generically useful, so I split it out in

Re: [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support

2011-12-02 Thread Dave Martin
On Fri, Dec 02, 2011 at 09:41:12AM -0800, Stephen Warren wrote: > Stephen Warren wrote at Thursday, December 01, 2011 9:20 AM: > > Dave Martin wrote at Thursday, December 01, 2011 5:14 AM: > > > On Thu, Dec 01, 2011 at 11:10:50AM +, Mark Brown wrote: > > > > On Wed, Nov 30, 2011 at 04:38:26PM -

Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

2011-12-02 Thread Dave Martin
[expanding CC -- apologies to anyone who gets this mail twice] On Thu, Nov 10, 2011 at 08:28:59PM +0400, Anton Vorontsov wrote: > Drivers should not use NO_IRQ; moreover, some architectures don't > have it nowadays. '0' is the 'no irq' case. > > Signed-off-by: Anton Vorontsov > Acked-by: Alan Co

Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

2011-12-02 Thread Dave Martin
On Thu, Nov 10, 2011 at 08:28:59PM +0400, Anton Vorontsov wrote: > Drivers should not use NO_IRQ; moreover, some architectures don't > have it nowadays. '0' is the 'no irq' case. > > Signed-off-by: Anton Vorontsov > Acked-by: Alan Cox > --- > > On Thu, Nov 10, 2011 at 03:38:16PM +, Alan Cox

Re: [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support

2011-12-02 Thread Marek Vasut
> Stephen Warren wrote at Thursday, December 01, 2011 9:20 AM: > > Dave Martin wrote at Thursday, December 01, 2011 5:14 AM: > > > On Thu, Dec 01, 2011 at 11:10:50AM +, Mark Brown wrote: > > > > On Wed, Nov 30, 2011 at 04:38:26PM -0500, Nicolas Pitre wrote: > > > > > On Wed, 30 Nov 2011, Mark B

Re: [U-Boot] [PATCH 02/14] fdt: Add functions to access phandles, arrays and bools

2011-12-02 Thread Simon Glass
Hi Jerry, On Fri, Dec 2, 2011 at 9:22 AM, Jerry Van Baren wrote: > On 12/01/2011 11:58 PM, Simon Glass wrote: >> >> Hi Jerry, >> >> On Thu, Dec 1, 2011 at 7:33 PM, Jerry Van Baren >>  wrote: > > [snip] > >>> FDT helper functions have been accumulating in common/fdt_support.c >>> rather >>> than a

Re: [PATCH v2] net/macb: add DT support

2011-12-02 Thread David Miller
From: Nicolas Ferre Date: Fri, 2 Dec 2011 18:43:02 +0100 > From: Jean-Christophe PLAGNIOL-VILLARD > > Allow the device tree to provide the mac address and the phy mode. > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > [nicolas.fe...@atmel.com: change "compatible" node property, doc and

Re: [PATCH] net/macb: add DT support

2011-12-02 Thread Nicolas Ferre
On 12/02/2011 06:28 PM, Jamie Iles : Hi Nicolas, On Fri, Dec 02, 2011 at 06:14:10PM +0100, Nicolas Ferre wrote: From: Jean-Christophe PLAGNIOL-VILLARD Allow the device tree to provide the mac address and the phy mode. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [nicolas.fe...@atmel.com: c

[PATCH] ARM: at91/net: add macb ethernet controller in 9g45 DT

2011-12-02 Thread Nicolas Ferre
Add the Cadence macb ethernet controller in at91sam9g45 .dtsi and enable it in at91sam9m10g45ek board device tree file. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91sam9g45.dtsi |7 +++ arch/arm/boot/dts/at91sam9m10g45ek.dts |6 ++ 2 files changed, 13 insertions(+),

[PATCH v2] net/macb: add DT support

2011-12-02 Thread Nicolas Ferre
From: Jean-Christophe PLAGNIOL-VILLARD Allow the device tree to provide the mac address and the phy mode. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [nicolas.fe...@atmel.com: change "compatible" node property, doc and DT hwaddr] Signed-off-by: Nicolas Ferre Cc: Jamie Iles --- v2: modify

RE: [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support

2011-12-02 Thread Stephen Warren
Stephen Warren wrote at Thursday, December 01, 2011 9:20 AM: > Dave Martin wrote at Thursday, December 01, 2011 5:14 AM: > > On Thu, Dec 01, 2011 at 11:10:50AM +, Mark Brown wrote: > > > On Wed, Nov 30, 2011 at 04:38:26PM -0500, Nicolas Pitre wrote: > > > > On Wed, 30 Nov 2011, Mark Brown wrote

Re: [PATCH] net/macb: add DT support

2011-12-02 Thread Jamie Iles
Hi Nicolas, On Fri, Dec 02, 2011 at 06:14:10PM +0100, Nicolas Ferre wrote: > From: Jean-Christophe PLAGNIOL-VILLARD > > Allow the device tree to provide the mac address and the phy mode. > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > [nicolas.fe...@atmel.com: change "compatible" node pr

[PATCH] net/macb: add DT support

2011-12-02 Thread Nicolas Ferre
From: Jean-Christophe PLAGNIOL-VILLARD Allow the device tree to provide the mac address and the phy mode. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [nicolas.fe...@atmel.com: change "compatible" node property, doc and DT hwaddr] Signed-off-by: Nicolas Ferre Cc: Jamie Iles --- Documentat

[PATCH v2] isp1760: Fix endianness-sensitivity in of_isp1760_probe()

2011-12-02 Thread Dave Martin
Data read direct from device tree properties will be in the device tree's native endianness (i.e., big-endian). This patch uses of_property_read_u32() to read the bus-width property in host byte order instead. Signed-off-by: Dave Martin Acked-by: Pawel Moll --- Changes since v1: v2: Rebased ag

Re: [PATCH 05/14] tegra: fdt: Add Tegra2x device tree file

2011-12-02 Thread Simon Glass
Hi Stephen, On Fri, Dec 2, 2011 at 7:58 AM, Stephen Warren wrote: > On 12/01/2011 06:24 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Nov 28, 2011 at 10:56 AM, Stephen Warren wrote: >>> On 11/23/2011 08:54 PM, Simon Glass wrote: This was taken from commit 1ea6b8f at: git://git.ke

Re: [PATCH 02/14] fdt: Add functions to access phandles, arrays and bools

2011-12-02 Thread Simon Glass
Hi Stephen, On Fri, Dec 2, 2011 at 7:55 AM, Stephen Warren wrote: > On 12/01/2011 06:01 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Nov 28, 2011 at 10:41 AM, Stephen Warren wrote: >>> On 11/23/2011 08:54 PM, Simon Glass wrote: Add a function to lookup a property which is a phandle i

Re: Pin control mappings for DT

2011-12-02 Thread Tony Lindgren
* Linus Walleij [111202 01:56]: > On Thu, Dec 1, 2011 at 11:22 PM, Tony Lindgren wrote: > > > But how does the second pinmux driver instance know if it's OK > > to add to the mapping or not? The mapping exists, but it might be > > also from the previous time you loaded the pinmux driver.. > > T

Re: [PATCH 05/14] tegra: fdt: Add Tegra2x device tree file

2011-12-02 Thread Stephen Warren
On 12/01/2011 06:24 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Nov 28, 2011 at 10:56 AM, Stephen Warren wrote: >> On 11/23/2011 08:54 PM, Simon Glass wrote: >>> This was taken from commit 1ea6b8f at: >>> git://git.kernel.org/pub/scm/linux/kernel/git/olof/tegra.git >> ... >> In particular, l

Re: [PATCH 02/14] fdt: Add functions to access phandles, arrays and bools

2011-12-02 Thread Stephen Warren
On 12/01/2011 06:01 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Nov 28, 2011 at 10:41 AM, Stephen Warren wrote: >> On 11/23/2011 08:54 PM, Simon Glass wrote: >>> Add a function to lookup a property which is a phandle in a node, and >>> another to read a fixed-length integer array from an fdt

Re: [PATCH 1/1] net/macb: add DT support

2011-12-02 Thread Jamie Iles
On Fri, Dec 02, 2011 at 04:30:36PM +0100, Nicolas Ferre wrote: > On 11/20/2011 06:11 PM, Jamie Iles : > >On Sun, Nov 20, 2011 at 05:47:40PM +0100, Jean-Christophe PLAGNIOL-VILLARD > >wrote: > >>On 15:58 Fri 18 Nov , Jamie Iles wrote: [...] > + compatible = "atmel,macb"; > >>> > >>>

Re: [PATCH v2 1/4] mfd: mc13xxx: add device tree probe support

2011-12-02 Thread Mark Brown
On Thu, Dec 01, 2011 at 05:21:05PM +0800, Shawn Guo wrote: > +Sub-nodes: > +- regulators : Contain the regulator nodes. The bindings details of > individual > + regulator node can be found in: > + Documentation/devicetree/bindings/regulator/regulator.txt How does the driver figure out which r

Re: [PATCH 1/1] net/macb: add DT support

2011-12-02 Thread Nicolas Ferre
On 11/20/2011 06:11 PM, Jamie Iles : On Sun, Nov 20, 2011 at 05:47:40PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: On 15:58 Fri 18 Nov , Jamie Iles wrote: Hi Jean-Christophe, On Fri, Nov 18, 2011 at 03:29:25PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: allow the DT to pass the m

Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings

2011-12-02 Thread Mark Brown
On Fri, Dec 02, 2011 at 03:59:01PM +0100, Cousson, Benoit wrote: > On 12/2/2011 3:00 PM, Mark Brown wrote: > >At least the DMA bindings seem fairly well sorted - we just merged the > >Tegra audio bindings which define a Tegra property for the DMA request > >signal. There's a reasonable amount of

Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings

2011-12-02 Thread Cousson, Benoit
On 12/2/2011 3:00 PM, Mark Brown wrote: On Fri, Dec 02, 2011 at 02:31:13PM +0100, Cousson, Benoit wrote: Even if the reg-names and interrupts-names are accepted, which is still not obvious due to a little bit of resistance, we still do not Yeah, it seems like there's very little traction on a

Re: Configurable interrupt sources, and DT bindings

2011-12-02 Thread Mark Brown
On Sat, Dec 03, 2011 at 01:31:07AM +1100, David Gibson wrote: > My apologies. I was mixing up who said what. It was Stephen who made > this proposal, kicking off the thread. Ah, OK - I think there's been some misreading here. > SW> One possibility is to describe this directly in the binding fo

Re: Configurable interrupt sources, and DT bindings

2011-12-02 Thread David Gibson
On Fri, Dec 02, 2011 at 01:34:13PM +, Mark Brown wrote: > On Fri, Dec 02, 2011 at 11:24:18PM +1100, David Gibson wrote: > > > No, you suggested it be a global property of the interrupt source. > > Same problem, just less so. > > Cite? My apologies. I was mixing up who said what. It was Ste

Re: [PATCH] irqdomain: protect macro variable in domain iterators

2011-12-02 Thread Dave Martin
On Fri, Dec 02, 2011 at 07:51:58AM -0600, Rob Herring wrote: > On 12/02/2011 06:59 AM, Dave Martin wrote: > > On Fri, Dec 02, 2011 at 02:53:17PM +0100, Nicolas Ferre wrote: > >> Signed-off-by: Nicolas Ferre > >> --- > >> Error found while using those iterators in an irq controller > >> initializat

Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings

2011-12-02 Thread Mark Brown
On Fri, Dec 02, 2011 at 02:31:13PM +0100, Cousson, Benoit wrote: > Even if the reg-names and interrupts-names are accepted, which is > still not obvious due to a little bit of resistance, we still do not Yeah, it seems like there's very little traction on any of the problems with legacy bindings

Re: [PATCH] irqdomain: protect macro variable in domain iterators

2011-12-02 Thread Rob Herring
On 12/02/2011 06:59 AM, Dave Martin wrote: > On Fri, Dec 02, 2011 at 02:53:17PM +0100, Nicolas Ferre wrote: >> Signed-off-by: Nicolas Ferre >> --- >> Error found while using those iterators in an irq controller >> initialization function. >> >> May also need protection around irq and hwirq macro v

Re: [PATCH v2] irqdomain: protect macro variable in domain iterators

2011-12-02 Thread Dave Martin
On Fri, Dec 02, 2011 at 02:30:09PM +0100, Nicolas Ferre wrote: > Signed-off-by: Nicolas Ferre Looks OK to me: Acked-by: Dave Martin > --- > v2: add brackets to each macro variable. > > include/linux/irqdomain.h | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff -

Re: Configurable interrupt sources, and DT bindings

2011-12-02 Thread Mark Brown
On Fri, Dec 02, 2011 at 11:24:18PM +1100, David Gibson wrote: > No, you suggested it be a global property of the interrupt source. > Same problem, just less so. Cite? > > Not in the real world, in the real world we don't have device tree > > bindings for most of the interrupt controllers out the

Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings

2011-12-02 Thread Cousson, Benoit
On 12/2/2011 2:02 PM, Mark Brown wrote: On Fri, Dec 02, 2011 at 02:32:59PM +0200, Peter Ujfalusi wrote: As of now we receive all these information via OMAP hwmod. All the properties (addresses, irq, etc) of the HW IP will be coming from DT as soon as I can remove the ti,hwmod property. Oh, ri

[PATCH v2] irqdomain: protect macro variable in domain iterators

2011-12-02 Thread Nicolas Ferre
Signed-off-by: Nicolas Ferre --- v2: add brackets to each macro variable. include/linux/irqdomain.h | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index bd4272b..e535063 100644 --- a/include/linux/irqdomain.

Re: [PATCH] irqdomain: protect macro variable in domain iterators

2011-12-02 Thread Nicolas Ferre
On 12/02/2011 01:59 PM, Dave Martin : On Fri, Dec 02, 2011 at 02:53:17PM +0100, Nicolas Ferre wrote: Signed-off-by: Nicolas Ferre --- Error found while using those iterators in an irq controller initialization function. May also need protection around irq and hwirq macro variables but those val

Re: Configurable interrupt sources, and DT bindings

2011-12-02 Thread David Gibson
On Fri, Dec 02, 2011 at 11:27:22AM +, Mark Brown wrote: > On Fri, Dec 02, 2011 at 04:38:14PM +1100, David Gibson wrote: > > On Thu, Dec 01, 2011 at 11:07:39AM +, Mark Brown wrote: > > > > Right, but you could stuff those in an enormous array or whatever - the > > > point was to describe th

Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings

2011-12-02 Thread Mark Brown
On Fri, Dec 02, 2011 at 02:32:59PM +0200, Peter Ujfalusi wrote: > As of now we receive all these information via OMAP hwmod. > All the properties (addresses, irq, etc) of the HW IP will be coming > from DT as soon as I can remove the ti,hwmod property. Oh, right. We should really be churning the

Re: [PATCH] irqdomain: protect macro variable in domain iterators

2011-12-02 Thread Dave Martin
On Fri, Dec 02, 2011 at 02:53:17PM +0100, Nicolas Ferre wrote: > Signed-off-by: Nicolas Ferre > --- > Error found while using those iterators in an irq controller > initialization function. > > May also need protection around irq and hwirq macro variables > but those values are usually plain "int

Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings

2011-12-02 Thread Cousson, Benoit
On 12/2/2011 1:25 PM, Mark Brown wrote: On Fri, Dec 02, 2011 at 11:52:56AM +0200, Peter Ujfalusi wrote: +Required properties: + - compatible : "ti,omap4-dmic" + - ti,hwmods : List of hwmod names associated with DMIC, in most case +it is "dmic". Shouldn't there also be a reg

Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings

2011-12-02 Thread Mark Brown
On Fri, Dec 02, 2011 at 11:52:56AM +0200, Peter Ujfalusi wrote: > +Required properties: > + - compatible : "ti,omap4-dmic" > + - ti,hwmods : List of hwmod names associated with DMIC, in most case > + it is "dmic". Shouldn't there also be a regs property giving the register window?

[PATCH] irqdomain: protect macro variable in domain iterators

2011-12-02 Thread Nicolas Ferre
Signed-off-by: Nicolas Ferre --- Error found while using those iterators in an irq controller initialization function. May also need protection around irq and hwirq macro variables but those values are usually plain "int" anyway... Tell me if you feel that it should be done. include/linux/irqdo

Re: Configurable interrupt sources, and DT bindings

2011-12-02 Thread Mark Brown
On Fri, Dec 02, 2011 at 04:38:14PM +1100, David Gibson wrote: > On Thu, Dec 01, 2011 at 11:07:39AM +, Mark Brown wrote: > > Right, but you could stuff those in an enormous array or whatever - the > > point was to describe the per interrupt information. > Well, ok, but that's not what you prop

Re: [PATCH v3 1/6] ASoC: WM8903: Disallow all invalid gpio_cfg pdata values

2011-12-02 Thread Mark Brown
On Thu, Dec 01, 2011 at 01:49:19PM -0700, Stephen Warren wrote: > The GPIO registers are 15 bits wide. Hence values, higher than 0x7fff are > not legal GPIO register values. Modify the pdata.gpio_cfg handling code > to reject all illegal values, not just WM8903_GPIO_NO_CONFIG (0x8000). This > will

Re: Pin control mappings for DT

2011-12-02 Thread Linus Walleij
On Thu, Dec 1, 2011 at 11:22 PM, Tony Lindgren wrote: > But how does the second pinmux driver instance know if it's OK > to add to the mapping or not? The mapping exists, but it might be > also from the previous time you loaded the pinmux driver.. The mappings are not added from pinmux drivers,

alias variable support

2011-12-02 Thread Kushwaha Prabhakar-B32579
Hi, Is there a way in dts to have alias for a variable just like we have alias for node. For example for a node "abc" alias_comp = "comp-2.0" abc@3100 { #address-cells = <1>; #size-cells = <0>;