Re: [PATCH] drivers/ata/pata_mpc52xx.c: add missing kfree

2012-03-11 Thread Sergei Shtylyov
Hello. On 10-03-2012 21:56, Julia Lawall wrote: From: Julia Lawalljulia.law...@lip6.fr There is no need to call the devm cleanup functions on failure of a probe or remove function. This doesn't correlate with the subject. Signed-off-by: Julia Lawalljulia.law...@lip6.fr WBR, Sergei

Re: [PATCH 03/11] regulator: fixed: Support driver probe deferral

2012-03-11 Thread Mark Brown
On Thu, Mar 08, 2012 at 03:51:23PM +0100, Thierry Reding wrote: If the specified GPIO is not found, return -EPROBE_DEFER. This will cause the driver to be probed again later when the required GPIO may have become available. Might be worth pushing this into gpiolib? It seems like wanting to

Re: [PATCH 1/4 v5] of_spi: add generic binding support to specify cs gpio

2012-03-11 Thread Grant Likely
On Fri, 9 Mar 2012 19:25:44 +0100, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: This will allow to use gpio for chip select with no modification in the driver binding When use the cs-gpios, the gpio number will be passed via the cs_gpio field and the number of chip select

[PATCH 2/2] ARM: kirkwood: Convert orion-nand to fdt

2012-03-11 Thread Jamie Lentin
The DNS-320 and 325 have a NAND partitioned to store uboot, uimage and root filesystem. Store this information in devicetree. Signed-off-by: Jamie Lentin j...@lentin.co.uk --- .../devicetree/bindings/mtd/orion-nand.txt | 41 +++ arch/arm/boot/dts/kirkwood-dns320.dts

[PATCH 1/2] ARM: kirkwood: Basic support for DNS-320 and DNS-325

2012-03-11 Thread Jamie Lentin
Add support for the DNS-320 and DNS-325. Describe as much as currently possible in the devicetree files, leave everything else in board-dt.c to be patched later. Signed-off-by: Jamie Lentin j...@lentin.co.uk --- arch/arm/boot/dts/kirkwood-dns320.dts | 54 ++

Re: [PATCH 1/2] ARM: kirkwood: Basic support for DNS-320 and DNS-325

2012-03-11 Thread Arnd Bergmann
On Sunday 11 March 2012, Jamie Lentin wrote: Add support for the DNS-320 and DNS-325. Describe as much as currently possible in the devicetree files, leave everything else in board-dt.c to be patched later. Signed-off-by: Jamie Lentin j...@lentin.co.uk Great work! + +/ { + model =

Re: [PATCH 2/2] ARM: kirkwood: Convert orion-nand to fdt

2012-03-11 Thread Arnd Bergmann
On Sunday 11 March 2012, Jamie Lentin wrote: The DNS-320 and 325 have a NAND partitioned to store uboot, uimage and root filesystem. Store this information in devicetree. All the important parts look good to me, just two small details: - board = pdev-dev.platform_data; + if

Re: [PATCH 1/4 v5] of_spi: add generic binding support to specify cs gpio

2012-03-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:07 Sun 11 Mar , Grant Likely wrote: On Fri, 9 Mar 2012 19:25:44 +0100, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: This will allow to use gpio for chip select with no modification in the driver binding When use the cs-gpios, the gpio number will be passed

[PATCH v3] drivers/ata/pata_mpc52xx.c: clean up error handling code

2012-03-11 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr This patch makes a number of changes with respect to the error-handling code: * Remove cleanup calls for the devm functions in both the error handling code and the remove function. This cleanup is done automatically. * The previous change simplifies

Re: [PATCH 0/2] Add support for DNS-320 and DNS-325 using devicetree

2012-03-11 Thread Jason Cooper
On Sun, Mar 11, 2012 at 02:33:24PM +, Jamie Lentin wrote: As agreed with Arnd Bergmann and Jason Cooper, include any board setup that cannot be done in devicetree in board-dt.c, then replace with devicetree entries. The NAND driver is converted to devicetree as part of this patch series,

Re: [PATCH 1/2] ARM: kirkwood: Basic support for DNS-320 and DNS-325

2012-03-11 Thread Jason Cooper
On Sun, Mar 11, 2012 at 02:33:25PM +, Jamie Lentin wrote: Add support for the DNS-320 and DNS-325. Describe as much as currently possible in the devicetree files, leave everything else in board-dt.c to be patched later. Signed-off-by: Jamie Lentin j...@lentin.co.uk Great work!

Re: [PATCH 1/2] ARM: kirkwood: Basic support for DNS-320 and DNS-325

2012-03-11 Thread Jason Cooper
On Sun, Mar 11, 2012 at 05:46:09PM +, Arnd Bergmann wrote: On Sunday 11 March 2012, Jamie Lentin wrote: Add support for the DNS-320 and DNS-325. Describe as much as currently possible in the devicetree files, leave everything else in board-dt.c to be patched later.

Re: [PATCH] dt: pinctrl: Document device tree binding

2012-03-11 Thread Randy Dunlap
On 03/09/2012 10:14 AM, Stephen Warren wrote: The core pin controller bindings define: * The fact that pin controllers expose pin configurations as nodes in device tree. * That the bindings for those pin configuration nodes is defined by the individual pin controller drivers. * A

Re: [PATCH 2/2] ARM: kirkwood: Convert orion-nand to fdt

2012-03-11 Thread Jason Cooper
On Sun, Mar 11, 2012 at 02:33:26PM +, Jamie Lentin wrote: The DNS-320 and 325 have a NAND partitioned to store uboot, uimage and root filesystem. Store this information in devicetree. Signed-off-by: Jamie Lentin j...@lentin.co.uk --- .../devicetree/bindings/mtd/orion-nand.txt |

Re: [PATCH 1/2] i2c-s3c2410: Rework device type handling

2012-03-11 Thread Thomas Abraham
On 9 March 2012 22:34, Karol Lewandowski k.lewando...@samsung.com wrote: Reorganize driver a bit to better handle device tree-based systems:  - move machine type to driver's private structure instead of   quering platform device variants in runtime  - replace s3c24xx_i2c_type enum with plain