Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-04-01 Thread Mark Brown
On Fri, Mar 30, 2012 at 06:45:07PM +, Arnd Bergmann wrote: > On Friday 30 March 2012, Stephen Warren wrote: > > > +- cd-inverted: when present, polarity on the wp gpio line is inverted > > > +- wp-inverted: when present, polarity on the wp gpio line is inverted > > I'm not sure about those tw

Re: [PATCH v5 04/16] pwm: Add table-based lookup for static mappings

2012-04-01 Thread Shawn Guo
On Sat, Mar 31, 2012 at 04:30:21PM +0200, Thierry Reding wrote: ... > The best solution that I could come up with is to not pass the index into the > of_pwm_request() function but rather forward the consumer name as passed into > pwm_get(). The of_pwm_request() could use the "pwm-names" property to

Re: [PATCH V2 6/6] pinctrl: tegra: Add complete device tree support

2012-04-01 Thread Linus Walleij
On Tue, Mar 20, 2012 at 6:44 PM, Stephen Warren wrote: > Implement pinctrl_ops dt_node_to_map() and dt_free_map(). These allow > complete specification of the desired pinmux configuration using device > tree. > > Signed-off-by: Stephen Warren > --- > v2: Rebase on of_property_for_each_string() A

Re: [PATCH v5 04/16] pwm: Add table-based lookup for static mappings

2012-04-01 Thread Shawn Guo
On Sun, Apr 01, 2012 at 11:20:46PM +0800, Shawn Guo wrote: > On Sat, Mar 31, 2012 at 04:30:21PM +0200, Thierry Reding wrote: ... > > The "bad" > > thing is that it'll make the "pwm-names" property mandatory if more than a > > single PWM is requested. > > > You do not have to make it mandatory, but

Re: [PATCH V4 Resend 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap()

2012-04-01 Thread Viresh Kumar
On 3/31/2012 12:15 AM, Stephen Warren wrote: >> > diff --git a/drivers/input/keyboard/tegra-kbc.c >> > b/drivers/input/keyboard/tegra-kbc.c > ... >> > #else >> > -static inline struct tegra_kbc_platform_data *tegra_kbc_dt_parse_pdata( >> > - struct platform_device *pdev) >> > +static struct tegr

[PATCH] fixup! Input: of_keymap: Introduce matrix_keypad_of_build_keymap()

2012-04-01 Thread Viresh Kumar
Hi Dmitry, This is an incremental patch over patch "Input: of_keymap: Introduce matrix_keypad_of_build_keymap()" sent earlier by me. Please squash it to that patch while applying. This contains last few changes suggested by Stephen on V4 of this patch. --- drivers/input/keyboard/tegra-kbc.c |

Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead

2012-04-01 Thread Benjamin Herrenschmidt
On Sun, 2012-04-01 at 23:27 +0200, Andreas Schwab wrote: > Grant Likely writes: > > > This patch drops the powerpc-specific irq_map table and replaces it with > > directly using the irq_alloc_desc()/irq_free_desc() interfaces for > > allocating > > and freeing irq_desc structures. > > This brea

Re: [PATCH v5 04/16] pwm: Add table-based lookup for static mappings

2012-04-01 Thread Thierry Reding
* Shawn Guo wrote: > On Sun, Apr 01, 2012 at 11:20:46PM +0800, Shawn Guo wrote: > > On Sat, Mar 31, 2012 at 04:30:21PM +0200, Thierry Reding wrote: > ... > > > The "bad" > > > thing is that it'll make the "pwm-names" property mandatory if more than a > > > single PWM is requested. > > > > > You do

Re: [PATCH V3 5/6] dt: Document Tegra20/30 pinctrl binding

2012-04-01 Thread Simon Glass
Hi Stephen, On Thu, Mar 22, 2012 at 11:27 AM, Stephen Warren wrote: > Define a new binding for the Tegra pin controller, which is capable of > defining all aspects of desired pin multiplexing and pin configuration. > This is all based on the new common pinctrl bindings. > > Add Tegra30 binding ba