Re: [RFC v2 3/5] i2c: Add of_i2c_get_adapter() function

2012-04-25 Thread Thierry Reding
* Stephen Warren wrote: > On 04/25/2012 03:45 AM, Thierry Reding wrote: > > This function resolves an OF device node to an I2C adapter registered > > with the I2C core. > > I think this is doing the same thing as a patch I posted recently: > http://www.spinics.net/lists/linux-i2c/msg07808.html I

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-25 Thread Stephen Warren
On 04/25/2012 06:15 AM, Arnd Bergmann wrote: > On Wednesday 25 April 2012, Felipe Balbi wrote: ... >>> Can this driver be located under "drivers/misc"? Or is there any better >>> place? >> >> maybe drivers/platform/arm/ ?? > > I really wouldn't want to add that directory: It has the risk of letti

Re: [PATCHv4 1/2] drivers: input: keypad: Add device tree support

2012-04-25 Thread Stephen Warren
On 04/25/2012 03:26 AM, Sourav Poddar wrote: > Update the Documentation with omap4 keypad device tree > binding information. > Add device tree support for omap4 keypad driver. > diff --git a/Documentation/devicetree/bindings/input/omap-keypad.txt > b/Documentation/devicetree/bindings/input/omap-k

Re: [RFC v2 3/5] i2c: Add of_i2c_get_adapter() function

2012-04-25 Thread Stephen Warren
On 04/25/2012 03:45 AM, Thierry Reding wrote: > This function resolves an OF device node to an I2C adapter registered > with the I2C core. I think this is doing the same thing as a patch I posted recently: http://www.spinics.net/lists/linux-i2c/msg07808.html What's the advantage of one way over t

[PATCH] I2C: xiic: Add OF binding support

2012-04-25 Thread Lars-Peter Clausen
Signed-off-by: Lars-Peter Clausen --- Documentation/devicetree/bindings/i2c/xiic.txt | 22 ++ drivers/i2c/busses/i2c-xiic.c | 23 ++- 2 files changed, 40 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/binding

Re: [RFC v2 0/5] Add NVIDIA Tegra DRM support

2012-04-25 Thread Thierry Reding
* Thierry Reding wrote: > This series adds a basic DRM driver for NVIDIA Tegra 2 processors. It > currently only supports the RGB output and I've successfully tested it > against the fbcon kernel module and the xf86-video-modesetting driver. > The code uses the Tegra's IOMMU/GART to remap non-conti

Re: dtc symbolic constants - not in the preprocessor?

2012-04-25 Thread David Gibson
On Tue, Apr 24, 2012 at 09:22:34PM -0600, Stephen Warren wrote: > On 04/19/2012 06:11 AM, David Gibson wrote: > > On Tue, Apr 17, 2012 at 08:44:23PM -0600, Stephen Warren wrote: > >> So, David has been leaning towards a simple text-based preprocessor as > >> the means to add symbolic constants to d

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-25 Thread Arnd Bergmann
On Wednesday 25 April 2012, Felipe Balbi wrote: > On Wed, Apr 25, 2012 at 08:37:47AM +0300, Hiroshi Doyu wrote: > > On Tue, 24 Apr 2012 21:56:45 +0200 > > Russell King - ARM Linux wrote: > > > > > On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote: > > > > The AHB Bus conforms to the

Re: [PATCHv4 1/2] drivers: input: keypad: Add device tree support

2012-04-25 Thread Roland Stigge
Hi! On 04/25/2012 01:56 PM, Poddar, Sourav wrote: > Even I was using the bindings as used by samsung-keypad driver. But according > to the comments and logically too, we should use the common matrix keyboard > bindings already descibed in > Documentation/devicetree/bindings/input/matrix-keymap.txt

Re: [PATCH 1/2] i2c-s3c2410: Rework device type handling

2012-04-25 Thread Karol Lewandowski
On 24.04.2012 16:44, Wolfram Sang wrote: > On Tue, Apr 24, 2012 at 10:40:49AM +0200, Karol Lewandowski wrote: >> On 23.04.2012 20:20, Wolfram Sang wrote: + if (pdev->dev.of_node) { + const struct of_device_id *match; + match = of_match_node(&s3c24xx_i2c_match, p

Re: [PATCH v2 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver

2012-04-25 Thread Dong Aisheng
On Fri, Apr 20, 2012 at 10:58:34PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > The driver has mux and config support while the gpio is still > not supported. > For select input setting, the driver will handle it internally > and do not need user to take care of it. > > The pinctrl-imx co

Re: [PATCHv4 1/2] drivers: input: keypad: Add device tree support

2012-04-25 Thread Roland Stigge
Hi Russell and Sourav, On 04/25/2012 12:52 PM, Russell King - ARM Linux wrote: > I think you and Roland Stigge need to put your heads together and come > up with a common DT binding for matrix keypad devices, rather than > inventing N different platform specific bindings. > >> +Required Board Spe

Re: [RFC] pinctrl: enhance reporting of errors when loading from DT

2012-04-25 Thread John Crispin
Hi Stephen, > This seems a little muddled. Why not: > > s = pinctrl_lookup_state_locked(...); > if (IS_ERR(s)) > dev_dbg(...); > } else { > ret = pinctrl_select_state_locked(...); > if (ret) { > dev_err(...); > } > } > ok > Note that pinctrl_lookup_state_locked() failing i

Re: [PATCHv3 1/4] ARM: tegra: Add AHB driver

2012-04-25 Thread Felipe Balbi
On Wed, Apr 25, 2012 at 02:07:36PM +0300, Hiroshi DOYU wrote: > The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced > High-performance Bus (AHB) architecture. > > The AHB Arbiter controls AHB bus master arbitration. This effectively > forms a second level of arbitration for access to

Re: [RFC] pinctrl: enhance reporting of errors when loading from DT

2012-04-25 Thread John Crispin
Hi Linus >> There are a few places tagged with //FIXME. > No C99 comments. See Documentation/CodingStyle. the //FIXME bits are as described below the tear line only there to show which places I checked. they obviously will be removed in the final patch > So if you're gonna keep them, > /* use pla

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
* Mark Brown wrote: > On Wed, Apr 25, 2012 at 12:41:47PM +0200, Thierry Reding wrote: > > > After taking a closer look I don't think Rhyland's patch is very useful for > > this driver. I need to lookup the platform ID by regulator name anyway so > > using the new code is actually more work and req

Re: [RFC] pinctrl: enhance reporting of errors when loading from DT

2012-04-25 Thread Linus Walleij
On Tue, Apr 24, 2012 at 6:53 PM, John Crispin wrote: > There are a few places tagged with //FIXME. No C99 comments. See Documentation/CodingStyle. So if you're gonna keep them, /* use plain C comments */ And follow up on Stephens comments... Yours, Linus Walleij __

Re: [PATCH V2] i2c: Add generic I2C multiplexer using pinctrl API

2012-04-25 Thread Linus Walleij
On Tue, Apr 24, 2012 at 11:02 PM, Stephen Warren wrote: > On 04/24/2012 02:09 PM, Wolfram Sang wrote: >> >> From what I know, compatible-properties should not be linux-specific >> since devicetrees are OS independent. pinctrl-i2cmux sounds >> linux-specific to me. >> >> So, is such a binding accep

Re: [PATCHv4 1/2] drivers: input: keypad: Add device tree support

2012-04-25 Thread Russell King - ARM Linux
I think you and Roland Stigge need to put your heads together and come up with a common DT binding for matrix keypad devices, rather than inventing N different platform specific bindings. On Wed, Apr 25, 2012 at 02:56:43PM +0530, Sourav Poddar wrote: > Update the Documentation with omap4 keypad de

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Mark Brown
On Wed, Apr 25, 2012 at 12:41:47PM +0200, Thierry Reding wrote: > After taking a closer look I don't think Rhyland's patch is very useful for > this driver. I need to lookup the platform ID by regulator name anyway so > using the new code is actually more work and requires a second table that > li

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
* Thierry Reding wrote: > * Mark Brown wrote: > > On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > > > This commit adds device tree support for the TPS6586x regulator. > > > > > > Signed-off-by: Thierry Reding > > > > This looks basically good from a quick scan through but the p

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-25 Thread Russell King - ARM Linux
On Wed, Apr 25, 2012 at 02:31:27PM +0530, Laxman Dewangan wrote: > Hi Vinod, > > On Monday 23 April 2012 06:47 PM, Laxman Dewangan wrote: >> On Monday 23 April 2012 06:36 PM, Russell King - ARM Linux wrote: >>> On Mon, Apr 23, 2012 at 05:47:03PM +0530, Laxman Dewangan wrote: Hi Russell, O

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
* Mark Brown wrote: > On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > > This commit adds device tree support for the TPS6586x regulator. > > > > Signed-off-by: Thierry Reding > > This looks basically good from a quick scan through but the pattern of > looking up regulator nodes

Re: [RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Mark Brown
On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > This commit adds device tree support for the TPS6586x regulator. > > Signed-off-by: Thierry Reding This looks basically good from a quick scan through but the pattern of looking up regulator nodes by name is very common so should

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-25 Thread Vinod Koul
On Wed, 2012-04-25 at 15:12 +0530, Laxman Dewangan wrote: > On Wednesday 25 April 2012 03:03 PM, Vinod Koul wrote: > > On Wed, 2012-04-25 at 14:31 +0530, Laxman Dewangan wrote: > >> I had a communication with Russell on another change thread and > >> understand that some more work need to be done

[RFC v2 4/5] drm: fixed: Add dfixed_frac

2012-04-25 Thread Thierry Reding
From: Robert Morell This helper macro retrieves the fractional part of a fixed20_12 20.12 fixed-point number. Signed-off-by: Robert Morell Signed-off-by: Olof Johansson Signed-off-by: Thierry Reding --- include/drm/drm_fixed.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/dr

[RFC v2 3/5] i2c: Add of_i2c_get_adapter() function

2012-04-25 Thread Thierry Reding
This function resolves an OF device node to an I2C adapter registered with the I2C core. Signed-off-by: Thierry Reding --- drivers/i2c/i2c-core.c | 34 ++ include/linux/of_i2c.h |7 +++ 2 files changed, 41 insertions(+) diff --git a/drivers/i2c/i2c-core

[RFC v2 0/5] Add NVIDIA Tegra DRM support

2012-04-25 Thread Thierry Reding
This series adds a basic DRM driver for NVIDIA Tegra 2 processors. It currently only supports the RGB output and I've successfully tested it against the fbcon kernel module and the xf86-video-modesetting driver. The code uses the Tegra's IOMMU/GART to remap non-contiguous memory. This means that cu

[RFC v2 1/5] iommu: Include linux/types.h

2012-04-25 Thread Thierry Reding
The linux/iommu.h header uses types defined in linux/types.h but doesn't include it. Signed-off-by: Thierry Reding --- include/linux/iommu.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index d937580..2b2fcdb 100644 --- a/include/linux/iomm

[RFC v2 2/5] tps6586x: Add device tree support

2012-04-25 Thread Thierry Reding
This commit adds device tree support for the TPS6586x regulator. Signed-off-by: Thierry Reding --- .../devicetree/bindings/regulator/tps6586x.txt | 97 ++ drivers/mfd/tps6586x.c | 105 drivers/regulator/tps6586x-regulator.c

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-25 Thread Vinod Koul
On Wed, 2012-04-25 at 14:31 +0530, Laxman Dewangan wrote: > > I had a communication with Russell on another change thread and > understand that some more work need to be done in virt_chan to support > cyclic one. > > I want to have the cyclic dma support in my driver so I want to go on > foll

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-25 Thread Felipe Balbi
On Wed, Apr 25, 2012 at 08:37:47AM +0300, Hiroshi Doyu wrote: > On Tue, 24 Apr 2012 21:56:45 +0200 > Russell King - ARM Linux wrote: > > > On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote: > > > The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced > > > High-performance B

Re: [PATCH v2 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver

2012-04-25 Thread Richard Zhao
Where' SION settings? Thanks Richard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss