Re: [PATCH 19/20] ARM: Exynos5: Add combiner, wakeup interrupt controller and ethernet nodes

2012-05-18 Thread Olof Johansson
On Fri, May 18, 2012 at 11:11 PM, Grant Likely wrote: > On Wed, 2 May 2012 10:57:11 -0700, Olof Johansson wrote: >> Hi, >> >> [adding devicetree-discuss] >> >> On Mon, Apr 30, 2012 at 12:14 PM, Thomas Abraham >> wrote: >> > And interrupt combiner, external interrupt wakeup interrupt controller >

Re: [PATCH v3 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller

2012-05-18 Thread Grant Likely
On Mon, 5 Mar 2012 12:09:58 +0100, Heiko Schocher wrote: > Add a function to initialize the Common Platform Interrupt Controller > (cp_intc) from TI used on OMAP-L1x SoCs using a device tree node. > > Signed-off-by: Heiko Schocher > Cc: davinci-linux-open-sou...@linux.davincidsp.com > Cc: linux

Re: [PATCH 19/20] ARM: Exynos5: Add combiner, wakeup interrupt controller and ethernet nodes

2012-05-18 Thread Grant Likely
On Wed, 2 May 2012 10:57:11 -0700, Olof Johansson wrote: > Hi, > > [adding devicetree-discuss] > > On Mon, Apr 30, 2012 at 12:14 PM, Thomas Abraham > wrote: > > And interrupt combiner, external interrupt wakeup interrupt controller > > and smsc9215 lan controller nodes. > > > > Signed-off-by: T

Re: [PATCH v2 5/5] MIPS: Octeon: Use device tree to register serial ports.

2012-05-18 Thread Grant Likely
On Thu, 26 Apr 2012 18:20:30 -0700, David Daney wrote: > From: David Daney > > Switch to using the device tree to register serial ports. > > Add all the ports with compatible = "cavium,octeon-3860-uart". Octeon serial > ports have their own device type, required port flags, and I/O > functions

Re: [PATCH v2 4/5] staging: octeon_ethernet: Convert to use device tree.

2012-05-18 Thread Grant Likely
On Thu, 26 Apr 2012 18:20:29 -0700, David Daney wrote: > From: David Daney > > Get MAC address and PHY connection from the device tree. The driver > is converted to a platform driver. > > Acked-by: Greg Kroah-Hartman > Signed-off-by: David Daney > Cc: net...@vger.kernel.org > Cc: Greg Kroah-

Re: [PATCH v2 2/5] netdev: mdio-octeon.c: Convert to use device tree.

2012-05-18 Thread Grant Likely
On Thu, 26 Apr 2012 18:20:27 -0700, David Daney wrote: > From: David Daney > > Get the MDIO bus controller addresses from the device tree, small > clean up in use of devm_* > > Remove, now unused, platform device setup code. Ditto on this one (and the others); make sure the new compatible valu

Re: [PATCH v2 1/5] i2c: Convert i2c-octeon.c to use device tree.

2012-05-18 Thread Grant Likely
On Thu, 26 Apr 2012 18:20:26 -0700, David Daney wrote: > From: David Daney > > There are three parts to this: > > 1) Remove the definitions of OCTEON_IRQ_TWSI and OCTEON_IRQ_TWSI2. >The interrupts are specified by the device tree and these hard >coded irq numbers block the used of the i

Re: [PATCH v8 2/4] MIPS: Octeon: Setup irq_domains for interrupts.

2012-05-18 Thread Grant Likely
On Thu, 26 Apr 2012 17:47:56 -0700, David Daney wrote: > From: David Daney > > Create two domains. One for the GPIO lines, and the other for on-chip > sources. > > Signed-off-by: David Daney Acked-by: Grant Likely but I've got some comments below that should probably be addressed in follow

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

2012-05-18 Thread David Daney
On 05/18/2012 03:09 PM, Timur Tabi wrote: David Daney wrote: I'm not sure what the "parent" MDIO bus node is supposed to represent. Is that that device that actually controls the muxing hardware No. It is the device that implements the master 802.3 clause {22,45} MDIO Station Management (

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-18 Thread Stephen Warren
On 05/18/2012 03:43 PM, Arnd Bergmann wrote: > On Friday 18 May 2012, Stephen Warren wrote: >>> The driver can still request the dma line by name "tx" and the subsystem >>> would pick one out of those with the same name. >>> >>> For the majority of cases, we would only need a single dma request lin

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

2012-05-18 Thread Timur Tabi
David Daney wrote: >> > I'm not sure what the "parent" MDIO bus node is supposed to represent. >> > Is that that device that actually controls the muxing hardware > No. It is the device that implements the master 802.3 clause {22,45} > MDIO Station Management (STA) protocol. Ah, I think I get

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

2012-05-18 Thread David Daney
On 05/18/2012 02:42 PM, Tabi Timur-B04825 wrote: On Wed, May 2, 2012 at 8:16 PM, David Daney wrote: From: David Daney This code has been working well for about six months on a couple of different configurations (boards), so I thought it would be a good time to send it out again, and I hope get

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-18 Thread Arnd Bergmann
On Friday 18 May 2012, Stephen Warren wrote: > > The driver can still request the dma line by name "tx" and the subsystem > > would pick one out of those with the same name. > > > > For the majority of cases, we would only need a single dma request line > > Hmm. Many devices have multiple differe

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

2012-05-18 Thread Tabi Timur-B04825
On Wed, May 2, 2012 at 8:16 PM, David Daney wrote: > From: David Daney > > This code has been working well for about six months on a couple of > different configurations (boards), so I thought it would be a good > time to send it out again, and I hope get it on the path towards > merging. David,

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-18 Thread Stephen Warren
On 05/18/2012 02:49 PM, Arnd Bergmann wrote: > On Wednesday 16 May 2012, Stephen Warren wrote: >> Simple case: >> >> /* e.g. FIFO TX DMA req - 2 DMACs possible */ >> dma-req-0 = <&dmac1 DMAC1_DMA_REQ_6>; >> /* e.g. FIFO RX DMA req 1 DMAC possible */ >> dma-req-1 = <&dmac1 DMAC1_DMA_REQ_8>; >> >> Mu

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-18 Thread Arnd Bergmann
On Wednesday 16 May 2012, Jassi Brar wrote: > On 17 May 2012 01:12, Arnd Bergmann wrote: > > > I'm still anything but convinced by this model. Basically it's the > > exact opposite of what we do for every other subsystem (irq, pinctrl, > > regulator, gpio, ...), where the device using some infras

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-18 Thread Arnd Bergmann
On Wednesday 16 May 2012, Stephen Warren wrote: > Simple case: > > /* e.g. FIFO TX DMA req - 2 DMACs possible */ > dma-req-0 = <&dmac1 DMAC1_DMA_REQ_6>; > /* e.g. FIFO RX DMA req 1 DMAC possible */ > dma-req-1 = <&dmac1 DMAC1_DMA_REQ_8>; > > Multiple DMAC case: > > /* e.g. FIFO TX DMA req - 2 DM

[PATCH V4] i2c: Add generic I2C multiplexer using pinctrl API

2012-05-18 Thread Stephen Warren
From: Stephen Warren This is useful for SoCs whose I2C module's signals can be routed to different sets of pins at run-time, using the pinctrl API. +-+ +-+ | dev | | dev | ++ +-+ +-

Re: [PATCH 1/1] iommu/tegra: smmu: Add DMA window parser

2012-05-18 Thread Stephen Warren
On 05/18/2012 12:43 AM, Hiroshi DOYU wrote: > This code was based on: > "arch/microblaze/kernel/prom_parse.c" > "arch/powerpc/kernel/prom_parse.c" > > Can be promoted as a global function for general use. > > Signed-off-by: Hiroshi DOYU Hiroshi, Once this is accepted, it might be worth

Re: [PATCH] of: add const to struct of_device_id.data

2012-05-18 Thread Uwe Kleine-König
__ > - void*data; > + const void *data; > #else > kernel_ulong_t data; > #endif any thoughts on this one? I got no feed back and it doesn't appear in next-20120518. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH] of: fix a few typos in the binding documentation

2012-05-18 Thread Uwe Kleine-König
evicetree/bindings/mtd/partition.txt > index f114ce1..6e1f61f 100644 > --- a/Documentation/devicetree/bindings/mtd/partition.txt > +++ b/Documentation/devicetree/bindings/mtd/partition.txt > @@ -35,4 +35,4 @@ flash@0 { > uimage@10 { > reg = <0x010 0x20

[PATCH v2 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-18 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a

[PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-18 Thread Thomas Abraham
With the spi controller hardware configuration moved into the driver data, there are no more default hardware configuration data that is passed through platform data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to these changes. Signed-off-by: Thomas Abraham Acked-by: J

[PATCH v2 3/6] ARM: Samsung: Remove pdev pointer paremeter from spi gpio setup functions

2012-05-18 Thread Thomas Abraham
The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this paremeter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/setup-spi.c |8 +++- arch/arm/ma

[PATCH v2 6/6] spi: s3c64xx: add device tree support

2012-05-18 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 277 +--- 2 files changed, 358 insertions(+), 32 deletion

[PATCH v2 2/6] spi: s3c64xx: move controller information into driver data

2012-05-18 Thread Thomas Abraham
Platform data is used to specify controller hardware specific information such as the tx/rx fifo level mask and bit offset of rx fifo level. Such information is not suitable to be supplied from device tree. Instead, it can be moved into the driver data and removed from platform data. Signed-off-by

[PATCH v2 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-05-18 Thread Thomas Abraham
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 972

[PATCH v2 0/6] spi: s3c64xx: add support for device tree

2012-05-18 Thread Thomas Abraham
Changes since v1: - Incorporated changes suggested by Mark Brown - Merged 2nd, 3rd and 5th patch into one single patch. - Listed the order of gpios in the device tree support documentation. - Switched to generic property names for chip select gpio line and number of slave select lines. -

Re: [PATCH RESEND v3 1/2] input: keyboard: Add keys driver for the LPC32xx SoC

2012-05-18 Thread Roland Stigge
Hi Dmitry! thanks for your suggestions, will include them into the next patch update. On 05/17/2012 07:38 PM, Dmitry Torokhov wrote: >> +of_property_read_u32(np, "keypad,num-rows", &rows); >> +of_property_read_u32(np, "keypad,num-columns", &columns); >> +if (!rows || rows != columns)

Re: [PATCH RESEND v9 1/2] gpio: Adjust of_xlate API to support multiple GPIO chips

2012-05-18 Thread Roland Stigge
Hi Grant, On 05/17/2012 10:37 PM, Grant Likely wrote: > On Wed, 16 May 2012 22:40:31 +0200, Roland Stigge wrote: >> This patch changes the of_xlate API to make it possible to manipulate the >> actual used gc. This way, multiple GPIO banks can be supported with the same >> DT >> registered GPIO c

Re: [PATCH v2 3/6] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-05-18 Thread Russell King - ARM Linux
On Thu, May 17, 2012 at 08:40:08PM +0530, Thomas Abraham wrote: > +err_clk: > + if (!IS_ERR(host->ciu_clk)) > + clk_disable_unprepare(host->ciu_clk); > + if (!IS_ERR(host->biu_clk)) > + clk_disable_unprepare(host->biu_clk); > + clk_put(host->ciu_clk); > + clk