Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-19 Thread Arnd Bergmann
On Friday 18 May 2012, Stephen Warren wrote: > On 05/18/2012 03:43 PM, Arnd Bergmann wrote: > > So if we do that, we might want to make the dma-names property mandatory > > for every device, and document what the names are. > > We could do that, but one more proposal: Add the client's ID/index in

Re: [PATCH V2] regulator: dt: fix the name of regulator supply

2012-05-19 Thread Mark Brown
On Sat, May 19, 2012 at 01:04:12AM +0530, Laxman Dewangan wrote: > If there is any input supply for regulator then the name > of supply need to provided by init_data->supply_regulator. > In dt case, the input supply is searched by the -supply > and here it is require to fix the name so that correct

Re: [PATCH V2] regulator: dt: fix the name of regulator supply

2012-05-19 Thread Mark Brown
On Sat, May 19, 2012 at 06:08:28PM +0530, Laxman Dewangan wrote: > The descriptor is set on the regulator driver and hence it need to > be parse this in the regulator driver. > We need to set the name regulator_desc->supply_name and hence it > needs to be in dt binding documentation of that device

Re: [PATCH v3 0/4] MFD: twl6040: Device tree support

2012-05-19 Thread Samuel Ortiz
Hi Peter, On Wed, May 16, 2012 at 02:11:54PM +0300, Peter Ujfalusi wrote: > Hello, > > Changes since v2: > - Child devices are no longer described in dts, they are created with > mfd_add_devices() > - ASoC codec device is created unconditionally (main function of twl6040) > > Changes since v1:

Re: [PATCH REPOST] dt: add vendor prefix for EM Microelectronics

2012-05-19 Thread Grant Likely
On Thu, 17 May 2012 15:18:31 -0600, Stephen Warren wrote: > From: Stephen Warren > > Add "emmicro" as the prefix for EM Microelectronics. A web search implies > this is a pretty unique and relevant match. > > Signed-off-by: Stephen Warren Merged, thanks g. > --- > .../devicetree/bindings/v

Re: [PATCH RESEND] Documentation: devicetree: Fix value format description

2012-05-19 Thread Grant Likely
On Wed, 16 May 2012 22:33:55 +0200, Roland Stigge wrote: > Numeric values in dts files can be specified in decimal and hex (the latter > prefixed 0x). The current documentation is updated with this patch to prevent > confusion about what is meant with values without "0x" (previously hex, now > dec

Re: [PATCH 01/10] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-05-19 Thread Grant Likely
On Wed, 09 May 2012 03:34:45 +0530, Thomas Abraham wrote: > The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. > > Cc: Jaswinder Singh > Signed-off-by: Thomas Abraham Acked-by: Grant Likely Since this series has dependencies, I'm fine with it going via another tree. g.

Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-19 Thread Grant Likely
On Wed, 09 May 2012 03:34:46 +0530, Thomas Abraham wrote: > Platform data is used to specify controller hardware specific information > such as the tx/rx fifo level mask and bit offset of rx fifo level. Such > information is not suitable to be supplied from device tree. Instead, > it can be moved

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-19 Thread Grant Likely
On Sun, 13 May 2012 15:51:35 +0100, Mark Brown wrote: > On Thu, May 10, 2012 at 01:17:32AM +0800, Thomas Abraham wrote: > > On 9 May 2012 22:28, Mark Brown wrote: > > > > This means that bisection will be broken - anything with only one tree > > > won't be able to load the SPI driver successful

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-19 Thread Grant Likely
On Wed, 09 May 2012 03:34:51 +0530, Thomas Abraham wrote: > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the slave

Re: [PATCH v2 0/6] spi: s3c64xx: add support for device tree

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:27 +0530, Thomas Abraham wrote: > Changes since v1: Heh, I really should look further down my inbox before I start replying to old patches. I'll recheck this version of the changes, but I'm still happy for this stuff to go via arm-soc or whatever branch makes the most

Re: [PATCH v2 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:28 +0530, Thomas Abraham wrote: > The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely > --- > drivers/spi/spi-s3c64xx.c |4 > 1 files changed, 0 inserti

Re: [PATCH v2 2/6] spi: s3c64xx: move controller information into driver data

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:29 +0530, Thomas Abraham wrote: > Platform data is used to specify controller hardware specific information > such as the tx/rx fifo level mask and bit offset of rx fifo level. Such > information is not suitable to be supplied from device tree. Instead, > it can be moved

Re: [PATCH v2 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:32 +0530, Thomas Abraham wrote: > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the slave

Re: [PATCH v2 6/6] spi: s3c64xx: add device tree support

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham wrote: > Add support for device based discovery. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely ... but one nitpick below... > +#ifdef CONFIG_OF > +static const struct of_device_id s3c64xx_spi_dt_match

Re: [PATCH 1/2] MIPS: OCTEON: Add register definitions for SPI host hardware.

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 14:34:45 -0700, David Daney wrote: > From: David Daney > > Needed by SPI driver. > > Signed-off-by: David Daney > --- > arch/mips/include/asm/octeon/cvmx-mpi-defs.h | 328 > ++ > 1 files changed, 328 insertions(+), 0 deletions(-) > create mode 10

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

2012-05-19 Thread Grant Likely
On Mon, 14 May 2012 11:13:41 -0700, David Daney wrote: > On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote: > > Hi David, > > A few comments. > > > > On Sat, May 12, 2012 at 3:04 AM, David Daney wrote: > [...] > > >> + > >> +#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */ > >

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 14:34:46 -0700, David Daney wrote: > From: David Daney > > Add the driver, link it into the kbuild system and provide device tree > binding documentation. > > Signed-off-by: David Daney Some comments below, but you can add my a-b: Acked-by: Grant Likely > +#include > +

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > From: David Daney > > When generating MODALIASes, it is convenient to add things like "spi:" > or "i2c:" to the front of the strings. This allows the standard > modprobe to find the right driver when automatically populating bus > childre

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

2012-05-19 Thread Grant Likely
On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: > On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > > From: David Daney > > > > When generating MODALIASes, it is convenient to add things like "spi:" > > or "i2c:" to the front of the strings. This allows the standard > > modprob

Re: [PATCH 3/3] eeprom/of: Add device tree bindings to at25.

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 15:05:23 -0700, David Daney wrote: > From: David Daney > > We can extract the "pagesize", "size" and "address-width" from the > device tree so that SPI eeproms can be fully specified in the device > tree. > > Also add a MODULE_DEVICE_TABLE so the drivers can be automatically