Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment

2012-06-11 Thread Fabio Estevam
Hi Sascha, On Mon, Jun 11, 2012 at 3:50 AM, Sascha Hauer wrote: > Traditionally I started counting at 0 no matter what the datasheet told. > Now we go to match the numbering with the datasheets, which of course > can be confusing while transitioning this. > Fabios patch is correct, there is no g

Re: [PATCH] devicetree: bindings: gpio-i2c belongs to i2c not gpio

2012-06-11 Thread Rob Herring
On 06/11/2012 07:26 AM, Wolfram Sang wrote: > On Fri, Apr 20, 2012 at 05:08:02PM +0200, Wolfram Sang wrote: >> gpio-i2c describes an I2C controller (using gpios for data and clock), >> so it must be described in i2c, not gpio. >> >> Signed-off-by: Wolfram Sang >> --- >> .../{gpio/gpio_i2c.txt =>

Re: [PATCH 1/9] ARM: Kirkwood: Add interrupt controller support for DT boards

2012-06-11 Thread Rob Herring
On 06/10/2012 05:31 AM, Andrew Lunn wrote: > Signed-off-by: Andrew Lunn > --- > .../devicetree/bindings/arm/mrvl/intc.txt | 20 ++ > arch/arm/boot/dts/kirkwood.dtsi|9 > arch/arm/mach-kirkwood/board-dt.c | 22 > ++

Configure standalone GPIO in device tree?

2012-06-11 Thread Subodh Nijsure
Hello, I am working with a hardware that has couple of GPIOs that are not tied to any specific device one to indicate board status, other to indicate presence of this hardware to some other 'independent' hardware. I have been going through some of the device tree files and I haven't come acr

[PATCH] pinctrl: Add one-register-per-pin type device tree based pinctrl driver

2012-06-11 Thread Tony Lindgren
Add one-register-per-pin type device tree based pinctrl driver. Currently this driver only works on omap2+ series of processors, where there is either an 8 or 16-bit padconf register for each pin. Support for other similar pinmux controllers can be added. Signed-off-by: Tony Lindgren --- Here'

Re: [PATCH 2/2] gpio: Add Avionic Design N-bit GPIO expander support

2012-06-11 Thread Arnd Bergmann
On Thursday 07 June 2012, Thierry Reding wrote: > > Unless you have an actual user of platform_data, don't borrow > > trouble by adding it. > > If I make the driver DT-only I should probably add a "select OF" to it's > Kconfig entry, right? Or should it rather be "depends on OF"? "depends on OF".

Re: Configure standalone GPIO in device tree?

2012-06-11 Thread Rob Herring
On 06/11/2012 08:56 AM, Subodh Nijsure wrote: > Hello, > > I am working with a hardware that has couple of GPIOs that are not tied > to any specific device one to indicate board status, other to indicate > presence of this hardware to some other 'independent' hardware. > > I have been going throu

Re: [PATCH] dt: fsl-imx-cspi.txt: Fix comment about GPIOs used for chip selects

2012-06-11 Thread Rob Herring
On 04/21/2012 12:21 PM, Fabio Estevam wrote: > The gpio numbers does not match the comment. > > Fix the comments for GPIOs used for chip selects. > > Signed-off-by: Fabio Estevam Applied. > --- > .../devicetree/bindings/spi/fsl-imx-cspi.txt |4 ++-- > 1 files changed, 2 insertions(

Re: [PATCH 1/4] dt: fsl-imx-esdhc.txt: Fix gpio number assignment

2012-06-11 Thread Rob Herring
On 06/11/2012 01:50 AM, Sascha Hauer wrote: > On Sun, Jun 10, 2012 at 11:11:13PM -0500, Rob Herring wrote: >> On 06/10/2012 09:03 PM, Fabio Estevam wrote: >>> On Sun, Jun 10, 2012 at 8:11 PM, Rob Herring wrote: On 06/10/2012 12:24 PM, Fabio Estevam wrote: > From: Fabio Estevam >

Re: [PATCH] of: export of_platform_populate()

2012-06-11 Thread Rob Herring
On 06/07/2012 06:57 PM, Stephen Warren wrote: > From: Stephen Warren > > Without this, modules can't use this API, leading to build failures. > > Signed-off-by: Stephen Warren > --- Applied for 3.5. Rob > This is useful in 3.5. > > drivers/of/platform.c |1 + > 1 files changed, 1 inser

Re: Overriding/concatenating kernel command-line with bootargs from dtb?

2012-06-11 Thread Rob Herring
On 06/08/2012 02:55 AM, Florian Fainelli wrote: > Hi all, > > I have a specific use case, where two boards using the same SoC have > different > UART speeds, which is something that I have specified in their corresponding > dts files. In order to make sure people don't mess up the configuration

[PATCH v2 01/10] PCI: Keep pci_fixup_irqs() around after init

2012-06-11 Thread Thierry Reding
Signed-off-by: Thierry Reding --- Changes in v2: - use __devinit annotations drivers/pci/setup-irq.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c index eb219a1..f0bcd56 100644 --- a/drivers/pci/setup-irq.c +++ b/driv

[PATCH v2 06/10] ARM: tegra: pcie: Add MSI support

2012-06-11 Thread Thierry Reding
This commit adds support for message signaled interrupts to the Tegra PCIe controller. Based on code by Krishna Kishore . Signed-off-by: Thierry Reding --- Changes in v2: - improve compile coverage by using the IS_ENABLED() macro - move MSI-related fields to a separate structure - free pages use

[PATCH v2 04/10] ARM: tegra: Move tegra_pcie_xclk_clamp() to PMC

2012-06-11 Thread Thierry Reding
The PMC code already accesses to PMC registers so it makes sense to move this function there as well. While at it, rename the function to tegra_pmc_pcie_xclk_clamp() for consistency. Signed-off-by: Thierry Reding Acked-by: Stephen Warren --- Changes in v2: - none --- arch/arm/mach-tegra/pcie.c

[PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT

2012-06-11 Thread Thierry Reding
Device tree support for the TPS6586x PMU used on Harmony has recently been added. This commit adds the required device tree nodes to probe the PMU from the device tree. Signed-off-by: Thierry Reding --- Changes in v2: - new patch --- arch/arm/boot/dts/tegra-harmony.dts| 83 +++

[PATCH v2 09/10] ARM: tegra: harmony: Initialize PCIe from DT

2012-06-11 Thread Thierry Reding
With the device tree support in place, probe the PCIe controller from the device tree and remove the corresponding workaround in the board file. Signed-off-by: Thierry Reding --- Changes in v2: - new patch --- arch/arm/boot/dts/tegra-harmony.dts| 19 +-- arch/arm/mach-tegr

[PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-11 Thread Thierry Reding
This commit adds support for instantiating the Tegra PCIe controller from a device tree. Signed-off-by: Thierry Reding --- Changes in v2: - increase compile coverage by using the IS_ENABLED() macro - disable node by default --- .../devicetree/bindings/pci/tegra-pcie.txt | 23 arc

[PATCH v2 00/10] ARM: tegra: Add PCIe device tree support

2012-06-11 Thread Thierry Reding
This patch series adds support for device tree based probing of the PCIe controller found on Tegra SoCs. Patches 1 and 2 keep the pci_fixup_irqs() and ARM-specific pci_common_init() functions around after init. This is required to support driver probe deferral, which may cause built-in drivers to

[PATCH v2 03/10] ARM: pci: Allow passing per-controller private data

2012-06-11 Thread Thierry Reding
In order to allow drivers to specify private data for each controller, this commit adds a private_data field to the struct hw_pci. This field is an array of nr_controllers pointers that will be used to initialize the private_data field of the corresponding controller's pci_sys_data structure. Sign

[PATCH v2 02/10] ARM: pci: Keep pci_common_init() around after init

2012-06-11 Thread Thierry Reding
Signed-off-by: Thierry Reding --- Changes in v2: - use __devinit annotations --- arch/arm/kernel/bios32.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c index 2555250..c9d28dd 100644 --- a/arch/arm/kernel/bios32.c ++

[PATCH v2 10/10] ARM: tegra: trimslice: Initialize PCIe from DT

2012-06-11 Thread Thierry Reding
With the device tree support in place, probe the PCIe controller from the device tree and remove the corresponding workaround in the board file. Signed-off-by: Thierry Reding --- Changes in v2: - new patch --- arch/arm/boot/dts/tegra-trimslice.dts |4 arch/arm/mach-tegra/board-dt-tegr

[PATCH v2 05/10] ARM: tegra: Rewrite PCIe support as a driver

2012-06-11 Thread Thierry Reding
This commit adds a platform device driver for the PCIe controller on Tegra SOCs. Current users of the old code (TrimSlice and Harmony) are converted and now initialize and register a corresponding platform device. Signed-off-by: Thierry Reding --- Changes in v2: - use struct hw_pci's new private

Re: [PATCH V3 5/6] Avoid duplicate probe for of platform devices

2012-06-11 Thread Rob Herring
[adding lkml and Greg KH] On 06/08/2012 04:43 AM, Jia Hongtao wrote: > We changed the pcie controller driver to platform driver so that the PCI > of platform devices need to be created earlier in the arch_initcall stage > according to the original timing of calling fsl_add_bridge(). So we do PCI >

Re: Configure standalone GPIO in device tree?

2012-06-11 Thread Subodh Nijsure
On 06/11/2012 07:21 AM, Rob Herring wrote: On 06/11/2012 08:56 AM, Subodh Nijsure wrote: Hello, I am working with a hardware that has couple of GPIOs that are not tied to any specific device one to indicate board status, other to indicate presence of this hardware to some other 'independent' ha

Re: Configure standalone GPIO in device tree?

2012-06-11 Thread Rob Herring
On 06/11/2012 10:37 AM, Subodh Nijsure wrote: > On 06/11/2012 07:21 AM, Rob Herring wrote: >> On 06/11/2012 08:56 AM, Subodh Nijsure wrote: >>> Hello, >>> >>> I am working with a hardware that has couple of GPIOs that are not tied >>> to any specific device one to indicate board status, other to in

[PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-11 Thread Roland Stigge
This patch adds a driver for the key scan interface of the LPC32xx SoC Signed-off-by: Roland Stigge For the DT binding: Acked-by: Rob Herring --- Applies to v3.5-rc2 Changes since v3: * Make driver DT-only since LPC32xx is converted to DT anyway now. * Use MATRIX_SCAN_CODE() * Use matrix_keypa

[PATCH v7] MTD: LPC32xx MLC NAND driver

2012-06-11 Thread Roland Stigge
This patch adds a driver for the MLC NAND controller of the LPC32xx SoC. Signed-off-by: Roland Stigge Signed-off-by: Alexandre Pereira da Silva --- Applies to v3.5-rc2 + LPC32xx SLC NAND driver (Kconfig + Makefile) Changes since v6: * Kconfig: select amba dma driver * Make wp_gpio optional by

Re: [PATCH v2 05/10] ARM: tegra: Rewrite PCIe support as a driver

2012-06-11 Thread Stephen Warren
On 06/11/2012 09:05 AM, Thierry Reding wrote: > This commit adds a platform device driver for the PCIe controller on > Tegra SOCs. Current users of the old code (TrimSlice and Harmony) are > converted and now initialize and register a corresponding platform > device. > diff --git a/arch/arm/mach-t

Re: [PATCH v2 06/10] ARM: tegra: pcie: Add MSI support

2012-06-11 Thread Stephen Warren
On 06/11/2012 09:05 AM, Thierry Reding wrote: > This commit adds support for message signaled interrupts to the Tegra > PCIe controller. Based on code by Krishna Kishore . > diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c > +static irqreturn_t tegra_pcie_msi_irq(int irq, void

Re: [PATCH v2 05/10] ARM: tegra: Rewrite PCIe support as a driver

2012-06-11 Thread Stephen Warren
On 06/11/2012 09:05 AM, Thierry Reding wrote: > This commit adds a platform device driver for the PCIe controller on > Tegra SOCs. Current users of the old code (TrimSlice and Harmony) are > converted and now initialize and register a corresponding platform > device. > -static int tegra_pcie_clock

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-11 Thread Stephen Warren
On 06/11/2012 09:05 AM, Thierry Reding wrote: > This commit adds support for instantiating the Tegra PCIe controller > from a device tree. > +++ b/Documentation/devicetree/bindings/pci/tegra-pcie.txt Can we please name this nvidia,tegra20-pcie.txt to match the naming of all the other Tegra bindin

Re: [PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT

2012-06-11 Thread Stephen Warren
On 06/11/2012 09:05 AM, Thierry Reding wrote: > Device tree support for the TPS6586x PMU used on Harmony has recently > been added. This commit adds the required device tree nodes to probe the > PMU from the device tree. > diff --git a/arch/arm/boot/dts/tegra-harmony.dts > b/arch/arm/boot/dts/teg

Re: [PATCH v2 09/10] ARM: tegra: harmony: Initialize PCIe from DT

2012-06-11 Thread Stephen Warren
On 06/11/2012 09:05 AM, Thierry Reding wrote: > With the device tree support in place, probe the PCIe controller from > the device tree and remove the corresponding workaround in the board > file. > diff --git a/arch/arm/boot/dts/tegra-harmony.dts > b/arch/arm/boot/dts/tegra-harmony.dts > +

RE: [PATCH V3 5/6] Avoid duplicate probe for of platform devices

2012-06-11 Thread Jia Hongtao-B38951
> -Original Message- > From: Rob Herring [mailto:robherri...@gmail.com] > Sent: Monday, June 11, 2012 11:33 PM > To: Jia Hongtao-B38951 > Cc: devicetree-discuss@lists.ozlabs.org; linux-ker...@vger.kernel.org; > Greg KH > Subject: Re: [PATCH V3 5/6] Avoid duplicate probe for of platform de

[PATCH 1/3] edac: create top-level debugfs directory

2012-06-11 Thread Rob Herring
From: Rob Herring Create a single, top-level "edac" directory for debugfs. An "mc[0-N]" directory is then created for each memory controller. Individual drivers can create additional entries such as h/w error injection control. Signed-off-by: Rob Herring --- drivers/edac/edac_mc_sysfs.c | 23

[PATCH v2 0/3] EDAC support for Calxeda Highbank

2012-06-11 Thread Rob Herring
From: Rob Herring This series adds EDAC support for Calxeda Highbank platform L2 and memory ECC hardware. This version is rebased current edac next tree for 3.6. Changes in this version are the addition of a common edac debugfs directory and coverting the highbank error injection to use debugfs.

[PATCH v2 3/3] edac: add support for Calxeda highbank L2 cache ecc

2012-06-11 Thread Rob Herring
From: Rob Herring Add support for L2 ECC on Calxeda highbank platform. Signed-off-by: Rob Herring --- .../devicetree/bindings/arm/calxeda/l2ecc.txt | 17 +++ arch/arm/boot/dts/highbank.dts |6 + drivers/edac/Kconfig |7 + drivers

[PATCH v2 2/3] edac: add support for Calxeda highbank memory controller

2012-06-11 Thread Rob Herring
From: Rob Herring Add support for memory controller on Calxeda Highbank platforms. Highbank platforms support a single 4GB mini-DIMM with 1-bit correction and 2-bit detection. Signed-off-by: Rob Herring --- .../devicetree/bindings/arm/calxeda/mem-ctrlr.txt | 17 ++ arch/arm/boot/dts/highban

Re: [PATCH v2 05/10] ARM: tegra: Rewrite PCIe support as a driver

2012-06-11 Thread Thierry Reding
* Stephen Warren wrote: > On 06/11/2012 09:05 AM, Thierry Reding wrote: > > This commit adds a platform device driver for the PCIe controller on > > Tegra SOCs. Current users of the old code (TrimSlice and Harmony) are > > converted and now initialize and register a corresponding platform > > devic

Re: [PATCH v2 06/10] ARM: tegra: pcie: Add MSI support

2012-06-11 Thread Thierry Reding
* Stephen Warren wrote: > On 06/11/2012 09:05 AM, Thierry Reding wrote: > > This commit adds support for message signaled interrupts to the Tegra > > PCIe controller. Based on code by Krishna Kishore . > > > diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c > > > +static irqret

Re: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-11 Thread Shubhrajyoti
On Tuesday 12 June 2012 01:14 AM, Roland Stigge wrote: > + > +struct lpc32xx_kscan_drv { > + struct input_dev *input; > + struct lpc32xx_kscan_cfg *kscancfg; > + struct clk *clk; > + void __iomem *kscan_base; > + int irq; Do you really need this irq field? It is used in the pro

Re: [PATCH v2 06/10] ARM: tegra: pcie: Add MSI support

2012-06-11 Thread Stephen Warren
On 06/11/2012 11:07 PM, Thierry Reding wrote: > * Stephen Warren wrote: >> On 06/11/2012 09:05 AM, Thierry Reding wrote: >>> This commit adds support for message signaled interrupts to the >>> Tegra PCIe controller. Based on code by Krishna Kishore >>> . ... >> Why allocate pcie->msi separately; wh

Re: [PATCH v2 06/10] ARM: tegra: pcie: Add MSI support

2012-06-11 Thread Thierry Reding
* Stephen Warren wrote: > On 06/11/2012 11:07 PM, Thierry Reding wrote: > > * Stephen Warren wrote: > >> On 06/11/2012 09:05 AM, Thierry Reding wrote: > >>> This commit adds support for message signaled interrupts to the > >>> Tegra PCIe controller. Based on code by Krishna Kishore > >>> . > ... >

Re: [PATCH v2 09/10] ARM: tegra: harmony: Initialize PCIe from DT

2012-06-11 Thread Thierry Reding
* Stephen Warren wrote: > On 06/11/2012 09:05 AM, Thierry Reding wrote: > > With the device tree support in place, probe the PCIe controller from > > the device tree and remove the corresponding workaround in the board > > file. > > > diff --git a/arch/arm/boot/dts/tegra-harmony.dts > > b/arch/ar

Re: [PATCH v2 06/10] ARM: tegra: pcie: Add MSI support

2012-06-11 Thread Thierry Reding
* Thierry Reding wrote: > * Stephen Warren wrote: > > On 06/11/2012 09:05 AM, Thierry Reding wrote: [...] > > > +static int tegra_pcie_disable_msi(struct platform_device *pdev) > > > > Should this free pcie->msi->pages? > > Yes it should. I actually mention making that change in the changelog but

Re: [PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT

2012-06-11 Thread Thierry Reding
* Stephen Warren wrote: > On 06/11/2012 09:05 AM, Thierry Reding wrote: > > Device tree support for the TPS6586x PMU used on Harmony has recently > > been added. This commit adds the required device tree nodes to probe the > > PMU from the device tree. > > > diff --git a/arch/arm/boot/dts/tegra-ha

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-11 Thread Thierry Reding
* Stephen Warren wrote: > On 06/11/2012 09:05 AM, Thierry Reding wrote: > > This commit adds support for instantiating the Tegra PCIe controller > > from a device tree. > > > +++ b/Documentation/devicetree/bindings/pci/tegra-pcie.txt > > Can we please name this nvidia,tegra20-pcie.txt to match th

Re: [PATCH v2 05/10] ARM: tegra: Rewrite PCIe support as a driver

2012-06-11 Thread Thierry Reding
* Stephen Warren wrote: > On 06/11/2012 09:05 AM, Thierry Reding wrote: > > This commit adds a platform device driver for the PCIe controller on > > Tegra SOCs. Current users of the old code (TrimSlice and Harmony) are > > converted and now initialize and register a corresponding platform > > devic