Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Thierry Reding
On Thu, Jun 14, 2012 at 01:50:56PM -0600, Stephen Warren wrote: > On 06/14/2012 01:29 PM, Thierry Reding wrote: > > On Thu, Jun 14, 2012 at 12:30:50PM -0600, Stephen Warren wrote: > >> On 06/14/2012 03:19 AM, Thierry Reding wrote: > ... > >>> #address-cells = <1>; #size-cells = <1>; > >>> > >>> pc

Re: [PATCH v3 1/4] clk: add DT clock binding support

2012-06-14 Thread Rob Herring
On 06/14/2012 10:17 PM, Shawn Guo wrote: > On Tue, Jun 12, 2012 at 09:41:48AM -0500, Rob Herring wrote: >> +struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec) >> +{ >> +struct of_clk_provider *provider; >> +struct clk *clk = NULL; > > Both clk and clkdev treat NULL as a

Re: [PATCH v3 1/4] clk: add DT clock binding support

2012-06-14 Thread Shawn Guo
On Tue, Jun 12, 2012 at 09:41:48AM -0500, Rob Herring wrote: > +struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec) > +{ > + struct of_clk_provider *provider; > + struct clk *clk = NULL; Both clk and clkdev treat NULL as a valid clock and return ERR_PTR for error case, wh

Re: [PATCH v4] usb: chipidea: permit driver bindings pass phy pointer

2012-06-14 Thread Richard Zhao
On Thu, Jun 14, 2012 at 08:46:24AM -0700, Greg KH wrote: > On Thu, Jun 14, 2012 at 10:52:57AM +0300, Alexander Shishkin wrote: > > Greg KH writes: > > > > > On Fri, Jun 08, 2012 at 08:37:06PM +0800, Richard Zhao wrote: > > >> Sometimes, the driver bindings may know what phy they use. > > >> For e

[GIT PULL] DT fixes for 3.5

2012-06-14 Thread Rob Herring
Grant, Please pull. Mainly some documentation updates and 2 fixes: - An export symbol fix for of_platform_populate from Stephen W. - A fix for the order compatible entries are matched to ensure the first compatible string is matched when there are multiple matches. Rob The following changes sin

Re: [PATCH v2 07/19] tegra: fdt: Add LCD definitions for Tegra

2012-06-14 Thread Stephen Warren
On 06/13/2012 10:19 AM, Simon Glass wrote: > Add LCD definitions and also a proposed binding for LCD displays. > > The PWFM is in progress on the device-tree-discuss list, so only a > very basic binding is offered here. I believe we have settled on a final representation, it just hasn't been adde

Re: [PATCH v2 03/19] fdt: Add function to look up a phandle's register address

2012-06-14 Thread Stephen Warren
On 06/13/2012 10:19 AM, Simon Glass wrote: > This is a commonly-used requirement, so add a function to support it > easily. Uggh. Why would this ever be needed; shouldn't the driver for the node referenced by the phandle fully control its own registers; why would any other driver randomly trample

Re: [PATCH] pinctrl: Add one-register-per-pin type device tree based pinctrl driver

2012-06-14 Thread Stephen Warren
On 06/11/2012 07:58 AM, Tony Lindgren wrote: > Add one-register-per-pin type device tree based pinctrl driver. > > Currently this driver only works on omap2+ series of processors, > where there is either an 8 or 16-bit padconf register for each pin. > Support for other similar pinmux controllers c

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Stephen Warren
On 06/14/2012 01:29 PM, Thierry Reding wrote: > On Thu, Jun 14, 2012 at 12:30:50PM -0600, Stephen Warren wrote: >> On 06/14/2012 03:19 AM, Thierry Reding wrote: ... >>> #address-cells = <1>; #size-cells = <1>; >>> >>> pci@8000 { >> >> I'm still not convinced that using the address of the port

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Thierry Reding
On Thu, Jun 14, 2012 at 12:30:50PM -0600, Stephen Warren wrote: > On 06/14/2012 03:19 AM, Thierry Reding wrote: > ... > > Okay, so the new pcie-controller node looks like this: > > > > pcie-controller { compatible = "nvidia,tegra20-pcie", > > "simple-bus"; reg = <0x80003000 0x0800 /* PADS re

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Stephen Warren
On 06/14/2012 03:19 AM, Thierry Reding wrote: ... > Okay, so the new pcie-controller node looks like this: > > pcie-controller { compatible = "nvidia,tegra20-pcie", > "simple-bus"; reg = <0x80003000 0x0800 /* PADS registers */ > 0x80003800 0x0200 /* AFI registers */ 0x80004000 0x00100

Re: [PATCH] powerpc/44x: Support OCM(On Chip Memory) for APM821xx SoC and Bluestone board

2012-06-14 Thread Josh Boyer
On Sun, May 6, 2012 at 11:52 PM, Vinh Nguyen Huu Tuong wrote: > This patch consists of: > - Add driver for OCM component > - Export OCM Information at /sys/class/ocm/ocminfo Again, apologies for the delay. Aside from the incorrect sysfs usage I pointed out in my other reply, I have just a few co

Re: Where to power on the wifi device before loading the driver.

2012-06-14 Thread Stephen Warren
On 06/14/2012 06:12 AM, Mark Brown wrote: > On Thu, Jun 14, 2012 at 08:31:20AM +0200, Thierry Reding wrote: >> On Wed, Jun 13, 2012 at 03:17:06PM -0600, Stephen Warren wrote: > >>> The core of the issue is that: > >>> * Tegra30 support is via device tree. * We have an SDIO bus, >>> and the WiFi d

Re: [PATCH v4] usb: chipidea: permit driver bindings pass phy pointer

2012-06-14 Thread Greg KH
On Thu, Jun 14, 2012 at 10:52:57AM +0300, Alexander Shishkin wrote: > Greg KH writes: > > > On Fri, Jun 08, 2012 at 08:37:06PM +0800, Richard Zhao wrote: > >> Sometimes, the driver bindings may know what phy they use. > >> For example, when using device tree, the usb controller may have a > >> ph

Re: [RFC] i.MX DRM devicetree binding

2012-06-14 Thread David Jander
On Thu, 14 Jun 2012 16:45:33 +0200 Sascha Hauer wrote: > On Thu, Jun 14, 2012 at 04:10:16PM +0200, David Jander wrote: > > On Thu, 14 Jun 2012 15:07:56 +0200 > > Sascha Hauer wrote: > > > > > + > > > +Required properties: > > > +- compatible: Should be "fsl,imx-parallel-display" > > > +- crtc:

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-14 Thread Guennadi Liakhovetski
Hi all Sorry for jumping in so late in the game. But I think, the model, to which this discussion is slowly converging, is not very well suitable for the shdma DMACs, present on SH and ARM sh-mobile SoCs. I might be wrong and the model is indeed suitable, in which case I'd be grateful, if someo

Re: [RFC] i.MX DRM devicetree binding

2012-06-14 Thread Sascha Hauer
On Thu, Jun 14, 2012 at 04:10:16PM +0200, David Jander wrote: > On Thu, 14 Jun 2012 15:07:56 +0200 > Sascha Hauer wrote: > > > + > > +Required properties: > > +- compatible: Should be "fsl,imx-parallel-display" > > +- crtc: the crtc this display is connected to, see below > > +Optional properties

Re: [RFC] i.MX DRM devicetree binding

2012-06-14 Thread David Jander
On Thu, 14 Jun 2012 15:07:56 +0200 Sascha Hauer wrote: > Hi All, > > The following is an attempt to come up with a devicetree binding for > DRM graphics on i.MX SoCs. I'm posting this seperate from the actual > code to not bury this in big patches. > > The bindings should cover most of the prob

Re: [Patch v5 03/13] USB: notify phy when root hub port connect change

2012-06-14 Thread Alan Stern
On Thu, 14 Jun 2012, Richard Zhao wrote: > > > + if (unlikely(hcd->phy && !hdev->level)) { > > > > This is okay, but it's more common to test for root hubs with > > "!hdev->parent". > So it will be like: > if (unlikely(hcd->phy && !hdev->parent)) { Yes. > And, > I didn't check (portchange & US

[RFC] i.MX DRM devicetree binding

2012-06-14 Thread Sascha Hauer
Hi All, The following is an attempt to come up with a devicetree binding for DRM graphics on i.MX SoCs. I'm posting this seperate from the actual code to not bury this in big patches. The bindings should cover most of the problems we had while implementing the possible IPU <-> (LVDS, HDMI, parall

Re: [PATCH v6 00/17] Add PWM framework and device tree support

2012-06-14 Thread Thierry Reding
On Thu, Jun 14, 2012 at 12:47:13PM +, Hebbar, Gururaja wrote: > On Tue, Apr 10, 2012 at 20:36:23, Thierry Reding wrote: > > This patch series adds very rudimentary device-tree support for PWM > > devices. With all of these patches applied (plus one board-specific > > patch that is not included)

Re: Where to power on the wifi device before loading the driver.

2012-06-14 Thread Mark Brown
On Thu, Jun 14, 2012 at 08:31:20AM +0200, Thierry Reding wrote: > On Wed, Jun 13, 2012 at 03:17:06PM -0600, Stephen Warren wrote: > > The core of the issue is that: > > * Tegra30 support is via device tree. > > * We have an SDIO bus, and the WiFi device attached to that bus is > > enumerable. > >

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Thierry Reding
On Thu, Jun 14, 2012 at 11:06:48AM +, Arnd Bergmann wrote: > On Thursday 14 June 2012, Thierry Reding wrote: > > On Thu, Jun 14, 2012 at 10:25:09AM +, Arnd Bergmann wrote: > > > On Thursday 14 June 2012, Thierry Reding wrote: > > > > > > > > > > I believe you will need an "interrupt-map" p

Re: [PATCH 1/9] ARM: Kirkwood: Add interrupt controller support for DT boards

2012-06-14 Thread Arnd Bergmann
On Thursday 14 June 2012, Andrew Lunn wrote: > > I think if you compute the number of interrupts in the domain from the > > number of > > registers that are described in the device tree, call orion_irq_init() > > based on those registers, and use irq domains for the gpio stuff as Rob > > suggeste

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-14 Thread Arnd Bergmann
On Wednesday 13 June 2012, Jon Hunter wrote: > > As I said previously, I think just encoding the direction but not > > the client specific ID (meaning we would have to disambiguate > > the more complex cases that Stephen mentioned using a dma-names > > property) would be the best because it keeps

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Arnd Bergmann
On Thursday 14 June 2012, Thierry Reding wrote: > On Thu, Jun 14, 2012 at 10:25:09AM +, Arnd Bergmann wrote: > > On Thursday 14 June 2012, Thierry Reding wrote: > > > > > > > > I believe you will need an "interrupt-map" property here, to map the > > > > host > > > > interrupts to the INTA-INT

Re: [PATCH 5/9] ARM: kirkwood: use devicetree for orion-spi

2012-06-14 Thread Arnd Bergmann
On Thursday 14 June 2012, Andrew Lunn wrote: > We either have auxdata and clean clock code, or no auxdata and messy > clock code with lots of aliases. > > The auxdata is also not limited to the name of the clocks. It allows > me to diff the kernel log for a DT boot and a none DT boot of the same >

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Thierry Reding
On Thu, Jun 14, 2012 at 10:25:09AM +, Arnd Bergmann wrote: > On Thursday 14 June 2012, Thierry Reding wrote: > > > > > > I believe you will need an "interrupt-map" property here, to map the host > > > interrupts to the INTA-INTD lines of the attached devices. > > > > Legacy interrupts are some

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Arnd Bergmann
On Thursday 14 June 2012, Thierry Reding wrote: > > > > I believe you will need an "interrupt-map" property here, to map the host > > interrupts to the INTA-INTD lines of the attached devices. > > Legacy interrupts are something I cannot test at all because I have no > hardware that supports them.

Re: [PATCH 5/9] ARM: kirkwood: use devicetree for orion-spi

2012-06-14 Thread Andrew Lunn
On Wed, Jun 13, 2012 at 09:10:30PM +, Arnd Bergmann wrote: > On Sunday 10 June 2012, Andrew Lunn wrote: > > @@ -26,6 +26,11 @@ static struct of_device_id kirkwood_dt_match_table[] > > __initdata = { > > { } > > }; > > > > +struct of_dev_auxdata kirkwood_auxdata_lookup[] __initdata =

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Thierry Reding
On Tue, Jun 12, 2012 at 10:36:55PM -1000, Mitch Bradley wrote: > On 6/12/2012 10:19 PM, Thierry Reding wrote: > >On Tue, Jun 12, 2012 at 10:05:35PM -1000, Mitch Bradley wrote: > >>On 6/12/2012 9:52 PM, Thierry Reding wrote: > >>>I think the configuration spaces and downstream I/O ranges need to be

Re: [PATCH 1/9] ARM: Kirkwood: Add interrupt controller support for DT boards

2012-06-14 Thread Andrew Lunn
On Thu, Jun 14, 2012 at 08:12:34AM +, Arnd Bergmann wrote: > On Sunday 10 June 2012, Andrew Lunn wrote: > > +static int __init kirkwood_add_irq_domain(struct device_node *np, > > + struct device_node > > *interrupt_parent) > > +{ > > + kirkwood_ini

Re: [PATCH v3 0/4] DT clock bindings

2012-06-14 Thread Shawn Guo
On Tue, Jun 12, 2012 at 11:23:18AM -0500, Rob Herring wrote: > Right. This is why I have reposted and copied those whom commented on my > pull request. I think at least some of Saravana's concerns boiled down > to not requiring using DT clock bindings and not requiring driver > changes to move to D

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-14 Thread Thierry Reding
On Wed, Jun 13, 2012 at 08:21:08PM +, Arnd Bergmann wrote: > On Wednesday 13 June 2012, Thierry Reding wrote: > > pci@8000 { > > reg = <0x8000 0x1000>; > > status = "disabled"; > > > > #address-

Re: [PATCH 1/9] ARM: Kirkwood: Add interrupt controller support for DT boards

2012-06-14 Thread Arnd Bergmann
On Sunday 10 June 2012, Andrew Lunn wrote: > +static int __init kirkwood_add_irq_domain(struct device_node *np, > + struct device_node > *interrupt_parent) > +{ > + kirkwood_init_irq(); > + irq_domain_add_legacy(np, 64, 0, 0, &irq_domain_simple_o

[PATCH v2] of: match by compatible property first

2012-06-14 Thread Thierry Reding
When matching devices against an OF device ID table, the first string of the compatible property that is listed in the table should match, regardless of its position in the table. Cc: Grant Likely Cc: Rob Herring Cc: devicetree-discuss@lists.ozlabs.org Signed-off-by: Thierry Reding --- Changes