Re: [PATCH RESEND] of: add const to struct of_device_id.data

2012-06-21 Thread Uwe Kleine-König
On Thu, Jun 07, 2012 at 12:20:14PM +0200, Uwe Kleine-König wrote: > Drivers should never need to modify the data of a device id. So it can > be const which in turn allows more consts in the driver. > > Signed-off-by: Uwe Kleine-König > --- > (Cc += lkml + Grant) > > Hello, > > this might introd

Re: [PATCH] spi/imx: make devtype_data member point to const data

2012-06-21 Thread Uwe Kleine-König
Hi Grant, On Mon, May 21, 2012 at 09:49:35PM +0200, Uwe Kleine-König wrote: > This is only cosmetic for now. In case that > > > http://mid.gmane.org/1335171381-24869-1-git-send-email-u.kleine-koe...@pengutronix.de > > will be applied, it fixes a warning > > drivers/spi/spi-imx.c: I

Re: [PATCH] of: fix a few typos in the binding documentation

2012-06-21 Thread Uwe Kleine-König
Hello Randy, expanding the audience a bit ... On Fri, May 18, 2012 at 04:21:48PM +0200, Uwe Kleine-König wrote: > On Mon, Apr 23, 2012 at 10:57:23AM +0200, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König > > --- > > Documentation/devicetree/bindings/mtd/atmel-nand.txt |2 +- > >

Re: [PATCH 1/1] of: reform prom_update_property function

2012-06-21 Thread Benjamin Herrenschmidt
On Fri, 2012-06-22 at 13:25 +0800, Dong Aisheng wrote: > Which seems the same behavior as the new prop_update_property api. > The only different is if no name, return -EINVAL; > Am i wrong? No, you are right. Sorry for the noise :-) Cheers, Ben. ___ d

Re: [PATCH 1/1] of: reform prom_update_property function

2012-06-21 Thread Dong Aisheng
On Fri, Jun 22, 2012 at 8:01 AM, Benjamin Herrenschmidt wrote: > On Thu, 2012-06-21 at 17:37 +0800, Dong Aisheng wrote: >> Maybe we could change it as as follows. >> It looks then the code follow is the same as before. >> Do you think if it's ok? >> >> diff --git a/arch/powerpc/platforms/pseries/r

Re: [PATCH 1/1] of: reform prom_update_property function

2012-06-21 Thread Benjamin Herrenschmidt
On Thu, 2012-06-21 at 17:37 +0800, Dong Aisheng wrote: > Maybe we could change it as as follows. > It looks then the code follow is the same as before. > Do you think if it's ok? > > diff --git a/arch/powerpc/platforms/pseries/reconfig.c > b/arch/powerpc/platforms/pseries/reconfig.c > index 7b3bf

Re: [RFC] ARM: OMAP: Remove nodes dynamically at runtime

2012-06-21 Thread Jon Hunter
On 06/21/2012 02:15 PM, Jon Hunter wrote: > Hi all, > > I am in the process of adding a device-tree binding for OMAP timers and > I have encountered a scenario where ideally it would be useful to remove > a device-tree node at runtime. > > The scenario is this ... > > 1. OMAP3 devices may or ma

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Mark Brown
On Thu, Jun 21, 2012 at 09:03:29PM +, Arnd Bergmann wrote: > The board specific settings on the other hand are about what to > put into those registers and what voltage to use. From all I can > tell, those settings belong into the node that actually uses the > regulator, not the node that defi

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Mark Brown
On Thu, Jun 21, 2012 at 11:53:41AM -1000, Mitch Bradley wrote: Whatever mail program you're using appears to be generating HTML mails and isn't doing an awesome job at formatting them, the plain text version is mangled too with most peculiar word wrapping which is quite hard to read. I've reflowe

Re: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios

2012-06-21 Thread Stephen Warren
On 06/20/2012 07:32 PM, Chen Peter-B29397 wrote: > >> I haven't been following the thread, but just noticed it. Very similar >> things (DT nodes for probed devices) are coming up quite a bit recently, >> for example: >> >> Re: Where to power on the wifi device before loading the driver. >> http:/

Re: [PATCH] pinctrl: Add one-register-per-pin type device tree based pinctrl driver

2012-06-21 Thread Stephen Warren
On 06/19/2012 07:56 AM, Tony Lindgren wrote: > Hi, > > Below is the pinctrl-single patch updated with hopefully all the Stephen's > comments addressed. The binding still needs to be looked at, see relevant > parts of the discussion below. ... > From: Tony Lindgren > Date: Wed, 6 Jun 2012 04:18:18

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Mitch Bradley
On 6/21/2012 9:45 AM, Mark Brown wrote: On Thu, Jun 21, 2012 at 05:17:45PM +, Arnd Bergmann wrote: On Thursday 21 June 2012, Mark Brown wrote: I'm not that big a fan of moving all the data into device tree as it means that you need even more parsing code and you need to update the device

Re: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios

2012-06-21 Thread Rob Herring
On 06/20/2012 10:05 AM, Shawn Guo wrote: > On Wed, Jun 20, 2012 at 09:29:39AM -0500, Rob Herring wrote: >> I mean just something like "fsl,hub-reset-gpios" in the ehci device >> node. It's at least under a usb node. Whether the ehci driver handles >> this or you just have a separate piece of code t

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Arnd Bergmann
On Thursday 21 June 2012, Stephen Warren wrote: > > It should never be necessary to add board-specific properties in the > > nodes that describe the SoC specific bits. What I was referring to > > is just moving the data that currently resides in the regulator > > driver into DT. > > I guess I must

Re: [PATCH v7] usb: chipidea: permit driver bindings pass phy pointer

2012-06-21 Thread Marc Kleine-Budde
On 06/21/2012 10:51 AM, Richard Zhao wrote: > Sometimes, the driver bindings may know what phy they use. > For example, when using device tree, the usb controller may have a > phandler pointing to usb phy. Remove the module doesn't remove the platform device. A subsequent modprobe fails with: --

Re: [PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT

2012-06-21 Thread Stephen Warren
On 06/11/2012 09:05 AM, Thierry Reding wrote: > Device tree support for the TPS6586x PMU used on Harmony has recently > been added. This commit adds the required device tree nodes to probe the > PMU from the device tree. > diff --git a/arch/arm/boot/dts/tegra-harmony.dts > b/arch/arm/boot/dts/teg

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Mark Brown
On Thu, Jun 21, 2012 at 05:17:45PM +, Arnd Bergmann wrote: > On Thursday 21 June 2012, Mark Brown wrote: > > I'm not that big a fan of moving all the data into device tree as it > > means that you need even more parsing code and you need to update the > > device trees for every board out there

Re: [PATCH v3 0/4] DT clock bindings

2012-06-21 Thread Mike Turquette
On 20120621-10:00, Rob Herring wrote: > On 06/21/2012 02:27 AM, Chris Ball wrote: > > > > 2) Use alloc_bootmem() instead of kzalloc() in of_clk_add_provider(), > >because we need to set up clocks during .init_early on ARM (which > >happens pre-slab) so that they

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Stephen Warren
On 06/21/2012 11:17 AM, Arnd Bergmann wrote: > On Thursday 21 June 2012, Mark Brown wrote: ... >> I'm also not sure if the tooling works well for allowing people to >> include standard DTs for chips and add new properties to nodes for the >> board specific configuration, though I think I've seen a

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Arnd Bergmann
On Thursday 21 June 2012, Mark Brown wrote: > Show Details > On Thu, Jun 21, 2012 at 02:50:35PM +, Arnd Bergmann wrote: > > > It seems that the drivers that are changed to use this could also try to > > describe the individual regulators completely, by moving the contents > > of e.g. ab850

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Mark Brown
On Thu, Jun 21, 2012 at 02:50:35PM +, Arnd Bergmann wrote: > It seems that the drivers that are changed to use this could also try to > describe the individual regulators completely, by moving the contents > of e.g. ab8500_regulator_info into the device tree, but having the string > identifier

Re: [PATCH v3 0/4] DT clock bindings

2012-06-21 Thread Rob Herring
Chris, On 06/21/2012 02:27 AM, Chris Ball wrote: > Hi Rob, > > On Tue, Jun 12 2012, Rob Herring wrote: >> This series defines clock bindings for Device-Tree and adds kernel >> support using the common clock infrastructure. The last patch enables >> DT clock support for the Calxeda Highbank platfo

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-21 Thread Arnd Bergmann
On Thursday 21 June 2012, Guennadi Liakhovetski wrote: > Indeed, this solution should be good enough, thanks! I'm not sure, whether > making this multiplexing available requires any additional code to the > generic DMA DT binding implementation. If it does - please, let's make > this a part of t

Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

2012-06-21 Thread Arnd Bergmann
On Wednesday 20 June 2012, Mark Brown wrote: > On Wed, Jun 20, 2012 at 03:01:15PM -0600, Stephen Warren wrote: > > The problem is that dtc has no named constants. Using raw integers > > instead of names would make the .dts file rather unreadable. The issue > > is much more accute for regulators tha

Re: [PATCH 02/02] clk: clk-of: Use alloc_bootmem() instead of kzalloc()

2012-06-21 Thread Paul Mundt
On Thu, Jun 21, 2012 at 03:32:04AM -0400, Chris Ball wrote: > When of_clk_add_provider() is used at boot time (during .init_early on > ARM, in the motivating case for this patch), kzalloc() cannot be used > because slab isn't up yet. > > Signed-off-by: Chris Ball I wouldn't use alloc_bootmem() u

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-21 Thread Guennadi Liakhovetski
Hi Arnd Sorry for a delayed reply, we had to discuss this your idea internally first before replying. On Fri, 15 Jun 2012, Arnd Bergmann wrote: > On Friday 15 June 2012, Guennadi Liakhovetski wrote: > > > In the common case, you could have one device connected to the third > > > slave ID of the

Re: [PATCH V2 0/3] regulator: dt: add policy to match regulator with prop "regulator-compatible"

2012-06-21 Thread Mark Brown
On Wed, Jun 20, 2012 at 10:23:52AM -0600, Stephen Warren wrote: > Related to this, I wonder if we need some scheme to tag individual > bindings as under-development vs. final, and some way to promote > bindings between those states (a bindings review board?!). Do binding Part of the trouble with

Re: [PATCH 1/1] of: reform prom_update_property function

2012-06-21 Thread Dong Aisheng
On Thu, Jun 21, 2012 at 08:16:36AM +0800, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-20 at 08:07 -0500, Rob Herring wrote: > > On 06/20/2012 12:54 AM, Dong Aisheng wrote: > > > From: Dong Aisheng > > > > > > prom_update_property() currently fails if the property doesn't > > > actually exist

Re: [PATCH RESEND] input: gpio_keys_polled: convert to dt

2012-06-21 Thread Dmitry Torokhov
Hi Alexandre, On Wed, Jun 20, 2012 at 08:34:21AM -0300, Alexandre Pereira da Silva wrote: > Add device tree support to gpio_keys_polled.c > > Signed-off-by: Alexandre Pereira da Silva > Tested-by: Roland Stigge > --- > drivers/input/keyboard/gpio_keys_polled.c | 121 > +++

Re: [PATCH v6 00/14] add imx usb driver based on Greg next tree

2012-06-21 Thread Marc Kleine-Budde
On 06/21/2012 10:52 AM, Richard Zhao wrote: > On Thu, Jun 21, 2012 at 09:24:39AM +0200, Marc Kleine-Budde wrote: >> On 06/21/2012 08:41 AM, Richard Zhao wrote: >>> The work is based on ci13xxx rework done by Alexander Shishkin. >>> >>> To let Greg pick up, I also added patches Alex queued that I d

Re: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-21 Thread Dmitry Torokhov
On Mon, Jun 11, 2012 at 09:44:51PM +0200, Roland Stigge wrote: > This patch adds a driver for the key scan interface of the LPC32xx SoC > > Signed-off-by: Roland Stigge > For the DT binding: Acked-by: Rob Herring Not a real review, just a quick question - if th driver is DT-only now do we need

Re: [PATCH v6 00/14] add imx usb driver based on Greg next tree

2012-06-21 Thread Richard Zhao
On Thu, Jun 21, 2012 at 09:24:39AM +0200, Marc Kleine-Budde wrote: > On 06/21/2012 08:41 AM, Richard Zhao wrote: > > The work is based on ci13xxx rework done by Alexander Shishkin. > > > > To let Greg pick up, I also added patches Alex queued that I depends on. > > Patch #1 - #9 : It can also be

[PATCH v7] usb: chipidea: permit driver bindings pass phy pointer

2012-06-21 Thread Richard Zhao
Sometimes, the driver bindings may know what phy they use. For example, when using device tree, the usb controller may have a phandler pointing to usb phy. Signed-off-by: Richard Zhao Reviewed-by: Marek Vasut Acked-by: Felipe Balbi Tested-by: Subodh Nijsure --- drivers/usb/chipidea/ci.h|

Re: [PATCH v5] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-21 Thread Dmitry Torokhov
On Mon, Jun 18, 2012 at 06:18:21PM -0300, Alexandre Pereira da Silva wrote: > On Mon, Jun 18, 2012 at 5:05 PM, Roland Stigge wrote: > > This patch adds a driver for the key scan interface of the LPC32xx SoC > > > > Signed-off-by: Roland Stigge > > For the DT binding: Acked-by: Rob Herring > > A

Re: [PATCH v6 12/14] usb: chipidea: permit driver bindings pass phy pointer

2012-06-21 Thread Richard Zhao
On Thu, Jun 21, 2012 at 09:18:22AM +0200, Marc Kleine-Budde wrote: > On 06/21/2012 08:41 AM, Richard Zhao wrote: > > Sometimes, the driver bindings may know what phy they use. > > For example, when using device tree, the usb controller may have a > > phandler pointing to usb phy. > > > > Signed-of

Re: [PATCH] pinctrl: Add one-register-per-pin type device tree based pinctrl driver

2012-06-21 Thread Linus Walleij
On Tue, Jun 19, 2012 at 3:56 PM, Tony Lindgren wrote: > Below is the pinctrl-single patch updated with hopefully all the Stephen's > comments addressed. The binding still needs to be looked at, see relevant > parts of the discussion below. I am happy with the code and the way it interacts with t

Re: [PATCH V2 0/3] regulator: dt: add policy to match regulator with prop "regulator-compatible"

2012-06-21 Thread Linus Walleij
On Wed, Jun 20, 2012 at 6:23 PM, Stephen Warren wrote: > Related to this, I wonder if we need some scheme to tag individual > bindings as under-development vs. final, and some way to promote > bindings between those states (a bindings review board?!). Hm, we just have Documentation/devicetree/bi

[PATCH 02/02] clk: clk-of: Use alloc_bootmem() instead of kzalloc()

2012-06-21 Thread Chris Ball
When of_clk_add_provider() is used at boot time (during .init_early on ARM, in the motivating case for this patch), kzalloc() cannot be used because slab isn't up yet. Signed-off-by: Chris Ball --- drivers/clk/clk-of.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH 01/02] clk: Refactor of_clk_* into a new clk-of.c

2012-06-21 Thread Chris Ball
This removes the dependency on CONFIG_COMMON_CLK, which is unnecessary for the of_clk_* functions -- these functions are passed a struct clk, which can either be a COMMON_CLK struct or an arch-specific one. Signed-off-by: Chris Ball --- drivers/clk/Makefile |2 + drivers/clk/clk-of.c

Re: [PATCH v3 0/4] DT clock bindings

2012-06-21 Thread Chris Ball
Hi Rob, On Tue, Jun 12 2012, Rob Herring wrote: > This series defines clock bindings for Device-Tree and adds kernel > support using the common clock infrastructure. The last patch enables > DT clock support for the Calxeda Highbank platform. > > I'm posting this again to solicit further review. T

Re: [PATCH v6 00/14] add imx usb driver based on Greg next tree

2012-06-21 Thread Marc Kleine-Budde
On 06/21/2012 08:41 AM, Richard Zhao wrote: > The work is based on ci13xxx rework done by Alexander Shishkin. > > To let Greg pick up, I also added patches Alex queued that I depends on. > Patch #1 - #9 : It can also be found at > http://github.com/virtuoso/linux-ci.git ci > > This patch series

Re: [PATCH v6 12/14] usb: chipidea: permit driver bindings pass phy pointer

2012-06-21 Thread Marc Kleine-Budde
On 06/21/2012 08:41 AM, Richard Zhao wrote: > Sometimes, the driver bindings may know what phy they use. > For example, when using device tree, the usb controller may have a > phandler pointing to usb phy. > > Signed-off-by: Richard Zhao > Reviewed-by: Marek Vasut > Acked-by: Felipe Balbi > Tes