Re: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-24 Thread Roland Stigge
On 21/06/12 10:56, Dmitry Torokhov wrote: > On Mon, Jun 11, 2012 at 09:44:51PM +0200, Roland Stigge wrote: >> This patch adds a driver for the key scan interface of the LPC32xx SoC >> >> Signed-off-by: Roland Stigge >> For the DT binding: Acked-by: Rob Herring > > Not a real review, just a quick

Re: [PATCH RESEND] of: add const to struct of_device_id.data

2012-06-24 Thread Uwe Kleine-König
Hello Arnd, On Fri, Jun 22, 2012 at 05:26:22PM +, Arnd Bergmann wrote: > On Friday 22 June 2012, Uwe Kleine-König wrote: > > On Thu, Jun 07, 2012 at 12:20:14PM +0200, Uwe Kleine-König wrote: > > > Drivers should never need to modify the data of a device id. So it can > > > be const which in tu

[PATCH v6] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-24 Thread Roland Stigge
This patch adds a driver for the key scan interface of the LPC32xx SoC Signed-off-by: Roland Stigge --- Applies to v3.5-rc3 Changes since v5: * Handle return code from matrix_keypad_build_keymap() * Remove platform data structure and integrate into device struct Changes since v4: * Remove irq

Re: [PATCH v6 00/14] add imx usb driver based on Greg next tree

2012-06-24 Thread Richard Zhao
On Thu, Jun 21, 2012 at 11:10:23AM +0200, Marc Kleine-Budde wrote: > On 06/21/2012 10:52 AM, Richard Zhao wrote: > > On Thu, Jun 21, 2012 at 09:24:39AM +0200, Marc Kleine-Budde wrote: > >> On 06/21/2012 08:41 AM, Richard Zhao wrote: > >>> The work is based on ci13xxx rework done by Alexander Shish

Re: [PATCH v7] usb: chipidea: permit driver bindings pass phy pointer

2012-06-24 Thread Richard Zhao
On Thu, Jun 21, 2012 at 10:42:52PM +0200, Marc Kleine-Budde wrote: > On 06/21/2012 10:51 AM, Richard Zhao wrote: > > Sometimes, the driver bindings may know what phy they use. > > For example, when using device tree, the usb controller may have a > > phandler pointing to usb phy. > > Remove the mo

Re: [PATCH v6 07/14] USB: Chipidea: add unified ci13xxx_{add,remove}_device for platform drivers

2012-06-24 Thread Richard Zhao
On Thu, Jun 21, 2012 at 02:41:08PM +0800, Richard Zhao wrote: > Platform drivers do the similar things to add/remove ci13xxx device, so > create a unified one. > > Signed-off-by: Richard Zhao > Reviewed-by: Felipe Balbi > Signed-off-by: Alexander Shishkin > --- > drivers/usb/chipidea/ci13xxx_m

Re: [PATCH] Fix compilation warning/error in setprop_inplace.c

2012-06-24 Thread David Gibson
On Wed, Jun 13, 2012 at 12:31:52PM +1000, David Gibson wrote: > On Tue, Jun 12, 2012 at 02:48:12PM -0600, Stephen Warren wrote: > > From: Stephen Warren > > > > When compiling the current code-base with gcc 4.6.1, the following warning > > is raised, which is interpreted as an error: > > > > cc1

Re: [PATCH V2] MXS: Add DT binding support into stmp3xxx-rtc

2012-06-24 Thread Shawn Guo
On Fri, Jun 08, 2012 at 08:56:44PM +0200, Marek Vasut wrote: > Add simple binding for the stmp3xxx-rtc. > > Signed-off-by: Marek Vasut > Cc: Alessandro Zummo Hi Alessandro, The patch has some changes on arch/arm/boot/dts/imx28.dtsi, and also we need the patch to convert some board files over t

Re: [RFC PATCH v2 1/2] drivers: misc: omap: add a new driver for ocp2scp

2012-06-24 Thread ABRAHAM, KISHON VIJAY
Hi Greg, On Sat, Jun 23, 2012 at 10:14 AM, Greg KH wrote: > On Fri, Jun 22, 2012 at 06:45:41PM +0530, Kishon Vijay Abraham I wrote: >> Adds a new driver _ocp2scp_. > > That's not what you called this driver in the patch below :( > >> This driver takes the responsibility of creating >> all the dev

[PATCH v2 1/1] of: reform prom_update_property function

2012-06-24 Thread Dong Aisheng
From: Dong Aisheng prom_update_property() currently fails if the property doesn't actually exist yet which isn't what we want. Change to add-or-update instead of update-only, then we can remove a lot duplicated lines. Suggested-by: Grant Likely Signed-off-by: Dong Aisheng --- ChangeLog v1->v2:

Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

2012-06-24 Thread Thierry Reding
On Fri, Jun 22, 2012 at 11:28:15AM -0600, Stephen Warren wrote: > On 06/22/2012 11:00 AM, Stephen Warren wrote: > > On 06/22/2012 05:00 AM, Thierry Reding wrote: > > ... > >> Stephen: can you try to find out whether the Tegra PCIe controller > >> indeed implements ECAM, or if this scheme is actual

Re: [PATCH v2 1/1] of: reform prom_update_property function

2012-06-24 Thread Benjamin Herrenschmidt
On Mon, 2012-06-25 at 14:28 +0800, Dong Aisheng wrote: > From: Dong Aisheng > > prom_update_property() currently fails if the property doesn't > actually exist yet which isn't what we want. Change to add-or-update > instead of update-only, then we can remove a lot duplicated lines. > > Suggested

[PATCH v7 02/14] usb: chipidea: drop useless arch-check

2012-06-24 Thread Richard Zhao
From: Felipe Balbi msm glue layer compiles on all arches just fine. Let's drop the unnecessary ARCH check so we have easier compile tests. Signed-off-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/Makefile |8 +--- 1 file changed, 5 insertions(+), 3 deleti

[PATCH v7 03/14] usb: chipidea: msm: add missing section annotation

2012-06-24 Thread Richard Zhao
From: Felipe Balbi no functional changes, it will just free up some code if we don't have hotplug. Signed-off-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/ci13xxx_msm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/c

[PATCH v7 05/14] USB: Chipidea: rename struct ci13xxx_udc_driver to struct ci13xxx_platform_data

2012-06-24 Thread Richard Zhao
This patch rename struct ci13xxx_udc_driver and var with the type. ci13xxx_platform_data reflect it's passed from platfrom driver. Signed-off-by: Richard Zhao Reviewed-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/ci.h |4 ++-- drivers/usb/chipidea/c

[PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-24 Thread Richard Zhao
From: Felipe Balbi allow this driver to be removed too. Signed-off-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/ci13xxx_msm.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_msm.c b/driver

[PATCH v7 00/14] add imx usb driver based on Greg next tree

2012-06-24 Thread Richard Zhao
The work is based on ci13xxx rework done by Alexander Shishkin. To let Greg pick up, I also added patches Alex queued that I depends on. Patch #1 - #9 : It can also be found at http://github.com/virtuoso/linux-ci.git ci This patch series can also be found at: https://github.com/riczhao/kernel-im

[PATCH v7 07/14] USB: Chipidea: add unified ci13xxx_{add, remove}_device for platform drivers

2012-06-24 Thread Richard Zhao
Platform drivers do the similar things to add/remove ci13xxx device, so create a unified one. Signed-off-by: Richard Zhao Reviewed-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/ci13xxx_msm.c | 34 ++-- drivers/usb/chipidea/ci13xxx_pci.c |

[PATCH v7 08/14] USB: Chipidea: add ci13xxx device id management

2012-06-24 Thread Richard Zhao
We use ida_simple_get and ida_simple_remove to manage the ids. Signed-off-by: Richard Zhao Reviewed-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/core.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipid

[PATCH v7 01/14] usb: chipidea: remove unneeded NULL check

2012-06-24 Thread Richard Zhao
From: Alexander Shishkin As reported by Dan Carpenter, there is a NULL check in udc_start() that follows a dereference of the pointer that's being checked. However, at that point udc pointer shouldn't ever be NULL and if it is, the dereference should cause an oops. Signed-off-by: Alexander Shish