Re: [PATCH v5 1/7] ARM: davinci, cp_intc: Add irq domain support

2012-06-25 Thread Heiko Schocher
Hello Sekhar, On 25.06.2012 19:15, Sekhar Nori wrote: Hi Heiko, On 5/30/2012 3:48 PM, Heiko Schocher wrote: Signed-off-by: Heiko Schocher Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicetree-discuss@lists.ozlabs.org Cc: Grant Likely Cc: Sek

Re: [PATCH v2] spi/pl022: add devicetree support

2012-06-25 Thread Thierry Reding
On Mon, Jun 25, 2012 at 06:06:28PM -0300, Alexandre Pereira da Silva wrote: [...] > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c [...] > @@ -1733,7 +1744,7 @@ static int calculate_effective_freq(struct pl022 > *pl022, int freq, struct > * A piece of default chip info unless the

Re: [RFC 2/2] usb: gadget: composite: parse dt overrides

2012-06-25 Thread Mitch Bradley
On 6/25/2012 1:49 PM, Rob Herring wrote: On 06/25/2012 03:23 PM, Alexandre Pereira da Silva wrote: Grab the devicetree node properties to override VendorId, ProductId, bcdDevice, Manucacturer, Product and SerialNumber Signed-off-by: Alexandre Pereira da Silva --- drivers/usb/gadget/composite

[PATCH] gpio: samsung: add flags specifier to device-tree binding

2012-06-25 Thread Olof Johansson
This adds a flags field to the gpio specifier for Samsung. I didn't want to add yet another field in the already quite long specifier, so I decided to compress it together with the Pull Up/Down settings instead. This is needed to, for example, have a gpio-keys input that is active low. Signed-off

Re: [PATCH v6 00/14] add imx usb driver based on Greg next tree

2012-06-25 Thread Shawn Guo
On Mon, Jun 25, 2012 at 01:18:22PM -0300, Fabio Estevam wrote: > Any suggestions as to how to make the driver work on mx23? > I won't be able to test it on my imx23-evk board, because the board design is somehow odd on vbus supply, which probably requires a board rework. -- Regards, Shawn _

Re: [PATCH 1/4] netdev/phy: Handle IEEE802.3 clause 45 Ethernet PHYs

2012-06-25 Thread David Miller
From: David Daney Date: Mon, 25 Jun 2012 16:48:40 -0700 > Therefore, I am going to propose that we add a 'flags' parameter to > get_phy_device() and change the (two) callers. Since there is only one flag, make it simply a bool for now. ___ devicetree-d

Re: [RFC 2/2] usb: gadget: composite: parse dt overrides

2012-06-25 Thread Rob Herring
On 06/25/2012 03:23 PM, Alexandre Pereira da Silva wrote: > Grab the devicetree node properties to override VendorId, ProductId, > bcdDevice, Manucacturer, Product and SerialNumber > > Signed-off-by: Alexandre Pereira da Silva > --- > drivers/usb/gadget/composite.c | 31 +++

Re: [PATCH 1/4] netdev/phy: Handle IEEE802.3 clause 45 Ethernet PHYs

2012-06-25 Thread David Daney
On 06/25/2012 04:33 PM, David Miller wrote: From: David Daney Date: Mon, 25 Jun 2012 16:11:23 -0700 Do you realize that at the time get_phy_device() is called, there is no PHY device? So there can be no attribute, nor are we passing a register address. Neither of these suggestions apply to th

Re: [PATCH v2 1/1] of: reform prom_update_property function

2012-06-25 Thread Rob Herring
On 06/25/2012 01:28 AM, Dong Aisheng wrote: > From: Dong Aisheng > > prom_update_property() currently fails if the property doesn't > actually exist yet which isn't what we want. Change to add-or-update > instead of update-only, then we can remove a lot duplicated lines. > > Suggested-by: Grant

Re: [PATCH 1/4] netdev/phy: Handle IEEE802.3 clause 45 Ethernet PHYs

2012-06-25 Thread David Miller
From: David Daney Date: Mon, 25 Jun 2012 16:11:23 -0700 > Do you realize that at the time get_phy_device() is called, there is > no PHY device? So there can be no attribute, nor are we passing a > register address. Neither of these suggestions apply to this > situation. > > We need to know a p

Re: [PATCH 1/4] netdev/phy: Handle IEEE802.3 clause 45 Ethernet PHYs

2012-06-25 Thread David Daney
On 06/25/2012 03:34 PM, David Miller wrote: From: David Daney Date: Fri, 22 Jun 2012 17:24:13 -0700 From: David Daney The IEEE802.3 clause 45 MDIO bus protocol allows for directly addressing PHY registers using a 21 bit address, and is used by many 10G Ethernet PHYS. Already existing is the a

Re: [PATCH 1/4] netdev/phy: Handle IEEE802.3 clause 45 Ethernet PHYs

2012-06-25 Thread David Miller
From: David Daney Date: Fri, 22 Jun 2012 17:24:13 -0700 > From: David Daney > > The IEEE802.3 clause 45 MDIO bus protocol allows for directly > addressing PHY registers using a 21 bit address, and is used by many > 10G Ethernet PHYS. Already existing is the ability of MDIO bus > drivers to use

Re: [RFC 2/2] usb: gadget: composite: parse dt overrides

2012-06-25 Thread Michal Nazarewicz
On Mon, 25 Jun 2012 22:23:52 +0200, Alexandre Pereira da Silva wrote: Grab the devicetree node properties to override VendorId, ProductId, bcdDevice, Manucacturer, Product and SerialNumber Signed-off-by: Alexandre Pereira da Silva Acked-by: Michal Nazarewicz @@ -1470,6 +1472,35 @@ static

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-25 Thread Arnd Bergmann
On Monday 25 June 2012, Vinod Koul wrote: > On Mon, 2012-06-25 at 11:51 -0500, Jon Hunter wrote: > > Hi Russell, > > Dan, Vinod, in this thread we have been discussing the addition of a > > generic device-tree binding for DMA controllers. In the below, we were > > discussing the addition of a devi

Re: [RFC PATCH v2 1/2] drivers: misc: omap: add a new driver for ocp2scp

2012-06-25 Thread Arnd Bergmann
On Monday 25 June 2012, Felipe Balbi wrote: > > > Can't this live where the scp drivers live? Actually, where is that at? > > > Do we have scp drivers? > > AFAIK, there isn't any driver for scp. But we have a driver for ocp > > and it is present at arch/arm/mach-omap2/omap_l3_noc.c > > I don't th

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-25 Thread Vinod Koul
On Mon, 2012-06-25 at 11:51 -0500, Jon Hunter wrote: > Hi Russell, > > On 06/22/2012 06:12 PM, Russell King - ARM Linux wrote: > > Before this goes much further... one fairly obvious and important point > > must be made. > > > > You're designing an API here. You're designing it *WITHOUT* involvi

Re: [PATCH v5 1/7] ARM: davinci, cp_intc: Add irq domain support

2012-06-25 Thread Sekhar Nori
Hi Heiko, On 5/30/2012 3:48 PM, Heiko Schocher wrote: > Signed-off-by: Heiko Schocher > Cc: davinci-linux-open-sou...@linux.davincidsp.com > Cc: linux-arm-ker...@lists.infradead.org > Cc: devicetree-discuss@lists.ozlabs.org > Cc: Grant Likely > Cc: Sekhar Nori > Cc: Wolfgang Denk > Cc: Sergei

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-25 Thread Jon Hunter
Hi Russell, On 06/22/2012 06:12 PM, Russell King - ARM Linux wrote: > Before this goes much further... one fairly obvious and important point > must be made. > > You're designing an API here. You're designing it *WITHOUT* involving > the two most important people in its design that there are. T

Re: [PATCH] mtd/m25p80: add device tree probe support

2012-06-25 Thread Marek Vasut
Dear Shawn Guo, > On Mon, Jun 25, 2012 at 06:01:22PM +0200, Marek Vasut wrote: > > Dear Shawn Guo, > > > > > On Sat, Jun 23, 2012 at 04:15:18AM +0200, Marek Vasut wrote: > > > > So is there any particular reason why this wasn't applied? > > > > > > Let me remind Artem by resending the patch tomo

Re: [PATCH v6 00/14] add imx usb driver based on Greg next tree

2012-06-25 Thread Fabio Estevam
Hi Richard/Shawn, On Thu, Jun 21, 2012 at 3:41 AM, Richard Zhao wrote: > The work is based on  ci13xxx rework done by Alexander Shishkin. > > To let Greg pick up, I also added patches Alex queued that I depends on. > Patch #1 - #9 : It can also be found at > http://github.com/virtuoso/linux-ci.gi

Re: [PATCH] mtd/m25p80: add device tree probe support

2012-06-25 Thread Shawn Guo
On Mon, Jun 25, 2012 at 06:01:22PM +0200, Marek Vasut wrote: > Dear Shawn Guo, > > > On Sat, Jun 23, 2012 at 04:15:18AM +0200, Marek Vasut wrote: > > > So is there any particular reason why this wasn't applied? > > > > Let me remind Artem by resending the patch tomorrow. > > Actually ... the SPI

Re: [PATCH] mtd/m25p80: add device tree probe support

2012-06-25 Thread Marek Vasut
Dear Shawn Guo, > On Sat, Jun 23, 2012 at 04:15:18AM +0200, Marek Vasut wrote: > > So is there any particular reason why this wasn't applied? > > Let me remind Artem by resending the patch tomorrow. Actually ... the SPI does have the heuristics to probe this chip without the patch. But there wa

Re: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios

2012-06-25 Thread Stephen Warren
On 06/21/2012 06:03 PM, Chen Peter-B29397 wrote: > >> >> That's a good point. We need those properties to be part of the device >> that controls the port/slot/connector, not the thing that plugs into it. >> Having each such binding and driver implement this themselves might not >> be a good idea

Re: [PATCH] mtd/m25p80: add device tree probe support

2012-06-25 Thread Shawn Guo
On Sat, Jun 23, 2012 at 04:15:18AM +0200, Marek Vasut wrote: > So is there any particular reason why this wasn't applied? > Let me remind Artem by resending the patch tomorrow. -- Regards, Shawn ___ devicetree-discuss mailing list devicetree-discuss@l

Re: [PATCH] input: gpio_keys: Cleanup devicetree parser

2012-06-25 Thread Rob Herring
On 06/25/2012 10:17 AM, Alexandre Pereira da Silva wrote: > Fix sizeof in memset. > Cleanup dt properties extraction. > Use for_each macro. > Use of_match_ptr macro. > > Signed-off-by: Alexandre Pereira da Silva Acked-by: Rob Herring > --- > drivers/input/keyboard/gpio_keys.c | 30 +

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread Marek Vasut
Dear Felipe Balbi, > Hi, > > On Mon, Jun 25, 2012 at 03:55:22PM +0200, Marek Vasut wrote: > > Dear ABRAHAM, KISHON VIJAY, > > > > > Hi, > > > > > > On Mon, Jun 25, 2012 at 7:03 PM, Marek Vasut wrote: > > > > Dear ABRAHAM, KISHON VIJAY, > > > > > > > >> Hi, > > > >> > > > >> On Mon, Jun 25, 2

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread Felipe Balbi
Hi, On Mon, Jun 25, 2012 at 03:55:22PM +0200, Marek Vasut wrote: > Dear ABRAHAM, KISHON VIJAY, > > > Hi, > > > > On Mon, Jun 25, 2012 at 7:03 PM, Marek Vasut wrote: > > > Dear ABRAHAM, KISHON VIJAY, > > > > > >> Hi, > > >> > > >> On Mon, Jun 25, 2012 at 12:26 PM, Richard Zhao > > >> > > >>

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread Marek Vasut
Dear ABRAHAM, KISHON VIJAY, > Hi, > > On Mon, Jun 25, 2012 at 7:03 PM, Marek Vasut wrote: > > Dear ABRAHAM, KISHON VIJAY, > > > >> Hi, > >> > >> On Mon, Jun 25, 2012 at 12:26 PM, Richard Zhao > >> > >> wrote: > >> > From: Felipe Balbi > >> > > >> > allow this driver to be removed too. > >>

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jun 25, 2012 at 7:03 PM, Marek Vasut wrote: > Dear ABRAHAM, KISHON VIJAY, > >> Hi, >> >> On Mon, Jun 25, 2012 at 12:26 PM, Richard Zhao >> >> wrote: >> > From: Felipe Balbi >> > >> > allow this driver to be removed too. >> > >> > Signed-off-by: Felipe Balbi >> > Signed-off-by: Alex

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread Marek Vasut
Dear ABRAHAM, KISHON VIJAY, > Hi, > > On Mon, Jun 25, 2012 at 12:26 PM, Richard Zhao > > wrote: > > From: Felipe Balbi > > > > allow this driver to be removed too. > > > > Signed-off-by: Felipe Balbi > > Signed-off-by: Alexander Shishkin > > --- > > drivers/usb/chipidea/ci13xxx_msm.c |

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jun 25, 2012 at 12:26 PM, Richard Zhao wrote: > From: Felipe Balbi > > allow this driver to be removed too. > > Signed-off-by: Felipe Balbi > Signed-off-by: Alexander Shishkin > --- >  drivers/usb/chipidea/ci13xxx_msm.c |   20 ++-- >  1 file changed, 14 insertions(+

Re: [PATCH RESEND] input: gpio_keys_polled: convert to dt

2012-06-25 Thread Rob Herring
On 06/20/2012 06:34 AM, Alexandre Pereira da Silva wrote: > Add device tree support to gpio_keys_polled.c > > Signed-off-by: Alexandre Pereira da Silva > Tested-by: Roland Stigge > --- > drivers/input/keyboard/gpio_keys_polled.c | 121 > +++-- > 1 file changed, 113 ins

RE: [PATCH 1/3] regulator: tps65217: Add device tree support

2012-06-25 Thread AnilKumar, Chimata
Hi Mark, Thanks for quick reply. On Mon, Jun 25, 2012 at 17:42:20, Mark Brown wrote: > On Mon, Jun 25, 2012 at 05:34:36PM +0530, AnilKumar Ch wrote: > > This commit adds device tree support for tps65217 pmic. And usage > > details are added to device tree documentation. > > > > Driver is tested

Re: [RFC PATCH v2 1/2] drivers: misc: omap: add a new driver for ocp2scp

2012-06-25 Thread Felipe Balbi
Hi, On Mon, Jun 25, 2012 at 11:09:54AM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi Greg, > > On Sat, Jun 23, 2012 at 10:14 AM, Greg KH wrote: > > On Fri, Jun 22, 2012 at 06:45:41PM +0530, Kishon Vijay Abraham I wrote: > >> Adds a new driver _ocp2scp_. > > > > That's not what you called this driver

[PATCH 0/3] Add device tree support for AM33XX regulators

2012-06-25 Thread AnilKumar Ch
Add device tree support for regulators present on AM33XX family of devices like AM335X-EVM and AM335X-Bone. TPS65217 regulator is present on AM335X-Bone and TPS65910 on AM335X-EVM. First patch adds the device tree support to tps65217 regulator so that it will take the parameters from am335x-bone.d

[PATCH 2/3] ARM: OMAP2+: AM33XX: Add tps65217 device tree data

2012-06-25 Thread AnilKumar Ch
Add device tree data for tps65217 regulator by adding all the consumers necessary for AM335X-BeagleBone. The data will be map to a regulator constraints which is required for regulator set_voltage and get_voltage calls. All tps65217 PMIC regulator constraints are placed in a seperate device tree i

Re: [PATCH 1/3] regulator: tps65217: Add device tree support

2012-06-25 Thread Mark Brown
On Mon, Jun 25, 2012 at 05:34:36PM +0530, AnilKumar Ch wrote: > This commit adds device tree support for tps65217 pmic. And usage > details are added to device tree documentation. > > Driver is tested by using kernel module with regulator set and get > APIs. This needs to be updated for the patch

Re: [PATCH v7 14/14] usb: chipidea: add imx platform driver

2012-06-25 Thread Marc Kleine-Budde
On 06/25/2012 08:56 AM, Richard Zhao wrote: > This patch supports only the host-mode functionality so far. > > Signed-off-by: Richard Zhao > Signed-off-by: Marek Vasut > Cc: Peter Chen > Cc: Alexander Shishkin > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Tested-by: Subodh Nijsure > --- >

Re: [PATCH v7 08/14] USB: Chipidea: add ci13xxx device id management

2012-06-25 Thread Marc Kleine-Budde
On 06/25/2012 12:03 PM, Richard Zhao wrote: > Could you use my USB test branch? Same result: ci_hdrc ci_hdrc.0: remove, state 1 usb usb1: USB disconnect, device number 1 ci_hdrc ci_hdrc.0: USB bus 1 deregistered Unable to handle kernel NULL pointer dereference at virtual address 006c pgd = c

Re: [PATCH v7 08/14] USB: Chipidea: add ci13xxx device id management

2012-06-25 Thread Marc Kleine-Budde
On 06/25/2012 08:56 AM, Richard Zhao wrote: > We use ida_simple_get and ida_simple_remove to manage the ids. > > Signed-off-by: Richard Zhao > Reviewed-by: Felipe Balbi > Signed-off-by: Alexander Shishkin Removing the "ci13xxx_imx" module doesn't work as expected: ci_hdrc ci_hdrc.0: remove, s

[PATCH v7] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-25 Thread Roland Stigge
This patch adds a driver for the key scan interface of the LPC32xx SoC Signed-off-by: Roland Stigge --- Applies to v3.5-rc4 Changes since v6: * Clear IRQ in LPC32XX_KS_IRQ register in lpc32xx_kscan_{open,close} * Declare lpc32xx_parse_dt() static * Pass kscandat to lpc32xx_parse_dt() instead of

Re: [PATCH v6] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-25 Thread Roland Stigge
Hi Dmitry! On 06/25/2012 09:06 AM, Dmitry Torokhov wrote: > On Sun, Jun 24, 2012 at 04:44:38PM +0200, Roland Stigge wrote: >> This patch adds a driver for the key scan interface of the LPC32xx SoC >> >> Signed-off-by: Roland Stigge >> > > This looks _very_ good, I just have a couple more comment

Re: [PATCH RESEND] input: gpio_keys_polled: convert to dt

2012-06-25 Thread Dmitry Torokhov
On Thu, Jun 21, 2012 at 08:37:18AM -0300, Alexandre Pereira da Silva wrote: > On Thu, Jun 21, 2012 at 6:18 AM, Dmitry Torokhov > wrote: > >> @@ -38,7 +40,7 @@ struct gpio_keys_button_data { > >>  struct gpio_keys_polled_dev { > >>       struct input_polled_dev *poll_dev; > >>       struct device *

Re: [PATCH v6] input: keyboard: Add keys driver for the LPC32xx SoC

2012-06-25 Thread Dmitry Torokhov
HI Roland, On Sun, Jun 24, 2012 at 04:44:38PM +0200, Roland Stigge wrote: > This patch adds a driver for the key scan interface of the LPC32xx SoC > > Signed-off-by: Roland Stigge > This looks _very_ good, I just have a couple more comments: > + > +static int lpc32xx_kscan_open(struct input_d

[PATCH v7 14/14] usb: chipidea: add imx platform driver

2012-06-25 Thread Richard Zhao
This patch supports only the host-mode functionality so far. Signed-off-by: Richard Zhao Signed-off-by: Marek Vasut Cc: Peter Chen Cc: Alexander Shishkin Cc: Felipe Balbi Cc: Greg Kroah-Hartman Tested-by: Subodh Nijsure --- .../devicetree/bindings/usb/ci13xxx-imx.txt| 20 ++ driv

[PATCH v7 13/14] usb: otg: add basic mxs phy driver support

2012-06-25 Thread Richard Zhao
mxs phy is used in Freescale i.MX SoCs, for example imx23, imx28, imx6Q. This patch adds the basic host support. Signed-off-by: Richard Zhao Signed-off-by: Marek Vasut Cc: Peter Chen Acked-by: Felipe Balbi Tested-by: Subodh Nijsure --- Documentation/devicetree/bindings/usb/mxs-phy.txt | 13

[PATCH v7 12/14] usb: chipidea: permit driver bindings pass phy pointer

2012-06-25 Thread Richard Zhao
Sometimes, the driver bindings may know what phy they use. For example, when using device tree, the usb controller may have a phandler pointing to usb phy. Signed-off-by: Richard Zhao Reviewed-by: Marek Vasut Acked-by: Felipe Balbi Tested-by: Subodh Nijsure --- drivers/usb/chipidea/ci.h|

[PATCH v7 11/14] USB: notify phy when root hub port connect change

2012-06-25 Thread Richard Zhao
Phy may need to change settings when port connect change. Signed-off-by: Richard Zhao Tested-by: Subodh Nijsure --- drivers/usb/core/hub.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 25a7422..6ecfb5e 100644 --- a/drivers/u

[PATCH v7 10/14] usb: otg: add notify_connect/notify_disconnect callback

2012-06-25 Thread Richard Zhao
This let usb phy driver has a chance to change hw settings when connect status change. Signed-off-by: Richard Zhao Acked-by: Felipe Balbi Tested-by: Subodh Nijsure --- include/linux/usb/otg.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/linux/usb/otg.h b

[PATCH v7 09/14] usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig

2012-06-25 Thread Richard Zhao
ci13xxx host needs Root Hub Transaction Translators. Reported-by: Shawn Guo Signed-off-by: Richard Zhao Acked-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/c