Re: [PATCH v2 07/19] tegra: fdt: Add LCD definitions for Tegra

On Wed, Jul 11, 2012 at 06:44:10AM +0200, Simon Glass wrote: > Hi Stephen, > > On Fri, Jun 15, 2012 at 1:32 AM, Stephen Warren wrote: > > > On 06/13/2012 10:19 AM, Simon Glass wrote: > > > Add LCD definitions and also a proposed binding for LCD displays. > > > > > > The PWFM is in progress on the

Re: [PATCH v3] PWM: add lpc32xx PWM support

On Tue, Jul 10, 2012 at 11:38:10AM -0300, Alexandre Pereira da Silva wrote: > Add lpc32xx SOC PWM driver. > > Signed-off-by: Alexandre Pereira da Silva > --- > Changes since v2: > * Update commit message > * Change the driver to handle the two PWM's of the SOC > * Disable clock on removal > > Ch

Re: [PATCH v2 03/19] fdt: Add function to look up a phandle's register address

Hi Stephen, On Fri, Jun 15, 2012 at 1:17 AM, Stephen Warren wrote: > On 06/13/2012 10:19 AM, Simon Glass wrote: > > This is a commonly-used requirement, so add a function to support it > > easily. > > Uggh. Why would this ever be needed; shouldn't the driver for the node > referenced by the phand

Re: [PATCH v2 07/19] tegra: fdt: Add LCD definitions for Tegra

Hi Stephen, On Fri, Jun 15, 2012 at 1:32 AM, Stephen Warren wrote: > On 06/13/2012 10:19 AM, Simon Glass wrote: > > Add LCD definitions and also a proposed binding for LCD displays. > > > > The PWFM is in progress on the device-tree-discuss list, so only a > > very basic binding is offered here.

Re: [PATCH 1/5] fdtput: Fix nit in help message

On Tue, Jul 10, 2012 at 05:56:44AM -0700, Simon Glass wrote: > There was an extra < in the help message, so fix it. > > Signed-off-by: Simon Glass Acked-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist,

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

On Tue, Jul 10, 2012 at 11:07:14AM -0400, Alan Stern wrote: > On Tue, 10 Jul 2012, Richard Zhao wrote: > > > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > > Phy may need to change settings when port connect change. > > > > > > Signed-off-by: Richard Zhao > > > Tested-by: Subo

Re: [PATCH 1/1] of: introduce helper to manage boolean

On 07/10/2012 05:53 PM, Simon Glass wrote: > Hi Scott, > > On Tue, Jul 10, 2012 at 11:23 PM, Scott Wood > wrote: > > Also note that even non-boolean properties can mean something different > when absent. Sometimes this is a default value; sometimes, like

Re: [PATCH 1/1] of: introduce helper to manage boolean

Hi Scott, On Tue, Jul 10, 2012 at 11:23 PM, Scott Wood wrote: > On 07/10/2012 07:10 AM, Simon Glass wrote: > > Hi, > > > > On Tue, Mar 13, 2012 at 5:16 AM, Grant Likely > > wrote: > > > > On Tue, 13 Mar 2012 04:17:39 +0100, Jean-Christophe PLAGNIOL-VILLARD >

Re: [PATCH 1/1] of: introduce helper to manage boolean

On 07/10/2012 07:10 AM, Simon Glass wrote: > Hi, > > On Tue, Mar 13, 2012 at 5:16 AM, Grant Likely > wrote: > > On Tue, 13 Mar 2012 04:17:39 +0100, Jean-Christophe PLAGNIOL-VILLARD > mailto:plagn...@jcrosoft.com>> wrote: > > On 14:39 Mon 12 Mar ,

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

Hi Roland, On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: > This patch adds a driver for the key scan interface of the LPC32xx SoC > Could of more things that I had in my patch but forgot to specifically call out: > + > + /* Configure the key scanner */ > + clk_prepare_e

[PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

This patch adds a driver for the key scan interface of the LPC32xx SoC Signed-off-by: Roland Stigge --- Applies to v3.5-rc6 Changes since v8: * Optimized lpc32xx_mod_states() to shift "changed" word and break on 0 * lpc32xx_parse_dt(): Return -EINVAL instead of -ENXIO * kfree() of keymap _after

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

Hi Dmitry, On 10/07/12 18:41, Dmitry Torokhov wrote: > Ah, right, I meant to change that too ;) > > Could you please try this one for me (instead of the previous one)? Same problem (you actually sent the same patch). I'm posting an updated version considering all your suggestions from your last

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

On 10 July 2012 22:27, Mark Brown wrote: > On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > >> In non-dt case, the platform code supplying the gpio number (slave >> select line) is responsible for requesting the gpio during the >> machine_init call. So the gpio request is not call

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > In non-dt case, the platform code supplying the gpio number (slave > select line) is responsible for requesting the gpio during the > machine_init call. So the gpio request is not called in the driver for > that gpio. In dt case, th

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

On 10 July 2012 20:08, Mark Brown wrote: > On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree based discovery. Since a

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

On Tue, Jul 10, 2012 at 11:36:25AM +0200, Roland Stigge wrote: > Hi Dmitry! > > On 07/10/2012 08:36 AM, Dmitry Torokhov wrote: > >> +static void lpc32xx_mod_states(struct lpc32xx_kscan_drv *kscandat, int > >> col) > >> +{ > >> + u8 key; > >> + int row; > >> + unsigned changed, scancode, keycod

Re: bisected regression since 3.5-rc5 - hang on boot on some sparc64 machines

On 07/10/2012 06:09 AM, Meelis Roos wrote: > A regression since 3.5-rc5 stops Sun Fire V100 and Sun Netra X1 sparc64 > machines from booting, hanging after enabling serial console. Several > different other sparc64 systems work fine with 3.5-rc6. prtconf and full > dmesg below. > > Bisecting le

Re: [PATCH v3] PWM: add lpc32xx PWM support

On 07/10/2012 04:38 PM, Alexandre Pereira da Silva wrote: > Add lpc32xx SOC PWM driver. > > Signed-off-by: Alexandre Pereira da Silva Acked-by: Roland Stigge > --- > Changes since v2: > * Update commit message > * Change the driver to handle the two PWM's of the SOC > * Disable clock on remova

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

On Tue, 10 Jul 2012, Richard Zhao wrote: > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > Phy may need to change settings when port connect change. > > > > Signed-off-by: Richard Zhao > > Tested-by: Subodh Nijsure > > --- > > drivers/usb/core/hub.c |8 > > 1 fil

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the sl

[PATCH v4 6/6] spi: s3c64xx: add device tree support

Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 277 +--- 2 files changed, 358 in

[PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a

[PATCH v4 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

With the spi controller hardware configuration moved into the driver data, there are no more default hardware configuration data that is passed through platform data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to these changes. Signed-off-by: Thomas Abraham Acked-by: J

[PATCH v4 3/6] ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions

The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this paremeter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/setup-spi.c |8 +++- arch/arm/ma

[PATCH v4 2/6] spi: s3c64xx: move controller information into driver data

Platform data is used to specify controller hardware specific information such as the tx/rx fifo level mask and bit offset of rx fifo level. Such information is not suitable to be supplied from device tree. Instead, it can be moved into the driver data and removed from platform data. Signed-off-by

[PATCH v4 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi

[PATCH v4 0/6] spi: s3c64xx: add support for device tree

Changes since v3: - Fixed the build breakage after applying 3rd patch in this series (which had dependency on the 6th patch). This was reported by Doug Anderson. Changes since v2: - Removed renaming of platform device name at runtime - Includes other minor fixes suggested by Olof, Grant, Kukjin

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

On Tue, 10 Jul 2012, Richard Zhao wrote: > > > @@ -4037,6 +4038,13 @@ static void hub_port_connect_change(struct usb_hub > > > *hub, int port1, > > > } > > > } > > > > > > + if (unlikely(hcd->phy && !hdev->parent)) { > > > > Why is this "unlikely"? And why mark it as such, is this

Re: [PATCH v4 0/5] ARM: topology: set the capacity of each cores for big.LITTLE

On Tue, 2012-07-10 at 14:35 +0200, Vincent Guittot wrote: > > May be the last one which enable ARCH_POWER should also go into tip ? > OK, I can take it. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/lis

[PATCH 5/5] fdtput: Add -p option to create subnodes along entire path

This option mimics mkdir's -p option. It automatically creates nodes as needed along the path provided. If the node already exists, no error is given. Signed-off-by: Simon Glass --- fdtput.c | 59 --- tests/run_tests.sh | 13 +

[PATCH 3/5] fdtput: Add -c option to create nodes

This option allows the creation of new nodes in a dtb file. The syntax is: fdtput -c The node_path contains the path of the node to be created. All path components up to the final one must exist already. The final one must not exist already. Signed-off-by: Simon Glass --- fdtput.c

[PATCH 4/5] fdtput: Adjust report_error() to use name, namelen params

As with many fdt functions, report_error() should permit a namelen to be specified, thus obviating the need for nul termination in strings passed to it. Signed-off-by: Simon Glass --- fdtput.c | 25 ++--- 1 files changed, 18 insertions(+), 7 deletions(-) diff --git a/fdtpu

[PATCH 2/5] fdtput: Prepare to support multiple operations

We want to add new options to this tool. In preparation for this, add the concept of a current operation. Signed-off-by: Simon Glass --- fdtput.c | 37 ++--- 1 files changed, 26 insertions(+), 11 deletions(-) diff --git a/fdtput.c b/fdtput.c index 244d1f1..eceb

[PATCH 1/5] fdtput: Fix nit in help message

There was an extra < in the help message, so fix it. Signed-off-by: Simon Glass --- fdtput.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fdtput.c b/fdtput.c index f6ebd24..244d1f1 100644 --- a/fdtput.c +++ b/fdtput.c @@ -162,7 +162,7 @@ static const char *usage_msg

Re: [PATCH v2] pwm: add lpc32xx pwm support

Hi! On 07/10/2012 01:53 PM, Alexandre Pereira da Silva wrote: > Add lpc32xx soc pwm driver. > > Signed-off-by: Alexandre Pereira da Silva > --- > +++ b/drivers/pwm/pwm-lpc32xx.c > @@ -0,0 +1,150 @@ > +/* > + * Copyright 2012 Alexandre Pereira da Silva > + * > + * The code contained herein is li

Re: [RFC PATCH] dtc: integrate gpp

Hi Stephen, On Thu, Jul 5, 2012 at 8:17 AM, Jean-Christophe PLAGNIOL-VILLARD < plagn...@jcrosoft.com> wrote: > On 14:12 Tue 03 Jul , Stephen Warren wrote: > > On 06/27/2012 03:41 PM, Stephen Warren wrote: > > > On 06/15/2012 12:53 PM, Stephen Warren wrote: > > >> From: Stephen Warren > > >>

Re: bootloader support for DTB on x86

On Tue, Jul 10, 2012 at 02:27:26PM +0200, Simon Glass wrote: > Hi, > > On Tue, May 22, 2012 at 2:56 PM, Thierry Reding < > thierry.red...@avionic-design.de> wrote: > > > Hi, > > > > I was looking at booting an x86-based platform using DT. However I wasn't > > able to find a bootloader that suppor

Re: [PATCH v4 0/5] ARM: topology: set the capacity of each cores for big.LITTLE

On 10 July 2012 13:27, Peter Zijlstra wrote: > On Mon, 2012-07-09 at 11:27 +0200, Vincent Guittot wrote: >> This patchset creates an arch_scale_freq_power function for ARM, which is >> used >> to set the relative capacity of each core of a big.LITTLE system. It also >> removes >> the broken powe

Re: bootloader support for DTB on x86

Hi, On Tue, May 22, 2012 at 2:56 PM, Thierry Reding < thierry.red...@avionic-design.de> wrote: > Hi, > > I was looking at booting an x86-based platform using DT. However I wasn't > able to find a bootloader that supports this. There also doesn't seem to > be a > method to append the DTB to the zI

Re: [PATCH v2] pwm: add lpc32xx pwm support

On Tue, Jul 10, 2012 at 08:53:32AM -0300, Alexandre Pereira da Silva wrote: > Add lpc32xx soc pwm driver. The subject and this still need fixing (soc -> SOC, pwm -> PWM). > Signed-off-by: Alexandre Pereira da Silva > --- > Changes since v1: > * Style fixes > * Better error handling > * Improved

Re: [PATCH 1/1] of: introduce helper to manage boolean

Hi, On Tue, Mar 13, 2012 at 5:16 AM, Grant Likely wrote: > On Tue, 13 Mar 2012 04:17:39 +0100, Jean-Christophe PLAGNIOL-VILLARD < > plagn...@jcrosoft.com> wrote: > > On 14:39 Mon 12 Mar , Scott Wood wrote: > > > On 03/09/2012 10:36 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > Ugh.

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

Dear Richard Zhao, [...] > > > --- a/drivers/usb/core/hub.c > > > +++ b/drivers/usb/core/hub.c > > > @@ -1924,6 +1924,11 @@ void usb_disconnect(struct usb_device **pdev) > > > > > >*/ > > > > > > device_del(&udev->dev); > > > > > > + if (udev->parent && !udev->parent->parent) { > > > +

Re: [PATCH v4 0/5] ARM: topology: set the capacity of each cores for big.LITTLE

On Mon, 2012-07-09 at 11:27 +0200, Vincent Guittot wrote: > This patchset creates an arch_scale_freq_power function for ARM, which is > used > to set the relative capacity of each core of a big.LITTLE system. It also > removes > the broken power estimation of x86. > > Modification since v3: >

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

On Tue, Jul 10, 2012 at 05:22:20AM +0200, Marek Vasut wrote: > Dear Richard Zhao, > > > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > > Phy may need to change settings when port connect change. > > > > > > Signed-off-by: Richard Zhao > > > Tested-by: Subodh Nijsure > > > ---

[PATCH v2 1/3] regulator: tps65217: Add device tree support

This commit adds device tree support for tps65217 pmic. And usage details are added to device tree documentation. Driver is tested by using kernel module with regulator set and get APIs. Signed-off-by: AnilKumar Ch --- .../devicetree/bindings/regulator/tps65217.txt | 91 +++

[PATCH v2 2/3] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

Add device tree data for tps65910 regulator by adding all the consumers necessary for AM335X-EVM. The data will be map to a regulator constraints which is required for regulator set_voltage and get_voltage calls. All tps65910 PMIC regulator constraints are placed in a seperate device tree include

[PATCH v2 0/3] Add device tree support for AM33XX regulators

Add device tree support for regulators present on AM33XX family of devices like AM335X-EVM and AM335X-Bone. TPS65217 regulator is present on AM335X-Bone and TPS65910 on AM335X-EVM. First patch adds the device tree support to tps65217 regulator so that it will take the parameters from tps65217.dtsi

[PATCH v2 3/3] ARM: OMAP2+: AM33XX: Add tps65217 device tree data

Add device tree data for tps65217 regulator by adding all the consumers necessary for AM335X-BeagleBone. The data will be map to a regulator constraints which is required for regulator set_voltage and get_voltage calls. All tps65217 PMIC regulator constraints are placed in a seperate device tree i

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

Hi Dmitry! On 07/10/2012 08:36 AM, Dmitry Torokhov wrote: >> +static void lpc32xx_mod_states(struct lpc32xx_kscan_drv *kscandat, int col) >> +{ >> +u8 key; >> +int row; >> +unsigned changed, scancode, keycode; >> + >> +key = readl(LPC32XX_KS_DATA(kscandat->kscan_base, col)); >> +

Re: [PATCH] pinctrl: Add one-register-per-pin type device tree based pinctrl driver

* Tony Lindgren [120627 03:37]: > * Stephen Warren [120626 10:10]: > > On 06/26/2012 07:43 AM, Tony Lindgren wrote: > > ... > > > Subject: [PATCH] pinctrl: Add one-register-per-pin type device tree based > > > pinctrl driver > > > > > > Add one-register-per-pin type device tree based pinctrl dr

Re: [PATCH] ARM: davinci: cp_intc: Add OF support for TI interrupt controller

Hi Rob, On 7/6/2012 10:23 PM, Sekhar Nori wrote: > Hi Grant, > > On 7/5/2012 6:13 PM, Heiko Schocher wrote: >> Hello Sekhar, >> >> On 03.07.2012 21:16, Sekhar Nori wrote: >>> From: Heiko Schocher >>> >>> Add a function to initialize the Common Platform Interrupt Controller >>> (cp_intc) from TI u

Re: [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

On Tuesday 10 July 2012 01:46 PM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Jul 10, 2012 at 11:59 AM, Rajendra Nayak wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap

Re: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data

On Tuesday 10 July 2012 01:43 PM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Jul 10, 2012 at 11:57 AM, Rajendra Nayak wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting

Re: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data

Hi, On Tue, Jul 10, 2012 at 11:57 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add usb otg data node in omap4/omap3 device tree file. Also update >> the node with board specific setting in omapx-.dts file. >> >> Signed-off-by: Kishon Vijay Abr

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

Hi, On Tue, Jul 10, 2012 at 12:14 PM, Rajendra Nayak wrote: > On Tuesday 10 July 2012 11:58 AM, ABRAHAM, KISHON VIJAY wrote: >> >> Hi, >> >> On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote: >>> >>> On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device

Re: [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

Hi, On Tue, Jul 10, 2012 at 11:59 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> All the unnessary functions in omap-phy-internal is removed. >> These functionality are now handled by omap-usb2 phy driver. >> >> Cc: Felipe Balbi >> Signed-off-by

Re: [PATCH] pwm: add lpc32xx pwm support

On Tue, Jul 10, 2012 at 09:56:08AM +0200, Roland Stigge wrote: > Hi, > > On 07/10/2012 08:48 AM, Thierry Reding wrote: > >> --- /dev/null +++ > >> b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt @@ -0,0 > >> +1,12 @@ +LPC32XX PWM controller + +Required properties: +- > >> compatible: shoul

Re: [PATCH] pwm: add lpc32xx pwm support

Hi, On 07/10/2012 08:48 AM, Thierry Reding wrote: >> --- /dev/null +++ >> b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt @@ -0,0 >> +1,12 @@ +LPC32XX PWM controller + +Required properties: +- >> compatible: should be "nxp,lpc3220-pwm" > > Does the compatible have to be lpc3220-pwm? Can't

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

On Tuesday 10 July 2012 12:18 PM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu wrote: + +#ifdef CONFIG_PM Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? Why? I think we should have CONFIG_PM_SLEEP only when we have *suspend*, *resume* hoo

Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

On Tuesday 10 July 2012 12:22 PM, ABRAHAM, KISHON VIJAY wrote: +TWL4030 USB PHY AND COMPARATOR >> + - compatible : Should be "ti,twl4030-usb" >> + - interrupts : The interrupt numbers to the cpu should be specified. >> First >> + interrupt number is the otg interrupt number that raises ID i