Re: Where to put a large bootloader-supplied device tree on ARM ?

2012-07-11 Thread Mitch Bradley
On 7/8/2012 6:30 PM, Nicolas Pitre wrote: > On Fri, 6 Jul 2012, Mitch Bradley wrote: > >> On 7/6/2012 3:23 PM, David VomLehn (dvomlehn) wrote: >>> The kernel *must* go where it is linked, but the FDT contains only relative >>> references and is thus free to go anywhere. The same is true of ramdisk

Re: [PATCH 1/1] of: introduce helper to manage boolean

2012-07-11 Thread Simon Glass
Hi Scott, On Wed, Jul 11, 2012 at 1:11 AM, Scott Wood wrote: > On 07/10/2012 05:53 PM, Simon Glass wrote: >> Hi Scott, >> >> On Tue, Jul 10, 2012 at 11:23 PM, Scott Wood > > wrote: >> >> Also note that even non-boolean properties can mean something different >>

Re: [PATCH V3 5/6] Avoid duplicate probe for of platform devices

2012-07-11 Thread Grant Likely
On Mon, 9 Jul 2012 07:58:31 -0700, Greg KH wrote: > On Mon, Jul 09, 2012 at 03:46:59AM +, Li Yang-R58472 wrote: > > > > I don't understand, why is this just showing up now? What changed to > > > > cause this? Couldn't that be the real problem here? > > > > > > > > > > The issue is showing u

Re: [PATCH] devicetree: add helper inline for retrieving a node's full name

2012-07-11 Thread Grant Likely
On Thu, 05 Jul 2012 11:07:31 -0500, Rob Herring wrote: > Grant, > > On 06/15/2012 12:50 PM, Grant Likely wrote: > > The pattern (np ? np->full_name : "") is rather common in the > > kernel, but can also make for quite long lines. This patch adds a new > > inline function, of_node_full_name() so

Re: [PATCH 4/4] gpio/pca953x: register the device irq using appropriate api's

2012-07-11 Thread Linus Walleij
On Tue, Jul 10, 2012 at 3:36 PM, Chandrabhanu Mahapatra wrote: > From: Leed Aguilar > > Here, the implementation of registration of requested IRQs has been corrected > with appropiate api's. The gpio number is requested through gpio_request_one() > API and conversion of the gpio to irq is done u

Re: [PATCH 3/4] OMAP: Define TCA6424 max number of possible IRQs

2012-07-11 Thread Linus Walleij
On Tue, Jul 10, 2012 at 3:36 PM, Chandrabhanu Mahapatra wrote: > From: Leed Aguilar > > TCA6424 being a 24 bit I2C and SMBus I/O expander has 24 available GPIO lines > that can be used as IRQs lines. So, the support for 24 more IRQ lines has been > added to the kernel. > > Change-Id: I22e4fbb3a1e

Re: [PATCH 2/4] gpio/pca953x: increase variables size to support 24 bit of data

2012-07-11 Thread Linus Walleij
On Tue, Jul 10, 2012 at 3:35 PM, Chandrabhanu Mahapatra wrote: > From: Leed Aguilar > > Increase variable size from u16 to u32 to allocate 24 bit of data required for > the TCA6424 I/O expander device type. > > Signed-off-by: Leed Aguilar > Signed-off-by: Chandrabhanu Mahapatra Looks good. A

Re: [PATCH 1/4] GPIO: PCA953X: Increase size of invert variable to support 24 bit

2012-07-11 Thread Linus Walleij
On Tue, Jul 10, 2012 at 3:35 PM, Chandrabhanu Mahapatra wrote: > TCA6424 is a low voltage 24 bit I2C and SMBus I/O expander of pca953x family > similar to its 16 bit predecessor TCA6416. It comes with three 8-bit active > Input, Output, Polarity Inversion and Configuration registers each. The >

Re: [PATCH v2] of: Add videomode helper

2012-07-11 Thread Guennadi Liakhovetski
On Wed, 11 Jul 2012, Sascha Hauer wrote: > Hi Guennadi, > > On Wed, Jul 11, 2012 at 10:34:54AM +0200, Guennadi Liakhovetski wrote: > > Hi Sascha > > > > > + > > > +Optional properties: > > > + - width-mm, height-mm: Display dimensions in mm > > > + - hsync-active-high (bool): Hsync pulse is acti

Re: [PATCH v2] of: Add videomode helper

2012-07-11 Thread Sascha Hauer
Hi Guennadi, On Wed, Jul 11, 2012 at 10:34:54AM +0200, Guennadi Liakhovetski wrote: > Hi Sascha > > > + > > +Optional properties: > > + - width-mm, height-mm: Display dimensions in mm > > + - hsync-active-high (bool): Hsync pulse is active high > > + - vsync-active-high (bool): Vsync pulse is act

Re: [PATCH 2/2] ARM: EXYNOS5: Add gscalar device from DT

2012-07-11 Thread Sylwester Nawrocki
Hi Shaik, On 07/11/2012 03:06 PM, AMEER BASHA SHAIK wrote: >>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >>> b/arch/arm/boot/dts/exynos5250.dtsi >>> index 4272b29..b945c00 100644 >>> --- a/arch/arm/boot/dts/exynos5250.dtsi >>> +++ b/arch/arm/boot/dts/exynos5250.dtsi >>> @@ -23,6 +23,13 @@ >>>

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-11 Thread Thomas Abraham
On 11 July 2012 23:19, Mark Brown wrote: > On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote: >> Changes since v4: >> - Includes the missing gpio request for slave select line gpio as suggested >> by Mark Brown. > > These looked OK (and have had quite a bit of review already so we'r

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote: > Changes since v4: > - Includes the missing gpio request for slave select line gpio as suggested > by Mark Brown. These looked OK (and have had quite a bit of review already so we're probably at the stage where incremental fixes ar

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
On 11 July 2012 19:01, Mark Brown wrote: > On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote: > >> Based on your comments to add the gpio request, only two patches 5/6 >> and 6/6 in this series have changed since. I have cc'ed you in the >> other 4 patches as well. If you do not have

[PATCH v5 6/6] spi: s3c64xx: add device tree support

2012-07-11 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 305 +--- 2 files changed, 378 in

[PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a

[PATCH v5 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-07-11 Thread Thomas Abraham
With the spi controller hardware configuration moved into the driver data, there are no more default hardware configuration data that is passed through platform data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to these changes. Signed-off-by: Thomas Abraham Acked-by: J

[PATCH v5 3/6] ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions

2012-07-11 Thread Thomas Abraham
The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this parameter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/setup-spi.c |8 +++- arch/arm/ma

[PATCH v5 2/6] spi: s3c64xx: move controller information into driver data

2012-07-11 Thread Thomas Abraham
Platform data is used to specify controller hardware specific information such as the tx/rx fifo level mask and bit offset of rx fifo level. Such information is not suitable to be supplied from device tree. Instead, it can be moved into the driver data and removed from platform data. Signed-off-by

[PATCH v5 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-07-11 Thread Thomas Abraham
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi

[PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-11 Thread Thomas Abraham
Changes since v4: - Includes the missing gpio request for slave select line gpio as suggested by Mark Brown. Changes since v3: - Fixed the build breakage after applying 3rd patch in this series (which had dependency on the 6th patch). This was reported by Doug Anderson. Changes since v2: - Re

Re: [PATCH 1/5] fdtput: Fix nit in help message

2012-07-11 Thread Jon Loeliger
> On Tue, Jul 10, 2012 at 05:56:44AM -0700, Simon Glass wrote: > > There was an extra < in the help message, so fix it. > > > > Signed-off-by: Simon Glass > > Acked-by: David Gibson Applied. jdl ___ devicetree-discuss mailing list devicetree-discuss

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote: > Based on your comments to add the gpio request, only two patches 5/6 > and 6/6 in this series have changed since. I have cc'ed you in the > other 4 patches as well. If you do not have those patches, please let > me know, I will repo

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
On 11 July 2012 17:17, Mark Brown wrote: > On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree based discovery. Since a

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote: > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the sl

Re: [PATCH 1/2] pinctrl: pinctrl-imx: add support for set bits for general purpose registers

2012-07-11 Thread Dong Aisheng
On Wed, Jul 11, 2012 at 05:33:32PM +0800, Zhao Richard-B20223 wrote: > On Mon, Jul 09, 2012 at 03:10:21PM +0800, Dong Aisheng wrote: > > On Fri, Jul 06, 2012 at 11:52:49PM +0800, Stephen Warren wrote: > > > On 07/06/2012 03:09 AM, Dong Aisheng wrote: > > > > From: Dong Aisheng > > > > > > > > The

[PATCH v5 6/6] spi: s3c64xx: add device tree support

2012-07-11 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 +++ drivers/spi/spi-s3c64xx.c | 306 +--- 2 files changed, 379 ins

[PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a

Re: [PATCH 1/2] pinctrl: pinctrl-imx: add support for set bits for general purpose registers

2012-07-11 Thread Richard Zhao
On Mon, Jul 09, 2012 at 03:10:21PM +0800, Dong Aisheng wrote: > On Fri, Jul 06, 2012 at 11:52:49PM +0800, Stephen Warren wrote: > > On 07/06/2012 03:09 AM, Dong Aisheng wrote: > > > From: Dong Aisheng > > > > > > The General Purpose Registers (GPR) is used to select operating modes for > > > gene

Re: [PATCH v2] of: Add videomode helper

2012-07-11 Thread Guennadi Liakhovetski
Hi Sascha On Wed, 4 Jul 2012, Sascha Hauer wrote: > This patch adds a helper function for parsing videomodes from the devicetree. > The videomode can be either converted to a struct drm_display_mode or a > struct fb_videomode. > > Signed-off-by: Sascha Hauer > --- > > changes since v1: > - use

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-11 Thread Dmitry Torokhov
On Wed, Jul 11, 2012 at 09:49:04AM +0200, Roland Stigge wrote: > On 07/10/2012 10:55 PM, Dmitry Torokhov wrote: > > Hi Roland, > > > > On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: > >> This patch adds a driver for the key scan interface of the LPC32xx SoC > >> > > > > Could of m

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-11 Thread Roland Stigge
On 07/10/2012 10:55 PM, Dmitry Torokhov wrote: > Hi Roland, > > On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: >> This patch adds a driver for the key scan interface of the LPC32xx SoC >> > > Could of more things that I had in my patch but forgot to specifically > call out: > >>