Re: [PATCH 05/14] ARM: at91: add pinctrl support

2012-08-27 Thread Richard Genoud
2012/8/28 Linus Walleij : > I'm following it now I think, after some discussion here at the kernel summit > I have come to the conclusion that the real problem with readability comes > from a shortcoming in the device tree compiler, that it cannot handle > macros and defines (no preprocessor) so it

Re: [PATCH 2/2] arm/dts: Cleanup regulator naming and remove @0,1..

2012-08-27 Thread Rajendra Nayak
Hi Tony, * Rajendra Nayak [120730 06:17]: regulators do not have a 'reg' property, hence the regulator@0, regulator@1 do not make sense. get rid of it. Looks like this needs to be refreshed to apply. Care to refresh against current devel-dt branch in case other places need the same change?

Re: [PATCH v3 3/4] arm/dts: AM33XX: Configure pinmuxs for D_CAN1 on AM335x-EVM

2012-08-27 Thread Vaibhav Hiremath
On 8/25/2012 1:44 AM, Tony Lindgren wrote: > * AnilKumar Ch [120816 05:20]: >> Add D_CAN1 pinctrl node to am3358_pinmux master node to export >> D_CAN functionality on AM335x EVM according to pinctrl-single >> driver. >> >> Signed-off-by: AnilKumar Ch >> --- >> Changes from v2: >> - Incorp

Re: [PATCH v2 5/7] ARM: imx6q: convert to use syscon to access anatop registers

2012-08-27 Thread Dong Aisheng
On Tue, Aug 28, 2012 at 11:23:10AM +0800, Zhao Richard-B20223 wrote: ... > > np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop"); > np unused. Correct. Will drop it. Regards Dong Aisheng ___ devicetree-discuss mailing list devicetree-discu

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-27 Thread Thomas Abraham
On 28 August 2012 10:46, Jaehoon Chung wrote: > On 08/28/2012 02:10 PM, Thomas Abraham wrote: >> On 28 August 2012 10:40, Thomas Abraham wrote: >>> On 28 August 2012 10:25, Jaehoon Chung wrote: Hi Thomas, On 08/28/2012 01:48 PM, Thomas Abraham wrote: > On 27 August 2012 14:28,

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-27 Thread Thomas Abraham
On 28 August 2012 10:40, Thomas Abraham wrote: > On 28 August 2012 10:25, Jaehoon Chung wrote: >> Hi Thomas, >> >> On 08/28/2012 01:48 PM, Thomas Abraham wrote: >>> On 27 August 2012 14:28, Jaehoon Chung wrote: Hi Thomas, > + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); >>

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-27 Thread Thomas Abraham
On 28 August 2012 10:25, Jaehoon Chung wrote: > Hi Thomas, > > On 08/28/2012 01:48 PM, Thomas Abraham wrote: >> On 27 August 2012 14:28, Jaehoon Chung wrote: >>> Hi Thomas, >>> + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); + if (gpio_is_valid(gpio)) { + if

Re: [PATCH v4 0/9] mmc: dw_mmc: add support for device tree based instantiation

2012-08-27 Thread Thomas Abraham
On 27 August 2012 15:01, Will Newton wrote: > On Sun, Aug 26, 2012 at 12:51 PM, Thomas Abraham > wrote: >> This is the fourth version of the patch series that adds device tree support >> for Synopsis Designware Mobile Storage Host Controller. In this version, the >> significant change is the spli

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-27 Thread Thomas Abraham
On 27 August 2012 14:28, Jaehoon Chung wrote: > Hi Thomas, > >> + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); >> + if (gpio_is_valid(gpio)) { >> + if (devm_gpio_request(host->dev, gpio, "dw-mci-wp")) >> + dev_info(host->dev, "gpio [%d] request failed\n

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Thomas Abraham
On 27 August 2012 13:31, Heiko Stübner wrote: > Hi Thomas, > > thanks for your review: > > Am Montag, 27. August 2012, 06:20:49 schrieb Thomas Abraham: >> Hi Heiko, >> >> On 26 August 2012 03:23, Heiko Stübner wrote: >> > Until now the Exynos-SoC was the only Samsung-SoC supporting the GPIOs >> >

Re: [PATCH v2 5/7] ARM: imx6q: convert to use syscon to access anatop registers

2012-08-27 Thread Richard Zhao
On Mon, Aug 27, 2012 at 03:24:43PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Using syscon to access anatop registers. > > Signed-off-by: Dong Aisheng > --- > ChangeLog v1->v2: > * update to use generic regmap api > --- > arch/arm/mach-imx/Kconfig |2 +- > arch/arm/mach-imx/

Re: [PATCH v2 4/7] regulator: anatop-regulator: convert to use syscon to access anatop register

2012-08-27 Thread Dong Aisheng
On Tue, Aug 28, 2012 at 06:15:35AM +0800, Shawn Guo wrote: > > + sreg->anatop = syscon_regmap_lookup_by_phandle(np, "fsl,anatop"); > > + if (IS_ERR(sreg->anatop)) > > + return PTR_ERR(sreg->anatop); > > + > > All the anatop regulators are child nodes of anatop. It looks a littl

Re: [PATCH v2 1/7] mfd: add syscon driver based on regmap

2012-08-27 Thread Dong Aisheng
On Tue, Aug 28, 2012 at 06:08:32AM +0800, Shawn Guo wrote: > On Mon, Aug 27, 2012 at 03:24:39PM +0800, Dong Aisheng wrote: > > From: Dong Aisheng > > > > Add regmap based syscon driver. > > This is usually used for access misc bits in registers which does not belong > > to a specific module, for

Re: [PATCH 05/14] ARM: at91: add pinctrl support

2012-08-27 Thread Linus Walleij
On Sat, Aug 25, 2012 at 1:38 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 11:49 Thu 23 Aug , Stephen Warren wrote: >> On 08/23/2012 01:06 AM, Richard Genoud wrote: >> > Let's take the PioA - peripheral B: 0xffe0399f >> > From the documentation table 4-3, we can extract the column PIO >> >

Re: [PATCH v3 06/25] docs: Xen ARM DT bindings

2012-08-27 Thread Rob Herring
On 08/16/2012 10:35 AM, Stefano Stabellini wrote: > Add a doc to describe the Xen ARM device tree bindings > > Signed-off-by: Stefano Stabellini > CC: devicetree-discuss@lists.ozlabs.org > CC: David Vrabel > --- > Documentation/devicetree/bindings/arm/xen.txt | 22 ++ > 1

Re: [PATCH v2 4/7] regulator: anatop-regulator: convert to use syscon to access anatop register

2012-08-27 Thread Shawn Guo
On Mon, Aug 27, 2012 at 03:24:42PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Using syscon to access anatop register. > > Acked-by: Mark Brown > Signed-off-by: Dong Aisheng > --- > ChangeLog v1-v2: > * update to use generic regmap api > --- > arch/arm/boot/dts/imx6q.dtsi |

Re: [PATCH v2 1/7] mfd: add syscon driver based on regmap

2012-08-27 Thread Shawn Guo
On Mon, Aug 27, 2012 at 03:24:39PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Add regmap based syscon driver. > This is usually used for access misc bits in registers which does not belong > to a specific module, for example, IMX IOMUXC GPR and ANATOP. > With this driver, client can use

Re: [PATCH 03/11] pinctrl: mvebu: kirkwood pinctrl driver

2012-08-27 Thread Stephen Warren
On 08/27/2012 12:19 PM, Sebastian Hesselbarth wrote: > On 08/27/2012 03:43 PM, Ben Dooks wrote: >> On 20/08/2012 06:49, Linus Walleij wrote: >>> On Sat, Aug 11, 2012 at 2:56 PM, Sebastian Hesselbarth >>> wrote: >>> (...) diff --git a/drivers/pinctrl/pinctrl-kirkwood.c b/drivers/pinctrl/p

RE: [PATCH] ARM: AM33XX: clock: Add dcan clock aliases for device-tree

2012-08-27 Thread Hiremath, Vaibhav
On Tue, Aug 28, 2012 at 00:06:45, Paul Walmsley wrote: > On Mon, 27 Aug 2012, Hiremath, Vaibhav wrote: > > > On Mon, Aug 27, 2012 at 22:50:12, Paul Walmsley wrote: > > > > > Is the dcan driver present in v3.6-rc kernels? > > > > Multiple versions have been submitted already, I have validated us

RE: [PATCH] ARM: AM33XX: clock: Add dcan clock aliases for device-tree

2012-08-27 Thread Paul Walmsley
On Mon, 27 Aug 2012, Hiremath, Vaibhav wrote: > On Mon, Aug 27, 2012 at 22:50:12, Paul Walmsley wrote: > > > Is the dcan driver present in v3.6-rc kernels? > > Multiple versions have been submitted already, I have validated using them. > Irrespective of this, it is independent change and requir

RE: [PATCH] ARM: AM33XX: clock: Add dcan clock aliases for device-tree

2012-08-27 Thread Hiremath, Vaibhav
On Mon, Aug 27, 2012 at 22:50:12, Paul Walmsley wrote: > Hi > > On Mon, 27 Aug 2012, Vaibhav Hiremath wrote: > > > Currently, the device names for the dcan module follows the > > format "dcan.X", where 'X' is the dcan instance number. > > On other side, driver may request for clock with/without c

Re: [PATCH] ARM: AM33XX: clock: Add dcan clock aliases for device-tree

2012-08-27 Thread Paul Walmsley
Hi On Mon, 27 Aug 2012, Vaibhav Hiremath wrote: > Currently, the device names for the dcan module follows the > format "dcan.X", where 'X' is the dcan instance number. > On other side, driver may request for clock with/without con_id > and dev_id, and it is expected that platform should respect t

[PATCH 2/2] arm/dts: AM33XX: Specify reg and interrupt property for all nodes

2012-08-27 Thread Vaibhav Hiremath
The device/node resources (like, IORESOURCE_MEM and IORESOURCE_IRQ) are overwritten by hwmod resources, due to all known reasons but that should not be the reason for not providing all the information in the DTS blob. Ideally we should use DTS resource and use HWMOD framework wherever required and

[PATCH 1/2] arm/dts: AM33XX: Convert all hex numbers to lower-case

2012-08-27 Thread Vaibhav Hiremath
To make it consistent, convert all hex number presentation to lower-case from all am33xx specific nodes. Signed-off-by: Vaibhav Hiremath Cc: Tony Lindgren --- arch/arm/boot/dts/am335x-bone.dts |2 +- arch/arm/boot/dts/am335x-evm.dts |2 +- arch/arm/boot/dts/am33xx.dtsi | 20 +

[PATCH 0/2] arm/dts: AM33XX: Add reg and interrupt property for all nodes

2012-08-27 Thread Vaibhav Hiremath
This series is trivial patch-series and should be considered as preparation for the future where we supposed to get rid of hwmod dependency. 1/2: Converts all hex numbers to lowercase, fixing inconsistency 2/2: Add reg and interrupt property to all device/module nodes inside DTS files. Alt

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Heiko Stübner
Am Montag, 27. August 2012, 11:51:27 schrieb Vasily Khoruzhick: > On Mon, Aug 27, 2012 at 12:44 PM, Heiko Stübner wrote: > > Hi Vasily, > > > > I'm not sure I follow :-) . > > > > The compatible property here only sets the mechanism on how to handle the > > gpios defined in the devicetree - here

[PATCH] ARM: AM33XX: clock: Add dcan clock aliases for device-tree

2012-08-27 Thread Vaibhav Hiremath
Currently, the device names for the dcan module follows the format "dcan.X", where 'X' is the dcan instance number. On other side, driver may request for clock with/without con_id and dev_id, and it is expected that platform should respect this request and return the requested clock handle. Now, w

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Vasily Khoruzhick
On Mon, Aug 27, 2012 at 12:44 PM, Heiko Stübner wrote: > Hi Vasily, > > I'm not sure I follow :-) . > > The compatible property here only sets the mechanism on how to handle the > gpios defined in the devicetree - here to use the s3c24xx-style. As you can > see in gpio-samsung.c the handling is al

Re: [PATCH V3 0/2] video: drm: Add Device tree support to DRM-FIMD

2012-08-27 Thread Leela Krishna Amudala
Hello Mr. Inki Dae, Can you please review this patch set once. Best Wishes, Leela Krishna Amudala. On Thu, Aug 16, 2012 at 3:38 PM, Leela Krishna Amudala wrote: > > This patch set adds device tree support for DRM-FIMD for Samsung's > Exynos5250. > It includes parsing platform data from dts file.

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Heiko Stübner
Hi Vasily, Am Montag, 27. August 2012, 10:57:04 schrieb Vasily Khoruzhick: > Hi, > > On Mon, Aug 27, 2012 at 11:01 AM, Heiko Stübner wrote: > > Hi Thomas, > > > > thanks for your review: > > > > Hmmm, but the logic to drive the gpio controller is the same for all > > arches. The only differenc

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Vasily Khoruzhick
Hi, On Mon, Aug 27, 2012 at 11:01 AM, Heiko Stübner wrote: > Hi Thomas, > > thanks for your review: > > Hmmm, but the logic to drive the gpio controller is the same for all arches. > The only difference is the number to use for the different pull up/down > settings. So I think the "samsung,s3c24x

Re: [PATCH V3 2/2] video: drm: exynos: Add device tree support

2012-08-27 Thread Sascha Hauer
On Thu, Aug 16, 2012 at 03:38:09PM +0530, Leela Krishna Amudala wrote: > Add device tree based discovery support for DRM-FIMD driver. > > Signed-off-by: Leela Krishna Amudala > --- > Documentation/devicetree/bindings/fb/drm-fimd.txt | 80 + > drivers/gpu/drm/exynos/exynos_drm_f

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Heiko Stübner
Hi Thomas, thanks for your review: Am Montag, 27. August 2012, 06:20:49 schrieb Thomas Abraham: > Hi Heiko, > > On 26 August 2012 03:23, Heiko Stübner wrote: > > Until now the Exynos-SoC was the only Samsung-SoC supporting the GPIOs > > via the device tree. This patch implements dt-support for

[PATCH v2 5/7] ARM: imx6q: convert to use syscon to access anatop registers

2012-08-27 Thread Dong Aisheng
From: Dong Aisheng Using syscon to access anatop registers. Signed-off-by: Dong Aisheng --- ChangeLog v1->v2: * update to use generic regmap api --- arch/arm/mach-imx/Kconfig |2 +- arch/arm/mach-imx/mach-imx6q.c | 43 --- 2 files changed, 19 ins

[PATCH v2 7/7] mfd: anatop-mfd: remove anatop driver

2012-08-27 Thread Dong Aisheng
From: Dong Aisheng The anatop registers are accessed via syscon now, no one will use mfd anatop driver anymore, remove it. Signed-off-by: Dong Aisheng --- drivers/mfd/Kconfig|8 --- drivers/mfd/Makefile |1 - drivers/mfd/anatop-mfd.c | 124 -

[PATCH v2 6/7] ARM: dts: imx6q: add simple-bus compatible string for anatop

2012-08-27 Thread Dong Aisheng
From: Dong Aisheng Originally the anatop regulator devices are populated by mfd anatop driver. Since mfd anatop driver will be deleted later, we change to populate the regulator devices by devicetree automatically. This will cause some warning messages as follows during boot due to device recreat

[PATCH v2 4/7] regulator: anatop-regulator: convert to use syscon to access anatop register

2012-08-27 Thread Dong Aisheng
From: Dong Aisheng Using syscon to access anatop register. Acked-by: Mark Brown Signed-off-by: Dong Aisheng --- ChangeLog v1-v2: * update to use generic regmap api --- arch/arm/boot/dts/imx6q.dtsi |6 ++ drivers/regulator/Kconfig|2 +- drivers/regulator/anatop

[PATCH v2 3/7] ARM: imx6q: add anatop support into syscon

2012-08-27 Thread Dong Aisheng
From: Dong Aisheng There're a few anatop registers need to be accessed by different modules. Add anatop registers into syscon support for easy access. Signed-off-by: Dong Aisheng --- arch/arm/boot/dts/imx6q.dtsi |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/a

[PATCH v2 2/7] ARM: imx6q: add iomuxc gpr support into syscon

2012-08-27 Thread Dong Aisheng
From: Dong Aisheng Include headfile for easy using. Signed-off-by: Dong Aisheng --- arch/arm/boot/dts/imx6q.dtsi |5 + include/linux/fsl/imx6q-iomuxc-gpr.h | 319 ++ 2 files changed, 324 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/

[PATCH v2 1/7] mfd: add syscon driver based on regmap

2012-08-27 Thread Dong Aisheng
From: Dong Aisheng Add regmap based syscon driver. This is usually used for access misc bits in registers which does not belong to a specific module, for example, IMX IOMUXC GPR and ANATOP. With this driver, client can use generic regmap API to access registers which are registered into syscon.

[PATCH v2 0/7] add syscon driver based on regmap for general registers access

2012-08-27 Thread Dong Aisheng
This patch series mainly adds an syscon driver which is used to access general system controller registers like FSL IOMUXC GPR and ANATOP, after that, we convert all the exist private access general registers code to use standard API from regmap to access registers. Finally we remove the old mfd a

Re: [PATCH] DT: export of_irq_to_resource_table()

2012-08-27 Thread Rob Herring
On 08/26/2012 02:13 AM, John Crispin wrote: > Trivial patch that exports the of_irq_to_resource_table() symbol so that > modules can use it. > > Signed-off-by: John Crispin > --- Applied for 3.7 Rob > drivers/of/irq.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --gi