RE: [PATCH 5/5] of: Modify c_can binding documentation

2012-09-02 Thread AnilKumar, Chimata
Hi Stephen, Thanks for the review, On Sun, Sep 02, 2012 at 07:32:38, Stephen Warren wrote: > On 09/01/2012 12:05 AM, AnilKumar, Chimata wrote: > > On Fri, Aug 31, 2012 at 14:59:21, AnilKumar, Chimata wrote: > >> Modify c_can binding documentation according to recent review comments > >> on device

Re: [PATCH v4 1/7] mfd: add syscon driver based on regmap

2012-09-02 Thread Shawn Guo
On Mon, Sep 03, 2012 at 10:31:03AM +0800, Dong Aisheng wrote: > > > > I think of_node_put should be moved out from here and put into > > syscon_node_to_regmap and syscon_regmap_lookup_by_compatible. > > > I guess no, if you want to move of_node_put into > syscon_regmap_lookup_by_phandle, > then

Re: [PATCH v4 2/7] ARM: imx6q: add iomuxc gpr support into syscon

2012-09-02 Thread Dong Aisheng
On Fri, Aug 31, 2012 at 10:02:48AM +0800, Shawn Guo wrote: > On Wed, Aug 29, 2012 at 06:56:53PM +0800, Dong Aisheng wrote: > > From: Dong Aisheng > > > > Include headfile for easy using. > > > > Acked-by: Stephen Warren > > Signed-off-by: Dong Aisheng > > --- > > arch/arm/boot/dts/imx6q.dtsi

Re: [PATCH v4 7/7] mfd: anatop-mfd: remove anatop driver

2012-09-02 Thread Dong Aisheng
On Fri, Aug 31, 2012 at 09:39:26AM +0800, Shawn Guo wrote: > On Wed, Aug 29, 2012 at 06:56:58PM +0800, Dong Aisheng wrote: > > -config MFD_ANATOP > > - bool "Support for Freescale i.MX on-chip ANATOP controller" > > - depends on SOC_IMX6Q > > - help > > - Select this option to enable Free

Re: [PATCH v4 1/7] mfd: add syscon driver based on regmap

2012-09-02 Thread Dong Aisheng
On Fri, Aug 31, 2012 at 09:26:29AM +0800, Shawn Guo wrote: > On Wed, Aug 29, 2012 at 06:56:52PM +0800, Dong Aisheng wrote: > > +config MFD_SYSCON > > +bool "System Controller Register R/W Based on Regmap" > > If the driver only compiles and works for device tree probe, we should > have the

Re: [PATCH v2 6/9] misc: Generic on-chip SRAM allocation driver

2012-09-02 Thread Shawn Guo
On Fri, Aug 31, 2012 at 11:27:01AM +0200, Philipp Zabel wrote: > This driver requests and remaps a memory region as configured in the > device tree. It serves memory from this region via the genalloc API. > > Other drivers can retrieve the genalloc pool from a phandle pointing > to this drivers' d

Re: [PATCH v2 5/9] genalloc: add a global pool list, allow to find pools by phys address

2012-09-02 Thread Shawn Guo
On Fri, Aug 31, 2012 at 11:27:00AM +0200, Philipp Zabel wrote: > This patch keeps all created pools in a global list and adds two > functions that allow to retrieve the gen_pool pointer from a known > physical address and from a device tree node. > > Signed-off-by: Philipp Zabel > --- > include/

Re: [PATCH v2 0/9] Add device tree support for on-chip SRAM

2012-09-02 Thread Shawn Guo
I do not understand the point of introducing those imx patches, 1 ~ 4 and 7, 8. They are all unnecessary churns to me. IMO, 4 patches are enough. * genalloc: add a global pool list, allow to find pools by phys address * misc: Generic on-chip SRAM allocation driver * ARM i.MX: remove IRAM_ALLO

Re: [PATCH 4/6 v2] ARM: integrator: initial device tree support

2012-09-02 Thread Rob Herring
On 08/31/2012 10:55 PM, Linus Walleij wrote: > This is initial device tree support for the ARM Integrator family, > we create a very basic device tree, #ifdef out the non-DT machines > when compiling for device tree. > > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Also switch over

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-09-02 Thread Daniel Mack
On 05.08.2012 21:12, Linus Walleij wrote: > On Sun, Aug 5, 2012 at 1:57 PM, Daniel Mack wrote: > >>> Acked-by: Linus Walleij >> >> Ok, thanks. Mark, did the patches reach you this time? I think they >> should go thru the SPI tree. > > Yeah no problem, Mark is always faster than me ... Hmm, I d

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread Roland Stigge
Hi Shiraz, On 01/09/12 13:14, shiraz hashim wrote: > On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: >> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >> pl022->master_info = platform_info; >> pl022->adev = adev; >> pl022->vendor = id->data; >> +

Re: [PATCH 3/6] ARM: plat-versatile: add DT support to FPGA IRQ controller

2012-09-02 Thread Arnd Bergmann
On Saturday 01 September 2012, Linus Walleij wrote: > > When all devices get their IRQ numbers from the device > > tree, you can move to linear IRQ domains instead of legacy, and let > > the irq domain code pick the numbers. > > It seems I have no other choice here than to move directly to > linea

Re: [PATCH 2/2] ARM: allow for ATAGS to be configured out when DT support is selected

2012-09-02 Thread Arnd Bergmann
On Thursday 30 August 2012, Nicolas Pitre wrote: > Now that ATAGS support is well contained, we can easily remove it from > the kernel build if so desired. It has to explicitly be disabled, and > only when DT support is selected. > > Note: disabling kernel ATAGS support does not prevent the usage

Re: [PATCH 2/6 v2] ARM: integrator: check PL010 device name rather than base address

2012-09-02 Thread Arnd Bergmann
On Saturday 01 September 2012, Linus Walleij wrote: > In the PL010 UART callback a comparison against the base address is > done to figure out which UART is doing the callback. This does not > play well with device tree, so let's check the dev_name() of the > device instead. > > Signed-off-by: Lin

Re: [PATCH 4/6 v2] ARM: integrator: initial device tree support

2012-09-02 Thread Arnd Bergmann
On Saturday 01 September 2012, Linus Walleij wrote: > diff --git a/arch/arm/boot/dts/integratorcp.dts > b/arch/arm/boot/dts/integratorcp.dts > new file mode 100644 > index 000..8fad5a1 > --- /dev/null > +++ b/arch/arm/boot/dts/integratorcp.dts > @@ -0,0 +1,69 @@ > +/* > + * Device Tree for th

Re: [PATCH 3/8] i2c: at91: use an id table for SoC dependent parameters

2012-09-02 Thread Sylwester Nawrocki
On 09/01/2012 11:10 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 22:47 Fri 31 Aug , Sylwester Nawrocki wrote: >> On 08/31/2012 04:51 PM, Nicolas Ferre wrote: > diff --git a/arch/arm/mach-at91/at91rm9200.c > b/arch/arm/mach-at91/at91rm9200.c > index f2112f9..0bc91e5 100644 >

Re: [PATCH 2/2] ARM: allow for ATAGS to be configured out when DT support is selected

2012-09-02 Thread Will Deacon
On Thu, Aug 30, 2012 at 10:10:08PM +0100, Nicolas Pitre wrote: > Now that ATAGS support is well contained, we can easily remove it from > the kernel build if so desired. It has to explicitly be disabled, and > only when DT support is selected. > > Note: disabling kernel ATAGS support does not pre

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread shiraz hashim
Hi Linus, On Sun, Sep 2, 2012 at 12:48 PM, Linus Walleij wrote: > On Sat, Sep 1, 2012 at 1:14 PM, shiraz hashim > wrote: >> Hi Roland, >> >> On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: >>> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >>> pl022->master_info =

Re: [PATCH v2 1/9] pinctrl: mvebu: pinctrl driver core

2012-09-02 Thread Linus Walleij
On Mon, Aug 27, 2012 at 6:33 AM, Stephen Warren wrote: > On 08/25/2012 08:53 AM, Sebastian Hesselbarth wrote: >> >> now I do understand but in the current driver we pass pingroups associated >> with the available functions, i.e. "mpp2" with "uart1", "uart2", >> "sdio0", aso. >> IMHO for the above

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread Linus Walleij
On Sat, Sep 1, 2012 at 1:14 PM, shiraz hashim wrote: > Hi Roland, > > On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: >> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >> pl022->master_info = platform_info; >> pl022->adev = adev; >> pl022->vendor = id