Re: [PATCH 1/2] hwmon: Add devicetree bindings to gpio-fan

2012-09-08 Thread Andrew Lunn
Hi Jamie +static int gpio_fan_get_of_pdata(struct device *dev, + struct gpio_fan_platform_data *pdata) +{ + struct device_node *node; + struct gpio_fan_speed *speed; + unsigned *ctrl; + unsigned i; + u32 u; + struct property *prop; +

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Anton Vorontsov
On Sat, Sep 08, 2012 at 09:23:40AM +0200, Marco Stornelli wrote: [...] + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (pdata == NULL) I wonder why people prefer to not write !pdata, which is more natural when reading the code.. :-) I think it's the same for sizeof, it's

Re: [PATCH v3 00/10] ARM: tegra: Add PCIe device tree support

2012-09-08 Thread Bjorn Helgaas
On Fri, Sep 7, 2012 at 6:04 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Sep 07, 2012 at 05:34:35PM -0600, Stephen Warren wrote: I guess it's a pretty basic premise of the current PCI code that all the PCI scanning happens well before any device drivers are registered,

Re: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-09-08 Thread Domenico Andreoli
On Fri, Sep 07, 2012 at 11:57:59PM +0200, Linus Walleij wrote: On Fri, Sep 7, 2012 at 6:00 PM, Domenico Andreoli cav...@gmail.com wrote: On Fri, Sep 07, 2012 at 02:30:59PM +, AnilKumar, Chimata wrote: How can gpio driver knows that leds-gpio driver require these 4 pins? because