On Mon, 2012-10-22 at 19:51 +1300, Tony Prisk wrote:
> >
> > > chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
> > > if (chip == NULL) {
> > > dev_err(&pdev->dev, "failed to allocate memory\n");
> > > @@ -123,26 +144,32 @@ static int __devinit pwm_probe(struct
> > > plat
On Mon, Oct 22, 2012 at 07:51:52PM +1300, Tony Prisk wrote:
> Replies to your comments inline:
>
> On Mon, 2012-10-22 at 08:34 +0200, Thierry Reding wrote:
> ...
> > > -static int __devinit pwm_probe(struct platform_device *pdev)
> > > +static const struct of_device_id vt8500_pwm_dt_ids[] = {
> >
On Mon, Oct 22, 2012 at 08:09:07PM +1300, Tony Prisk wrote:
> On Mon, 2012-10-22 at 19:51 +1300, Tony Prisk wrote:
> > >
> > > > chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
> > > > if (chip == NULL) {
> > > > dev_err(&pdev->dev, "failed to allocate m
On Sat, Oct 20, 2012 at 01:04:12PM +0200, Thierry Reding wrote:
> On Thu, Oct 04, 2012 at 07:59:20PM +0200, Steffen Trumtrar wrote:
> [...]
> > diff --git a/drivers/of/of_videomode.c b/drivers/of/of_videomode.c
> [...]
> > +#if defined(CONFIG_DRM)
>
> This should be:
>
> #if IS_ENABLED(CONF
On Mon, 2012-10-22 at 09:24 +0200, Thierry Reding wrote:
> On Mon, Oct 22, 2012 at 08:09:07PM +1300, Tony Prisk wrote:
> > On Mon, 2012-10-22 at 19:51 +1300, Tony Prisk wrote:
> > > >
> > > > > chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
> > > > > if (chip == NULL) {
>
On Sat, Oct 20, 2012 at 09:59:51PM +0200, Thierry Reding wrote:
> On Thu, Oct 04, 2012 at 07:59:19PM +0200, Steffen Trumtrar wrote:
> [...]
> > diff --git a/include/linux/of_display_timings.h
> > b/include/linux/of_display_timings.h
> [...]
> > +struct display_timings {
> > + unsigned int num_ti
Hi Sourav,
On 10/22/2012 09:29 AM, Sourav Poddar wrote:
> Currently, omap4 keypad mux settings are done in the board file.
> Populate the mux settings in the dts file for the keypad to
> work via dt.
Have you changed the driver to handle properly the dependency with the
pinctrl and thus return EP
On Mon, Oct 22, 2012 at 08:36:22PM +1300, Tony Prisk wrote:
> On Mon, 2012-10-22 at 09:24 +0200, Thierry Reding wrote:
> > On Mon, Oct 22, 2012 at 08:09:07PM +1300, Tony Prisk wrote:
> > > On Mon, 2012-10-22 at 19:51 +1300, Tony Prisk wrote:
> > > > >
> > > > > > chip = devm_kzalloc(&pdev->dev
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch-vt8500 is also included.
Signed-off-by: Tony Prisk
---
v2 changes:
Merged binding doc patch with main code patch
Fixes as reque
On 10/22/2012 10:23 AM, Sourav wrote:
> Hi Benoit,
> On Monday 22 October 2012 01:15 PM, Benoit Cousson wrote:
>> Hi Sourav,
>>
>> On 10/22/2012 09:29 AM, Sourav Poddar wrote:
>>> Currently, omap4 keypad mux settings are done in the board file.
>>> Populate the mux settings in the dts file for the
On Mon, Oct 22, 2012 at 09:13:35PM +1300, Tony Prisk wrote:
> This patch updates pwm-vt8500.c to support devicetree probing and
> make use of the common clock subsystem.
>
> A binding document describing the PWM controller found on
> arch-vt8500 is also included.
>
> Signed-off-by: Tony Prisk
>
On Fri, Oct 19, 2012 at 12:20 AM, Stephen Warren wrote:
> On 10/18/2012 03:06 AM, Haojian Zhuang wrote:
>> Configure pins by pinctrl driver.
>
> In general, it seems better to use pinctrl "hogs" if the driver is only
> going to statically set up one pinctrl state and never change it. The
> altern
On Fri, Oct 19, 2012 at 12:26 AM, Stephen Warren wrote:
> On 10/18/2012 03:07 AM, Haojian Zhuang wrote:
>> Mutex is locked duplicatly by pinconf_groups_show() and
>> pin_config_group_get(). It results dead lock. So avoid to lock mutex
>> in pinconf_groups_show().
>
> With this outer lock removed,
On Sat, Oct 20, 2012 at 3:13 AM, Tony Lindgren wrote:
> * Haojian Zhuang [121018 02:08]:
>> Add pinconf generic support with POWER SOURCE, BIAS PULL.
> ...
>
>> + case PIN_CONFIG_POWER_SOURCE:
>> + if (pcs->psmask == PCS_OFF_DISABLED
>> + || pcs->psshift == PCS
Hi Tony,
On 10/18/2012 12:00 PM, Benoit Cousson wrote:
> On 10/18/2012 11:25 AM, Peter Ujfalusi wrote:
>> Fixes the following errors:
>> [2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
>> [2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
>>
>> Which is because we fa
On Monday 22 October 2012, Thierry Reding wrote:
> On Mon, Oct 22, 2012 at 07:51:52PM +1300, Tony Prisk wrote:
> > Replies to your comments inline:
> >
> > On Mon, 2012-10-22 at 08:34 +0200, Thierry Reding wrote:
> > ...
> > > > -static int __devinit pwm_probe(struct platform_device *pdev)
> > > >
On Mon, Oct 22, 2012 at 11:50:21AM +, Arnd Bergmann wrote:
> On Monday 22 October 2012, Thierry Reding wrote:
> > On Mon, Oct 22, 2012 at 07:51:52PM +1300, Tony Prisk wrote:
> > > Replies to your comments inline:
> > >
> > > On Mon, 2012-10-22 at 08:34 +0200, Thierry Reding wrote:
> > > ...
>
On Monday 22 October 2012, Thierry Reding wrote:
> > As long as we get build warnings for leaving out the __devinit/__devexit
> > annotations, I would generally recommend putting them in. If we do a
> > patch to remove all of them, a couple extra instances will not cause
> > any more troubles than
On Sun, 21 Oct 2012, Tony Prisk wrote:
> +static u64 ehci_dma_mask = DMA_BIT_MASK(32);
...
> + /* Right now device-tree probed devices don't get dma_mask set.
> + * Since shared usb code relies on it, set it here for now.
> + * Once we have dma capability bi
On Mon, Oct 22, 2012 at 01:52:08PM +, Arnd Bergmann wrote:
> On Monday 22 October 2012, Thierry Reding wrote:
> > > As long as we get build warnings for leaving out the __devinit/__devexit
> > > annotations, I would generally recommend putting them in. If we do a
> > > patch to remove all of th
Hi Sourav,
On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote:
> Adapt keypad to use pinctrl framework.
>
> Tested on omap4430 sdp with 3.7-rc1 kernel.
I do not see anything in the driver that would directly use pinctrl. Is
there a better place to select default pin configuration; may
Hi Thomas,
On 10/07/2012 07:10 PM, Thomas Abraham wrote:
> All Samsung platforms include several types of clocks including fixed-rate,
> mux, divider and gate clock types. There are typically hundreds of such clocks
> on each of the Samsung platforms. To enable Samsung platforms to register
> the
On 10/20/2012 04:10 PM, Tony Prisk wrote:
> Add a binding document for ehci-platform driver.
>
> Signed-off-by: Tony Prisk
> ---
> .../devicetree/bindings/usb/ehci-platform.txt | 27
>
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/
Changelog:
v2:
1. Remove "pinctrl-single,gpio-mask". Since GPIO function is one of the
mux function in the pinmux register of both OMAP and PXA/MMP silicons.
Use "pinctrl-single,function-mask" instead.
2. Remove "pinctrl-single,gpio-enable" & "pinctrl-single,gpio-disable".
Use "pinctrl-single,gpio
Pinctrl driver is necessary for MMP DT & MMP2 DT platforms.
Signed-off-by: Haojian Zhuang
---
arch/arm/mach-mmp/Kconfig |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index 178d4da..ebdda83 100644
--- a/arch/arm/m
Marvell's PXA/MMP silicon also match the behavior of pinctrl-single.
Each pin binds to one register. A lot of pins could be configured
as gpio.
Now add three properties in below.
pinctrl-single,gpio-ranges: gpio range array
pinctrl-single,gpio:
pinctrl-single,gpio-func:
Signed-off-by: Haojian Z
Add pinconf generic support with POWER SOURCE, BIAS PULL.
Signed-off-by: Haojian Zhuang
---
drivers/pinctrl/Kconfig |1 +
drivers/pinctrl/pinctrl-single.c | 276 --
2 files changed, 266 insertions(+), 11 deletions(-)
diff --git a/drivers/pinctrl
Add pinctrl-single support with device tree in pxa910 dkb platform.
Signed-off-by: Haojian Zhuang
---
arch/arm/boot/dts/pxa910-dkb.dts | 187 +-
arch/arm/boot/dts/pxa910.dtsi| 78
2 files changed, 264 insertions(+), 1 deletions(-)
diff
Add comments with pinconf & gpio range in the document of
pinctrl-single.
Signed-off-by: Haojian Zhuang
---
.../devicetree/bindings/pinctrl/pinctrl-single.txt | 52
arch/arm/boot/dts/pxa910.dtsi |1 -
2 files changed, 52 insertions(+), 1 deletions(
Configure pins by pinctrl driver.
Signed-off-by: Haojian Zhuang
---
drivers/tty/serial/pxa.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c
index 9033fc6..02dc771 100644
--- a/drivers/tty/serial/pxa.c
+++ b/driv
Use devm_kzalloc & add checking in probe() function.
Signed-off-by: Haojian Zhuang
---
drivers/i2c/busses/i2c-pxa.c | 26 ++
1 files changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 1034d93..7c8b5
Configure pins by pinctrl driver.
Signed-off-by: Haojian Zhuang
---
drivers/i2c/busses/i2c-pxa.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 7c8b5d0..11e4a30 100644
--- a/drivers/i2c/busses/i2c-pxa
Dump pinmux register value, not only function part in the pinmux
register.
Also fix the issue on caluclating pin offset. The last parameter
should be pin number, not register offset.
Signed-off-by: Haojian Zhuang
---
drivers/pinctrl/pinctrl-single.c |8
1 files changed, 4 insertion
* Sourav Poddar [121022 00:30]:
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -194,6 +194,27 @@
> 0xbc 0x100 /* abe_mcbsp2_fsx.abe_mcbsp2_fsx INPUT
> | MODE0 */
> >;
> };
> +
> + keypad_pins: pinmux_keypad_p
* Haojian Zhuang [121022 03:11]:
> On Sat, Oct 20, 2012 at 3:13 AM, Tony Lindgren wrote:
> > * Haojian Zhuang [121018 02:08]:
> >> Add pinconf generic support with POWER SOURCE, BIAS PULL.
> > ...
> >
> >> + case PIN_CONFIG_POWER_SOURCE:
> >> + if (pcs->psmask == PCS_OFF_DISABLED
On Mon, 22 Oct 2012, Stephen Warren wrote:
> On 10/20/2012 04:10 PM, Tony Prisk wrote:
> > Add a binding document for ehci-platform driver.
> > +Optional properties:
> > +- caps-offset : offset to the capabilities register (default = 0)
> > +- has-tt : controller has transaction translator(s).
>
On 10/22/2012 11:34 AM, Alan Stern wrote:
> On Mon, 22 Oct 2012, Stephen Warren wrote:
>
>> On 10/20/2012 04:10 PM, Tony Prisk wrote:
>>> Add a binding document for ehci-platform driver.
>
>>> +Optional properties:
>>> +- caps-offset : offset to the capabilities register (default = 0)
>>> +- has-
On Mon, 2012-10-22 at 17:08 +0200, Thierry Reding wrote:
> On Mon, Oct 22, 2012 at 01:52:08PM +, Arnd Bergmann wrote:
> > On Monday 22 October 2012, Thierry Reding wrote:
> > > > As long as we get build warnings for leaving out the __devinit/__devexit
> > > > annotations, I would generally reco
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch-vt8500 is also included.
Signed-off-by: Tony Prisk
---
.../devicetree/bindings/pwm/vt8500-pwm.txt | 17
drivers
On Mon, 22 Oct 2012, Stephen Warren wrote:
> >>> +- has-tt : controller has transaction translator(s).
> >>> +- has-synopsys-hc-bug : controller has the synopsys hc bug
> >>
> >> That would normally be determined by the driver based on the particular
> >> compatible value that is in device tree.
>
On 10/22/2012 02:45 AM, Linus Walleij wrote:
> On Fri, Oct 19, 2012 at 12:20 AM, Stephen Warren
> wrote:
>
>> On 10/18/2012 03:06 AM, Haojian Zhuang wrote:
>>> Configure pins by pinctrl driver.
>>
>> In general, it seems better to use pinctrl "hogs" if the driver is only
>> going to statically s
* Haojian Zhuang [121022 09:11]:
> Marvell's PXA/MMP silicon also match the behavior of pinctrl-single.
> Each pin binds to one register. A lot of pins could be configured
> as gpio.
>
> Now add three properties in below.
> pinctrl-single,gpio-ranges: gpio range array
> pinctrl-single,gpio:
> pi
* Péter Ujfalusi [121022 04:42]:
> Hi Tony,
>
> On 10/18/2012 12:00 PM, Benoit Cousson wrote:
> > On 10/18/2012 11:25 AM, Peter Ujfalusi wrote:
> >> Fixes the following errors:
> >> [2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
> >> [2.324432] omap-mcbsp 49024000.mcbsp: inv
* Tony Lindgren [121022 13:29]:
> * Haojian Zhuang [121022 09:11]:
> > --- a/drivers/pinctrl/pinctrl-single.c
> > +++ b/drivers/pinctrl/pinctrl-single.c
> > @@ -28,8 +28,10 @@
> > #define DRIVER_NAME"pinctrl-single"
> > #define PCS_MUX_PINS_NAME "pinctrl-single,
On 10/22/2012 01:00 PM, Alan Stern wrote:
> On Mon, 22 Oct 2012, Stephen Warren wrote:
>
> +- has-tt : controller has transaction translator(s).
> +- has-synopsys-hc-bug : controller has the synopsys hc bug
That would normally be determined by the driver based on the particular
>
* Haojian Zhuang [121022 09:13]:
> Dump pinmux register value, not only function part in the pinmux
> register.
This makes sense, but should be done using pcs_read, not pcs_readl,
see below.
> Also fix the issue on caluclating pin offset. The last parameter
> should be pin number, not register o
On 10/22/2012 10:08 AM, Haojian Zhuang wrote:
> Add comments with pinconf & gpio range in the document of
> pinctrl-single.
>
> Signed-off-by: Haojian Zhuang
> ---
> .../devicetree/bindings/pinctrl/pinctrl-single.txt | 52
>
> arch/arm/boot/dts/pxa910.dtsi
47 matches
Mail list logo
