Re: [PATCH 2/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-01 Thread Mark Brown
On Sat, Dec 01, 2012 at 03:37:27PM +0530, Padmavathi Venna wrote: > sound/soc/samsung/dma.c | 24 ++-- > sound/soc/samsung/dma.h |3 +++ > sound/soc/samsung/i2s.c |3 +++ > sound/soc/samsung/smdk_wm8994.c |7 +-- > 4 files changed, 17

Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio

2012-12-01 Thread Linus Walleij
On Sat, Dec 1, 2012 at 8:34 PM, Linus Walleij wrote: > The crucial question is: can the STMPE controllers be > used for GPIO, PWM, keypad and touchscreen at the > *same time* or are they nailed to *one* usecase during > electronics design? Looking closer at the datasheet it seems to mux pins on

Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio

2012-12-01 Thread Linus Walleij
On Mon, Nov 26, 2012 at 12:28 PM, Lee Jones wrote: > On Fri, 23 Nov 2012, Shiraz Hashim wrote: [About st-norequest-mask] >> This is a board dependent parameter which just informs gpio driver >> about pins, which must not be requested. It may happen for a stmpe >> variant where such gpio pins are

Re: How about a gpio_get(device *, char *) function?

2012-12-01 Thread Linus Walleij
On Thu, Nov 29, 2012 at 6:34 PM, Grant Likely wrote: > On Wed, 28 Nov 2012 12:38:38 +0900, Alex Courbot wrote: >> On Monday 26 November 2012 19:14:31 Grant Likely wrote: >> > I don't have any problem with a gpio_get function, but I do agree that >> > making it return an opaque handle is how it sh

Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio

2012-12-01 Thread Shiraz Hashim
On Sat, Dec 1, 2012 at 10:05 PM, Linus Walleij wrote: > On Mon, Nov 26, 2012 at 12:32 PM, Shiraz Hashim wrote: >> On Mon, Nov 26, 2012 at 11:28:23AM +, Lee Jones wrote: >>> >>> Doesn't pinctrl normally handle this kind of stuff? >> >> Yes, but I think it is only for managing the SoC and its p

Re: [PATCH V2] gpio: stmpe: Add DT support for stmpe gpio

2012-12-01 Thread Viresh Kumar
On 1 December 2012 22:17, Linus Walleij wrote: > If you can, try to avoid this: > Content-Type: text/plain; charset=WINDOWS-1252 > Content-Transfer-Encoding: quoted-printable > > That kind om message encoding makes my life a living hell > (but I fixed it, manually editing the whole patch) how did

Re: [PATCH 0/2] gpio: dt: add gpio-export support

2012-12-01 Thread Linus Walleij
On Sat, Nov 24, 2012 at 7:48 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 15:43 Wed 21 Nov , Linus Walleij wrote: >> On Wed, Nov 21, 2012 at 11:12 AM, Jean-Christophe PLAGNIOL-VILLARD >> wrote: >> >> > HI, >> > >> > This patch serie add the support of gpio-export to DT >> > >> >

Re: [PATCH V5 1/2] mfd: stmpe: Get rid of irq_invert_polarity

2012-12-01 Thread Linus Walleij
On Thu, Nov 29, 2012 at 3:40 PM, Viresh Kumar wrote: > Since the very first patch, stmpe core driver is using irq_invert_polarity as > part of platform data. But, nobody is actually using it in kernel till now. > > Also, this is not something part of hardware specs, but is included to cater > som

Re: [PATCH V2] gpio: stmpe: Add DT support for stmpe gpio

2012-12-01 Thread Linus Walleij
On Mon, Nov 26, 2012 at 12:36 PM, Viresh Kumar wrote: > From: Vipul Kumar Samar > > This patch allows the STMPE GPIO driver to be successfully probed and > initialised when Device Tree support is enabled. Bindings are mentioned in > Documentation too. > > Acked-by: Lee Jones > Signed-off-by: Vi

Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio

2012-12-01 Thread Linus Walleij
On Mon, Nov 26, 2012 at 12:32 PM, Shiraz Hashim wrote: > On Mon, Nov 26, 2012 at 11:28:23AM +, Lee Jones wrote: >> >> Doesn't pinctrl normally handle this kind of stuff? > > Yes, but I think it is only for managing the SoC and its pads. No pinctrl is also for off-SoC pin controllers, you can

Re: [PATCH 1/2] ASoC: Samsung: WM8994: Add basic device tree support for machine file

2012-12-01 Thread Mark Brown
On Sat, Dec 01, 2012 at 03:37:26PM +0530, Padmavathi Venna wrote: > Add the basic device tree based lookup. > > Signed-off-by: Padmavathi Venna > --- > sound/soc/samsung/smdk_wm8994.c | 23 +++ Any new device tree bindings need binding documentation. Your subject line is a

[PATCH 2/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-01 Thread Padmavathi Venna
Previously, the ASoC 'platform' (PCM/DMA) object was instantiated via a platform_device. This didn't represent the hardware well, since there was no separate hardware associated with this platform_device; it was a virtual device with sole purpose to call snd_soc_register_platform(). This change re

[PATCH 0/2] ASoC: Samsung: Remove platform device support

2012-12-01 Thread Padmavathi Venna
Samsung audio DMA device and machine device were getting registered as platform devices with out having any real H/W peripherials associated with them. With device tree support we can't add these platform devices in the machine file. So Added basic device tree based look up for the machine device.

[PATCH 1/2] ASoC: Samsung: WM8994: Add basic device tree support for machine file

2012-12-01 Thread Padmavathi Venna
Add the basic device tree based lookup. Signed-off-by: Padmavathi Venna --- sound/soc/samsung/smdk_wm8994.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c index 48dd4dd..f9ba2b9 100