Re: [PATCH V2 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-07 Thread Felipe Balbi
Hi, On Thu, Feb 07, 2013 at 07:05:06PM -0600, Jon Hunter wrote: > If the device-tree blob is present during boot, then register the SDMA > controller with the device-tree DMA driver so that we can use device-tree > to look-up DMA client information. > > Signed-off-by: Jon Hunter single comment

Re: [PATCH V2 1/2] ARM: dts: OMAP2+: Add SDMA controller bindings and nodes

2013-02-07 Thread Felipe Balbi
On Thu, Feb 07, 2013 at 07:05:05PM -0600, Jon Hunter wrote: > Add SDMA controller binding for OMAP2+ devices and populate DMA client > information for SPI and MMC periperhal on OMAP3+ devices. Please note > that OMAP24xx devices do not have SPI and MMC bindings available yet and > so DMA client inf

RE: [PATCH v2 2/3] mmc: davinci_mmc: add DT support

2013-02-07 Thread Manjunathappa, Prakash
Hi Mark, On Thu, Feb 07, 2013 at 16:16:56, Mark Rutland wrote: > Hello, > > I have a couple of comments on the dt bindings and the way it's parsed. > Thanks for your review comments. > On Thu, Feb 07, 2013 at 07:57:04AM +, Manjunathappa, Prakash wrote: > > Adds device tree support for davi

Re: [PATCH V3 4/5] ARM: dts: Add #dma-cells for generic dma binding support

2013-02-07 Thread Padma Venkat
Hi Rob, On Wed, Feb 6, 2013 at 8:54 PM, Rob Herring wrote: > On 02/06/2013 12:18 AM, Padmavathi Venna wrote: >> This patch adds #dma-cells property to PL330 DMA controller >> nodes for supporting generic dma dt bindings on samsung >> exynos5250 platform. > > The subject doesn't reflect this is fo

RE: [PATCH V2 2/2] ARM: davinci: restart: fix wdt to machine restart with DT

2013-02-07 Thread Kumar, Anil
Hi Sekhar, Thanks for the review. On Thu, Feb 07, 2013 at 23:45:53, Nori, Sekhar wrote: > > On 2/6/2013 9:30 AM, Kumar, Anil wrote: > > In non DT case da8xx_register_watchdog() is called to register platform > > device > > "da8xx_wdt_device" by board file. But in DT case it is not called and wd

Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-07 Thread Tony Lindgren
ops: 5 [#1] SMP ARM > [2.306243] Modules linked in: > [2.309448] CPU: 0Not tainted (3.8.0-rc6-next-20130207-00016-g735c237 > #35) > [2.317169] PC is at twl_i2c_read+0x3c/0xec > [2.321563] LR is at twl_i2c_read+0x1c/0xec > [2.325988] pc : []lr : [

[PATCH V2 0/2] ARM: dts: Add DT bindings for OMAP SDMA

2013-02-07 Thread Jon Hunter
Adds device-tree bindings from SDMA on OMAP2+ devices. DMA client bindings are also added for devices that have SPI and MMC bindings populated. Client binding data is based upon existing HWMOD data for OMAP and has been checked against OMAP documentation. Please note that the underlying (legacy) O

[PATCH V2 1/2] ARM: dts: OMAP2+: Add SDMA controller bindings and nodes

2013-02-07 Thread Jon Hunter
Add SDMA controller binding for OMAP2+ devices and populate DMA client information for SPI and MMC periperhal on OMAP3+ devices. Please note that OMAP24xx devices do not have SPI and MMC bindings available yet and so DMA client information is not populated. Signed-off-by: Jon Hunter --- .../devi

[PATCH V2 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-07 Thread Jon Hunter
If the device-tree blob is present during boot, then register the SDMA controller with the device-tree DMA driver so that we can use device-tree to look-up DMA client information. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/dma.c |4 drivers/dma/omap-dma.c| 37 ++

Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-07 Thread Jon Hunter
boards. [2.286132] Unable to handle kernel NULL pointer dereference at virtual address 0000 [ 2.294738] pgd = c0004000 [2.297576] [] *pgd= [2.301361] Internal error: Oops: 5 [#1] SMP ARM [2.306243] Modules linked in: [2.309448] CPU: 0Not tai

Re: [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-07 Thread Marc Kleine-Budde
On 02/07/2013 10:46 PM, Joe Perches wrote: > alloc failures already get standardized OOM > messages and a dump_stack. > > For the affected mallocs around these OOM messages: > > Converted kmallocs with multiplies to kmalloc_array. > Converted a kmalloc/memcpy to kmemdup. > Removed now unused stac

[PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-07 Thread Joe Perches
alloc failures already get standardized OOM messages and a dump_stack. For the affected mallocs around these OOM messages: Converted kmallocs with multiplies to kmalloc_array. Converted a kmalloc/memcpy to kmemdup. Removed now unused stack variables. Removed unnecessary parentheses. Neatened alig

Re: [PATCH] watchdog: ath79_wdt: add device tree matching

2013-02-07 Thread Wim Van Sebroeck
Hi Gabor, > Cc: Grant Likely > Cc: devicetree-discuss@lists.ozlabs.org > Signed-off-by: Gabor Juhos > --- > .../devicetree/bindings/watchdog/qca-ar7130-wdt.txt | 13 > + > drivers/watchdog/ath79_wdt.c | 11 +++ > 2 files changed, 24 in

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013 21:19:04 Linus Walleij wrote: > On Thu, Feb 7, 2013 at 8:42 PM, Arnd Bergmann wrote: > > On Thursday 07 February 2013, Linus Walleij wrote: > > >> Actually I once read about a feature where the kernel provides > >> a static page full of zeroes or something like this,

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-07 Thread Linus Walleij
On Thu, Feb 7, 2013 at 8:42 PM, Arnd Bergmann wrote: > On Thursday 07 February 2013, Linus Walleij wrote: >> Actually I once read about a feature where the kernel provides >> a static page full of zeroes or something like this, that would be >> ideal to use in cases like this, then all of this du

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Linus Walleij wrote: > On Tue, Jan 29, 2013 at 2:13 PM, Arnd Bergmann wrote: > > On Tuesday 29 January 2013, Andy Shevchenko wrote: > > >> > + pl022->dummypage = kmalloc(PAGE_SIZE, GFP_KERNEL); > >> > >> Where this memory will be freed? > >> In dependence of the an

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-07 Thread Linus Walleij
On Mon, Jan 28, 2013 at 6:57 PM, Arnd Bergmann wrote: > With the new OF DMA binding, it is possible to completely avoid the > need for platform_data for configuring a DMA channel. In cases where the > platform has already been converted, calling dma_request_slave_channel > should get all the nece

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-07 Thread Linus Walleij
On Tue, Jan 29, 2013 at 2:13 PM, Arnd Bergmann wrote: > On Tuesday 29 January 2013, Andy Shevchenko wrote: >> > + pl022->dummypage = kmalloc(PAGE_SIZE, GFP_KERNEL); >> >> Where this memory will be freed? >> In dependence of the answer could you consider to use >> devm_kmalloc or __get_free_page

Re: [PATCH V2 2/2] ARM: davinci: restart: fix wdt to machine restart with DT

2013-02-07 Thread Sekhar Nori
On 2/6/2013 9:30 AM, Kumar, Anil wrote: > In non DT case da8xx_register_watchdog() is called to register platform device > "da8xx_wdt_device" by board file. But in DT case it is not called and wdt > device get registered via wdt DT node. > > Currently code is passing platform device "da8xx_wdt_de

Re: [PATCH V2 1/2] ARM: davinci: da850: add wdt DT node

2013-02-07 Thread Sekhar Nori
On 2/6/2013 9:30 AM, Kumar, Anil wrote: > Add da850 wdt DT node. > Add OF_DEV_AUXDATA for wdt driver to use wdt clock. > > Signed-off-by: Kumar, Anil > --- a/arch/arm/mach-davinci/da8xx-dt.c > +++ b/arch/arm/mach-davinci/da8xx-dt.c > @@ -37,11 +37,17 @@ static void __init da8xx_init_irq(void) >

Re: [PATCH] ARM: dts: add minimal DT support for DevKit8000

2013-02-07 Thread Mark Rutland
Hello, I have a couple of minor comments. On Thu, Feb 07, 2013 at 02:11:37PM +, Anil Kumar wrote: > DevKit8000 is a beagle board clone from Timll, sold by > armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D, > S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and > JTAG i

[PATCH RFC v6] [media] Add a V4L2 OF parser

2013-02-07 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski Add a V4L2 OF parser, implementing bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Guennadi Liakhovetski [s.nawro...@samsung.com: various corrections and improvements since the initial version] Signed-off-by: Sylwes

[PATCH v5] iio: Add OF support

2013-02-07 Thread Guenter Roeck
Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck --- v5: - Updated examples in bindings. v4: - Fixed wrong parameter to dummy of_iio_channel_get_by_name if CONFIG_OF is undefined, and wrong return value. - Initialize indio_dev->of_node in iio_device_registe

Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114

2013-02-07 Thread Peter De Schrijver
> > > > + /* xusb_hs_src */ > > > + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC); > > > + val |= BIT(25); /* always select PLLU_60M */ > > > + writel(val, clk_base + CLK_SOURCE_XUSB_SS_SRC); > > > + > > > + clk = clk_register_fixed_factor(NULL, "xusb_hs_src", "pll_u

Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013 09:51:11 Jon Hunter wrote: > >> @@ -673,7 +702,7 @@ static int omap_dma_init(void) > >> { > >> int rc = platform_driver_register(&omap_dma_driver); > >> > >> -if (rc == 0) { > >> +if ((rc == 0) && (!of_have_populated_dt())) { > >> pdev = pla

Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-07 Thread Jon Hunter
On 02/07/2013 08:39 AM, Arnd Bergmann wrote: > On Wednesday 06 February 2013, Jon Hunter wrote: >> +static struct of_dma_filter_info info; > > Both members of this structure are constant, so you can just initialize it > here, > and it would be nice to give it a more descriptive name, such as >

Re: [PATCH 1/2] ARM: dts: OMAP2+: Add SDMA controller bindings and nodes

2013-02-07 Thread Arnd Bergmann
On Wednesday 06 February 2013, Jon Hunter wrote: > Add SDMA controller binding for OMAP2+ devices and populate DMA client > information for SPI and MMC periperhal on OMAP3+ devices. Please note > that OMAP24xx devices do not have SPI and MMC bindings available yet and > so DMA client information is

Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-07 Thread Arnd Bergmann
On Wednesday 06 February 2013, Jon Hunter wrote: > +static struct of_dma_filter_info info; Both members of this structure are constant, so you can just initialize it here, and it would be nice to give it a more descriptive name, such as omap_dmadev_info. > static struct platform_driver omap_dma

Re: [PATCH 0/2] ARM: dts: Add DT bindings for OMAP SDMA

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013 14:18:05 Peter Ujfalusi wrote: > I looked briefly around in the mentioned code and I wonder how this is going > to work with audio (ASoC). > When we boot with DT it looks like we are _not_ creating the DMA resources for > the device as it is done for the IRQ and IO/MEM.

Re: [PATCH] devicetree: Move NS2 LEDs binding into LEDs directory

2013-02-07 Thread Jason Cooper
On Thu, Feb 07, 2013 at 12:22:56PM +, Grant Likely wrote: > leds-ns2.txt is a binding for LEDs, not GPIOs. Move the documentation in > with the rest of the LEDs bindings. > > Cc: Andrew Lunn > Cc: Simon Guinot > Cc: Jason Cooper > Signed-off-by: Grant Likely > --- > .../devicetree/binding

Re: [PATCH 0/2] ARM: dts: Add DT bindings for OMAP SDMA

2013-02-07 Thread Peter Ujfalusi
Hi Jon, On 02/06/2013 10:03 PM, Jon Hunter wrote: > Adds device-tree bindings from SDMA on OMAP2+ devices. DMA client > bindings are also added for devices that have SPI and MMC bindings > populated. Client binding data is based upon existing HWMOD data for > OMAP and has been checked against OMAP

[PATCH] devicetree: Move NS2 LEDs binding into LEDs directory

2013-02-07 Thread Grant Likely
leds-ns2.txt is a binding for LEDs, not GPIOs. Move the documentation in with the rest of the LEDs bindings. Cc: Andrew Lunn Cc: Simon Guinot Cc: Jason Cooper Signed-off-by: Grant Likely --- .../devicetree/bindings/gpio/leds-ns2.txt | 26 .../devicetree/binding

[PATCH 1/1] documentation/devicetree: Fix a typo in exynos-dw-mshc.txt

2013-02-07 Thread Sachin Kamat
Fixed a typo in referenced file name. Cc: Thomas Abraham Cc: Grant Likely Signed-off-by: Sachin Kamat --- .../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Doc

Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons

2013-02-07 Thread Tomasz Figa
On Thursday 07 of February 2013 15:10:27 Tushar Behera wrote: > +CC: David Jander > +CC: Dmitry Torokhov > > On 02/07/2013 01:13 PM, Girish KS wrote: > >> + > >> +gpio_keys { > >> +compatible = "gpio-keys"; > >> +#address-cells = <1>; > >> +

Re: [PATCH v2 2/3] mmc: davinci_mmc: add DT support

2013-02-07 Thread Mark Rutland
Hello, I have a couple of comments on the dt bindings and the way it's parsed. On Thu, Feb 07, 2013 at 07:57:04AM +, Manjunathappa, Prakash wrote: > Adds device tree support for davinci_mmc. Also add binding documentation. > Tested in non-dma PIO mode and without GPIO card_detect/write_protec

Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons

2013-02-07 Thread Tushar Behera
+CC: David Jander +CC: Dmitry Torokhov On 02/07/2013 01:13 PM, Girish KS wrote: >> + >> +gpio_keys { >> +compatible = "gpio-keys"; >> +#address-cells = <1>; >> +#size-cells = <0>; > > Just want to understand why these properties

Re: Heads up on a device tree change

2013-02-07 Thread James Hogan
On 06/02/13 14:28, Grant Likely wrote: > On Wed, Feb 6, 2013 at 1:32 PM, James Hogan wrote: >> On 06/02/13 13:11, Grant Likely wrote: >>> - Resources on platform_devices get registered so they appear in >>> /proc/iomem and /proc/ioports and so that device drivers get the added >>> protection of re

Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons

2013-02-07 Thread Tomasz Figa
Hi, I'm wondering why Exynos5250 has not been migrated to use pinctrl yet. Support for it in pinctrl-samsung driver has been already merged, but I don't see any pinctrl nodes in exynos5250.dtsi. This is important because the legacy gpio-samsung support is going to be dropped, as it already hap

RE: [PATCH V2 6/6] ARM: davinci: da850: add tps6507x regulator DT data

2013-02-07 Thread Vishwanathrao Badarkhe, Manish
Hi Mark, On Tue, Jan 29, 2013 at 13:08:54, Vishwanathrao Badarkhe, Manish wrote: > Add tps6507x regulator device tree data to da850-evm by adding regulator > consumers with tightened constraints and regulator-name.TPS6507x regulator > handle can be obtained by using this regulator name. > Regula

RE: [PATCH V2 5/6] ARM: regulator: add tps6507x device tree data

2013-02-07 Thread Vishwanathrao Badarkhe, Manish
Hi Mark, On Tue, Jan 29, 2013 at 13:08:53, Vishwanathrao Badarkhe, Manish wrote: > Add device tree data for tps6507x regulator by adding all tps6507x regulator > nodes. Regulators are initialized based on compatible name provided in > tps6507x DT file. > > All tps6507x PMIC regulator device tre

Re: [PATCH v3 13/13] mmc: tmio: add barriers to IO operations

2013-02-07 Thread Paul Mundt
On Wed, Feb 06, 2013 at 08:47:00PM +0100, Guennadi Liakhovetski wrote: > Without barriers SDIO operations fail with runtime PM enabled. > > Signed-off-by: Guennadi Liakhovetski > Cc: Paul Mundt > --- > > v3: use iowrite16_rep() and ioread16_rep() for consistency. > Looks better to me! Reviewe

Re: [PATCH] ARM: davinci: da850: add DT node for I2C0

2013-02-07 Thread Sekhar Nori
On 2/6/2013 3:06 PM, Vishwanathrao Badarkhe, Manish wrote: > Add I2C0 device tree and pin muxing information to da850-evm. > Also, add OF_DEV_AUXDATA for I2C0 controller driver in da850 > board dt file to use I2C0 clock. > Verified i2c0 node gets created in sys class interface as > "/sys/class/i2c-

Re: [PATCH 0/2] ARM: dts: Add DT bindings for OMAP SDMA

2013-02-07 Thread Felipe Balbi
On Wed, Feb 06, 2013 at 03:03:14PM -0600, Jon Hunter wrote: > Adds device-tree bindings from SDMA on OMAP2+ devices. DMA client > bindings are also added for devices that have SPI and MMC bindings > populated. Client binding data is based upon existing HWMOD data for > OMAP and has been checked aga

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Simon Horman wrote: > > Please write the binding in a way that does not refer to a specific > > implementation in Linux: The binding should describe the hardware > > independent of details in the driver. In particular, I think you > > should not refer to the TMIO_MMC_B