Re: Active low GPIOs (was [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver)

2013-02-14 Thread Alex Courbot
On Thu, Feb 14, 2013 at 2:01 AM, Linus Walleij wrote: On Thu, Feb 14, 2013 at 1:41 AM, Stephen Warren wrote: On 02/13/2013 05:34 PM, Doug Anderson wrote: A little torn here. It adds a bunch of complexity to the code to handle this case and there are no known or anticipated users. I only w

[PATCH v4 5/5] ARM: davinci: da850: override mmc DT node device name

2013-02-14 Thread Manjunathappa, Prakash
Populate OF_DEV_AUXDATA with desired device name expected by davinci_mmc driver. Without this clk_get of davinci_mmc DT driver fails. Signed-off-by: Manjunathappa, Prakash Cc: linux-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-ker...@vger.kernel.org Cc: davinci-linux-ope

[PATCH v4 4/5] ARM: davinci: da850: add mmc DT entries

2013-02-14 Thread Manjunathappa, Prakash
Add DT entry for MMC. Also add entry for pinmux information. Tested: 1) Without GPIO card detection and EDMA support as DT support for GPIO and EDMA are yet come. 2) By creating/deleting files and mounting/unmounting the partition. Signed-off-by: Manjunathappa, Prakash Cc: linux-...@vger.kerne

[PATCH v4 3/5] mmc: davinci_mmc: add DT support

2013-02-14 Thread Manjunathappa, Prakash
Adds device tree support for davinci_mmc. Also add binding documentation. As of now in non-dma PIO mode and without GPIO card_detect/write_protect option because of dependencies on EDMA and GPIO module DT support. Signed-off-by: Manjunathappa, Prakash Reviewed-by: Mark Rutland Cc: linux-...@vger

[PATCH v4 2/5] mmc: davinci_mmc: derive controller IP version from platform_device_id

2013-02-14 Thread Manjunathappa, Prakash
Stop getting controller IP version via platform data, instead derive it from platform_device_id table. Signed-off-by: Manjunathappa, Prakash --- Suppose to be v1 but got added later to this series. drivers/mmc/host/davinci_mmc.c| 17 - include/linux/platform_data/m

[PATCH v4 0/5] Add DT support for davinci_mmc driver

2013-02-14 Thread Manjunathappa, Prakash
Patch set adds DT support for davinci_mmc driver and is verified on da850-evm without card_detect/write_protect and EDMA support. Also takecare to derive controller IP version from platform_device_id table, remove version specification in pdata. DT patches depends on below patches under review: 1)

[PATCH v4 1/5] ARM: davinci: mmc: derive version information from device name

2013-02-14 Thread Manjunathappa, Prakash
Remove specifying mmc controller IP version information via platform data, instead specify device name so that driver derives it from platform_device_id table. Also change the clock node name to match the changed dev_id. Tested on da850-evm to make sure driver loads without clk_get failures. Signe

Re: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-02-14 Thread Vivek Gautam
On Sat, Feb 9, 2013 at 4:05 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding EHCI device tree node for Exynos5250 along with >> the device base adress and gpio line for vbus. >> >> Signed-off-by: Vivek Gautam >> Acked-by: Jingoo Han >> Acked-by: Grant Likely >> --- >> >> Changes from v4

Re: [PATCH 1/4] of/pci: Provide support for parsing PCI DT ranges property

2013-02-14 Thread Thomas Petazzoni
Hello, On Thu, 14 Feb 2013 20:17:45 +0100, Thierry Reding wrote: > On Thu, Feb 14, 2013 at 04:53:41PM +, Andrew Murray wrote: > > Thierry, > > > > If you don't have much bandwidth I'd be quite happy to take this on - this > > would be beneficial for my eventual patchset. I can start by refact

Re: [PATCH] Added license header to dtc/libfdt/fdt.h and libfdt_env.h

2013-02-14 Thread David Gibson
On Thu, Feb 14, 2013 at 06:39:36PM -0600, Kim Phillips wrote: > On Thu, 14 Feb 2013 10:32:56 +1100 > David Gibson wrote: > > > On Wed, Feb 13, 2013 at 11:32:01AM -0500, Justin Sobota wrote: > > > This commit adds a license header to fdt.h and libfdt_env.h because > > > the license was omitted > >

[PATCH v4] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
From: Nobuhiro Iwamatsu This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V4: - Remove empty sh_eth_parse_dt(). V3: - Removed sentnece of "needs-init" from document. V2: - Removed ether_setup(). - Fixed typo from "sh-etn" to "sh-eth".

Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver

2013-02-14 Thread Doug Anderson
Stephen, On Thu, Feb 14, 2013 at 4:16 PM, Stephen Warren wrote: >> We can avoid that logic with has_full_constraints. That will be some >> work to get done but also should be done at some point in time. Once >> we use has_full_constraints we'll get ERR_PTR(-EPROBE_DEFER); > > That flag is norma

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
On Thu, Feb 14, 2013 at 10:24 AM, Kuninori Morimoto wrote: > > Hi Iwamatsu-san > > Thank you for this patch. > > Small comment from me > >> +#ifdef CONFIG_OF > (snip) >> +sh_eth_parse_dt(struct device *dev, struct net_device *ndev) >> +{ >> + int ret; >> + struct device_node *np = dev->of_

Re: [PATCH] Added license header to dtc/libfdt/fdt.h and libfdt_env.h

2013-02-14 Thread Kim Phillips
On Thu, 14 Feb 2013 10:32:56 +1100 David Gibson wrote: > On Wed, Feb 13, 2013 at 11:32:01AM -0500, Justin Sobota wrote: > > This commit adds a license header to fdt.h and libfdt_env.h because > > the license was omitted > > So, having a quick look at the git blame for both these files, it > look

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
(2013/02/14 10:24), Kuninori Morimoto wrote: Hi Iwamatsu-san Thank you for this patch. Small comment from me +#ifdef CONFIG_OF (snip) +sh_eth_parse_dt(struct device *dev, struct net_device *ndev) +{ + int ret; + struct device_node *np = dev->of_node; + struct sh_eth_plat_

Re: Active low GPIOs (was [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver)

2013-02-14 Thread Linus Walleij
On Thu, Feb 14, 2013 at 6:48 PM, Stephen Warren wrote: > This is actually why I rather dislike the idea that device tree has an > immutable bindings. To some exten, I imagine that much of > Documentation/stable_api_nonsense.txt could apply against device tree! > We can't fix problems like this by

[PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-02-14 Thread Doug Anderson
The i2c-arbitrator-cros-ec driver implements the arbitration scheme that the Embedded Controller (EC) on the ARM Chromebook expects to use for bus multimastering. This i2c-arbitrator-cros-ec driver could also be used in other places where standard I2C bus arbitration can't be used and two extra GP

Re: Active low GPIOs (was [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver)

2013-02-14 Thread Stephen Warren
On 02/14/2013 05:02 PM, Linus Walleij wrote: > On Thu, Feb 14, 2013 at 6:05 PM, Doug Anderson wrote: ... >> One argument for keeping "cd-inverted" too is >> for controllers that don't use a GPIO for card detect. >> In this case >> you could imagine a MMC controller that has a "card detect" on >>

Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver

2013-02-14 Thread Stephen Warren
On 02/14/2013 04:59 PM, Doug Anderson wrote: > Stephen, > > On Thu, Feb 14, 2013 at 3:35 PM, Stephen Warren wrote: >>> [1.51] platform-lcd supply lcd_vdd not found, using dummy regulator >> >> What prints that? I assume that's some error-handling logic in the >> platform-lcd driver. It's

Re: Active low GPIOs (was [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver)

2013-02-14 Thread Linus Walleij
On Thu, Feb 14, 2013 at 6:05 PM, Doug Anderson wrote: > Linus, >> But changing it would have very drastic effects. >> Consider this snippet from >> arch/arm/boot/dts/snowball.dts: >> >> // External Micro SD slot >> sdi0_per1@80126000 { >> arm,primecell-periphid = <0x10480180>; >> max-

Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver

2013-02-14 Thread Doug Anderson
Stephen, On Thu, Feb 14, 2013 at 3:35 PM, Stephen Warren wrote: >> [1.51] platform-lcd supply lcd_vdd not found, using dummy regulator > > What prints that? I assume that's some error-handling logic in the > platform-lcd driver. It's probably not detecting an -EPROBE_DEFFERED > return fro

[PATCH v3] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
From: Nobuhiro Iwamatsu This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V3: - Remove empty sh_eth_parse_dt(). V3: - Removed sentnece of "needs-init" from document. V2: - Removed ether_setup(). - Fixed typo from "sh-etn" to "sh-eth".

Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver

2013-02-14 Thread Stephen Warren
On 02/14/2013 02:40 PM, Doug Anderson wrote: > On Wed, Feb 13, 2013 at 4:54 PM, Doug Anderson wrote: > You should be able to replace all that with: > > module_platform_driver(&i2c_arbitrator_driver); ... > OK, so I dug into my problems here a little bit. All of the problems > are with

Re: [PATCH 1/9] ARM: dt: add header to define GPIO flags

2013-02-14 Thread Stephen Warren
On 02/14/2013 01:48 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Wed, 13 Feb 2013 22:33:10 > +0100: >> Many GPIO device tree bindings use the same flags. Create a header to >> define those. ... [discussion about adding include guards] > To avoid multple inclusion problems, do we want the abov

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-14 Thread Stephen Warren
On 02/14/2013 01:34 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Thu, 14 Feb 2013 21:15:28 > +0100: > >> Oh, and I don't think you updated e.g. nvidia,tegra20-car.txt to remove >> the list of clocks. > > Not yet removed. I think that this could be done with the patch which > allows kernel s

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-14 Thread Sylwester Nawrocki
On 02/13/2013 09:42 PM, Stephen Warren wrote: On 02/12/2013 03:39 PM, Sylwester Nawrocki wrote: [...] The whole subsystem topology is exposed to user space through the Media Controller API. OK, stable user-visible names are a reasonable use for device tree. I still don't think you should use

Re: [PATCH 0/2] Device Tree support for CMA (Contiguous Memory Allocator)

2013-02-14 Thread Sylwester Nawrocki
Hi, On 02/14/2013 10:30 PM, Sascha Hauer wrote: On Thu, Feb 14, 2013 at 01:45:26PM +0100, Marek Szyprowski wrote: ... Here is my initial proposal for device tree integration for Contiguous Memory Allocator. The code is quite straightforward, however I expect that the memory bindings require so

[PATCH] watchdog: at91rm9200: add DT support

2013-02-14 Thread Joachim Eastwood
Signed-off-by: Joachim Eastwood --- .../devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt| 9 + drivers/watchdog/Kconfig | 2 +- drivers/watchdog/at91rm9200_wdt.c| 9 + 3 files changed, 19 insertio

[PATCH] rtc: at91rm9200: add DT support

2013-02-14 Thread Joachim Eastwood
Signed-off-by: Joachim Eastwood --- .../devicetree/bindings/rtc/atmel,at91rm9200-rtc.txt | 15 +++ drivers/rtc/rtc-at91rm9200.c | 9 + 2 files changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91rm92

Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver

2013-02-14 Thread Doug Anderson
On Wed, Feb 13, 2013 at 4:54 PM, Doug Anderson wrote: You should be able to replace all that with: module_platform_driver(&i2c_arbitrator_driver); >>> >>> Sigh. Yeah, I had that. ...but it ends up getting initted >>> significantly later in the init process and that was uncovering

Re: [Linaro-mm-sig] [PATCH 2/2] drivers: dma-contiguous: add initialization from device tree

2013-02-14 Thread Laura Abbott
Hi, On 2/14/2013 4:45 AM, Marek Szyprowski wrote: +name: an name given to the defined region. +base-address: the base address of the defined region. +size: the size of the memory region. +linux,contiguous-region: property indicating that the defined memory + re

Re: [PATCH 1/2] drivers: dma-contiguous: clean source code and prepare for device tree

2013-02-14 Thread Laura Abbott
Hi, On 2/14/2013 4:45 AM, Marek Szyprowski wrote: This patch cleans the initialization of dma contiguous framework. The all-in-one dma_declare_contiguous() function is now separated into dma_contiguous_reserve_area() which only steals the the memory from memblock allocator and dma_contiguous_add

Re: [PATCH 0/2] Device Tree support for CMA (Contiguous Memory Allocator)

2013-02-14 Thread Sascha Hauer
Hi Marek, On Thu, Feb 14, 2013 at 01:45:26PM +0100, Marek Szyprowski wrote: > Hello, > > Here is my initial proposal for device tree integration for Contiguous > Memory Allocator. The code is quite straightforward, however I expect > that the memory bindings require some discussion. > > The prop

Re: [PATCH 1/9] ARM: dt: add header to define GPIO flags

2013-02-14 Thread Hiroshi Doyu
Stephen Warren wrote @ Wed, 13 Feb 2013 22:33:10 +0100: > From: Stephen Warren > > Many GPIO device tree bindings use the same flags. Create a header to > define those. > > Signed-off-by: Stephen Warren > --- > arch/arm/boot/dts/gpio.h | 10 ++ > 1 file changed, 10 insertions(+) >

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-14 Thread Hiroshi Doyu
Stephen Warren wrote @ Thu, 14 Feb 2013 21:15:28 +0100: > Oh, and I don't think you updated e.g. nvidia,tegra20-car.txt to remove > the list of clocks. Not yet removed. I think that this could be done with the patch which allows kernel source to include DT header files. > BTW, I assume this pat

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Sylwester Nawrocki
On 02/14/2013 12:43 PM, Mark Brown wrote: On Thu, Feb 14, 2013 at 11:48:59AM +0100, Sylwester Nawrocki wrote: NAK. Why we should live with this temporary code when there is already pinctrl support for Exynos SoCs ? If the pinctrl driver for Exynos5 was updated you could instead just do

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-14 Thread Stephen Warren
On 02/14/2013 11:59 AM, Hiroshi Doyu wrote: > To replace magic number in tegra_car: > > - clocks = <&tegra_car 28>; > + clocks = <&tegra_car CLK_HOST1X>; > diff --git a/arch/arm/boot/dts/tegra20-car.h b/arch/arm/boot/dts/tegra20-car.h Sorry, forgot a couple small comm

[PATCH 2/2] ARM: tegra114: convert device tree files to use CLK defines

2013-02-14 Thread Hiroshi Doyu
Replace magic number in tegra_car: - clocks = <&tegra_car 28>; + clocks = <&tegra_car CLK_HOST1X>; Signed-off-by: Hiroshi Doyu --- .../bindings/clock/nvidia,tegra114-car.txt |2 +- arch/arm/boot/dts/tegra114.dtsip | 13 +++-- 2

[PATCH 1/2] ARM: tegra114: create a DT header defining CLK IDs

2013-02-14 Thread Hiroshi Doyu
To replace magic number in tegra_car: - clocks = <&tegra_car 28>; + clocks = <&tegra_car CLK_HOST1X>; Signed-off-by: Hiroshi Doyu --- Depends on: [PATCH v6 00/10] Tegra114 clockframework http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148895.h

Re: [PATCH v2 0/4] ARM: mvebu: Add support for SPI flash devices in Armada 370/XP

2013-02-14 Thread Jason Cooper
On Wed, Feb 13, 2013 at 06:24:14AM -0300, Ezequiel Garcia wrote: > Hi Jason, > > On Wed, Feb 6, 2013 at 10:28 AM, Jason Cooper wrote: > > On Wed, Feb 06, 2013 at 02:16:54PM +0100, Gregory CLEMENT wrote: > >> On 02/06/2013 02:06 PM, Ezequiel Garcia wrote: > >> > This is second version of the SPI p

Re: [PATCH 1/4] of/pci: Provide support for parsing PCI DT ranges property

2013-02-14 Thread Thierry Reding
On Thu, Feb 14, 2013 at 04:53:41PM +, Andrew Murray wrote: > Thierry, > > If you don't have much bandwidth I'd be quite happy to take this on - this > would be beneficial for my eventual patchset. I can start by refactoring > common > implementations of pci_process_bridge_OF_ranges or similar

[v2 4/4] ARM: tegra30: convert device tree files to use CLK defines

2013-02-14 Thread Hiroshi Doyu
Replace magic number in tegra_car: - clocks = <&tegra_car 28>; + clocks = <&tegra_car CLK_HOST1X>; Signed-off-by: Hiroshi Doyu --- .../bindings/clock/nvidia,tegra30-car.txt |2 +- arch/arm/boot/dts/tegra30.dtsip| 87 ++--

[v2 3/4] ARM: tegra30: create a DT header defining CLK IDs

2013-02-14 Thread Hiroshi Doyu
To replace magic number in tegra_car: - clocks = <&tegra_car 28>; + clocks = <&tegra_car CLK_HOST1X>; Signed-off-by: Hiroshi Doyu --- arch/arm/boot/dts/tegra30-car.h | 171 +++ 1 file changed, 171 insertions(+) create mode 100644

[v2 2/4] ARM: tegra20: convert device tree files to use CLK defines

2013-02-14 Thread Hiroshi Doyu
Replace magic number in tegra_car: - clocks = <&tegra_car 28>; + clocks = <&tegra_car CLK_HOST1X>; Signed-off-by: Hiroshi Doyu --- .../bindings/clock/nvidia,tegra20-car.txt |2 +- arch/arm/boot/dts/tegra20-paz00.dtsp |2 +- arch/arm/boo

[v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-14 Thread Hiroshi Doyu
To replace magic number in tegra_car: - clocks = <&tegra_car 28>; + clocks = <&tegra_car CLK_HOST1X>; Signed-off-by: Hiroshi Doyu --- arch/arm/boot/dts/tegra20-car.h | 114 +++ 1 file changed, 114 insertions(+) create mode 100644

[v2 0/4] ARM: tegra: convert device tree files to use CLK defines

2013-02-14 Thread Hiroshi Doyu
Hi, With new dtc+cpp feature, we can get rid of magic numbers in dts* files. To get rid of Tegra clock magic number, the following patches were created with a script run as below. This can be applied for Tegra114 clock as well. for x in 20 30; do cat drivers/clk/tegra/clk-tegra$x.c | enum2def

Re: [PATCH 6/9] ARM: tegra: use pre-processor for all device trees

2013-02-14 Thread Olof Johansson
On Thu, Feb 14, 2013 at 9:41 AM, Rob Herring wrote: > Just a reminder to use -M for git format-patch. Why -M for format-patch > is not the default I wonder. Also, don't quote a huge patch just to make a 2-line comment. :-) -M is likely not the default because classic patch does not understand i

Re: [PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe

2013-02-14 Thread Marek Vasut
Dear Grant Likely, > On Thu, 10 Jan 2013 12:42:53 +0100, Linus Walleij wrote: > > On Tue, Jan 8, 2013 at 12:14 PM, Viresh Kumar wrote: > > > On 8 January 2013 16:41, Lee Jones wrote: > > >>> Hmm.. I tried a bit, but couldn't find any such call :( > > >>> Probably an assumption is taken here.

Re: Active low GPIOs (was [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver)

2013-02-14 Thread Mark Brown
On Thu, Feb 14, 2013 at 10:48:45AM -0700, Stephen Warren wrote: > This is actually why I rather dislike the idea that device tree has an > immutable bindings. To some exten, I imagine that much of > Documentation/stable_api_nonsense.txt could apply against device tree! > We can't fix problems like

Re: [PATCH 1/1] ARM: dt: add header to define tegra20 clocks

2013-02-14 Thread Stephen Warren
On 02/13/2013 11:38 PM, Hiroshi Doyu wrote: > To replace magic number in "clocks = <&tegra_car 28>;" I like the concept here; I was thinking about doing this today, but you beat me to it:-) Feel free to create the Tegra30 header too, and modify all the *.dts* files. To address other comments in t

[PATCH 2/5] pcmcia: at91_cf: convert to dev_ print functions

2013-02-14 Thread Joachim Eastwood
Convert all pr_* functions to equivalent dev_* functions and drop the driver_name variable. Signed-off-by: Joachim Eastwood --- drivers/pcmcia/at91_cf.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.

Re: Active low GPIOs (was [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver)

2013-02-14 Thread Stephen Warren
On 02/14/2013 10:05 AM, Doug Anderson wrote: > Linus, > > On Thu, Feb 14, 2013 at 2:01 AM, Linus Walleij > wrote: >> On Thu, Feb 14, 2013 at 1:41 AM, Stephen Warren >> wrote: >>> On 02/13/2013 05:34 PM, Doug Anderson wrote: >> A little torn here. It adds a bunch of complexity to the code

[PATCH 5/5] pcmcia: at91_cf: add support for DT

2013-02-14 Thread Joachim Eastwood
Signed-off-by: Joachim Eastwood --- .../devicetree/bindings/ata/atmel-at91_cf.txt | 19 + drivers/pcmcia/Kconfig | 2 +- drivers/pcmcia/at91_cf.c | 45 +- 3 files changed, 64 insertions(+), 2 deletions(-) cre

[PATCH 3/5] pcmcia: at91_cf: use devm_ functions for allocations

2013-02-14 Thread Joachim Eastwood
Signed-off-by: Joachim Eastwood --- drivers/pcmcia/at91_cf.c | 77 +++- 1 file changed, 24 insertions(+), 53 deletions(-) diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c index 4eec14b..43bc342 100644 --- a/drivers/pcmcia/at91_cf.c +++

[PATCH 4/5] pcmcia: at91_cf: clean up header includes

2013-02-14 Thread Joachim Eastwood
Use includes from linux/ instead of asm/ and remove a unnecessary mach/ include. Signed-off-by: Joachim Eastwood --- drivers/pcmcia/at91_cf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c index 43bc342..bce8a64 10064

[PATCH 1/5] pcmcia: at91_cf: fix gpio_get_value in at91_cf_get_status

2013-02-14 Thread Joachim Eastwood
Commit 80af9e6d (pcmcia at91_cf: fix raw gpio number usage) forgot to change the parameter in gpio_get_value after adding gpio validation. Signed-off-by: Joachim Eastwood --- drivers/pcmcia/at91_cf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pcmcia/at91_cf.c

[PATCH 0/5] pcmcia: at91_cf: clean up and add DT support

2013-02-14 Thread Joachim Eastwood
Hi This series clean up at91_cf a bit and add DT bindings. Patch series tested on custom RM9200 board in both with DT and with old platform data. Joachim Eastwood (5): pcmcia: at91_cf: fix gpio_get_value in at91_cf_get_status pcmcia: at91_cf: convert to dev_ print functions pcmcia: at91_c

Re: [PATCH] pinctrl: pinctrl-single: fix the binding documentation

2013-02-14 Thread Tony Lindgren
* Linus Walleij [130212 04:16]: > On Mon, Feb 11, 2013 at 3:46 AM, Kumar, Anil wrote: > > > As there are no use of #address-cells and #size-cells properties > > in pinctrl-single driver DT node. Fix pinctrl-single binding documentation > > to remove these properties. > > > > Signed-off-by: Kumar

Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver

2013-02-14 Thread Stephen Warren
On 02/14/2013 03:01 AM, Linus Walleij wrote: > On Thu, Feb 14, 2013 at 1:41 AM, Stephen Warren wrote: >> On 02/13/2013 05:34 PM, Doug Anderson wrote: > >>> A little torn here. It adds a bunch of complexity to the code to >>> handle this case and there are no known or anticipated users. I only >

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-14 Thread Dmitry Torokhov
On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote: > >> > >> +config KEYBOARD_CROS_EC > >> + tristate "ChromeOS EC keyboard" > >> + select INPUT_MATRIXKMAP > >> + select MFD_CROS_EC > > > > Is this select safe? I.e. does MFD_CROS_EC depend on anything else? > > I'll remove it

Re: Active low GPIOs (was [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver)

2013-02-14 Thread Doug Anderson
Linus, On Thu, Feb 14, 2013 at 2:01 AM, Linus Walleij wrote: > On Thu, Feb 14, 2013 at 1:41 AM, Stephen Warren wrote: >> On 02/13/2013 05:34 PM, Doug Anderson wrote: > >>> A little torn here. It adds a bunch of complexity to the code to >>> handle this case and there are no known or anticipated

Re: [PATCH 0/9] ARM: tegra: use new dtc+cpp feature

2013-02-14 Thread Tony Lindgren
* Stephen Warren [130213 13:37]: > From: Stephen Warren > > This series converts the Tegra device tree files to use the new feature > of running cpp over .dts files before compiling them with dtc. This > allows GPIOs and other GPIO/IRQ specifier cells to be named for example. > > As far as merg

Re: [PATCH 1/4] of/pci: Provide support for parsing PCI DT ranges property

2013-02-14 Thread Andrew Murray
On Wed, Feb 13, 2013 at 10:53:11PM +, Grant Likely wrote: > On Mon, 11 Feb 2013 09:22:17 +0100, Thierry Reding > wrote: > > From: Andrew Murray > > > > DT bindings for PCI host bridges often use the ranges property to describe > > memory and IO ranges - this binding tends to be the same acr

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

2013-02-14 Thread Sylwester Nawrocki
On 02/14/2013 04:45 PM, Sachin Kamat wrote: > Thanks for reviewing. Does the filename look good or should it be exynos-g2d? You're welcome. My apologies for being a bit late. I guess exynos-g2d.txt would be more appropriate. OTOH if this document is going to cover all Samsung G2D IP blocks then cu

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Arnd Bergmann
On Thursday 14 February 2013, Guennadi Liakhovetski wrote: > On Thu, 14 Feb 2013, Magnus Damm wrote: > > On Thu, Feb 14, 2013 at 5:28 PM, Guennadi Liakhovetski > > > My take on this is the following: having N optionally available on > > > different IP-versions features, I'd rather have N DT propert

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

2013-02-14 Thread Sachin Kamat
Hi Tomasz, On Thursday, 14 February 2013, Tomasz Figa wrote: > Hi Sachin, > > On Wednesday 06 of February 2013 17:21:17 Sachin Kamat wrote: >> Added documentaion about G2D bindings. >> >> Signed-off-by: Sachin Kamat >> --- >> .../devicetree/bindings/gpu/samsung-g2d.txt| 30 >>

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

2013-02-14 Thread Sachin Kamat
On Thursday, 14 February 2013, Sylwester Nawrocki < sylvester.nawro...@gmail.com> wrote: > On 02/06/2013 12:51 PM, Sachin Kamat wrote: >> >> Added documentaion about G2D bindings. > > s/documentaion/documentation Ok. > >> Signed-off-by: Sachin Kamat >> --- >> .../devicetree/bindings/gpu/samsung-

Re: [PATCH v2 1/2] [media] s5p-g2d: Add DT based discovery support

2013-02-14 Thread Sachin Kamat
On Thursday, 14 February 2013, Sylwester Nawrocki < sylvester.nawro...@gmail.com> wrote: > On 02/12/2013 06:30 PM, Sachin Kamat wrote: >> >> Hi Sylwester, >> >> On Wednesday, 6 February 2013, Sachin Kamat wrote: >>> >>> This patch adds device tree based discovery support to G2D driver >>> >>> Si

Re: [PATCH 1/1] ARM: dt: add header to define tegra20 clocks

2013-02-14 Thread Peter De Schrijver
> There could be the same kind of requirement from others that both > "dtsip" and "C-source" want to share the same header file. If we > consider that DT is the exact H/W description, C-source should be able > to include a DT header file. > > For example, a C-header file for "enum tegra{20,30}_clk

Re: [PATCH V4 0/4] Add generic DMA DT binding support

2013-02-14 Thread Vinod Koul
On Thu, Feb 14, 2013 at 09:10:04AM +0530, Padmavathi Venna wrote: Logically this should have been v5 :) Applied all, thanks -- ~Vinod > Changes since V3: > - Make dma-cells property optional as suggested by Rob Herring > - Add dma-requests and dma-channels properties to DMA contr

Re: [PATCH v2] dma: of-dma.c: fix memory leakage

2013-02-14 Thread Vinod Koul
On Thu, Feb 14, 2013 at 11:16:10AM +0100, Cong Ding wrote: > The memory allocated to ofdma might be a leakage when error occurs. > > Signed-off-by: Cong Ding Applied, thanks -- ~Vinod > --- > drivers/dma/of-dma.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/of-dma.c

Re: [PATCH 1/1] ARM: dt: add header to define tegra20 clocks

2013-02-14 Thread Hiroshi Doyu
Peter De Schrijver wrote @ Thu, 14 Feb 2013 11:12:20 +0100: > On Thu, Feb 14, 2013 at 07:38:17AM +0100, Hiroshi Doyu wrote: > > To replace magic number in "clocks = <&tegra_car 28>;" > > > > But then we should probably also remove the enum tegra20_clk and replace it > with this header file. We

[PATCH v4 RESEND] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

2013-02-14 Thread Andreas Larsson
This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP core library from Aeroflex Gaisler. This also adds support to gpio-generic for using custom accessor functions. The grgpio driver uses this to use ioread32be and iowrite32be for big endian register accesses. Reviewed-by: Anton

[PATCH 2/2] drivers: dma-contiguous: add initialization from device tree

2013-02-14 Thread Marek Szyprowski
Add device tree support for contiguous memory regions defined in device tree. Initialization is done in 2 steps. First, the contiguous memory is reserved, what happens very early, when only flattened device tree is available. Then on device initialization the corresponding cma regions are assigned

[PATCH 1/2] drivers: dma-contiguous: clean source code and prepare for device tree

2013-02-14 Thread Marek Szyprowski
This patch cleans the initialization of dma contiguous framework. The all-in-one dma_declare_contiguous() function is now separated into dma_contiguous_reserve_area() which only steals the the memory from memblock allocator and dma_contiguous_add_device() function, which assigns given device to the

[PATCH 0/2] Device Tree support for CMA (Contiguous Memory Allocator)

2013-02-14 Thread Marek Szyprowski
Hello, Here is my initial proposal for device tree integration for Contiguous Memory Allocator. The code is quite straightforward, however I expect that the memory bindings require some discussion. The proposed bindings allows to define contiguous memory regions of specified base address and size

Re: [PATCH v2] gpio: mcp23s08: convert driver to DT

2013-02-14 Thread Lars Poeschel
On Wednesday 13 February 2013 at 13:51:12, Linus Walleij wrote: > On Wed, Feb 13, 2013 at 12:13 PM, Lars Poeschel wrote: > > On Monday 11 February 2013 at 22:25:51, Grant Likely wrote: > >> However, is the pullup selection per-gpio line? If so, then why not > >> encode it into the flags field of

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Mark Brown
On Thu, Feb 14, 2013 at 11:48:59AM +0100, Sylwester Nawrocki wrote: > NAK. > Why we should leave with this temporary code when there is already > pinctrl support for Exynos SoCs ? > If the pinctrl driver for Exynos5 was updated you could instead just do > devm_pinctrl_get_select_default(&i2s->p

[PATCH 1/1] ARM: dts: AM33XX: Add CPSW phy_id device tree data to am335x-evmsk

2013-02-14 Thread Mugunthan V N
Add phy_id device tree data to am335x-evmsk device to bring up CPSW ethernet present on am335x starter kit. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/am335x-evmsk.dts |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/a

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Tomasz Figa
Hi, On Thursday 14 of February 2013 11:48:59 Sylwester Nawrocki wrote: > On 01/18/2013 12:47 PM, Padmavathi Venna wrote: > > Add support for device based discovery. > > > > Signed-off-by: Padmavathi Venna > > --- > > ... > > > /* Lock for cross i/f checks */ > > > > @@ -997,19 +1006,76 @@ st

Re: [PATCH v2 8/8] reset: Add driver for gpio-controlled reset pins

2013-02-14 Thread Russell King - ARM Linux
On Wed, Feb 13, 2013 at 06:34:32PM +0100, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel Just be aware that PXA has a "gpio reset" facility which is used for SoC reset - see arch/arm/mach-pxa/reset.c The use of gpio-reset would be ambiguous... or maybe PXA's usage could be combined somehow

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Sylwester Nawrocki
On 01/18/2013 12:47 PM, Padmavathi Venna wrote: > Add support for device based discovery. > > Signed-off-by: Padmavathi Venna > --- ... > /* Lock for cross i/f checks */ > @@ -997,19 +1006,76 @@ static struct i2s_dai *i2s_alloc_dai(struct > platform_device *pdev, bool sec) > return i2s; >

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Sylwester Nawrocki
Hi, On 01/18/2013 12:47 PM, Padmavathi Venna wrote: > Add support for device based discovery. > > Signed-off-by: Padmavathi Venna > --- > .../devicetree/bindings/sound/samsung-i2s.txt | 63 ++ > sound/soc/samsung/dma.c|3 +- > sound/soc/samsung/dma.h

Re: [RFC 1/1] ARM: omap2: gpmc: Move binding documentation to memory-controller

2013-02-14 Thread Ezequiel Garcia
On Wed, Feb 13, 2013 at 09:13:27AM -0600, Jon Hunter wrote: > > On 02/13/2013 05:13 AM, Ezequiel Garcia wrote: > > GPMC stands for General Purpose Memory Controller, and it's primarily > > used to handle memories such as NOR, NAND, SRAM. > > Note that this controller is also used to handle network

[PATCH v2] dma: of-dma.c: fix memory leakage

2013-02-14 Thread Cong Ding
The memory allocated to ofdma might be a leakage when error occurs. Signed-off-by: Cong Ding --- drivers/dma/of-dma.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index 59631b2..583e50e3 100644 --- a/drivers/dma/of-dma.c +++ b/drivers/dma/of-

Re: [PATCH 1/1] ARM: dt: add header to define tegra20 clocks

2013-02-14 Thread Peter De Schrijver
On Thu, Feb 14, 2013 at 07:38:17AM +0100, Hiroshi Doyu wrote: > To replace magic number in "clocks = <&tegra_car 28>;" > But then we should probably also remove the enum tegra20_clk and replace it with this header file. We should also consider removing the list of IDs from the documentation and r

Re: [PATCH v1 1/4] i2c: mux: Add i2c-arbitrator 'mux' driver

2013-02-14 Thread Linus Walleij
On Thu, Feb 14, 2013 at 1:41 AM, Stephen Warren wrote: > On 02/13/2013 05:34 PM, Doug Anderson wrote: >> A little torn here. It adds a bunch of complexity to the code to >> handle this case and there are no known or anticipated users. I only >> wish that the GPIO polarity could be more hidden f

Re: [PATCH V4 0/5] Add generic DMA DT binding support

2013-02-14 Thread Vinod Koul
On Thu, Feb 14, 2013 at 11:12:51AM +0530, Padma Venkat wrote: > Hi Vinod, > > On Thu, Feb 14, 2013 at 10:17 AM, Vinod Koul wrote: > > On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote: > >> Hi Vinod, > >> > >> On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul wrote: > >> > On Mon, Feb 11, 2

Re: Use of of_parse_phandle()/of_node_put()

2013-02-14 Thread Peter Ujfalusi
On 02/13/2013 06:02 PM, Anil Kumar wrote: > 8--- > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index b7e84a7..9000f4a 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -1044,6 +1044,13 @@ static void soc_remove_dai_links(struct > snd_soc_ca

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Guennadi Liakhovetski
Hi Magnus On Thu, 14 Feb 2013, Magnus Damm wrote: > Hi Guennadi, > > [Added Laurent to CC] > > On Thu, Feb 14, 2013 at 5:28 PM, Guennadi Liakhovetski > wrote: > > On Thu, 14 Feb 2013, Magnus Damm wrote: > > > >> On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman wrote: > >> > On Thu, Feb 14, 2013

[PATCH 4/4 v6] ASoC: simple-card: add Device Tree support

2013-02-14 Thread Kuninori Morimoto
Support for loading the simple-card module via devicetree. It requests cpu/codec information, and .of_xlate_dai_name support on each driver for probing. Signed-off-by: Kuninori Morimoto --- v5 -> v6 - cpu/codec become sub-node - it is using new .of_xlate_dai_name based snd_soc_of_get_port_d

[PATCH 3/4 v6] ASoC: fsi: enable .of_xlate_dai_name on struct snd_soc_dai_driver

2013-02-14 Thread Kuninori Morimoto
fsi driver can be used from simple-card driver which requires .of_xlate_dai_name. This patch supports .of_xlate_dai_name. Signed-off-by: Kuninori Morimoto --- v5 -> v6 - new patch .../devicetree/bindings/sound/renesas,fsi.txt |9 + sound/soc/sh/fsi.c

[PATCH 2/4 v6] ASoC: ak4642: enable .of_xlate_dai_name on struct snd_soc_dai_driver

2013-02-14 Thread Kuninori Morimoto
ak4642 driver can be used from simple-card driver which requires .of_xlate_dai_name. This patch supports .of_xlate_dai_name. Signed-off-by: Kuninori Morimoto --- v5 -> v6 - new patch Documentation/devicetree/bindings/sound/ak4642.txt |5 + sound/soc/codecs/ak4642.c

Re: Use of of_parse_phandle()/of_node_put()

2013-02-14 Thread Peter Ujfalusi
On 02/13/2013 05:40 PM, Anil Kumar wrote: > It looks issue is different here. > I have done some testing here with patch[1]. In this patch i tried to > get same "of_device" node pointer > again and found refcount for this dt node is 1 [Result]. > > As of_parse_phandle() says it "returns the device

[PATCH 1/4 v6] ASoC: add .of_xlate_dai_name callback on struct snd_soc_dai_driver

2013-02-14 Thread Kuninori Morimoto
ASoC sound driver requires CPU/CODEC drivers for probing, and each CPU/CODEC has some DAI on it. Then, "dai name matching" have been used to identify CPU-CODEC DAI pair on ASoC. But, the "dai port number matching" is now required from DeviceTree. The solution of this issue is to replace the dai po

Re: [PATCH 0/4 v6] ASoC: add snd_soc_of_get_port_dai_name()

2013-02-14 Thread Kuninori Morimoto
Hi Mar, Stephen These are v6 of simple-card DT support Kuninori Morimoto (4): ASoC: add .of_xlate_dai_name callback on struct snd_soc_dai_driver ASoC: ak4642: enable .of_xlate_dai_name on struct snd_soc_dai_driver ASoC: fsi: enable .of_xlate_dai_name on struct snd_soc_dai_drive

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Magnus Damm
Hi Guennadi, [Added Laurent to CC] On Thu, Feb 14, 2013 at 5:28 PM, Guennadi Liakhovetski wrote: > On Thu, 14 Feb 2013, Magnus Damm wrote: > >> On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman wrote: >> > On Thu, Feb 14, 2013 at 10:42:21AM +0900, Magnus Damm wrote: >> >> On Thu, Feb 14, 2013 at 1

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Guennadi Liakhovetski
On Thu, 14 Feb 2013, Magnus Damm wrote: > On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman wrote: > > On Thu, Feb 14, 2013 at 10:42:21AM +0900, Magnus Damm wrote: > >> On Thu, Feb 14, 2013 at 12:59 AM, Guennadi Liakhovetski > >> wrote: > >> > On Thu, 7 Feb 2013, Simon Horman wrote: > >> > > >> >>

[PATCH v9 8/8] watchdog: code: fix the alignement of some function declarations

2013-02-14 Thread Fabio Porcedda
Signed-off-by: Fabio Porcedda Cc: Wim Van Sebroeck Cc: linux-watch...@vger.kernel.org --- drivers/watchdog/watchdog_core.c | 2 +- drivers/watchdog/watchdog_dev.c | 17 ++--- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/watchdog/watchdog_core.c b/drivers/

[PATCH v9 7/8] watchdog: orion_wdt: move the min_timeout initialization

2013-02-14 Thread Fabio Porcedda
Move the min_timeout initialization inside the orion_wdt definition. Only compile tested. Signed-off-by: Fabio Porcedda Cc: Andrew Lunn Acked-by: Jason Cooper --- drivers/watchdog/orion_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/orion_wdt.c b/dr

  1   2   >