Re: [PATCH v7 3/3] of/pci: mips: convert to common of_pci_range_parser

2013-04-20 Thread Jason Cooper
On Fri, Apr 19, 2013 at 09:19:50AM +0200, Gabor Juhos wrote: > 2013.04.18. 15:09 keltezéssel, Jason Cooper írta: > > On Thu, Apr 18, 2013 at 01:59:10PM +0100, Andrew Murray wrote: > >> On Wed, Apr 17, 2013 at 04:42:48PM +0100, Linus Walleij wrote: > >>> On Tue, Apr 16, 2013 at 12:18 PM, Andrew Murr

Re: [PATCH 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-04-20 Thread Lars-Peter Clausen
Hi, Some comments on top of what Jonathan said. On 04/18/2013 05:38 PM, Alexandre Belloni wrote: [...] > diff --git a/drivers/iio/adc/nau7802.c b/drivers/iio/adc/nau7802.c > new file mode 100644 > index 000..0148fd8 > --- /dev/null > +++ b/drivers/iio/adc/nau7802.c > @@ -0,0 +1,644 @@ [...]

Re: [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-20 Thread Inki Dae
2013/4/17 Sylwester Nawrocki > This patch adds OF initialization support for the FIMC driver. > The binding documentation can be found at Documentation/devicetree/ > bindings/media/samsung-fimc.txt. > > The syscon regmap interface is used to serialize access to the > shared CAMBLK registers from

Re: [PATCH v2 0/3] drm/exynos: Add device tree support for IPP driver

2013-04-20 Thread Inki Dae
Hi Sylwester, DRM FIMC driver could be more cleaned up with this patch series. And your third patch And just minor issue. The second patch has build warnings like below, WARNING: static const char * array should probably be static const char * const #111: FILE: drivers/gpu/drm/exynos/exynos_drm_f

Re: [PATCH 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-04-20 Thread Jonathan Cameron
On 04/18/2013 04:38 PM, Alexandre Belloni wrote: > The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable > gain and sampling rates. > > Signed-off-by: Alexandre Belloni > Signed-off-by: Maxime Ripard A few bits and pieces inline. Ouch, that interrupt handling is annoyingly com

Re[2]: [PATCH 1/2] GPIO: clps711x: Rewrite driver for using generic GPIO code

2013-04-20 Thread Alexander Shiyan
> On Sat, Apr 13, 2013 at 08:21:39AM +0400, Alexander Shiyan wrote: > > +static void __init clps711x_add_gpio(void) > > +{ > > + const struct resource clps711x_gpio0_res[] = { > > + DEFINE_RES_MEM(PADR, SZ_1), > > + DEFINE_RES_MEM(PADDR, SZ_1), > > + }; ... > which will in i