Re: [RFC PATCH v2 1/2] drivers: misc: omap: add a new driver for ocp2scp

2012-06-24 Thread ABRAHAM, KISHON VIJAY
Hi Greg, On Sat, Jun 23, 2012 at 10:14 AM, Greg KH wrote: > On Fri, Jun 22, 2012 at 06:45:41PM +0530, Kishon Vijay Abraham I wrote: >> Adds a new driver _ocp2scp_. > > That's not what you called this driver in the patch below :( > >> This driver takes the responsibility of creating >> all the dev

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jun 25, 2012 at 12:26 PM, Richard Zhao wrote: > From: Felipe Balbi > > allow this driver to be removed too. > > Signed-off-by: Felipe Balbi > Signed-off-by: Alexander Shishkin > --- >  drivers/usb/chipidea/ci13xxx_msm.c |   20 ++-- >  1 file changed, 14 insertions(+

Re: [PATCH v7 04/14] usb: chipidea: msm: add remove method

2012-06-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jun 25, 2012 at 7:03 PM, Marek Vasut wrote: > Dear ABRAHAM, KISHON VIJAY, > >> Hi, >> >> On Mon, Jun 25, 2012 at 12:26 PM, Richard Zhao >> >> wrote: >> > From: Felipe Balbi >> > >> > allow this driver to be removed

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add device tree support for twl6030 usb driver. >> Update the Documentation with device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I >> ---

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:16 AM, Rajendra Nayak wrote: >> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt >> b/Documentation/devicetree/bindings/usb/omap-usb.txt >> new file mode 100644 >> index 000..80a28c9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu wrote: >> > + >> > +#ifdef CONFIG_PM > > Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? Why? I think we should have CONFIG_PM_SLEEP only when we have *suspend*, *resume* hooks. But this driver has only *runtime_suspend* and *runt

Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:32 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add device tree support for twl6030 usb driver. > > > twl4030? My bad. Will fix it. > > >> Update the Documentation with device tree binding information. >> >> Sign

Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:43 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add twl4030-usb data node in twl4030 device tree file. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/twl4030.dtsi | 21 +++

Re: [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:59 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> All the unnessary functions in omap-phy-internal is removed. >> These functionality are now handled by omap-usb2 phy driver. >> >> Cc: Felipe Balbi >> Signed-off-by

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 12:14 PM, Rajendra Nayak wrote: > On Tuesday 10 July 2012 11:58 AM, ABRAHAM, KISHON VIJAY wrote: >> >> Hi, >> >> On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote: >>> >>> On Thursday 28 June 2012 05:21 PM, Kishon Vij

Re: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data

2012-07-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:57 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add usb otg data node in omap4/omap3 device tree file. Also update >> the node with board specific setting in omapx-.dts file. >> >> Signed-off-by: Kishon Vijay Abr

Re: [RFC PATCH v2 1/2] drivers: misc: omap: add a new driver for ocp2scp

2012-07-16 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 16, 2012 at 1:42 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jun 25, 2012 at 04:26:08PM +, Arnd Bergmann wrote: >> On Monday 25 June 2012, Felipe Balbi wrote: >> > > > Can't this live where the scp drivers live? Actually, where is that >> > > > at? >> > > > Do we have scp driv

Re: [PATCH 1/2] drivers: bus: add a new driver for omap-ocp2scp

2012-07-16 Thread ABRAHAM, KISHON VIJAY
+Arnd Bergmann On Mon, Jul 16, 2012 at 7:43 PM, Kishon Vijay Abraham I wrote: > Adds a new driver *omap-ocp2scp*. This driver takes the responsibility of > creating all the devices that is connected to OCP2SCP. In the case of OMAP4, > USB2PHY is connected to ocp2scp. > > This also includes device

Re: [PATCH v2 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-17 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 17, 2012 at 5:57 PM, Sergei Shtylyov wrote: > Hello. > > > On 17-07-2012 12:10, Kishon Vijay Abraham I wrote: > >> Add omap-usb2 data node in omap4 device tree file. > > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/omap4.dtsi |5 + >> 1 files ch

Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data

2012-07-17 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 17, 2012 at 6:06 PM, Sergei Shtylyov wrote: > Hello. > > > On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: > >> Add ocp2scp data node in omap4 device tree file. > > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/omap4.dtsi |8 >> 1 files c

Re: [PATCH v3 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 19, 2012 at 11:11 AM, Ajay Kumar Gupta wrote: > Currently we have one single nop transceiver support as same is > defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. > This need to be changed to support multiple otg controller each > using nop transceiver on a platfor

Re: [PATCH v3 07/11] usb: otg: nop: add dt support

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 19, 2012 at 11:11 AM, Ajay Kumar Gupta wrote: > Added device tree support for nop transceiver driver and updated the > Documentation with device tree binding information for am33xx platform. > > Signed-off-by: Ajay Kumar Gupta > --- > .../devicetree/bindings/usb/am33xx-usb.txt

Re: [PATCHv6] arm/dts: omap4-sdp: Add keypad data

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Jul 13, 2012 at 8:27 PM, Sourav Poddar wrote: > Add keypad data node in omap4 device tree file. > Also fill the device tree binding parameters > with the required value in "omap4-sdp" dts file. > > Tested on omap4430 sdp with 3.5-rc6 kernel. > > Cc: Tony Lindgren > Cc: Benoit Cousson

Re: [PATCH v4 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 19, 2012 at 6:51 PM, Gupta, Ajay Kumar wrote: > Hi, >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Documentation/devicetree/bindings/usb/omap-usb.txt | 34 - >> drivers/usb/musb/omap2430.c| 55 >> >> 2 files change

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti wrote: > On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: >> + writel(~PHY_PD, phy->control_dev); >> + /* XXX: add proper documentation for this delay */ >> + mdelay(200); >

Re: [PATCH v2 1/2] drivers: bus: add a new driver for omap-ocp2scp

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:50 PM, Felipe Balbi wrote: > Hi, > > On Wed, Jul 18, 2012 at 12:00:38PM +0530, Kishon Vijay Abraham I wrote: >> Adds a new driver *omap-ocp2scp*. This driver takes the responsibility of >> creating all the devices that is connected to OCP2SCP. In the case of OMAP4, >>

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:57 PM, Felipe Balbi wrote: > On Mon, Jul 30, 2012 at 02:39:50PM +0530, Kishon Vijay Abraham I wrote: >> All phy related programming like enabling/disabling the clocks, powering >> on/off the phy is taken care of by this driver. It is also used for OTG >> related funct

Re: [PATCH v6 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:58 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:52PM +0530, Kishon Vijay Abraham I wrote: >> All the PHY configuration other than VBUS, ID GND and OTG SRP are removed >> from twl6030. The phy configurations are taken care by the dedicated >> usb2 ph

Re: [PATCH v6 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:59 PM, Felipe Balbi wrote: > On Mon, Jul 30, 2012 at 02:39:53PM +0530, Kishon Vijay Abraham I wrote: >> The mailbox register for usb otg in omap is present in control module. >> On detection of any events VBUS or ID, this register should be written >> to send the noti

Re: [PATCH v6 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:01 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:54PM +0530, Kishon Vijay Abraham I wrote: >> Add device tree support for twl6030 usb driver. >> Update the Documentation with device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham

Re: [PATCH v6 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:02 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:56PM +0530, Kishon Vijay Abraham I wrote: >> Add device tree support for twl4030 usb driver. >> Update the Documentation with device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham

Re: [PATCH v6 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:06 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:40:00PM +0530, Kishon Vijay Abraham I wrote: >> All the unnessary functions in omap-phy-internal is removed. >> These functionality are now handled by omap-usb2 phy driver. >> >> Cc: Felipe Balbi >> Sign

Re: [PATCH v6 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:04 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:58PM +0530, Kishon Vijay Abraham I wrote: >> Added device tree support for omap musb driver and updated the >> Documentation with device tree binding information. >> >> Signed-off-by: Kishon Vijay Abra

Re: [PATCH v6 00/11] omap: musb: Add device tree support

2012-08-06 Thread ABRAHAM, KISHON VIJAY
On Mon, Aug 6, 2012 at 2:22 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:49PM +0530, Kishon Vijay Abraham I wrote: >> This patch series adds device tree support for MUSB and device >> tree support for all the related modules to get MUSB working in >> OMAP platform. >> >> A new o

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread ABRAHAM, KISHON VIJAY
Hi Felipe, On Mon, Aug 6, 2012 at 2:19 PM, Felipe Balbi wrote: > Hi, > > On Fri, Aug 03, 2012 at 08:01:44PM +0530, ABRAHAM, KISHON VIJAY wrote: >> >> + return 0; >> >> +} >> >> + >> >> +#ifdef CONFIG_PM_RUNTIME >> >

Re: [PATCH v4 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-08-10 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 10, 2012 at 12:40 PM, Praveen Paneri wrote: > This driver uses usb_phy interface to interact with s3c-hsotg. Supports > phy_init and phy_shutdown functions to enable/disable phy. Tested with > smdk6410 and smdkv310. More SoCs can be brought under later. > > Signed-off-by: Praveen

Re: [RESEND PATCH v4 0/2] omap: add ocp2scp as a bus driver

2012-08-22 Thread ABRAHAM, KISHON VIJAY
On Wed, Aug 22, 2012 at 6:04 PM, Arnd Bergmann wrote: > On Wednesday 22 August 2012, Kishon Vijay Abraham I wrote: >> This patch series has been lying here for long. If no one has any >> comments on this patch series, can someone pick it up? > > I've added them now as a drivers/ocp2scp branch arm-

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-08-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Sat, Aug 25, 2012 at 11:43 PM, Marc Kleine-Budde wrote: > On 08/24/2012 08:46 AM, Richard Zhao wrote: >> Did you try both enableing and disabing DT pass build? > > Impossible on mx28 :) The platform always selects USE_DT, but on imx it > builds without DT support. > >> On Thu, Aug 23, 2012

Re: [PATCH v8 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Aug 30, 2012 at 4:20 PM, Ravi Babu wrote: > From: Ajay Kumar Gupta > > Added device tree data for usbss on am33xx. There are two musb controllers > on am33xx platform so have port0_mode and port1_mode additional data. > > Signed-off-by: Ajay Kumar Gupta > Signed-off-by: Ravi Babu >

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 31, 2012 at 5:53 PM, Felipe Balbi wrote: > Hi, > > On Fri, Aug 31, 2012 at 04:39:47PM +0530, Ravi Babu wrote: >> From: Santhapuri, Damodar >> >> AM335x uses NOP transceiver driver and need to enable builtin PHY >> by writing into usb_ctrl register available in system control >> m

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread ABRAHAM, KISHON VIJAY
On Fri, Aug 31, 2012 at 6:49 PM, Felipe Balbi wrote: > On Fri, Aug 31, 2012 at 06:51:04PM +0530, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Fri, Aug 31, 2012 at 5:53 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Fri, Aug 31, 2012 at 04:39:47P

Re: [PATCH v7 1/7] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Aug 6, 2012 at 6:37 PM, Kishon Vijay Abraham I wrote: > All phy related programming like enabling/disabling the clocks, powering > on/off the phy is taken care of by this driver. It is also used for OTG > related functionality like srp. > > This also includes device tree support for u

Re: [PATCH] arm/dts: omap: Add omap-usb2 dt data

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 1:53 PM, Benoit Cousson wrote: > Hi Kishon, > > On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote: >> Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is >> connected to ocp2scp, omap-usb2 dt data is added as a child node >> of ocp2scp. > > Could y

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 10, 2012 at 10:13 PM, Felipe Balbi wrote: > Hi, > > On Mon, Sep 10, 2012 at 06:17:03PM +0200, Benoit Cousson wrote: >> > On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: >> >> The mailbox register for usb otg in omap is present in control module. >> >> On detection o

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 3:23 PM, Vaibhav Hiremath wrote: > > > On 9/11/2012 2:39 PM, Kishon Vijay Abraham I wrote: >> Added device tree support for omap musb driver and updated the >> Documentation with device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> D

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-09-20 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 19, 2012 at 8:11 PM, Marc Kleine-Budde wrote: > On 09/19/2012 01:30 PM, Kishon Vijay Abraham I wrote: >> Added a driver for usb3 phy that handles the interaction between usb phy >> device and dwc3 controller. >> >> This also includes device tree support for usb3 phy driver and >>

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-09-24 Thread ABRAHAM, KISHON VIJAY
Hi, On Sat, Sep 22, 2012 at 3:03 AM, Rabin Vincent wrote: > 2012/9/6 Kishon Vijay Abraham I : >> All the PHY configuration other than VBUS, ID GND and OTG SRP are removed >> from twl6030. The phy configurations are taken care by the dedicated >> usb2 phy driver. So twl6030 is made as comparator d

Re: [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-24 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 24, 2012 at 3:08 PM, Praveen Paneri wrote: > Hi Kishon, Felipe, > > Any further comments on these patches? Can they be merged now? I don't have any other comments. Thanks Kishon ___ devicetree-discuss mailing list devicetree-discuss@li

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: > On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: >> All phy related programming like enabling/disabling the clocks, powering >> on/off the phy is taken care of by this driver. It is also used for OTG >> related functionality like srp.

Re: [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 25, 2012 at 5:48 PM, Rob Herring wrote: > On 09/25/2012 06:23 AM, Praveen Paneri wrote: >> Hi Rob, >> >> On Mon, Sep 24, 2012 at 6:34 PM, Rob Herring wrote: >>> On 09/17/2012 07:54 AM, Praveen Paneri wrote: This driver uses usb_phy interface to interact with s3c-hsotg. Suppo

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 19, 2012 at 5:26 PM, Felipe Balbi wrote: > On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: >> "usb_otg_ss_refclk960m" is needed by usb2 phy present in omap5. For >> omap4, the clk_get of this clock will fail since it does not have this >> clock. >> >> Signe

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 26, 2012 at 11:57 PM, Felipe Balbi wrote: > Hi, > > On Wed, Sep 26, 2012 at 11:10:48AM +0530, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Wed, Sep 19, 2012 at 5:26 PM, Felipe Balbi wrote: >> > On Wed, Sep 19, 2012 at 05:00:29PM

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-27 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 27, 2012 at 7:54 PM, Rob Herring wrote: > On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: >>> On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: >>>> All phy relat

Re: [PATCH v2 1/2] usb: phy: add a new driver for usb3 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 27, 2012 at 7:48 PM, Russell King - ARM Linux wrote: > On Thu, Sep 27, 2012 at 07:34:07PM +0530, Kishon Vijay Abraham I wrote: >> +static int omap5_usb_phy_power(struct omap_usb *phy, bool on) >> +{ >> + u32 val; >> + unsigned long rate; >> + struct clk *sys_clk; >> +

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit wrote: > On 9/27/2012 7:24 AM, Rob Herring wrote: >> >> On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: >>> >>> Hi, >>> >>> On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring >>> wro

Re: [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:27 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 28, 2012 at 06:23:10PM +0530, Kishon Vijay Abraham I wrote: >> Used of_platform_populate() to populate dwc3 core platform_device >> from device tree data. Since now the allocation of unique device id is >> handled be o

Re: [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:28 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 28, 2012 at 06:23:11PM +0530, Kishon Vijay Abraham I wrote: >> Before accessing any register, runtime API's should be invoked to enable >> the clocks. runtime API's are added here to prevent abort during register >> ac

Re: [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:29 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 28, 2012 at 06:23:13PM +0530, Kishon Vijay Abraham I wrote: >> Add an API in the omap glue layer to write to the mailbox register which >> can be used by comparator driver(twl). To pass the detection of the attached >>

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:32 PM, Felipe Balbi wrote: > On Fri, Sep 28, 2012 at 06:23:15PM +0530, Kishon Vijay Abraham I wrote: >> Added dwc3 support for dwc3 core and update the documentation with >> device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Docu

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 8:42 PM, Cousson, Benoit wrote: > On 9/28/2012 3:07 AM, ABRAHAM, KISHON VIJAY wrote: >> >> Hi, >> >> On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit wrote: >>> >>> On 9/27/2012 7:24 AM, Rob Herring wrote: >>>>

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Sun, Sep 30, 2012 at 10:17 PM, Sergei Shtylyov wrote: > Hello. > > > On 28-09-2012 14:53, Kishon Vijay Abraham I wrote: > >> Added dwc3 support for dwc3 core and update the documentation with >> device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I > > [...] > > >> d

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 4:31 PM, Sourav Poddar wrote: > smsc ece1099 is a keyboard scan or gpio expansion device. > The patch create keypad and gpio expander child for this > multi function smsc driver. > > Tested on omap5430 evm with 3.6-rc6 custom kernel. Can we have this line in comment sec

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown wrote: > On Mon, Oct 01, 2012 at 05:00:06PM +0530, ABRAHAM, KISHON VIJAY wrote: >> On Mon, Oct 1, 2012 at 4:31 PM, Sourav Poddar wrote: > > Delete irrelevant context from your replies, it makes it much easier to > find new text.

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown wrote: > On Mon, Oct 01, 2012 at 05:23:15PM +0530, ABRAHAM, KISHON VIJAY wrote: >> On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown > >> > No, this is not at all sensible - if there's an mfd_remove_devices() >> > functio

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Oct 2, 2012 at 6:08 PM, Mark Brown wrote: > On Mon, Oct 01, 2012 at 08:54:23PM +0530, ABRAHAM, KISHON VIJAY wrote: >> On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown > >> > Why would that be helpful? Most platforms don't support DT at all, and > >> I