kernel for Intel MID with OF enabled
(it required a hack in the arch Kconfig, of course), compiled fine.
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo
On Fri, Jun 21, 2013 at 3:25 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
Any other comments on patch itself?
Looks fine to me.
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
,
+clock_frequency)) {
+ /* Get IRQ from device tree */
+ err = of_irq_to_resource(pdev-dev.of_node, 0, res_irq);
So, you don't like the idea to get as much as possible before
alloc_netdev(), don't you?
--
With Best Regards,
Andy Shevchenko
On Thu, Jun 20, 2013 at 7:00 PM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
On Thu, Jun 20, 2013 at 2:53 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
please take a look at 6th re-spin of the patch.
Usually it's better to start new thread for new version of the patchset.
Oh
*priv)
+{
+ snprintf(bus-id, MII_BUS_ID_SIZE, %.8x, (unsigned int)priv-regs);
Is bus-id exposed to user-space somehow?
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https
patch everything around?
(Though I think better to think and create documents first and after
program accordingly)
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo
can avoid those 0xff.
+ ndev = alloc_etherdev(sizeof(struct arc_emac_priv));
+ if (!ndev) {
+ err = -ENOMEM;
+ goto out;
+ }
Redundant goto. Just return here.
+ }
+
+
Extra line.
--
With Best Regards,
Andy Shevchenko
On Thu, Jun 13, 2013 at 9:33 PM, Joe Perches j...@perches.com wrote:
On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote:
On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated
On Thu, Jun 13, 2013 at 11:25 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
On 06/13/2013 10:25 PM, Andy Shevchenko wrote:
On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated
)
+ return false;
return true;
}
What if rewrite like
if (divider-flags CLK_DIVIDER_EVEN == 0)
return true;
return div 2 || div % 2 == 0;
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss
On Tue, Jun 11, 2013 at 3:37 PM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
On Tue, Jun 11, 2013 at 3:06 PM, Heiko Stübner he...@sntech.de wrote:
Am Dienstag, 11. Juni 2013, 13:51:56 schrieb Andy Shevchenko:
On Tue, Jun 11, 2013 at 2:29 PM, Heiko Stübner he...@sntech.de wrote
__iomem *reg_base_addr; /* MAC registers base address */
kerneldoc format?
+++ b/drivers/net/ethernet/arc/arc_emac_regs.h
@@ -0,0 +1,72 @@
+/*
+ * Copyright (C) 2004, 2007-2010, 2011-2013 Synopsys, Inc. (www.synopsys.com)
2007-2013 ?
--
With Best Regards,
Andy Shevchenko
Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
)
present, so to keep the footprint low, add this small variant to the
pltfm driver.
My comments against v1 of this patch are still valid.
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
);
+ if (ret ret != -ENODEV)
From the discussion of dw_dmac I remember we decide that ENODEV check
is redundant.
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https
2 pure_initcall
3 arch_initcall
14 postcore_initcall
29 subsys_initcall)
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree
= ~(0xff shift);
+ mux |= xbar_chans[i][0] shift;
+ writel(mux, (void *)((u32)xbar + offset));
+ }
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https
On Sat, Feb 16, 2013 at 4:00 PM, Arnd Bergmann a...@arndb.de wrote:
On Saturday 16 February 2013, Andy Shevchenko wrote:
On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann a...@arndb.de wrote:
+ if (WARN_ON(fargs.req = 16 || fargs.src = 2 || fargs.dst = 2))
+ return NULL
, as well as the earlier attempt from
Viresh. Both of these are currently not merged upstream however.
This version incorporates feedback from Viresh Kumar, Andy Shevchenko
and Russell King.
Sorry, few comments below.
After addressing them take my Acked-by: Andy Shevchenko
andriy.shevche
);
+ if (err)
+ dma_async_device_unregister(dw-dma);
I don't think this is a good idea. The impossibility to register in the
of-dma helper is not critical. Just printing debug message is enough.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
%
rename from drivers/of/dma.c
rename to drivers/dma/of-dma.c
--
1.7.0.4
Anyone cares to Ack?
--
~Vinod
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
fargs.cfg_hi = be32_to_cpup(dma_spec-args+0) 7;
We have macros for such shifts.
drivers/dma/dw_dmac.c:187: cfghi = DWC_CFGH_DST_PER(...
drivers/dma/dw_dmac.c:189: cfghi = DWC_CFGH_SRC_PER(...
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
On Tue, 2013-01-29 at 16:27 +0530, Viresh Kumar wrote:
On 29 January 2013 16:24, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Tue, 2013-01-29 at 16:19 +0530, Viresh Kumar wrote:
if (DMA_TO_DEV)
// dest is periph
fargs.cfg_hi = be32_to_cpup(dma_spec-args+0
.
Are the
two number ranges sharing the same address space, i.e. is
request '7' as the destination guaranteed to be the same device
as request '7' in the source?
Request line should be unique. It means a real wire from slave hw to the
dmac.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel
On Wed, Jan 30, 2013 at 8:41 AM, Matt Porter mpor...@ti.com wrote:
On Mon, Jan 28, 2013 at 09:27:24PM +0200, Andy Shevchenko wrote:
On Tue, Jan 15, 2013 at 10:32 PM, Matt Porter mpor...@ti.com wrote:
Adds support for parsing the TI EDMA DT data into the required
EDMA private API platform
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/of/dma.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/of/dma.c b/drivers/of/dma.c
index 59631b2..1ae6120 100644
--- a/drivers/of/dma.c
+++ b/drivers/of/dma.c
@@ -117,7 +117,9 @@ int
/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https
. Supplying a new patch, getting it reviewed/tested and
being pulled by Linus is not so easy :)
Two ways:
- Keep it as is, and i will fix it separately and quickly
- Drop it :(
Will we survive if the patch is in mainline? I mean how big the impact
of it is?
--
Andy Shevchenko andriy.shevche
documentation again.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
(struct dma_chan *chan);
dma_addr_t dw_dma_get_dst_addr(struct dma_chan *chan);
+bool dw_generic_filter(struct dma_chan *chan, void *param);
#endif /* DW_DMAC_H */
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
On Fri, Oct 12, 2012 at 11:34 AM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 12 October 2012 13:53, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote:
diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt
b
On Fri, Oct 12, 2012 at 1:36 PM, viresh kumar viresh.ku...@linaro.org wrote:
On Fri, Oct 12, 2012 at 1:53 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote:
+ while (++i dw-sd_count) {
+ if (!strcmp(dw-sd[i
On Fri, Oct 12, 2012 at 2:01 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 12 October 2012 16:10, Andy Shevchenko andy.shevche...@gmail.com wrote:
+ if (!found) {
+ last_dw = dw;
+ last_bus_id = param;
+ return false;
Because of return here you
;
+}
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
)
+{
+ struct device_node *sn, *cn, *np = pdev-dev.of_node;
+ struct dw_dma_platform_data *pdata;
+ struct dw_dma_slave *sd;
+ u32 val, arr[4];
Let me weekend to think about naming. I really can't offer anything else
right now.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
On Fri, Oct 12, 2012 at 6:18 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 12 October 2012 20:28, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
+ if (last_dw) {
+ if ((last_bus_id == param) (last_dw == dw
On Mon, 2012-10-15 at 08:59 +0530, Viresh Kumar wrote:
On 12 October 2012 20:28, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
+ if (last_dw) {
+ if ((last_bus_id == param) (last_dw == dw))
+ return false;
+ }
Just came to my mind
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: Rob Herring rob.herr...@calxeda.com
---
drivers/of/fdt.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index
39 matches
Mail list logo
