Re: [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-03 Thread Bryan Wu
On Mon, Dec 3, 2012 at 6:13 AM, Peter Ujfalusi wrote: > Hi Bryan, > > On 11/14/2012 02:14 AM, Bryan Wu wrote: >> On Mon, Nov 12, 2012 at 6:41 AM, Peter Ujfalusi >> wrote: >>> Update the driver to use the new API for requesting pwm so we can take >>> advant

Re: [PATCH v4 2/2] Add documentation for tca6507 devicetree bindings.

2012-12-03 Thread Bryan Wu
On Fri, Nov 30, 2012 at 2:00 PM, Marek Belisko wrote: > Signed-off-by: Marek Belisko > --- > Documentation/devicetree/bindings/leds/tca6507.txt | 33 > > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/tca6507.txt > > diff --g

Re: [PATCH v4 2/2] Add documentation for tca6507 devicetree bindings.

2012-12-03 Thread Bryan Wu
On Mon, Dec 3, 2012 at 3:21 PM, Belisko Marek wrote: > On Mon, Dec 3, 2012 at 8:29 PM, Bryan Wu wrote: >> On Fri, Nov 30, 2012 at 2:00 PM, Marek Belisko >> wrote: >>> Signed-off-by: Marek Belisko >>> --- >>> Documentation/d

Re: [PATCH v4 1/2] leds/tca6507: Add support for devicetree.

2012-12-03 Thread Bryan Wu
Looks like this patch is based on linux-next tree, I fixed this. And I will solve the conflict when we do actually merge in next cycle. -Bryan On Fri, Nov 30, 2012 at 2:00 PM, Marek Belisko wrote: > Support added only for leds (not for gpio's). > > Signed-off-by: Marek Belisko > --- > Changes f

Re: [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-04 Thread Bryan Wu
On Tue, Dec 4, 2012 at 12:11 AM, Peter Ujfalusi wrote: > Hi Bryan, > > On 12/03/2012 07:32 PM, Bryan Wu wrote: >> On Mon, Dec 3, 2012 at 6:13 AM, Peter Ujfalusi wrote: >> Actually, I'm waiting for some feedback from DT maintainers about this >> new binding. But i

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-02 Thread Bryan Wu
nding documentation changed to reflect the changes > > Changes since v1: > - As suggested by Bryan Wu: the legacy pwm_request() has been removed from > patch 1 > - Device tree bindings added for leds-pwm driver. > > When we boot with Device tree we handle one LED per device to b

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-03 Thread Bryan Wu
On Wed, Jan 2, 2013 at 11:22 PM, Thierry Reding wrote: > On Wed, Jan 02, 2013 at 06:10:13PM -0800, Bryan Wu wrote: >> Hi Peter, >> >> I merged this patchset into my for-next branch already. >> >> Thanks for pushing this. > > Hi Bryan, > > Did you al

[PATCH 1/2] ARM: DT: tegra: Add Tegra30 Beaver board support

2013-01-11 Thread Bryan Wu
Ethernet - Audio input/output - SATA port - HDMI output - UART and JTAG Signed-off-by: Bryan Wu --- arch/arm/boot/dts/Makefile |3 +- arch/arm/boot/dts/tegra30-beaver.dts | 374 ++ 2 files changed, 376 insertions(+), 1 deletion(-) create mode

[PATCH 2/2] ARM: DT: tegra: Unify the description of Tegra20 boards

2013-01-11 Thread Bryan Wu
Use engineering name 'Tegra20' instead of 'Tegra2' Signed-off-by: Bryan Wu --- arch/arm/boot/dts/tegra20-harmony.dts |2 +- arch/arm/boot/dts/tegra20-ventana.dts |2 +- arch/arm/boot/dts/tegra20-whistler.dts |2 +- 3 files changed, 3 insertions(+), 3 deleti

[PATCH 1/2] ARM: DT: tegra: Add board leaver compatible properties

2013-01-11 Thread Bryan Wu
Signed-off-by: Bryan Wu --- Documentation/devicetree/bindings/arm/tegra.txt | 51 --- 1 file changed, 45 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Documentation/devicetree/bindings/arm/tegra.txt index 6e69d2e..ff9199a

[PATCH 2/2] ARM: DT: tegra: Add Tegra30 Beaver board support

2013-01-11 Thread Bryan Wu
Ethernet - Audio input/output - SATA port - HDMI output - UART and JTAG Signed-off-by: Bryan Wu --- Documentation/devicetree/bindings/arm/tegra.txt |2 + arch/arm/boot/dts/Makefile |3 +- arch/arm/boot/dts/tegra30-beaver.dts| 374

[PATCH 1/2] ARM: DT: tegra: Add board level compatible properties

2013-01-11 Thread Bryan Wu
The compatible properties of Tegra SoC based boards or machines need to be documented. This patch adds these board levle compatible properties into device tree binding document. Signed-off-by: Bryan Wu --- Documentation/devicetree/bindings/arm/tegra.txt | 29 ++- 1 file

[PATCH 2/2] ARM: DT: tegra: Add Tegra30 Beaver board support

2013-01-11 Thread Bryan Wu
Ethernet - Audio input/output - SATA port - HDMI output - UART and JTAG Signed-off-by: Bryan Wu --- Documentation/devicetree/bindings/arm/tegra.txt |1 + arch/arm/boot/dts/Makefile |3 +- arch/arm/boot/dts/tegra30-beaver.dts| 374

Re: [PATCH 1/2] leds/tca6507: Add support for devicetree.

2012-11-14 Thread Bryan Wu
On Tue, Oct 30, 2012 at 2:45 PM, Marek Belisko wrote: > Support added only for leds (not for gpio's). > > Signed-off-by: Marek Belisko > --- > drivers/leds/leds-tca6507.c | 73 > +-- > 1 file changed, 70 insertions(+), 3 deletions(-) > Overall, this lo

Re: [PATCH 1/2] leds/tca6507: Add support for devicetree.

2012-11-14 Thread Bryan Wu
On Tue, Nov 6, 2012 at 12:32 PM, Belisko Marek wrote: > Hi, > > On Tue, Nov 6, 2012 at 7:24 PM, Bryan Wu wrote: >> >> On Tue, Oct 30, 2012 at 2:45 PM, Marek Belisko >> wrote: >> > Support added only for leds (not for gpio's). >> > >> >

Re: [PATCH v3 1/2] leds/tca6507: Add support for devicetree.

2012-11-14 Thread Bryan Wu
On Mon, Nov 12, 2012 at 1:25 PM, Marek Belisko wrote: > Support added only for leds (not for gpio's). > > Signed-off-by: Marek Belisko > --- > > Changes from v2: > - change compatible property to "ti,tca6507" > - add documentation for linux,default-trigger > > Changes from v1: > - return proper e

Re: [PATCH v3 2/2] Add documentation for tca6507 devicetree bindings.

2012-11-14 Thread Bryan Wu
It looks fine to me, but I need a DT maintainer's ack. Stephen, could you help on this. I will merge this patch via my tree. Thanks, -Bryan On Mon, Nov 12, 2012 at 1:25 PM, Marek Belisko wrote: > Signed-off-by: Marek Belisko > --- > Documentation/devicetree/bindings/leds/tca6507.txt | 40 >

Re: [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm

2012-11-14 Thread Bryan Wu
On Mon, Nov 12, 2012 at 6:41 AM, Peter Ujfalusi wrote: > Update the driver to use the new API for requesting pwm so we can take > advantage of the pwm_lookup table to find the correct pwm to be used for the > LED functionality. > If the devm_get_pwm fails we fall back to legacy mode to try to get

Re: [PATCH v3 2/2] Add documentation for tca6507 devicetree bindings.

2012-11-14 Thread Bryan Wu
On Wed, Nov 14, 2012 at 11:26 AM, Stephen Warren wrote: > On 11/13/2012 06:05 PM, Bryan Wu wrote: >> It looks fine to me, but I need a DT maintainer's ack. Stephen, could >> you help on this. I will merge this patch via my tree. > > I'm not actually a DT maintain

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > The Palmas familly of chips has LED support. This is not always muxed > to output pins so depending on the setting of the mux this driver > will create the appropriate LED class devices. > > Signed-off-by: Graeme Gregory > Signed-off-by: Ian La

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Tue, Mar 12, 2013 at 12:10 PM, Mark Brown wrote: > On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: >> On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > >> > + spinlock_t value_lock; > >> I think you don't need this spinlock to protect

Re: [PATCH] of: Add more stubs for non-OF builds

2013-06-20 Thread Bryan Wu
Hi Rob, Is this patch good for merging? In Alex's one patch to add device tree supporting for a leds driver, we got building errors due to miss definitions of some of_xxx api functions. It looks obviously to me that we need to fix this in device tree core instead put #ifdef CONFIG_OF everywhere.

Re: [PATCH] of: Add more stubs for non-OF builds

2013-06-20 Thread Bryan Wu
On Thu, Jun 20, 2013 at 5:26 PM, Grant Likely wrote: > On Thu, 20 Jun 2013 16:49:54 -0700, Bryan Wu wrote: >> Hi Rob, >> >> Is this patch good for merging? >> >> In Alex's one patch to add device tree supporting for a leds driver, >> we got building e

Re: Re[2]: [PATCH] of: Add more stubs for non-OF builds

2013-06-21 Thread Bryan Wu
On Fri, Jun 21, 2013 at 7:17 AM, Alexander Shiyan wrote: >> On Thu, Jun 20, 2013 at 5:26 PM, Grant Likely >> wrote: >> > On Thu, 20 Jun 2013 16:49:54 -0700, Bryan Wu wrote: >> >> Hi Rob, >> >> >> >> Is this patch good for merging? >

Re: [PATCH] leds: Add device tree binding for pca9633

2013-06-26 Thread Bryan Wu
On Wed, Jun 26, 2013 at 7:17 AM, Tony Lindgren wrote: > Similar to tca6507, we can just parse the standard LED > properties for pca9633. > > Tested on a pca9632, which is compatible with pca9633. > > Signed-off-by: Tony Lindgren > > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/pca

Re: [PATCH] leds: Add device tree binding for pca9633

2013-07-01 Thread Bryan Wu
On Thu, Jun 27, 2013 at 7:24 AM, Tony Lindgren wrote: > * Tony Lindgren [130627 00:28]: >> * Bryan Wu [130626 16:53]: >> > On Wed, Jun 26, 2013 at 7:17 AM, Tony Lindgren wrote: >> > > @@ -22,6 +22,7 @@ >> > > #include >> > > #include

Re: [PATCH] ARM: ux500: register LP5521 LEDs in the device tree

2013-05-31 Thread Bryan Wu
On Wed, May 22, 2013 at 1:12 AM, Linus Walleij wrote: > From: Linus Walleij > > Based on pending device tree support in the LP55xx drivers > we can add the correct LED and channel configuration from the > ux500 device tree for all HREF variants. > > Cc: Milo Kim > Cc: B

Re: [PATCH] ARM: ux500: register LP5521 LEDs in the device tree

2013-06-03 Thread Bryan Wu
On Mon, Jun 3, 2013 at 1:18 AM, Lee Jones wrote: > On Fri, 31 May 2013, Bryan Wu wrote: > >> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij >> wrote: >> > From: Linus Walleij >> > >> > Based on pending device tree support in the LP55xx driver

Re: [PATCH] ARM: ux500: register LP5521 LEDs in the device tree

2013-06-04 Thread Bryan Wu
On Tue, Jun 4, 2013 at 12:35 AM, Lee Jones wrote: > On Mon, 03 Jun 2013, Bryan Wu wrote: > >> On Mon, Jun 3, 2013 at 1:18 AM, Lee Jones wrote: >> > On Fri, 31 May 2013, Bryan Wu wrote: >> > >> >> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij