Re: [PATCH 1/3] ARM: dts: Add headers with constants for MTD partitions

2013-06-19 Thread Florian Vaussard
Hello, Thank you for the review. On 06/12/2013 03:05 PM, Grant Likely wrote: On Tue, 11 Jun 2013 16:48:56 +0200, Florian Vaussard florian.vauss...@epfl.ch wrote: These constants can be used to easily declare MTD partitions inside DTS. The constants MTDPART_OFS_* are purposely not included

Re: [PATCH] ARM: dts: Protect pinctrl headers against multiple inclusions

2013-06-19 Thread Florian Vaussard
Hello Benoit, On 06/12/2013 06:18 PM, Cousson, Benoit wrote: Hi Florian, On 6/12/2013 8:42 AM, Florian Vaussard wrote: Hello Grant, On 06/11/2013 11:57 PM, Grant Likely wrote: On Tue, 11 Jun 2013 16:50:50 +0200, Florian Vaussard florian.vauss...@epfl.ch wrote: Pinctrl headers were

Re: [PATCH 0/4] ARM: dts: OMAP3: Updates for Overo

2013-06-19 Thread Florian Vaussard
Hello Benoit, Any comments on this series? Regards, Florian On 06/11/2013 04:49 PM, Florian Vaussard wrote: Hello, This series performs several updates to omap3-overo and omap3-tobi. Patch 1 is necessary to patch 2 for the IRQ constant. The SMSC911X is largely taken from omap3-igep. Regards

Re: [PATCH v2 1/4] ARM: dts: omap4-panda: Add USB Host support

2013-06-19 Thread Florian Vaussard
Hello, On 06/19/2013 01:03 PM, Roger Quadros wrote: On 06/19/2013 01:10 PM, Benoit Cousson wrote: On 06/19/2013 02:46 AM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [130619 00:42]: Hi Benoit, On 06/19/2013 04:17 AM, Benoit Cousson wrote: Hi Roger, On 06/18/2013 11:04 AM, Roger

Re: [PATCH 1/3] mfd: twl4030-power: Split from twl-core into a dedicated module

2013-06-18 Thread Florian Vaussard
Hello, Thank you for the review. On 06/18/2013 01:56 AM, Samuel Ortiz wrote: Hi Florian, On Thu, May 30, 2013 at 03:51:54PM +0200, Florian Vaussard wrote: For now, the call to twl4030-power is hard-wired inside twl-core. To ease the future transition to DT, make twl4030-power as a separate

Re: [PATCH 2/3] mfd: twl4030-power: Start transition to DT

2013-06-18 Thread Florian Vaussard
Hello, On 06/18/2013 02:02 AM, Samuel Ortiz wrote: Hi Florian, On Thu, May 30, 2013 at 03:51:55PM +0200, Florian Vaussard wrote: int twl4030_power_probe(struct platform_device *pdev) { struct twl4030_power_data *pdata = pdev-dev.platform_data; + struct device_node *node

[PATCH v2 1/5] mfd: twl4030-power: Split from twl-core into a dedicated module

2013-06-18 Thread Florian Vaussard
For now, the call to twl4030-power is hard-wired inside twl-core. To ease the future transition to DT, make twl4030-power as a separate module, like what is already done for twl4030-audio and others. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl-core.c | 12

[PATCH v2 0/5] mfd: twl4030-power: Start DT conversion and updates

2013-06-18 Thread Florian Vaussard
the refactoring of the probe function into a dedicated patch - new patch to fix registers relocking on error - rebased on mfd-next Florian Vaussard (5): mfd: twl4030-power: Split from twl-core into a dedicated module mfd: twl4030-power: Simplify probing of power scripts and resources mfd: twl4030-power

[PATCH v2 2/5] mfd: twl4030-power: Simplify probing of power scripts and resources

2013-06-18 Thread Florian Vaussard
Increase lisibility when probing power scripts and resources by creating dedicated functions. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl4030-power.c | 60 -- 1 files changed, 40 insertions(+), 20 deletions(-) diff --git

[PATCH v2 5/5] mfd: twl4030-power: Fix relocking on error

2013-06-18 Thread Florian Vaussard
If an error occurs when loading power scripts or resources, the registers are not correctly relocked. Fix it. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl4030-power.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/mfd

[PATCH v2 3/5] mfd: twl4030-power: Start transition to DT

2013-06-18 Thread Florian Vaussard
Support for loading twl4030-power module via devicetree. For now, when booting with a DT, only the poweroff callback feature is supported through the ti,use_poweroff property. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- .../devicetree/bindings/mfd/twl4030-power.txt | 28

[PATCH v2 4/5] mfd: twl4030-power: Simplify error path

2013-06-18 Thread Florian Vaussard
Remove unnecessary goto statements, causing duplicated if conditions. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl4030-power.c | 38 +++--- 1 files changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/twl4030

Re: [PATCH] ARM: dts: Protect pinctrl headers against multiple inclusions

2013-06-12 Thread Florian Vaussard
Hello Grant, On 06/11/2013 11:57 PM, Grant Likely wrote: On Tue, 11 Jun 2013 16:50:50 +0200, Florian Vaussard florian.vauss...@epfl.ch wrote: Pinctrl headers were not protected with #ifndef. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Obviously this needs to go in via whatever

[PATCH 1/3] ARM: dts: Add headers with constants for MTD partitions

2013-06-11 Thread Florian Vaussard
by parse_ofpart_partitions(). Two cells should be used to correctly encode the negative constants, but this breaks current usage. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- include/dt-bindings/mtd/partitions.h | 12 include/dt-bindings/sizes.h | 52

[PATCH 0/3] ARM: dts: OMAP3: Use constants with MTD devices

2013-06-11 Thread Florian Vaussard
that inside omap3430-sdp.dts (nor@0,0), it appears with this series that partitions 'kernel-nor' and 'filesystem-nor' overlaps by (2*SZ_128K), which is probably not desired. Regards, Florian Florian Vaussard (3): ARM: dts: Add headers with constants for MTD partitions ARM: dts: Add omap3-overo NAND

[PATCH 2/3] ARM: dts: Add omap3-overo NAND flash memory binding

2013-06-11 Thread Florian Vaussard
Add device-tree node for the on-board NAND memory. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-overo.dtsi | 50 arch/arm/boot/dts/omap3.dtsi |2 + 2 files changed, 52 insertions(+), 0 deletions(-) diff

[PATCH 3/3] ARM: dts: OMAP3: Use MTD constants for OMAP3 boards

2013-06-11 Thread Florian Vaussard
Use the MTD constants for NAND and OneNAND nodes used in OMAP3 DTS. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-devkit8000.dts | 10 +- arch/arm/boot/dts/omap3-igep0020.dts | 10 +- arch/arm/boot/dts/omap3-igep0030.dts | 10

[PATCH 1/4] ARM: dts: OMAP3: Include IRQ header

2013-06-11 Thread Florian Vaussard
Some nodes in OMAP3 DTS now use edge or level sensitive interrupts. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3.dtsi |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index

[PATCH 2/4] ARM: dts: omap3-tobi: Add SMSC911X node

2013-06-11 Thread Florian Vaussard
The Tobi expansion boards embeds a SMSC LAN8700 PHY. Add the corresponding node into the DT. The regulators are not designed to be turned off. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-tobi.dts | 48 ++ 1 files

[PATCH 3/4] ARM: dts: omap3-tobi: Correct polarity for GPIO LED

2013-06-11 Thread Florian Vaussard
The LED is active low, not active high. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-tobi.dts |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/omap3-tobi.dts b/arch/arm/boot/dts/omap3-tobi.dts index dea726f

[PATCH 0/4] ARM: dts: OMAP3: Updates for Overo

2013-06-11 Thread Florian Vaussard
Hello, This series performs several updates to omap3-overo and omap3-tobi. Patch 1 is necessary to patch 2 for the IRQ constant. The SMSC911X is largely taken from omap3-igep. Regards, Florian Florian Vaussard (4): ARM: dts: OMAP3: Include IRQ header ARM: dts: omap3-tobi: Add SMSC911X node

[PATCH 4/4] ARM: dts: omap3-overo: Add default trigger for TWL4030 LED

2013-06-11 Thread Florian Vaussard
Commit c971ff1 'leds: leds-pwm: Defer led_pwm_set() if PWM can sleep' fixed a crash when using a trigger with a pwm-led provided by an external chip. Now it is safe to add the default trigger according to board-overo.c. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot

Re: [PATCH] ARM: dts: omap3-devkit8000: fix NAND memory binding

2013-06-11 Thread Florian Vaussard
Hello, On 05/31/2013 03:49 PM, Florian Vaussard wrote: Hello, Gentle ping. Does someone has any comments on this fix? Can someone tests on the real hardware? Nobody has this hardware somewhere in a drawer? :-) Regards, Florian Regards, Florian On 05/23/2013 10:11 AM, Florian Vaussard

[PATCH] ARM: dts: Protect pinctrl headers against multiple inclusions

2013-06-11 Thread Florian Vaussard
Pinctrl headers were not protected with #ifndef. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- include/dt-bindings/pinctrl/am33xx.h |5 + include/dt-bindings/pinctrl/omap.h |5 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/dt-bindings

Re: [PATCH 1/3] ARM: dts: Add headers with constants for MTD partitions

2013-06-11 Thread Florian Vaussard
Hello Stephen, On 06/11/2013 06:24 PM, Stephen Warren wrote: On 06/11/2013 08:48 AM, Florian Vaussard wrote: These constants can be used to easily declare MTD partitions inside DTS. The constants MTDPART_OFS_* are purposely not included. Indeed, parse_ofpart_partitions() is expecting u64

Re: [PATCH 3/3] ARM: dts: OMAP3: Use MTD constants for OMAP3 boards

2013-06-11 Thread Florian Vaussard
Hello Javier, On 06/11/2013 05:29 PM, Javier Martinez Canillas wrote: On 06/11/2013 04:48 PM, Florian Vaussard wrote: Use the MTD constants for NAND and OneNAND nodes used in OMAP3 DTS. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-devkit8000.dts

Re: [PATCH 3/3] ARM: dts: OMAP3: Use MTD constants for OMAP3 boards

2013-06-11 Thread Florian Vaussard
Hello, On 06/11/2013 06:27 PM, Stephen Warren wrote: On 06/11/2013 08:48 AM, Florian Vaussard wrote: Use the MTD constants for NAND and OneNAND nodes used in OMAP3 DTS. I don't quite understand the split between patches 2/3 and 3/3; isn't the edit to omap3-overo.dtsi (part of) a board file

Re: [net-next PATCH v4 3/5] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone

2013-06-06 Thread Florian Vaussard
Hello, On 06/05/2013 07:08 PM, Mugunthan V N wrote: Add pinmux configurations for MII based CPSW ethernet to am335x-bone. In this patch, only single named mode/state is added and these pins are configured during pinctrl driver initialization. Default mode is nothing but the values required for

Re: [PATCH v2 0/4] ARM: dts: AM3XXX: Use preprocessor for device trees

2013-06-06 Thread Florian Vaussard
Hello, On 06/06/2013 09:22 AM, Benoit Cousson wrote: On 06/06/2013 07:28 AM, Mohammed, Afzal wrote: Hi Benoit, On Wed, Jun 05, 2013 at 18:19:00, Cousson, Benoit wrote: + Afzal, Hi Vaibhav and Afzal, Can someone test this series before I pull it. I still don't have any AM board to do it

[PATCH v2 1/4] ARM: dts: AM3XXX: Use #include for all device trees

2013-06-03 Thread Florian Vaussard
Replace /include/ by #include for AM33XX and AM35XX device tree files, in order to use the C pre-processor, making use of #define features possible. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/am335x-bone.dts |2 +- arch/arm/boot/dts/am335x-evm.dts

[PATCH v2 3/4] ARM: dts: AM33XX: Specific pinctrl header

2013-06-03 Thread Florian Vaussard
The pinctrl IP inside the AM33XX family differs slightly from what is found on OMAP2+. Define a specific header to take account of the differences. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- include/dt-bindings/pinctrl/am33xx.h | 37 ++ 1 files

[PATCH v2 4/4] ARM: dts: AM33XX: Use pinctrl constants

2013-06-03 Thread Florian Vaussard
Using constants for pinctrl allows a better readability, and removes redundancy with comments. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/am335x-bone.dts | 18 +- arch/arm/boot/dts/am335x-evm.dts | 58 ++-- arch

[PATCH v2 0/4] ARM: dts: AM3XXX: Use preprocessor for device trees

2013-06-03 Thread Florian Vaussard
' on OMAP, but '0' on AM33xx) Florian Vaussard (4): ARM: dts: AM3XXX: Use #include for all device trees ARM: dts: AM33XX: Use existing constants for GPIOs ARM: dts: AM33XX: Specific pinctrl header ARM: dts: AM33XX: Use pinctrl constants arch/arm/boot/dts/am335x-bone.dts | 28

[PATCH v2 2/4] ARM: dts: AM33XX: Use existing constants for GPIOs

2013-06-03 Thread Florian Vaussard
Use standard GPIO constants to enhance the readability of DT GPIOs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/am335x-bone.dts |8 arch/arm/boot/dts/am335x-evm.dts | 14 +++--- arch/arm/boot/dts/am335x-evmsk.dts | 16

Re: [PATCH 1/2] gpiolib: add gpio_export_with_name

2013-05-31 Thread Florian Vaussard
Hello Linus, On 05/30/2013 11:11 PM, Linus Walleij wrote: On Thu, May 30, 2013 at 10:38 PM, Florian Vaussard florian.vauss...@epfl.ch wrote: Indeed, I work in a robotics lab :-) One of our board (mach-imx/ mx31moboard*.c) controls for example the multiplexing of two cameras sharing the same

[PATCH v4 4/5] ARM: dts: OMAP2+: Header file for pinctrl constants

2013-05-31 Thread Florian Vaussard
Most of the constants are taken from arch/arm/mach-omap2/mux.h. Define some others for the PIN_OUTPUT_* flavours. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Reviewed-by: Stephen Warren swar...@nvidia.com --- include/dt-bindings

[PATCH v4 2/5] ARM: dts: OMAP2+: Use existing constants for GPIOs

2013-05-31 Thread Florian Vaussard
Use standard GPIO constants to enhance the readability of DT GPIOs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Reviewed-by: Stephen Warren swar...@nvidia.com --- arch/arm/boot/dts/omap2.dtsi |2 ++ arch/arm/boot

[PATCH v4 1/5] ARM: dts: OMAP2+: Use #include for all device trees

2013-05-31 Thread Florian Vaussard
Replace /include/ by #include for OMAP2+ DT, in order to use the C pre-processor, making use of #define features possible. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Reviewed-by: Stephen Warren swar...@nvidia.com --- arch/arm

[PATCH v4 0/5] ARM: dts: OMAP2+: Use preprocessor for device trees

2013-05-31 Thread Florian Vaussard
will follow shortly. Best regards, Florian From v3: - Rebased on Benoit's for_3.11/dts branch From v2: - Address Tony's comments (standardize comments, remove OMAP_ prefix) From v1: - Remove duplicated fix - Remove OMAP_GPIO macro - Add pinctrl constants Florian Vaussard (5): ARM: dts: OMAP2

[PATCH v4 3/5] ARM: dts: OMAP4/5: Use existing constants for IRQs

2013-05-31 Thread Florian Vaussard
Use the constants defined in include/dt-bindings/interrupt-controller/ to enhance readability. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Reviewed-by: Stephen Warren swar...@nvidia.com --- arch/arm/boot/dts/omap4-panda

[PATCH v4 5/5] ARM: dts: OMAP2+: Use pinctrl constants

2013-05-31 Thread Florian Vaussard
Using constants for pinctrl allows a better readability, and removes redundancy with comments. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Reviewed-by: Stephen Warren swar...@nvidia.com --- arch/arm/boot/dts/omap2.dtsi

[PATCH 1/4] ARM: dts: AM3XXX: Use #include for all device trees

2013-05-31 Thread Florian Vaussard
Replace /include/ by #include for AM33XX and AM35XX device tree files, in order to use the C pre-processor, making use of #define features possible. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/am335x-bone.dts |2 +- arch/arm/boot/dts/am335x-evm.dts

[PATCH 0/4] ARM: dts: AM3XXX: Use preprocessor for device trees

2013-05-31 Thread Florian Vaussard
+: Use preprocessor for device trees, itself based on Benoit's for_3.11/dts branch. Regards, Florian Florian Vaussard (4): ARM: dts: AM3XXX: Use #include for all device trees ARM: dts: AM33XX: Use existing constants for GPIOs ARM: dts: AM33XX: Specific pinctrl header ARM: dts: AM33XX: Use

[PATCH 3/4] ARM: dts: AM33XX: Specific pinctrl header

2013-05-31 Thread Florian Vaussard
The pinctrl IP inside the AM33XX family differs slightly from what is found on OMAP2+. Define a specific header to take account of the differences. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- include/dt-bindings/pinctrl/am33xx.h | 19 +++ 1 files changed, 19

[PATCH 4/4] ARM: dts: AM33XX: Use pinctrl constants

2013-05-31 Thread Florian Vaussard
Using constants for pinctrl allows a better readability, and removes redundancy with comments. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/am335x-bone.dts | 18 +- arch/arm/boot/dts/am335x-evm.dts | 28 ++-- arch

[PATCH 2/4] ARM: dts: AM33XX: Use existing constants for GPIOs

2013-05-31 Thread Florian Vaussard
Use standard GPIO constants to enhance the readability of DT GPIOs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/am335x-bone.dts |8 arch/arm/boot/dts/am335x-evm.dts | 14 +++--- arch/arm/boot/dts/am335x-evmsk.dts | 16

Re: [PATCH] ARM: dts: omap3-devkit8000: fix NAND memory binding

2013-05-31 Thread Florian Vaussard
Hello, Gentle ping. Does someone has any comments on this fix? Can someone tests on the real hardware? Regards, Florian On 05/23/2013 10:11 AM, Florian Vaussard wrote: Commit d36b4cd 'ARM: OMAP2+: Add additional GPMC timing parameters' updated GPMC binding, but omap3-devkit8000

[PATCH v2 1/1] ARM: dts: OMAP4/AM35xx: Fix missing dtb in the dtbs target

2013-05-31 Thread Florian Vaussard
When making the dtbs target on OMAP/AM35xx, some trees are not built. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/Makefile |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index

[PATCH v2 0/1] ARM: dts: OMAP4/AM35xx: Fix missing dtb in the dtbs target

2013-05-31 Thread Florian Vaussard
Hello, When testing the OMAP/AM35xx DTS, I noticed that some platforms were missing from the dtbs target, forcing the user to build them manually. This patch corrects this. Regards, Florian Since v1: - Added AM35xx missing platforms Florian Vaussard (1): ARM: dts: OMAP4/AM35xx: Fix missing

Re: [PATCH v9] ARM: dts: omap4-panda: Update the LED support for the panda DTS

2013-05-31 Thread Florian Vaussard
Hello Dan, On 05/31/2013 05:19 PM, Dan Murphy wrote: The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different. A1-A3 = gpio_wk7 ES = gpio_110 There is no change to LED D2 Abstract away the pinmux and the LED definitions for the two boards into the respective DTS

Re: [PATCH v2 1/1] ARM: dts: OMAP4/AM35xx: Fix missing dtb in the dtbs target

2013-05-31 Thread Florian Vaussard
Hello Benoit, On 05/31/2013 04:45 PM, Benoit Cousson wrote: On 05/31/2013 04:05 PM, Florian Vaussard wrote: When making the dtbs target on OMAP/AM35xx, some trees are not built. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Thanks for the fix Florian. I need to applied your AM

Re: [PATCH v1] ARM: dts: omap4-panda: Update the twl6040 gpio to macro definition

2013-05-31 Thread Florian Vaussard
= v1v8; v2v1-supply = v2v1; I missed it during the conversion, thank you. Reviewed-by: Florian Vaussard florian.vauss...@epfl.ch ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: [PATCH 1/2] gpiolib: add gpio_export_with_name

2013-05-30 Thread Florian Vaussard
Hello Grant, On 11/26/2012 02:59 PM, Grant Likely wrote: On Wed, 21 Nov 2012 11:14:08 +0100, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: allow to specify a name to an exported gpio Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com The gpio sysfs ABI is

[PATCH 0/3] mfd: twl4030-power: Start DT conversion

2013-05-30 Thread Florian Vaussard
around 350 mA on Overo+Tobi to about 40 mA. The poweroff callback was tested with both DT and non-DT boots. Best regards, Florian Florian Vaussard (3): mfd: twl4030-power: Split from twl-core into a dedicated module mfd: twl4030-power: Start transition to DT mfd: twl4030-power: Simplify error

[PATCH 1/3] mfd: twl4030-power: Split from twl-core into a dedicated module

2013-05-30 Thread Florian Vaussard
For now, the call to twl4030-power is hard-wired inside twl-core. To ease the future transition to DT, make twl4030-power as a separate module, like what is already done for twl4030-audio and others. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl-core.c | 12

[PATCH 2/3] mfd: twl4030-power: Start transition to DT

2013-05-30 Thread Florian Vaussard
Support for loading twl4030-power module via devicetree. For now, when booting with a DT, only the poweroff callback feature is supported through the ti,use_poweroff property. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- .../devicetree/bindings/mfd/twl4030-power.txt | 28

[PATCH 3/3] mfd: twl4030-power: Simplify error path

2013-05-30 Thread Florian Vaussard
Remove unnecessary goto statements, causing duplicated if conditions. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl4030-power.c | 37 ++--- 1 files changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/twl4030

Re: [PATCH 1/2] gpiolib: add gpio_export_with_name

2013-05-30 Thread Florian Vaussard
Hello Linus, On 05/30/2013 10:03 PM, Linus Walleij wrote: On Thu, May 30, 2013 at 11:19 AM, Florian Vaussard florian.vauss...@epfl.ch wrote: Even if work is progressing towards having gpio-controlled reset pins [1], some boards still need GPIOs to be exported to userspace for other

Re: [PATCH v2 14/14] ARM: dts: AM43x: initial support

2013-05-29 Thread Florian Vaussard
Hello, On 05/29/2013 10:53 AM, Benoit Cousson wrote: + Florian Hi Afzal, On 05/27/2013 04:37 PM, Afzal Mohammed wrote: DT source (minimal) for AM4372 SoC to represent AM43x SoC's. Those represented here are the minimal DT nodes necessary to get kernel booting. In DT nodes, ti,hwmod property

Re: [PATCH v3 0/5] ARM: dts: OMAP2+: use preprocessor for device trees

2013-05-28 Thread Florian Vaussard
On 05/27/2013 04:52 PM, Florian Vaussard wrote: Hello, Following a similar proposal by Stephen Warren for tegra [1], this series makes use of the C preprocessor when compiling OMAP DT files, and accomplishes some improvements to improve overall readability. I realized that I should also

Re: [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees

2013-05-28 Thread Florian Vaussard
On 05/28/2013 05:07 PM, Stephen Warren wrote: On 05/23/2013 09:36 AM, Florian Vaussard wrote: Hello, Following a similar proposal by Stephen Warren for tegra [1], this series makes use of the C preprocessor when compiling OMAP DT files, and accomplishes some improvements to improve overall

Re: [PATCH v2 5/5] ARM: dts: OMAP2+: use pinctrl constants

2013-05-27 Thread Florian Vaussard
Hello Tony, Thanks for your review. On 05/23/2013 08:46 PM, Tony Lindgren wrote: * Florian Vaussard florian.vauss...@epfl.ch [130523 08:42]: index f39b237..b3cc896 100644 --- a/arch/arm/boot/dts/omap2.dtsi +++ b/arch/arm/boot/dts/omap2.dtsi @@ -9,6 +9,7 @@ */ #include dt-bindings/gpio

Re: [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees

2013-05-27 Thread Florian Vaussard
Hello Santosh, Thank you for your review. On 05/23/2013 06:00 PM, Santosh Shilimkar wrote: On Thursday 23 May 2013 11:36 AM, Florian Vaussard wrote: Hello, Following a similar proposal by Stephen Warren for tegra [1], this series makes use of the C preprocessor when compiling OMAP DT files

[PATCH v3 0/5] ARM: dts: OMAP2+: use preprocessor for device trees

2013-05-27 Thread Florian Vaussard
Tony's comments (standardize comments, remove OMAP_ prefix) From v1: - Remove duplicated fix - Remove OMAP_GPIO macro - Add pinctrl constants Florian Vaussard (5): ARM: dts: OMAP2+: use #include for all device trees ARM: dts: OMAP2+: use existing constants for GPIOs ARM: dts: OMAP4/5: use

[PATCH v3 1/5] ARM: dts: OMAP2+: use #include for all device trees

2013-05-27 Thread Florian Vaussard
Replace /include/ by #include for OMAP2+ DT, in order to use the C pre-processor, making use of #define features possible. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/boot/dts/omap2.dtsi |2 +- arch

[PATCH v3 2/5] ARM: dts: OMAP2+: use existing constants for GPIOs

2013-05-27 Thread Florian Vaussard
Use standard GPIO constants to enhance the readability of DT GPIOs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/boot/dts/omap2.dtsi |2 ++ arch/arm/boot/dts/omap3-beagle-xm.dts |4 ++-- arch

[PATCH v3 3/5] ARM: dts: OMAP4/5: use existing constants for IRQs

2013-05-27 Thread Florian Vaussard
Use the constants defined in include/dt-bindings/interrupt-controller/ to enhance readability. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/boot/dts/omap4-panda-common.dtsi |8 +- arch/arm/boot/dts/omap4-sdp.dts

[PATCH v3 4/5] ARM: dts: OMAP2+: header file for pinctrl constants

2013-05-27 Thread Florian Vaussard
Most of the constants are taken from arch/arm/mach-omap2/mux.h. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- include/dt-bindings/pinctrl/omap.h | 50 1 files changed, 50 insertions(+), 0

[PATCH v3 5/5] ARM: dts: OMAP2+: use pinctrl constants

2013-05-27 Thread Florian Vaussard
Using constants for pinctrl allows a better readability, and remove redundancy with comments. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/boot/dts/omap2.dtsi |1 + arch/arm/boot/dts/omap3-beagle.dts

[PATCH 1/2] ARM: dts: Add omap3-overo NAND flash memory binding

2013-05-23 Thread Florian Vaussard
Add device-tree node for the on-board NAND memory. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-overo.dtsi | 50 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b

[PATCH 2/2] ARM: dts: omap3-overo: add default trigger for TWL4030 LED

2013-05-23 Thread Florian Vaussard
Commit c971ff1 'leds: leds-pwm: Defer led_pwm_set() if PWM can sleep' fixed a crash when using a trigger with a pwm-led provided by an external chip. Now it is safe to add the default trigger according to board-overo.c. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot

[PATCH 0/2] ARM: dts: updates for omap3-overo

2013-05-23 Thread Florian Vaussard
Hello, This series adds support to omap3-overo for the onboard NAND memory, and restore the default trigger for the pwm-led provided by TWL4030. Best regards, Florian Florian Vaussard (2): ARM: dts: Add omap3-overo NAND flash memory binding ARM: dts: omap3-overo: add default trigger

[PATCH] ARM: dts: omap3-devkit8000: fix NAND memory binding

2013-05-23 Thread Florian Vaussard
Commit d36b4cd 'ARM: OMAP2+: Add additional GPMC timing parameters' updated GPMC binding, but omap3-devkit8000 was not updated accordingly, resulting in a broken configuration. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-devkit8000.dts | 29

[PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees

2013-05-23 Thread Florian Vaussard
fix - Remove OMAP_GPIO macro - Add pinctrl constants Florian Vaussard (5): ARM: dts: OMAP2+: use #include for all device trees ARM: dts: OMAP2+: use existing constants for GPIOs ARM: dts: OMAP4/5: use existing constants for IRQs ARM: dts: OMAP2+: header file for pinctrl constants ARM: dts

[PATCH v2 1/5] ARM: dts: OMAP2+: use #include for all device trees

2013-05-23 Thread Florian Vaussard
Replace /include/ by #include for OMAP2+ DT, in order to use the C pre-processor, making use of #define features possible. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap2.dtsi |2 +- arch/arm/boot/dts/omap2420-h4.dts |2 +- arch

[PATCH v2 2/5] ARM: dts: OMAP2+: use existing constants for GPIOs

2013-05-23 Thread Florian Vaussard
Use standard GPIO constants to enhance the readability of DT GPIOs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap2.dtsi |2 ++ arch/arm/boot/dts/omap3-beagle-xm.dts |4 ++-- arch/arm/boot/dts/omap3-beagle.dts|6

[PATCH v2 3/5] ARM: dts: OMAP4/5: use existing constants for IRQs

2013-05-23 Thread Florian Vaussard
Use the constants defined in include/dt-bindings/interrupt-controller/ to enhance readability. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap4-panda-common.dtsi |8 +- arch/arm/boot/dts/omap4-sdp.dts |6 +- arch/arm/boot/dts/omap4-var

[PATCH v2 4/5] ARM: dts: OMAP2+: header file for pinctrl constants

2013-05-23 Thread Florian Vaussard
Most of the constants are taken from arch/arm/mach-omap2/mux.h. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- include/dt-bindings/pinctrl/omap.h | 54 1 files changed, 54 insertions(+), 0 deletions(-) create mode 100644 include/dt-bindings

[PATCH v2 5/5] ARM: dts: OMAP2+: use pinctrl constants

2013-05-23 Thread Florian Vaussard
Using constants for pinctrl allows a better readability, and remove redundancy with comments. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap2.dtsi |1 + arch/arm/boot/dts/omap3-beagle.dts| 24 arch/arm/boot/dts/omap3

[PATCH] ARM: dts: OMAP4. fix missing omap4-sdp-es23plus.dtb in dtbs target

2013-05-23 Thread Florian Vaussard
When making the dtbs target, omap4-sdp-es23plus.dtb is not built. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index b9f7121

[PATCH 0/5] ARM: dts: OMAP2+: use preprocessor for device trees

2013-05-22 Thread Florian Vaussard
, Florian [1] https://patchwork.kernel.org/patch/2560091/ Florian Vaussard (5): ARM: dts: OMAP2+: use #include for all device trees ARM: dts: OMAP2+: create a DT header for GPIO ARM: dts: OMAP2+: convert DT files to use the new OMAP_GPIO macro ARM: dts: OMAP3: fix incorrect notation for musb

[PATCH 1/5] ARM: dts: OMAP2+: use #include for all device trees

2013-05-22 Thread Florian Vaussard
Replace /include/ by #include for OMAP2+ DT, in order to use the C pre-processor, making use of #define features possible. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap2.dtsi |2 +- arch/arm/boot/dts/omap2420-h4.dts |2 +- arch

[PATCH 2/5] ARM: dts: OMAP2+: create a DT header for GPIO

2013-05-22 Thread Florian Vaussard
Define the OMAP_GPIO macro to conveniently use GPIO inside OMAP DT. For example: gpios = gpio6 3 0; /* GPIO 163 */ can be replaced by gpios = OMAP_GPIO(163, 0); Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- include/dt-bindings/gpio/omap-gpio.h | 289

[PATCH 4/5] ARM: dts: OMAP3: fix incorrect notation for musb-hdrc interrupt

2013-05-22 Thread Florian Vaussard
On OMAP3, the INTC interrupt controller has only 1 cell. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3.dtsi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 15049b8

Re: [PATCH 1/5] ARM: dts: OMAP2+: use #include for all device trees

2013-05-22 Thread Florian Vaussard
Hi Tony, On 05/22/2013 05:40 PM, Tony Lindgren wrote: * Florian Vaussard florian.vauss...@epfl.ch [130522 07:33]: Replace /include/ by #include for OMAP2+ DT, in order to use the C pre-processor, making use of #define features possible. This is good, but let's use it with case. Probably

Re: [PATCH 2/5] ARM: dts: OMAP2+: create a DT header for GPIO

2013-05-22 Thread Florian Vaussard
Hello Stephan, Tony, Thank you for your reviews. On 05/22/2013 05:34 PM, Tony Lindgren wrote: * Stephen Warren swar...@wwwdotorg.org [130522 08:32]: On 05/22/2013 08:27 AM, Florian Vaussard wrote: Define the OMAP_GPIO macro to conveniently use GPIO inside OMAP DT. For example: gpios

Re: [PATCH 3/5] ARM: dts: OMAP2+: convert DT files to use the new OMAP_GPIO macro

2013-05-22 Thread Florian Vaussard
Hi Stepen, Thank you for your review, On 05/22/2013 05:28 PM, Stephen Warren wrote: On 05/22/2013 08:27 AM, Florian Vaussard wrote: Use OMAP_GPIO(), in conjunction with standard GPIO flags, to enhance the readability of DT GPIOs. diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch

Re: [PATCH 0/9] ARM: dts: Various OMAP2+ device-tree updates

2013-03-14 Thread Florian Vaussard
series for v3.10. This is based upon v3.9-rc1 and the OMAP3 GPMC binding from Florian Vaussard [1] and OMAP5 DT SPI patch from Felipe Balbi [2]. [1] https://patchwork.kernel.org/patch/2057111/ I've tried to follow the series review, and it seems that Florian was considering sending some other

Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support

2013-02-26 Thread Florian Vaussard
Hi, On 02/07/2013 08:58 AM, Peter Ujfalusi wrote: Hi, On 02/06/2013 02:30 PM, Benoit Cousson wrote: So a patch is being merged to handle triggers in the case of pwm leds [1]. When done, we will be able to add back the default trigger. Do you want to wait on it to merge this series? What

Re: [PATCH 1/2] ARM: dts: OMAP3: Add GPMC controller

2013-02-05 Thread Florian Vaussard
Hi Javier, On 02/04/2013 12:57 PM, Javier Martinez Canillas wrote: [...] Yes, I saw on the list that Tony asked you too extend the GPMC DT support. Flash support is on my TODO list too but I don't know if I'm going to have time to work on this in the next few weeks. Since you are thinking

Re: [PATCH 0/2] ARM: dts: OMAP3: Add GPMC controller and NAND memory to Overo

2013-02-04 Thread Florian Vaussard
So how should we handle such case? Having several dtsi depending on the Overo's revision would be a mess to my sense, considering the non-conditional include inside the expansion boards' dts. Or would it make sense to extend the DT binding for partitions? Yes makes sense to extend the binding

Re: [PATCH 0/2] ARM: dts: omap3-overo: Add pwm-leds and audio support

2013-02-04 Thread Florian Vaussard
Hello Benoit, On 01/24/2013 01:21 PM, Benoit Cousson wrote: + Peter who did the original PWM Hi Florian, On 01/23/2013 06:56 PM, Florian Vaussard wrote: Hello Benoit, This patchset adds some new DT supports to the Overo products. The first patch converts the PMIC LEDB output to use the pwm

Re: [PATCH 1/2] ARM: dts: OMAP3: Add GPMC controller

2013-02-04 Thread Florian Vaussard
Hi Javier, On 02/04/2013 10:27 AM, Javier Martinez Canillas wrote: Hi Florian, On Mon, Jan 28, 2013 at 6:54 PM, Florian Vaussard florian.vauss...@epfl.ch wrote: Add device-tree support for the GPMC controller on the OMAP3. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch

[PATCH 2/2] ARM: dts: OMAP3: Add NAND memory for Overo products

2013-01-28 Thread Florian Vaussard
Add device-tree support for the on-board NAND memory, with corresponding partitions. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3-overo.dtsi | 49 1 files changed, 49 insertions(+), 0 deletions(-) diff --git a/arch

[PATCH 0/2] ARM: dts: OMAP3: Add GPMC controller and NAND memory to Overo

2013-01-28 Thread Florian Vaussard
-conditional include inside the expansion boards' dts. Or would it make sense to extend the DT binding for partitions? This serie was tested on an Overo with 512MB of NAND. Best regards, Florian [1] git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git omap-for-v3.9/gpmc Florian

[PATCH 1/2] ARM: dts: OMAP3: Add GPMC controller

2013-01-28 Thread Florian Vaussard
Add device-tree support for the GPMC controller on the OMAP3. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi

Re: [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds

2013-01-25 Thread Florian Vaussard
We have two drivers at the moment: pwm-twl and pwm-twl-led. However new out of SoC PWM drivers might come (for example for palmas). So it worth take a look at some generic implementation. OK. So I have the series. I need to add few more things but pwm-leds on BeagleBoard works fine when I put

Re: [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds

2013-01-24 Thread Florian Vaussard
Hi Peter, diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi index 89808ce..800be29 100644 --- a/arch/arm/boot/dts/omap3-overo.dtsi +++ b/arch/arm/boot/dts/omap3-overo.dtsi @@ -14,12 +14,13 @@ /include/ omap3.dtsi / { - leds { -

Re: [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds

2013-01-24 Thread Florian Vaussard
I did it at first, but the led API executes in atomic context, where the pwm-twl-led driver uses i2c communication. Setting a trigger will result in a kernel panic. Now that you mentioned it, this might be true. [c0013204] (unwind_backtrace+0x0/0xec) from [c00348ac]

Re: [PATCH 1/2] ARM: dts: omap3-overo: Add support for pwm-leds

2013-01-24 Thread Florian Vaussard
Hi I am working on a patch for pwm-twl-led to defer using a workqueue right now. Great! The only thing I worry about is the latency we are going to get with the workqueue. If the latency becomes critical, we can create our own workqueue. Hrm, when we handled the led via gpio-leds it

  1   2   >