[PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-21 Thread Gerhard Sittig
make the matrix_keypad_map_key() routine return an error code instead of boolean, as its name suggests an action and not a query Signed-off-by: Gerhard Sittig --- drivers/input/matrix-keymap.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH v1 00/12] input: keypad-matrix: doc update, hw separation, polling, binary columns

2013-06-21 Thread Gerhard Sittig
] = us[1] = 0; total: 0 errors, 0 warnings, 1 checks, 95 lines checked Gerhard Sittig (12): input: matrix-keypad: update devicetree binding doc input: matrix-keymap: func call coding style nit input: matrix-keypad: rename variables and funcs input: matrix-keypad: push/pull, separ

[PATCH v1 05/12] input: matrix-keypad: update comments, diagnostics

2013-06-21 Thread Gerhard Sittig
- add comments about individual routines' purpose and their interaction, pre-conditions and consequences - mark a few spots which may need some more attention or clarification - rephrase some diagnostics messages Signed-off-by: Gerhard Sittig --- drivers/input/keyboard/matrix_keypad.c |

[PATCH v1 07/12] input: keypad-matrix: introduce polling support

2013-06-21 Thread Gerhard Sittig
could be made to work appropriately in the polling case Signed-off-by: Gerhard Sittig --- .../bindings/input/gpio-matrix-keypad.txt | 17 drivers/input/keyboard/matrix_keypad.c | 92 ++-- include/linux/input/matrix_keypad.h|4 +- 3

[PATCH v1 06/12] input: keypad-matrix: refactor matrix scan logic

2013-06-21 Thread Gerhard Sittig
-off-by: Gerhard Sittig --- drivers/input/keyboard/matrix_keypad.c | 43 ++-- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 85e16a2..0b2599d 100644 --- a/drivers

[PATCH v1 01/12] input: matrix-keypad: update devicetree binding doc

2013-06-21 Thread Gerhard Sittig
update the device tree binding documentation for the GPIO matrix keypad driver: mention the driver's selecting all columns at once, reword the delay descriptions, add the missing active low GPIO pin level property Signed-off-by: Gerhard Sittig --- .../bindings/input/gpio-matrix-keypa

[PATCH v1 04/12] input: matrix-keypad: push/pull, separate polarity

2013-06-21 Thread Gerhard Sittig
de or configurations, and is an improvement in those areas where the former implementations was restricted Signed-off-by: Gerhard Sittig --- .../bindings/input/gpio-matrix-keypad.txt | 18 + arch/arm/mach-davinci/board-tnetv107x-evm.c|3 +- arch/arm/mach-omap2/board

[PATCH v1 03/12] input: matrix-keypad: rename variables and funcs

2013-06-21 Thread Gerhard Sittig
eflect that it takes care of GPIO pins while its caller handles logical matrix lines Signed-off-by: Gerhard Sittig --- drivers/input/keyboard/matrix_keypad.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/input/keyboard/matrix_keypa

[PATCH v1 12/12] input: matrix-keypad: add diagnostics in probe()

2013-06-21 Thread Gerhard Sittig
optionally dump relevant configuration of pins, matrix lines, and delay/interval times at the very end of the probe routine (development feature, silent by default) Signed-off-by: Gerhard Sittig --- drivers/input/keyboard/matrix_keypad.c | 18 ++ 1 file changed, 18 insertions

[PATCH v1 09/12] input: matrix-keypad: add binary column encoding

2013-06-21 Thread Gerhard Sittig
introduce support to optionally run a binary column address bit pattern on column GPIO pins in contrast to the formerly assumed one-out-of-N approach Signed-off-by: Gerhard Sittig --- .../bindings/input/gpio-matrix-keypad.txt | 46 ++-- drivers/input/keyboard

[PATCH v1 11/12] input: keypad-matrix: AC14xx device tree update

2013-06-21 Thread Gerhard Sittig
r more reliable detection of short lived key presses (including a range spec to reduce timer management overhead) as well as a slightly increased overall matrix poll frequency - fix keymap comments, make the names match the codes Signed-off-by: Gerhard Sittig --- arch/powerpc/boot/dts/ac

[PATCH v1 10/12] input: keypad_matrix: use usleep_range() for scan delay

2013-06-21 Thread Gerhard Sittig
ost Signed-off-by: Gerhard Sittig --- .../bindings/input/gpio-matrix-keypad.txt |7 +++-- drivers/input/keyboard/matrix_keypad.c | 29 +--- include/linux/input/matrix_keypad.h|5 3 files changed, 35 insertions(+), 6 deletions(-

[PATCH v1 08/12] input: keypad-matrix: tell GPIO pins from matrix lines

2013-06-21 Thread Gerhard Sittig
gned-off-by: Gerhard Sittig --- .../bindings/input/gpio-matrix-keypad.txt | 16 +++ drivers/input/keyboard/matrix_keypad.c | 50 ++-- include/linux/input/matrix_keypad.h|6 +++ 3 files changed, 57 insertions(+), 15 deletions(-) d

Re: [PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-22 Thread Gerhard Sittig
or v2. Thank you for reviewing this. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-

Re: [PATCH v1 12/12] input: matrix-keypad: add diagnostics in probe()

2013-06-22 Thread Gerhard Sittig
On Sat, Jun 22, 2013 at 04:28 +0200, Marek Vasut wrote: > > Dear Gerhard Sittig, > > > optionally dump relevant configuration of pins, matrix lines, > > and delay/interval times at the very end of the probe routine > > (development feature, silent by default) >

Re: [PATCH v1 01/12] input: matrix-keypad: update devicetree binding doc

2013-06-22 Thread Gerhard Sittig
comes available upon request, and all of it is documented. On Fri, Jun 21, 2013 at 15:31 -0600, Stephen Warren wrote: > > On 06/21/2013 12:09 PM, Gerhard Sittig wrote: > > update the device tree binding documentation for the GPIO matrix keypad > > driver: mention the driver's

Re: [PATCH v1 04/12] input: matrix-keypad: push/pull, separate polarity

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 15:34 -0600, Stephen Warren wrote: > > On 06/21/2013 12:09 PM, Gerhard Sittig wrote: > > extend the device tree adjustable hardware configuration: > > - allow for differing polarity of the row and column GPIO pins > > - optionally fully drive colum

Re: [PATCH v1 07/12] input: keypad-matrix: introduce polling support

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 15:38 -0600, Stephen Warren wrote: > > On 06/21/2013 12:09 PM, Gerhard Sittig wrote: > > detecting changes in the key press status may not work reliably in > > interrupt driven mode (see the documentation part of the change for > > details) > >

Re: [PATCH v1 08/12] input: keypad-matrix: tell GPIO pins from matrix lines

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 15:41 -0600, Stephen Warren wrote: > > On 06/21/2013 12:09 PM, Gerhard Sittig wrote: > > > diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt > > b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt > > >

Re: [PATCH v1 10/12] input: keypad_matrix: use usleep_range() for scan delay

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 16:00 -0600, Stephen Warren wrote: > > On 06/21/2013 12:09 PM, Gerhard Sittig wrote: > > querying keyboards isn't a time critical task and does not depend on > > exact timing in the microseconds order -- the timeouts and delays are > > arbitrar

Re: [PATCH v1 08/12] input: keypad-matrix: tell GPIO pins from matrix lines

2013-06-28 Thread Gerhard Sittig
(which may or may not be expensive in "abolute" terms, but certainly is more expensive than a keymap check), and eliminiates the issue of emitting events which lack codes. Sounds like the appropriate solution to the problem. virtually yours Gerhard Sittig -- DENX Software Engineering Gm

Re: [PATCH v1 01/12] input: matrix-keypad: update devicetree binding doc

2013-06-28 Thread Gerhard Sittig
On Mon, Jun 24, 2013 at 16:00 -0600, Stephen Warren wrote: > > On 06/22/2013 03:23 AM, Gerhard Sittig wrote: > ... > > [ device tree binding doc, discussing matrix hardware layouts ] > > I think both "simple" and "mechanical" should be removed. My r

Re: [PATCH v1 04/12] input: matrix-keypad: push/pull, separate polarity

2013-06-28 Thread Gerhard Sittig
is fits with my observation that application drivers on top of gpiolib often take care of such a property which actually looks like it would belong to the physical attachment. I understand that a chip's driver will hide when a SoC's pin is inverted, but I cannot see where gpiolib pr

Re: [PATCH v1 01/12] input: matrix-keypad: update devicetree binding doc

2013-06-30 Thread Gerhard Sittig
atures which explicitly must get enabled before changed behaviour will occur. So I need some more time to think of which parts to change in which ways and how to make sure that nothings breaks ... virtually yours Gerhard Sittig -- DENX Software Engineering GmbH,

Re: [PATCH v1 04/12] input: matrix-keypad: push/pull, separate polarity

2013-06-30 Thread Gerhard Sittig
On Fri, Jun 28, 2013 at 09:01 -0600, Stephen Warren wrote: > > On 06/28/2013 02:33 AM, Gerhard Sittig wrote: > > On Mon, Jun 24, 2013 at 17:14 -0600, Stephen Warren wrote: > >> > >> [ active low pins, individually for sets or even single pins ] > >> > &g

Re: [PATCH v1 08/12] input: keypad-matrix: tell GPIO pins from matrix lines

2013-06-30 Thread Gerhard Sittig
On Fri, Jun 28, 2013 at 11:25 -0700, Dmitry Torokhov wrote: > > On Fri, Jun 28, 2013 at 08:35:42AM -0600, Stephen Warren wrote: > > On 06/28/2013 01:52 AM, Gerhard Sittig wrote: > > > > > > [ late reply, just catching up with the backlog ] > > > &g

[PATCH RFC 0/8] MPC512x DMA slave s/g support, OF DMA lookup

2013-07-12 Thread Gerhard Sittig
blurb is below the stats Alexander Popov (1): powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory Gerhard Sittig (6): dma: mpc512x: fix start condition in execute() dma: mpc512x: support 'terminate all' control request dts: mpc512x: p

[PATCH RFC 1/8] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-07-12 Thread Gerhard Sittig
From: Alexander Popov From: Alexander Popov Data transfers between memory and i/o memory require more delicate TCD (Transfer Control Descriptor) configuration and DMA channel service requests via hardware. dma_device.device_control callback function is needed to configure DMA channel to work w

[PATCH RFC 2/8] dma: mpc512x: fix start condition in execute()

2013-07-12 Thread Gerhard Sittig
adjust the conditions how submitted DMA jobs get started: memory transfers need to get initiated by an explicit software request, all transfers which involve peripherals need to reference the external requester line Signed-off-by: Gerhard Sittig --- drivers/dma/mpc512x_dma.c |4 +++- 1 file

[PATCH RFC 3/8] dma: mpc512x: support 'terminate all' control request

2013-07-12 Thread Gerhard Sittig
device_control() routine's introduction) Signed-off-by: Gerhard Sittig --- drivers/dma/mpc512x_dma.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c index df10a48..0053ff8 100644 --- a/driver

[PATCH RFC 4/8] dts: mpc512x: prepare for preprocessor support

2013-07-12 Thread Gerhard Sittig
prepare C preprocessor support when processing MPC512x DTS files - switch from DTS syntax to CPP syntax for include specs - create a symlink such that DTS processing can reference includes Signed-off-by: Gerhard Sittig --- arch/powerpc/boot/dts/ac14xx.dts |2 +- arch/powerpc/boot

[PATCH RFC 5/8] dma: mpc512x: use symbolic specifiers for DMA channels

2013-07-12 Thread Gerhard Sittig
the mpc5121.dtsi as well as the DMA engine driver use those names instead of numbers Signed-off-by: Gerhard Sittig --- arch/powerpc/boot/dts/mpc5121.dtsi|6 +- drivers/dma/mpc512x_dma.c |6 -- include/dt-bindings/dma/mpc512x-dma.h | 21 + 3

[PATCH RFC 6/8] dma: of: Add common xlate function for matching by channel id

2013-07-12 Thread Gerhard Sittig
From: Lars-Peter Clausen From: Lars-Peter Clausen This patch adds a new common OF dma xlate callback function which will match a channel by it's id. The binding expects one integer argument which it will use to lookup the channel by the id. Unlike of_dma_simple_xlate this function is able to

[PATCH RFC 7/8] dma: mpc512x: register for device tree channel lookup

2013-07-12 Thread Gerhard Sittig
register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees), provide the '#dma-cells' property in the shared mpc5121.dtsi file, and introduce a bindings document for the MPC512x DMA controller Signed-off-by: Gerh

[PATCH RFC 8/8] HACK mmc: mxcmmc: enable clocks for the MPC512x

2013-07-12 Thread Gerhard Sittig
Q&D HACK to enable SD card support without correct COMMON_CLK support, best viewed with 'git diff -w -b', NOT acceptable for mainline (NAKed) Signed-off-by: Gerhard Sittig --- drivers/mmc/host/mxcmmc.c | 41 +++-- 1 file changed, 27 ins

Re: [PATCH RFC 5/8] dma: mpc512x: use symbolic specifiers for DMA channels

2013-07-13 Thread Gerhard Sittig
[ MPC8308 knowledge required, see below ] On Sat, Jul 13, 2013 at 09:17 +0200, Arnd Bergmann wrote: > > On Friday 12 July 2013, Gerhard Sittig wrote: > > +++ b/include/dt-bindings/dma/mpc512x-dma.h > > @@ -0,0 +1,21 @@ > > +/* > > + * This header file provid

Re: [PATCH RFC 5/8] dma: mpc512x: use symbolic specifiers for DMA channels

2013-07-14 Thread Gerhard Sittig
On Sun, Jul 14, 2013 at 10:50 +0200, Arnd Bergmann wrote: > > On Saturday 13 July 2013, Gerhard Sittig wrote: > > > > [ ... ] > > > > Thank you for the feedback. > > > > OK, so not adding the dt-bindings header leads to no change in > > the DTS n

Re: [PATCH RFC 1/8] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-07-14 Thread Gerhard Sittig
On Sun, Jul 14, 2013 at 12:05 +0200, Lars-Peter Clausen wrote: > > On 07/12/2013 05:26 PM, Gerhard Sittig wrote: > [...] > ] > > + if (mchan->tcd_nunits) > > + tcd->nbytes = mchan->tcd_nunits * 4; > > + else > > +

[PATCH RFC v2 0/5] MPC512x DMA slave s/g support, OF DMA lookup

2013-07-14 Thread Gerhard Sittig
r adjust the parts that I've contributed Alexander Popov (1): dma: mpc512x: add support for peripheral transfers Gerhard Sittig (3): dma: mpc512x: re-order mpc8308 specific instructions dma: mpc512x: register for device tree channel lookup HACK mmc: mxcmmc: enable clocks for the MPC512x

[PATCH RFC v2 1/5] dma: mpc512x: re-order mpc8308 specific instructions

2013-07-14 Thread Gerhard Sittig
hannel count which in combination with the re-ordering obsoletes a comment this modification only re-orders instructions but doesn't change behaviour Signed-off-by: Gerhard Sittig --- drivers/dma/mpc512x_dma.c | 48 + 1 file changed, 31 insert

[PATCH RFC v2 2/5] dma: mpc512x: add support for peripheral transfers

2013-07-14 Thread Gerhard Sittig
of slave s/g preparation and device control ] Signed-off-by: Alexander Popov [ execute() start condition, mpc8308 compat, terminate all, s/g length check, reworded commit msg ] Signed-off-by: Gerhard Sittig --- drivers/dma/mpc512x_dma.c | 168 +++-- 1 file

[PATCH RFC v2 3/5] dma: of: Add common xlate function for matching by channel id

2013-07-14 Thread Gerhard Sittig
d DMA controller. Signed-off-by: Lars-Peter Clausen Signed-off-by: Gerhard Sittig --- drivers/dma/of-dma.c | 47 +++ include/linux/of_dma.h |4 2 files changed, 51 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c

[PATCH RFC v2 5/5] HACK mmc: mxcmmc: enable clocks for the MPC512x

2013-07-14 Thread Gerhard Sittig
Q&D HACK to enable SD card support without correct COMMON_CLK support, best viewed with 'git diff -w -b', NOT acceptable for mainline (NAKed) Signed-off-by: Gerhard Sittig --- drivers/mmc/host/mxcmmc.c | 41 +++-- 1 file changed, 27 ins

[PATCH RFC v2 4/5] dma: mpc512x: register for device tree channel lookup

2013-07-14 Thread Gerhard Sittig
register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees), provide the '#dma-cells' property in the shared mpc5121.dtsi file, and introduce a bindings document for the MPC512x DMA controller Signed-off-by: Gerh

[PATCH v1 01/24] spi: mpc512x: prepare clocks before enabling them

2013-07-15 Thread Gerhard Sittig
clocks need to get prepared before they can get enabled, fix the MPC512x PSC SPI master's initialization Signed-off-by: Gerhard Sittig --- drivers/spi/spi-mpc512x-psc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mp

[PATCH v1 00/24] add COMMON_CLK support for PowerPC MPC512x

2013-07-15 Thread Gerhard Sittig
equires a cast which shadows real mismatches: WARNING: static const char * array should probably be static const char * const #413: FILE: arch/powerpc/platforms/512x/clock-commonclk.c:335: +static const char *parent_names_mux0[] = { total: 0 errors, 1 warnings, 0 checks, 836 lines checked

[PATCH v1 03/24] mtd: mpc5121_nfc: prepare clocks before enabling them

2013-07-15 Thread Gerhard Sittig
must prepare clocks before enabling them, unprepare after disable Signed-off-by: Gerhard Sittig --- drivers/mtd/nand/mpc5121_nfc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c index 3c9cdcb..eb7771d

[PATCH v1 04/24] powerpc: mpc512x: array decl for MCLK registers in CCM

2013-07-15 Thread Gerhard Sittig
MSCAN CCR fields declared here aren't referenced anywhere Signed-off-by: Gerhard Sittig --- arch/powerpc/include/asm/mpc5121.h | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/include/asm/mpc5121.h b/arch/powerpc/include/asm/mpc5121.h ind

[PATCH v1 02/24] serial: mpc512x: prepare clocks before enabling them

2013-07-15 Thread Gerhard Sittig
clocks need to get prepared before they can get enabled, and after disabling them they can get unprepared Signed-off-by: Gerhard Sittig --- drivers/tty/serial/mpc52xx_uart.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers

[PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-15 Thread Gerhard Sittig
the common clock drivers were motivated/initiated by ARM development and apparently assume little endian peripherals wrap register/peripherals access in the common code (div, gate, mux) in preparation of adding COMMON_CLK support for other platforms Signed-off-by: Gerhard Sittig --- drivers

[PATCH v1 06/24] dts: mpc512x: prepare for preprocessor support

2013-07-15 Thread Gerhard Sittig
prepare C preprocessor support when processing MPC512x DTS files - switch from DTS syntax to CPP syntax for include specs - create a symlink such that DTS processing can reference includes Signed-off-by: Gerhard Sittig --- arch/powerpc/boot/dts/ac14xx.dts |2 +- arch/powerpc/boot

[PATCH v1 08/24] dts: mpc512x: add clock related device tree specs

2013-07-15 Thread Gerhard Sittig
SoC input (fixed frequency) - provide default values with 33MHz oscillator frequency in the common include (the 66MHz IPS bus already was there), add override values for the ifm AC14xx board which deviates from the reference design (25MHz xtal, 80MHz IPS bus) Signed-off-by: Gerhard Sittig -

[PATCH v1 07/24] dts: mpc512x: introduce dt-bindings/clock/ header

2013-07-15 Thread Gerhard Sittig
introduce a dt-bindings/ header file for MPC512x clocks, providing symbolic identifiers for those SoC clocks which clients will reference from their device tree nodes Signed-off-by: Gerhard Sittig --- include/dt-bindings/clock/mpc512x-clock.h | 59 + 1 file changed

[PATCH v1 10/24] dts: mpc512x: add clock specs for client lookups

2013-07-15 Thread Gerhard Sittig
rivers to keep up compatibility, an alternative approach would be to register clkdev items in the platform's clock driver for the migration period Signed-off-by: Gerhard Sittig --- arch/powerpc/boot/dts/mpc5121.dtsi | 79 1 file changed, 79 insertion

[PATCH v1 11/24] net: can: mscan: add a comment on reg to idx mapping

2013-07-15 Thread Gerhard Sittig
add a comment about the magic of deriving an MSCAN component index from the peripheral's physical address / register offset Signed-off-by: Gerhard Sittig --- drivers/net/can/mscan/mpc5xxx_can.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/

[PATCH v1 09/24] clk: mpc512x: introduce COMMON_CLK for MPC512x

2013-07-15 Thread Gerhard Sittig
viders the previous PPC_CLOCK implementation is kept in place and resides in parallel to the common clock implementation for test and comparison during migration, a compile time option picks one of the two alternatives (Kconfig switch, common clock used by default) Signed-off-by: Gerhard Sitti

[PATCH v1 13/24] spi: mpc512x: OF clock lookup, use the 'mclk' name

2013-07-15 Thread Gerhard Sittig
after PSC related clock specifiers were added to the device tree, the former 'psc%d_mclk' isn't needed any longer to lookup clock items Signed-off-by: Gerhard Sittig --- drivers/spi/spi-mpc512x-psc.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/

[PATCH v1 12/24] net: can: mscan: make mpc512x code use common clock

2013-07-15 Thread Gerhard Sittig
hange is that the CAN driver no longer needs to access the SoC's clock control registers, which shall be the domain of the platform's clock driver Signed-off-by: Gerhard Sittig --- drivers/net/can/mscan/mpc5xxx_can.c | 139 +++ 1 file changed, 139 inse

[PATCH v1 14/24] powerpc/mpc512x: improve DIU related clock setup

2013-07-15 Thread Gerhard Sittig
shall succeed upon first try in the usual case, will test a few less desirable yet acceptable frequencies in edge cases, and will fallback to "best effort" if none of the previously tried frequencies pass the test Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock

[PATCH v1 15/24] serial: mpc512x: OF clock lookup, use the 'mclk' name

2013-07-15 Thread Gerhard Sittig
with device tree based clock lookup, the MCLK name no longer depends on the PSC index Signed-off-by: Gerhard Sittig --- drivers/tty/serial/mpc52xx_uart.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial

[PATCH v1 16/24] clk: mpc512x: remove now obsolete clkdev registration

2013-07-15 Thread Gerhard Sittig
after the PSC drivers for UART and SPI mode got converted to device tree based clock lookup, the former MCLK name which depends on the PSC index isn't needed any longer -- remove the clk_register_clkdev() invocation Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock-common

[PATCH v1 17/24] serial: mpc512x: setup the PSC FIFO clock as well

2013-07-15 Thread Gerhard Sittig
prepare and enable the FIFO clock upon PSC FIFO initialization, disable and unprepare the FIFO clock upon PSC FIFO uninitialization, remove the pre-enable workaround from the platform's clock driver Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock-commonclk.c |

[PATCH v1 18/24] i2c: mpc: OF clock lookup for MPC512x

2013-07-15 Thread Gerhard Sittig
make the MPC I2C driver prepare and enable the peripheral clock ('per' for register access) in the MPC512x setup routine, make this clock setup non-fatal to allow for a migration period, remove the pre-enabling hack in the platform's clock driver Signed-off-by: Gerhard Sittig --

[PATCH v1 19/24] USB: fsl-mph-dr-of: OF clock lookup, prepare and enable

2013-07-15 Thread Gerhard Sittig
device tree based clock lookup in the MPC512x initialization (lookup 'per' for register access), add error check in the clock setup, must prepare clocks before they can get enabled, unprepare after disable Signed-off-by: Gerhard Sittig --- drivers/usb/host/fsl-mph-dr-o

[PATCH v1 20/24] fs_enet: OF clock lookup (non-fatal), prepare and enable

2013-07-15 Thread Gerhard Sittig
tree specs for clocks, but failure to enable a specified clock is considered fatal Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock-commonclk.c |1 - .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 27 +++- include/linux/fs_enet

[PATCH v1 21/24] [media] fsl-viu: OF clock lookup, prepare before enable

2013-07-16 Thread Gerhard Sittig
device tree based clock lookup, must prepare clocks before enabling them, unprepare after disable, error check in the clock setup Signed-off-by: Gerhard Sittig --- drivers/media/platform/fsl-viu.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/media

[PATCH v1 22/24] powerpc/fsl-pci: OF clock lookup, prepare before enable

2013-07-16 Thread Gerhard Sittig
ff-by: Gerhard Sittig --- arch/powerpc/sysdev/fsl_pci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 46ac1dd..cb2ed92 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -17,6

[PATCH v1 23/24] clk: mpc512x: switch to COMMON_CLK, remove PPC_CLOCK

2013-07-16 Thread Gerhard Sittig
completely switch to, i.e. unconditionally use COMMON_CLK for the MPC512x platform, and retire the PPC_CLOCK implementation for that platform after the transition has completed Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/Kconfig | 14 +- arch/powerpc/platforms/512x/Makefile

[PATCH v1 24/24] net: can: mscan: remove MPC512x non-COMMON_CLK code path

2013-07-16 Thread Gerhard Sittig
transition to the COMMON_CLK framework has completed for the MPC512x platform, remove the now obsolete code path of the mpc5xxx mscan driver which accessed clock control module registers directly Signed-off-by: Gerhard Sittig --- drivers/net/can/mscan/mpc5xxx_can.c | 136

Re: [PATCH RFC v2 2/5] dma: mpc512x: add support for peripheral transfers

2013-07-17 Thread Gerhard Sittig
On Tue, Jul 16, 2013 at 12:37 +0200, Lars-Peter Clausen wrote: > > On 07/14/2013 02:01 PM, Gerhard Sittig wrote: > > From: Alexander Popov > > > > introduce support for slave s/g transfer preparation and the associated > > device control callback in the MPC512x DMA

Re: [PATCH v1 01/24] spi: mpc512x: prepare clocks before enabling them

2013-07-17 Thread Gerhard Sittig
On Mon, Jul 15, 2013 at 21:17 +0100, Mark Brown wrote: > > On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote: > > clocks need to get prepared before they can get enabled, > > fix the MPC512x PSC SPI master's initialization > > > Signed-off-by: Gerh

Re: [PATCH v1 15/24] serial: mpc512x: OF clock lookup, use the 'mclk' name

2013-07-17 Thread Gerhard Sittig
On Mon, Jul 15, 2013 at 23:54 +0200, Sascha Hauer wrote: > > On Mon, Jul 15, 2013 at 11:46:01PM +0200, Gerhard Sittig wrote: > > with device tree based clock lookup, the MCLK name no longer > > depends on the PSC index > > > > Signed-off-by: Gerhard Sittig &

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-17 Thread Gerhard Sittig
On Mon, Jul 15, 2013 at 21:38 +0200, Sascha Hauer wrote: > > On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote: > > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c > > index 6d55eb2..2c07061 100644 > > --- a/drivers/clk/clk-divider.c &

Re: [PATCH v1 01/24] spi: mpc512x: prepare clocks before enabling them

2013-07-17 Thread Gerhard Sittig
On Wed, Jul 17, 2013 at 13:07 +0100, Mark Brown wrote: > > On Wed, Jul 17, 2013 at 01:22:29PM +0200, Gerhard Sittig wrote: > > On Mon, Jul 15, 2013 at 21:17 +0100, Mark Brown wrote: > > > On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote: > > > &

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Gerhard Sittig
On Mon, Jul 15, 2013 at 21:38 +0200, Sascha Hauer wrote: > > On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote: > > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c > > index 6d55eb2..2c07061 100644 > > --- a/drivers/clk/clk-divider.c &

[PATCH v2 00/24] add COMMON_CLK support for PowerPC MPC512x

2013-07-18 Thread Gerhard Sittig
t() routine - remove the clkdev.h header file inclusion directive with the removal of the clkdev registration call Gerhard Sittig (24): spi: mpc512x: cleanup clock API use serial: mpc512x: cleanup clock API use mtd: mpc5121_nfc: prepare clocks before enabling them powerpc: mpc512x:

[PATCH v2 01/24] spi: mpc512x: cleanup clock API use

2013-07-18 Thread Gerhard Sittig
n the clock handling previously went unnoticed, but will become fatal in the common clock scenario Signed-off-by: Gerhard Sittig --- drivers/spi/spi-mpc512x-psc.c | 49 ++--- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/drivers/spi/spi-mpc512x

[PATCH v2 03/24] mtd: mpc5121_nfc: prepare clocks before enabling them

2013-07-18 Thread Gerhard Sittig
must prepare clocks before enabling them, unprepare after disable Signed-off-by: Gerhard Sittig --- drivers/mtd/nand/mpc5121_nfc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c index 3c9cdcb..eb7771d

[PATCH v2 02/24] serial: mpc512x: cleanup clock API use

2013-07-18 Thread Gerhard Sittig
d upon allocation already just in case the clock is not only required for bitrate generation but for register access as well Signed-off-by: Gerhard Sittig --- drivers/tty/serial/mpc52xx_uart.c | 100 ++--- 1 file changed, 83 insertions(+), 17 delet

[PATCH v2 04/24] powerpc: mpc512x: array decl for MCLK registers in CCM

2013-07-18 Thread Gerhard Sittig
MSCAN CCR fields declared here aren't referenced anywhere Signed-off-by: Gerhard Sittig --- arch/powerpc/include/asm/mpc5121.h | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/include/asm/mpc5121.h b/arch/powerpc/include/asm/mpc5121.h ind

[PATCH v2 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Gerhard Sittig
the common clock drivers were motivated/initiated by ARM development and apparently assume little endian peripherals wrap register/peripherals access in the common code (div, gate, mux) in preparation of adding COMMON_CLK support for other platforms Signed-off-by: Gerhard Sittig --- drivers

[PATCH v2 06/24] dts: mpc512x: prepare for preprocessor support

2013-07-18 Thread Gerhard Sittig
prepare C preprocessor support when processing MPC512x DTS files - switch from DTS syntax to CPP syntax for include specs - create a symlink such that DTS processing can reference includes Signed-off-by: Gerhard Sittig --- arch/powerpc/boot/dts/ac14xx.dts |2 +- arch/powerpc/boot

[PATCH v2 07/24] dts: mpc512x: introduce dt-bindings/clock/ header

2013-07-18 Thread Gerhard Sittig
introduce a dt-bindings/ header file for MPC512x clocks, providing symbolic identifiers for those SoC clocks which clients will reference from their device tree nodes Signed-off-by: Gerhard Sittig --- include/dt-bindings/clock/mpc512x-clock.h | 59 + 1 file changed

[PATCH v2 08/24] dts: mpc512x: add clock related device tree specs

2013-07-18 Thread Gerhard Sittig
SoC input (fixed frequency) - provide default values with 33MHz oscillator frequency in the common include (the 66MHz IPS bus already was there), add override values for the ifm AC14xx board which deviates from the reference design (25MHz xtal, 80MHz IPS bus) Signed-off-by: Gerhard Sittig -

[PATCH v2 09/24] clk: mpc512x: introduce COMMON_CLK for MPC512x

2013-07-18 Thread Gerhard Sittig
lable Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/Kconfig | 14 +- arch/powerpc/platforms/512x/Makefile |4 +- arch/powerpc/platforms/512x/clock-commonclk.c | 778 + include/linux/clk-provider.h | 16 + 4 files cha

[PATCH v2 10/24] dts: mpc512x: add clock specs for client lookups

2013-07-18 Thread Gerhard Sittig
rivers to keep up compatibility, an alternative approach would be to register clkdev items in the platform's clock driver for the migration period Signed-off-by: Gerhard Sittig --- arch/powerpc/boot/dts/mpc5121.dtsi | 79 1 file changed, 79 insertion

[PATCH v2 11/24] spi: mpc512x: remove now obsolete clock lookup name

2013-07-18 Thread Gerhard Sittig
after device tree based clock lookup became available, the peripheral driver need no longer construct clock names which include the PSC index, remove the "psc%d_mclk" template and unconditionally use "mclk" Signed-off-by: Gerhard Sittig --- drivers/spi/spi-mpc512x-psc.c |

[PATCH v2 12/24] serial: mpc512x: remove now obsolete clock lookup name

2013-07-18 Thread Gerhard Sittig
after device tree based clock lookup became available, the peripheral driver need no longer construct clock names which include the PSC index, remove the "psc%d_mclk" template and unconditionally use "mclk" Signed-off-by: Gerhard Sittig --- drivers/tty/serial/mpc52xx_uart.

[PATCH v2 13/24] clk: mpc512x: remove now obsolete clkdev registration

2013-07-18 Thread Gerhard Sittig
ned-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock-commonclk.c | 12 1 file changed, 12 deletions(-) diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c b/arch/powerpc/platforms/512x/clock-commonclk.c index 6627957..b822469 100644 --- a/arch/powerpc/platforms/

[PATCH v2 14/24] serial: mpc512x: setup the PSC FIFO clock as well

2013-07-18 Thread Gerhard Sittig
prepare and enable the FIFO clock upon PSC FIFO initialization, disable and unprepare the FIFO clock upon PSC FIFO uninitialization, remove the pre-enable workaround from the platform's clock driver Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock-commonclk.c |

[PATCH v2 16/24] net: can: mscan: make mpc512x code use common clock

2013-07-18 Thread Gerhard Sittig
hange is that the CAN driver no longer needs to access the SoC's clock control registers, which shall be the domain of the platform's clock driver Signed-off-by: Gerhard Sittig --- drivers/net/can/mscan/mpc5xxx_can.c | 139 +++ 1 file changed, 139 inse

[PATCH v2 15/24] net: can: mscan: add a comment on reg to idx mapping

2013-07-18 Thread Gerhard Sittig
add a comment about the magic of deriving an MSCAN component index from the peripheral's physical address / register offset Signed-off-by: Gerhard Sittig --- drivers/net/can/mscan/mpc5xxx_can.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/

[PATCH v2 17/24] powerpc/mpc512x: improve DIU related clock setup

2013-07-18 Thread Gerhard Sittig
shall succeed upon first try in the usual case, will test a few less desirable yet acceptable frequencies in edge cases, and will fallback to "best effort" if none of the previously tried frequencies pass the test Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock

[PATCH v2 18/24] i2c: mpc: OF clock lookup for MPC512x

2013-07-18 Thread Gerhard Sittig
make the MPC I2C driver prepare and enable the peripheral clock ('per' for register access) in the MPC512x setup routine, make this clock setup non-fatal to allow for a migration period, remove the pre-enabling hack in the platform's clock driver Signed-off-by: Gerhard Sittig --

[PATCH v2 19/24] USB: fsl-mph-dr-of: OF clock lookup, prepare and enable

2013-07-18 Thread Gerhard Sittig
device tree based clock lookup in the MPC512x initialization (lookup 'per' for register access), add error check in the clock setup, must prepare clocks before they can get enabled, unprepare after disable Signed-off-by: Gerhard Sittig --- drivers/usb/host/fsl-mph-dr-o

[PATCH v2 20/24] fs_enet: OF clock lookup (non-fatal), prepare and enable

2013-07-18 Thread Gerhard Sittig
tree specs for clocks, but failure to enable a specified clock is considered fatal Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/clock-commonclk.c |1 - .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 27 +++- include/linux/fs_enet

[PATCH v2 22/24] powerpc/fsl-pci: OF clock lookup, prepare before enable

2013-07-18 Thread Gerhard Sittig
ff-by: Gerhard Sittig --- arch/powerpc/sysdev/fsl_pci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 46ac1dd..cb2ed92 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -17,6

[PATCH v2 21/24] [media] fsl-viu: OF clock lookup, prepare before enable

2013-07-18 Thread Gerhard Sittig
device tree based clock lookup, must prepare clocks before enabling them, unprepare after disable, error check in the clock setup Signed-off-by: Gerhard Sittig --- drivers/media/platform/fsl-viu.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/media

[PATCH v2 23/24] clk: mpc512x: switch to COMMON_CLK, remove PPC_CLOCK

2013-07-18 Thread Gerhard Sittig
completely switch to, i.e. unconditionally use COMMON_CLK for the MPC512x platform, and retire the PPC_CLOCK implementation for that platform after the transition has completed Signed-off-by: Gerhard Sittig --- arch/powerpc/platforms/512x/Kconfig | 14 +- arch/powerpc/platforms/512x/Makefile

[PATCH v2 24/24] net: can: mscan: remove MPC512x non-COMMON_CLK code path

2013-07-18 Thread Gerhard Sittig
transition to the COMMON_CLK framework has completed for the MPC512x platform, remove the now obsolete code path of the mpc5xxx mscan driver which accessed clock control module registers directly Signed-off-by: Gerhard Sittig --- drivers/net/can/mscan/mpc5xxx_can.c | 136

  1   2   >