RE: Best practice device tree design for display subsystems/DRM

2013-07-04 Thread Inki Dae
> -Original Message- > From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] > Sent: Thursday, July 04, 2013 4:25 PM > To: Inki Dae > Cc: 'Jean-Francois Moine'; 'Daniel Drake'; devicetree- > disc...@lists.ozlabs.org; dri-de..

RE: Best practice device tree design for display subsystems/DRM

2013-07-04 Thread Inki Dae
> -Original Message- > From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] > Sent: Wednesday, July 03, 2013 8:52 PM > To: Inki Dae > Cc: 'Russell King'; devicetree-discuss@lists.ozlabs.org; 'Jean-Francois > Moine';

RE: Best practice device tree design for display subsystems/DRM

2013-07-03 Thread Inki Dae
> -Original Message- > From: Russell King [mailto:r...@arm.linux.org.uk] > Sent: Wednesday, July 03, 2013 9:05 PM > To: Inki Dae > Cc: 'Sebastian Hesselbarth'; 'Sascha Hauer'; 'Daniel Drake'; 'Jean- > Francois M

RE: Best practice device tree design for display subsystems/DRM

2013-07-03 Thread Inki Dae
> -Original Message- > From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] > Sent: Wednesday, July 03, 2013 7:53 PM > To: Russell King > Cc: Inki Dae; 'Sascha Hauer'; 'Daniel Drake'; 'Jean-Francois Moine';

RE: Best practice device tree design for display subsystems/DRM

2013-07-03 Thread Inki Dae
> -Original Message- > From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] > Sent: Wednesday, July 03, 2013 6:09 PM > To: Sascha Hauer > Cc: Inki Dae; 'Daniel Drake'; 'Jean-Francois Moine'; devicetree- > disc...@li

RE: Best practice device tree design for display subsystems/DRM

2013-07-03 Thread Inki Dae
framebuffer or other subsystems? The above dtsi file is specific to DRM subsystem. And I think the dtsi file has no any dependency on certain subsystem so board dtsi file should be considered for all device drivers based on other subsystems: i.e., Linux framebuffer, DRM, and so no. So I *str

RE: Best practice device tree design for display subsystems/DRM

2013-07-03 Thread Inki Dae
; the driver(s) have been registered, which may not be in the correct > order. > That's true but how drivers could be registered prior to devices? The devices registering codes are built in kernel image so the drivers cannot be registered prior to devices as long as we don't modify t

RE: Best practice device tree design for display subsystems/DRM

2013-07-02 Thread Inki Dae
se drivers. > You will need cross-driver function calls (exynos_drm_device_register) > to make it work. You will need to add loops to wait for the previous > component to successfully initialize (or shutdown), and only then kick > DisplayPort link training (or turn the transmitter off). That makes >

Re: [PATCH v3 3/3] ARM/dts: change compatible strings for hdmi subsystem

2013-06-20 Thread Inki Dae
2013/6/20 Rahul Sharma > Thanks Mr. Kim, > > I will post v4 with aforesaid change. > > You don't need to re-post it. I gonna change it to "ARM/dts: change compatible strings for Exynos5250 hdmi subsystem", and merge it. Is there another you want? Thanks, Ink

RE: [PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-19 Thread Inki Dae
fter patch 2 and 3 it is still broken, > > - and eventually all in-tree users are fixed by patch 4 (but you can't > > fix out-of-tree users). > > > > Please do it without changing existing compatible values. Even if they > are > > misleading, this is all can

RE: [PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-19 Thread Inki Dae
> -Original Message- > From: Inki Dae [mailto:inki@samsung.com] > Sent: Wednesday, June 19, 2013 4:06 PM > To: 'Rahul Sharma'; 'linux-samsung-...@vger.kernel.org'; 'devicetree- > disc...@lists.ozlabs.org'; 'dri-de...@lists.freed

RE: [PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

2013-06-19 Thread Inki Dae
n of using compatible string > which represent the SoC in which the IP was added for the first > time. > Hi Rahul, Could you separate this patch into two patches, driver side and document side, and the below patch also? [PATCH v2 2/4] drm/exynos: add support for exynos5420 mixer Th

RE: [PATCH 3/4] drm/exynos: fix interlace resolutions for exynos5420

2013-06-18 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: 김승우 [mailto:sw0312@samsung.com] > Sent: Wednesday, June 19, 2013 2:34 PM > To: Rahul Sharma > Cc: linux-samsung-...@vger.kernel.org; devicetree- disc...@lists.ozlabs.org; > dri-de...@lists.freedesktop.org; kge

Re: [PATCH 7/9] drm/exynos: use of_get_named_gpio to get hdmi hpd gpio

2013-06-16 Thread Inki Dae
Applied. Thanks, Inki Dae 2013/6/14 김승우 > Hello Rahul, > > this patch is not related with others and it looks good to me. > > On 2013년 06월 11일 23:11, Rahul Sharma wrote: > > Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata > > which is not

Re: [PATCH 4/4] ARM/dts: add clocks to hdmi dt node for exynos5250

2013-06-13 Thread Inki Dae
Acked-by: Inki Dae Thanks, Inki Dae 2013/6/11 Rahul Sharma > Fix wrong clock numbers in hdmi dt node. Removed hdmiphy > clock which was a dummy clock earlier and not required now. > Also added mux clock to change the clock parent. > > Signed-off-by: Rahul Sharma > --- &g

Re: [PATCH 3/4] ARM: dts: Add mixer clocks to mixer node

2013-06-13 Thread Inki Dae
Acked-by: Inki Dae Thanks, Inki Dae 2013/6/11 Rahul Sharma > From: Sean Paul > > This patch adds the mixer clocks to the mixer node in the dts file. > > Signed-off-by: Sean Paul > Signed-off-by: Rahul Sharma > --- > arch/arm/boot/dts/exynos5250.dtsi |2

RE: [PATCH 2/4] drm/exynos: add mout_hdmi clock in hdmi driver to change parent

2013-06-13 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: Rahul Sharma [mailto:rahul.sha...@samsung.com] > Sent: Tuesday, June 11, 2013 3:54 PM > To: linux-samsung-...@vger.kernel.org; devicetree-discuss@lists.ozlabs.org; > dri-de...@lists.freedesktop.org > Cc: kgene@s

RE: [PATCH 1/4] drm/exynos: Prepare/Unprepare HDMI subsystem clocks

2013-06-13 Thread Inki Dae
Applied. Thanks, Inki Dae > -Original Message- > From: Rahul Sharma [mailto:rahul.sha...@samsung.com] > Sent: Tuesday, June 11, 2013 3:54 PM > To: linux-samsung-...@vger.kernel.org; devicetree-discuss@lists.ozlabs.org; > dri-de...@lists.freedesktop.org > Cc: kgene@s

RE: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-13 Thread Inki Dae
> -Original Message- > From: Sylwester Nawrocki [mailto:s.nawro...@samsung.com] > Sent: Thursday, June 13, 2013 5:56 PM > To: Rahul Sharma > Cc: Rahul Sharma; Inki Dae; linux-samsung-...@vger.kernel.org; devicetree- > disc...@lists.ozlabs.org; DRI mailing list; Kukjin

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-11 Thread Inki Dae
2013/6/12 Inki Dae > Hi Rahul, > > This patch is important to us. Actually, previous hdmi driver had > controlled hdmiphy HDMI_PHY_CONTROL as if that were a clock but now that > doesn't exist anymore. So we need to discuss how hdmiphy should be handled. > I konw that

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-11 Thread Inki Dae
s5250/hdmi: replace dummy hdmiphy clock with pmu reg control And then let's start review :) Thanks, Inki Dae 2013/6/11 Rahul Sharma > Previously, hdmiphy is added as a dummy clock in clock file for > exynos SoCs. Enable/Disable to this clock, actually toggles the power > control

Re: [PATCH] drm/exynos: fix multiple definition build error

2013-04-28 Thread Inki Dae
2013/4/27 Sylwester Nawrocki > On 04/26/2013 09:42 PM, Tomasz Figa wrote: > >> On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote: >> >>> On 04/26/2013 10:20 AM, Inki Dae wrote: >>> >>>> Exactly right. it's my mistake. But now it se

Re: [PATCH] drm/exynos: fix multiple definition build error

2013-04-28 Thread Inki Dae
2013/4/27 Tomasz Figa > On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote: > > On 04/26/2013 10:20 AM, Inki Dae wrote: > > > Exactly right. it's my mistake. But now it seems that > > > __mode_of_device_table is multi defined at fimd and g2d side so t

Re: [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-20 Thread Inki Dae
2013/4/17 Sylwester Nawrocki > This patch adds OF initialization support for the FIMC driver. > The binding documentation can be found at Documentation/devicetree/ > bindings/media/samsung-fimc.txt. > > The syscon regmap interface is used to serialize access to the > shared CAMBLK registers from

Re: [PATCH v2 0/3] drm/exynos: Add device tree support for IPP driver

2013-04-20 Thread Inki Dae
set looks good to me but I'd like to take more opinions from others. And you can find my comments at the third patch. Thanks, Inki Dae 2013/4/17 Sylwester Nawrocki > Hi Inki, > > This small patch series adds device tree support for the DRM FIMC driver. > The binding d

Re: [PATCH Resend 1/1] Revert "of/exynos_g2d: Add Bindings for exynos G2D driver"

2013-04-12 Thread Inki Dae
Applied. Thanks, Inki Dae 2013/4/12 Sachin Kamat > This reverts commit 09495dda6a62c74b13412a63528093910ef80edd. > The description is incomplete and the location of this file > is incorrect. Based on discussion with the Samsung media and DRM subsystem > maintainers, the doc

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-12 Thread Inki Dae
2013/2/12 Sylwester Nawrocki : > On 02/12/2013 02:17 PM, Inki Dae wrote: >> Applied and will go to -next. >> And please post the document(in >> Documentation/devicetree/bindings/gpu/) for it later. > > There is already some old patch applied in the devicetree/next tree:

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-12 Thread Inki Dae
Applied and will go to -next. And please post the document(in Documentation/devicetree/bindings/gpu/) for it later. Thanks, Inki Dae 2013/2/6 Sachin Kamat : > From: Ajay Kumar > > This patch adds device tree match table for Exynos G2D controller. > > Signed-off-by: Ajay Kumar

RE: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-06 Thread Inki Dae
> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sylwester Nawrocki > Sent: Wednesday, February 06, 2013 8:24 PM > To: Inki Dae > Cc: 'Sachin Kamat'; linux-me...@vger.kernel.org; dri- &

RE: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-06 Thread Inki Dae
> -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Wednesday, February 06, 2013 5:03 PM > To: Inki Dae > Cc: linux-me...@vger.kernel.org; dri-de...@lists.freedesktop.org; > devicetree-discuss@lists.ozlabs.org; k.deb...@samsung.com; > s

RE: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-05 Thread Inki Dae
Looks good to me but please add document for it. To other guys, And is there anyone who know where this document should be added to? I'm not sure that the g2d document should be placed in Documentation/devicetree/bindings/gpu, media, drm/exynos or arm/exynos. At least, this document should be

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-04 Thread Inki Dae
2013/2/4 Sachin Kamat : > On 1 February 2013 18:28, Inki Dae wrote: >> >> >> >> >> 2013. 2. 1. 오후 8:52 Inki Dae 작성: >> >>> >>> >>>> -Original Message- >>>> From: linux-media-ow...@vger.kernel.org [mailto:lin

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-03 Thread Inki Dae
2013. 2. 1. 오후 8:52 Inki Dae 작성: > > >> -Original Message- >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Sachin Kamat >> Sent: Friday, February 01, 2013 8:40 PM >> To: Inki Dae >> Cc:

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sachin Kamat > Sent: Friday, February 01, 2013 8:40 PM > To: Inki Dae > Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- > me...@vg

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sachin Kamat > Sent: Friday, February 01, 2013 8:13 PM > To: Sylwester Nawrocki > Cc: Inki Dae; Kukjin Kim; Sylwester Nawrocki; linux-me...@vger.ke

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Inki Dae
Hi Kukjin, > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Kukjin Kim > Sent: Friday, February 01, 2013 9:15 AM > To: 'Sylwester Nawrocki'; 'Inki Dae' > Cc: 'Sachin Kam

Re: [PATCH v2] drm/exynos: Get HDMI version from device tree

2013-01-30 Thread Inki Dae
2013/1/31 Stephen Warren : > On 01/30/2013 06:16 PM, Inki Dae wrote: >> 2013/1/30 Sylwester Nawrocki : >>> Hi, >>> >>> >>> On 01/08/2013 11:56 PM, Stephen Warren wrote: >>>> >>>> On 01/08/2013 01:16 PM, Sean Paul wrote: >>&

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
> -Original Message- > From: Sylwester Nawrocki [mailto:sylvester.nawro...@gmail.com] > Sent: Thursday, January 31, 2013 5:51 AM > To: Inki Dae > Cc: Sachin Kamat; linux-me...@vger.kernel.org; dri- > de...@lists.freedesktop.org; devicetree-discuss@lists.ozlabs.org; &g

Re: [PATCH v2] drm/exynos: Get HDMI version from device tree

2013-01-30 Thread Inki Dae
2013/1/30 Sylwester Nawrocki : > Hi, > > > On 01/08/2013 11:56 PM, Stephen Warren wrote: >> >> On 01/08/2013 01:16 PM, Sean Paul wrote: >>> >>> Add a property to the hdmi node so we can specify the HDMI version in >>> the device tree instead of just defaulting to v1.4 with the existence of >>> the

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
2013/1/25 Sachin Kamat : > From: Ajay Kumar > > This patch adds device tree match table for Exynos G2D controller. > > Signed-off-by: Ajay Kumar > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) >

Re: [PATCH v2] drm/exynos: Get HDMI version from device tree

2013-01-29 Thread Inki Dae
the version info register so we could support all mixer controllers of Exynos SoC checking that register. So if you are planning on such thing for Mixer also then I'd recommend you to consider checking that register. Thanks, Inki Dae > > Sean > _

Re: [PATCH 0/3] add mie driver for exynos

2012-12-19 Thread Inki Dae
2012/12/12 Stéphane Marchesin > On Mon, Dec 10, 2012 at 1:27 AM, Inki Dae wrote: > > > > > > 2012/12/10 Stéphane Marchesin > >> > >> On Sun, Dec 9, 2012 at 10:26 PM, Inki Dae wrote: > >> > > >> > > >> > 2012/12/6 R.

Re: [PATCH 0/3] add mie driver for exynos

2012-12-19 Thread Inki Dae
2012/12/10 Stéphane Marchesin > On Sun, Dec 9, 2012 at 10:26 PM, Inki Dae wrote: > > > > > > 2012/12/6 R. Chandrasekar > > > >> From: "R. Chandrasekar" > >> > >> this patch set adds the driver support for the dithering functi

Re: [PATCH 0/3] add mie driver for exynos

2012-12-19 Thread Inki Dae
imd and lcd panel(or mipi-dsi, eDP) to enhance image to be displayed. And it seems like that this doesn't need drm framework-relevant interfaces, such as gem. And also, please refer to the below link, Common Display Framework, for more generic way. http://lists.freedesktop.org/archi